• J
    perf tools: Fix 'disabled' attribute config for record command · 774cb499
    Jiri Olsa 提交于
    Currently the record command sets all events initially as disabled.
    
    There's non conditional perf_evlist__enable call, that enables all
    events before we exec tracee program. That actually screws whole
    enable_on_exec logic, because the event is enabled before the traced
    program got executed.
    
    What we actually want is:
    
    1) For any type of traced program:
      - all independent events and group leaders are disabled
      - all group members are enabled
    
       Group members are ruled by group leaders. They need to
       be enabled, because the group scheduling relies on that.
    
    2) For traced programs executed by perf:
       - all independent events and group leaders have
         enable_on_exec set
       - we don't specifically enable or disable any event during
         the record command
    
       Independent events and group leaders are initially disabled
       and get enabled by exec. Group members are ruled by group
       leaders as stated in 1).
    
    3) For traced programs attached by perf (pid/tid):
       - we specifically enable or disable all events during
         the record command
    
       When attaching events to already running traced we
       enable/disable events specifically, as there's no
       initial traced exec call.
    
    Fixing appropriate perf_event_attr test case to cover this change.
    Signed-off-by: NJiri Olsa <jolsa@redhat.com>
    Acked-by: NNamhyung Kim <namhyung@kernel.org>
    Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/1352741644-16809-3-git-send-email-jolsa@redhat.comSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
    774cb499
evsel.c 26.7 KB