• D
    AFS: Fix cache manager service handlers · 6c67c7c3
    David Howells 提交于
    Fix the cache manager RPC service handlers.  The afs_send_empty_reply() and
    afs_send_simple_reply() functions:
    
     (a) Kill the call and free up the buffers associated with it if they fail.
    
     (b) Return with call intact if it they succeed.
    
    However, none of the callers actually check the result or clean up if
    successful - and may use the now non-existent data if it fails.
    
    This was detected by Dan Carpenter using a static checker:
    
    	The patch 08e0e7c8: "[AF_RXRPC]: Make the in-kernel AFS
    	filesystem use AF_RXRPC." from Apr 26, 2007, leads to the following
    	static checker warning:
    	"fs/afs/cmservice.c:155 SRXAFSCB_CallBack()
    		 warn: 'call' was already freed."
    Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: NDavid Howells <dhowells@redhat.com>
    6c67c7c3
rxrpc.c 20.1 KB