• T
    binder: fix race between munmap() and direct reclaim · 9d57cfd4
    Todd Kjos 提交于
    commit 5cec2d2e5839f9c0fec319c523a911e0a7fd299f upstream.
    
    An munmap() on a binder device causes binder_vma_close() to be called
    which clears the alloc->vma pointer.
    
    If direct reclaim causes binder_alloc_free_page() to be called, there
    is a race where alloc->vma is read into a local vma pointer and then
    used later after the mm->mmap_sem is acquired. This can result in
    calling zap_page_range() with an invalid vma which manifests as a
    use-after-free in zap_page_range().
    
    The fix is to check alloc->vma after acquiring the mmap_sem (which we
    were acquiring anyway) and skip zap_page_range() if it has changed
    to NULL.
    
    Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
    Signed-off-by: NTodd Kjos <tkjos@google.com>
    Reviewed-by: NJoel Fernandes (Google) <joel@joelfernandes.org>
    Cc: stable <stable@vger.kernel.org> # 4.19
    Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    9d57cfd4
binder_alloc.c 28.1 KB