• A
    perf script: Allow printing period for non freq mode groups · 5039c8a2
    Andi Kleen 提交于
    When using leader sampling the values of the not sampled but counted
    events are shown by perf script in "period".
    
    Currently printing period is only allowed when the main event has a
    period, that is it is in frequency mode.
    
    This implies that we cannot dump the values of counted events when the
    leader event is not in frequency mode.
    
    Just remove the check that the period must be set on all events. It will
    just be printed as 0 instead if it's not available.
    
    This fixes the following:
    
      $ perf record -c 100000 -e '{cycles,branches}:S'
      $ perf script -F event,period
    
    Further commentary by Jiri Olsa:
    
    The period will be the value of configured period, not 0:
    
    int perf_evsel__parse_sample(struct ...
      ...
      data->period = evsel->attr.sample_period;
    
      $ perf record -c 100000
      $ perf script -F event,period | head -3
      Failed to open /tmp/perf-2048.map, continuing without symbols
          100000 cycles:ppp:
          100000 cycles:ppp:
    
    other than that I think we can remove that check, because we will have
    always sane number in period
    Signed-off-by: NAndi Kleen <ak@linux.intel.com>
    Acked-by: NJiri Olsa <jolsa@kernel.org>
    Link: http://lkml.kernel.org/r/20171109145528.23371-4-andi@firstfloor.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
    5039c8a2
builtin-script.c 85.2 KB