• N
    rtlwifi: btcoex: Use proper enumerated types for Wi-Fi only interface · 4cfcb537
    Nathan Chancellor 提交于
    [ Upstream commit 31138a827d1b3d6e4855bddb5a1e44e7b32309c0 ]
    
    Clang warns when one enumerated type is implicitly converted to another.
    
    drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1327:34:
    warning: implicit conversion from enumeration type 'enum
    btc_chip_interface' to different enumeration type 'enum
    wifionly_chip_interface' [-Wenum-conversion]
                    wifionly_cfg->chip_interface = BTC_INTF_PCI;
                                                 ~ ^~~~~~~~~~~~
    drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1330:34:
    warning: implicit conversion from enumeration type 'enum
    btc_chip_interface' to different enumeration type 'enum
    wifionly_chip_interface' [-Wenum-conversion]
                    wifionly_cfg->chip_interface = BTC_INTF_USB;
                                                 ~ ^~~~~~~~~~~~
    drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1333:34:
    warning: implicit conversion from enumeration type 'enum
    btc_chip_interface' to different enumeration type 'enum
    wifionly_chip_interface' [-Wenum-conversion]
                    wifionly_cfg->chip_interface = BTC_INTF_UNKNOWN;
                                                 ~ ^~~~~~~~~~~~~~~~
    3 warnings generated.
    
    Use the values from the correct enumerated type, wifionly_chip_interface.
    
    BTC_INTF_UNKNOWN = WIFIONLY_INTF_UNKNOWN = 0
    BTC_INTF_PCI = WIFIONLY_INTF_PCI = 1
    BTC_INTF_USB = WIFIONLY_INTF_USB = 2
    
    Link: https://github.com/ClangBuiltLinux/linux/issues/135Signed-off-by: NNathan Chancellor <natechancellor@gmail.com>
    Acked-by: NPing-Ke Shih <pkshih@realtek.com>
    Signed-off-by: NKalle Valo <kvalo@codeaurora.org>
    Signed-off-by: NSasha Levin <sashal@kernel.org>
    4cfcb537
halbtcoutsrc.c 56.4 KB