• I
    x86/fpu: Fix FPU register read access to the current task · 47f01e8c
    Ingo Molnar 提交于
    Bobby Powers reported the following FPU warning during ELF coredumping:
    
       WARNING: CPU: 0 PID: 27452 at arch/x86/kernel/fpu/core.c:324 fpu__activate_stopped+0x8a/0xa0()
    
    This warning unearthed an invalid assumption about fpu__activate_stopped()
    that I added in:
    
      67e97fc2 ("x86/fpu: Rename init_fpu() to fpu__unlazy_stopped() and add debugging check")
    
    the old init_fpu() function had an (intentional but obscure) side effect:
    when FPU registers are accessed for the current task, for reading, then
    it synchronized live in-register FPU state with the fpstate by saving it.
    
    So fix this bug by saving the FPU if we are the current task. We'll
    still warn in fpu__save() if this is called for not yet stopped
    child tasks, so the debugging check is still preserved.
    
    Also rename the function to fpu__activate_fpstate(), because it's not
    exclusively used for stopped tasks, but for the current task as well.
    
    ( Note that this bug calls for a cleaner separation of access-for-read
      and access-for-modification FPU methods, but we'll do that in separate
      patches. )
    Reported-by: NBobby Powers <bobbypowers@gmail.com>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Dave Hansen <dave.hansen@linux.intel.com>
    Cc: Fenghua Yu <fenghua.yu@intel.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: NIngo Molnar <mingo@kernel.org>
    47f01e8c
regset.c 8.8 KB