• X
    md/raid1: Use a new variable to count flighting sync requests · 43ac9b84
    Xiao Ni 提交于
    In new barrier codes, raise_barrier waits if conf->nr_pending[idx] is not zero.
    After all the conditions are true, the resync request can go on be handled. But
    it adds conf->nr_pending[idx] again. The next resync request hit the same bucket
    idx need to wait the resync request which is submitted before. The performance
    of resync/recovery is degraded.
    So we should use a new variable to count sync requests which are in flight.
    
    I did a simple test:
    1. Without the patch, create a raid1 with two disks. The resync speed:
    Device:         rrqm/s   wrqm/s     r/s     w/s    rMB/s    wMB/s avgrq-sz avgqu-sz   await r_await w_await  svctm  %util
    sdb               0.00     0.00  166.00    0.00    10.38     0.00   128.00     0.03    0.20    0.20    0.00   0.19   3.20
    sdc               0.00     0.00    0.00  166.00     0.00    10.38   128.00     0.96    5.77    0.00    5.77   5.75  95.50
    2. With the patch, the result is:
    sdb            2214.00     0.00  766.00    0.00   185.69     0.00   496.46     2.80    3.66    3.66    0.00   1.03  79.10
    sdc               0.00  2205.00    0.00  769.00     0.00   186.44   496.52     5.25    6.84    0.00    6.84   1.30 100.10
    Suggested-by: NShaohua Li <shli@kernel.org>
    Signed-off-by: NXiao Ni <xni@redhat.com>
    Acked-by: NColy Li <colyli@suse.de>
    Signed-off-by: NShaohua Li <shli@fb.com>
    43ac9b84
raid1.c 91.3 KB