• D
    iop-adma: Corrected array overflow in RAID6 Xscale(R) test. · 3d9ea9e3
    Don Morris 提交于
    Bug: cppcheck reported overflow in array assignment (for loop walks
    0 to IOP_ADMA_NUM_SRC_TEST+2, array size is IOP_ADMA_NUM_SRC_TEST).
    
    Reported as: https://bugzilla.kernel.org/show_bug.cgi?id=42677
    
    Test code pq_src array was grown by two elements to correspond with actual
    usage (IOP_ADMA_NUM_SRC_TEST+2), stack consumption was kept constant by
    modifying the pq_dest two element array which is only used when pq_src
    is referenced up to IOP_ADMA_NUM_SRC_TEST elements into the address
    of the new last two elements of the pq_src array. This is presumed to
    be the original intent but would be reliant on compilers always having
    pq_dest contiguous with the final element of pq_src.
    
    Note: This is a re-send of a request for review from two weeks ago.
    Looking for review (or shootdown), adding LKML to list for a wider
    audience. Thanks.
    
    Updated per review comments of Sergei Shtylyov <sshtylyov@mvista.com>
    Signed-off-by: NDon Morris <don.morris@hp.com>
    Signed-off-by: NDan Williams <dan.j.williams@intel.com>
    3d9ea9e3
iop-adma.c 49.0 KB