• M
    kernel/cpu.c: Move the CPU_DYING notifiers · 3ba35573
    Manfred Spraul 提交于
    When a cpu is taken offline, the CPU_DYING notifiers are called on the
    dying cpu. According to <linux/notifiers.h>, the cpu should be "not
    running any task, not handling interrupts, soon dead".
    
    For the current implementation, this is not true:
    - __cpu_disable can fail. If it fails, then the cpu will remain alive
      and happy.
    - At least on x86, __cpu_disable() briefly enables the local interrupts
      to handle any outstanding interrupts.
    
    What about moving CPU_DYING down a few lines, behind the __cpu_disable()
    line?
    There are only two CPU_DYING handlers in the kernel right now: one in
    kvm, one in the scheduler. Both should work with the patch applied
    [and: I'm not sure if either one handles a failing __cpu_disable()]
    
    The patch survives simple offlining a cpu. kvm untested due to lack
    of a test setup.
    Signed-off-By: NManfred Spraul <manfred@colorfullife.com>
    Signed-off-by: NIngo Molnar <mingo@elte.hu>
    3ba35573
cpu.c 11.4 KB