• P
    [PATCH] uml ubd driver: ubd_io_lock usage fixup · 33f775ee
    Paolo 'Blaisorblade' Giarrusso 提交于
    Add some comments about requirements for ubd_io_lock and expand its use.
    
    When an irq signals that the "controller" (i.e.  another thread on the host,
    which does the actual requests and is the only one blocked on I/O on the host)
    has done some work, we call again the request function ourselves
    (do_ubd_request).
    
    We now do that with ubd_io_lock held - that's useful to protect against
    concurrent calls to elv_next_request and so on.
    
    XXX: Maybe we shouldn't call at all the request function.  Input needed on
    this.  Are we supposed to plug and unplug the queue?  That code "indirectly"
    does that by setting a flag, called do_ubd, which makes the request function
    return (it's a residual of 2.4 block layer interface).
    
    Meanwhile, however, merge this patch, which improves things.
    
    Cc: Jens Axboe <axboe@suse.de>
    Signed-off-by: NPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
    Cc: Jeff Dike <jdike@addtoit.com>
    Signed-off-by: NAndrew Morton <akpm@osdl.org>
    Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
    33f775ee
ubd_kern.c 32.0 KB