• J
    mm/memcontrol.c: fix uninitialized variable use in mem_cgroup_move_parent() · 8dba474f
    Jesper Juhl 提交于
    In mm/memcontrol.c::mem_cgroup_move_parent() there's a path that jumps
    to the 'put_back' label
    
      	ret = __mem_cgroup_try_charge(NULL, gfp_mask, &parent, false, charge);
      	if (ret || !parent)
      		goto put_back;
    
    where we'll
    
      	if (charge > PAGE_SIZE)
      		compound_unlock_irqrestore(page, flags);
    
    but, we have not assigned anything to 'flags' at this point, nor have we
    called 'compound_lock_irqsave()' (which is what sets 'flags').  The
    'put_back' label should be moved below the call to
    compound_unlock_irqrestore() as per this patch.
    Signed-off-by: NJesper Juhl <jj@chaosbits.net>
    Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
    Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
    Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    Cc: Pavel Emelianov <xemul@openvz.org>
    Cc: "Kirill A. Shutemov" <kirill@shutemov.name>
    Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
    8dba474f
memcontrol.c 129.8 KB