• J
    V4L/DVB: IR/mceusb: more streamlining of device init · 22b0766b
    Jarod Wilson 提交于
    Spent a while last night getting device initialization packet captures
    under Windows for all generations of devices. There are a few places
    where we were doing things differently, and few things we were doing
    that we don't need to do, particularly on gen3 hardware, and I *think*
    one of those things is what was locking up my pinnacle hw from time to
    time -- at least, its been perfectly well behaved every time its been
    plugged in since making this change.
    
    First up, we're adding a bit more to the gen1 init routine here. Its
    not absolutely necessary, the hardware works the same both with and
    without it, but I'd like to be consistent w/Windows here.
    
    Second, DEVICE_RESET is never called when initializing either of my
    gen3 devices, its only called for gen1 and gen2. The bits in the gen3
    init after removing that, are safe (and interesting) to run on all
    hardware, so there's no more gen3-specific init done, there's instead
    a generic mceusb_get_parameters() that is run for all hardware.
    
    Third, the gen3 flag isn't needed. We only care if hardware is gen3
    during probe, so I've dropped that from the device flags struct.
    
    Successfully tested on all three generations of mceusb hardware.
    Signed-off-by: NJarod Wilson <jarod@redhat.com>
    Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
    22b0766b
mceusb.c 31.5 KB