• E
    KEYS: encrypted: fix dereference of NULL user_key_payload · 13923d08
    Eric Biggers 提交于
    A key of type "encrypted" references a "master key" which is used to
    encrypt and decrypt the encrypted key's payload.  However, when we
    accessed the master key's payload, we failed to handle the case where
    the master key has been revoked, which sets the payload pointer to NULL.
    Note that request_key() *does* skip revoked keys, but there is still a
    window where the key can be revoked before we acquire its semaphore.
    
    Fix it by checking for a NULL payload, treating it like a key which was
    already revoked at the time it was requested.
    
    This was an issue for master keys of type "user" only.  Master keys can
    also be of type "trusted", but those cannot be revoked.
    
    Fixes: 7e70cb49 ("keys: add new key-type encrypted")
    Reviewed-by: NJames Morris <james.l.morris@oracle.com>
    Cc: <stable@vger.kernel.org>    [v2.6.38+]
    Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
    Cc: David Safford <safford@us.ibm.com>
    Signed-off-by: NEric Biggers <ebiggers@google.com>
    Signed-off-by: NDavid Howells <dhowells@redhat.com>
    13923d08
encrypted.c 25.9 KB