• S
    CPU hotplug, perf: Fix CPU hotplug callback registration · f0bdb5e0
    Srivatsa S. Bhat 提交于
    Subsystems that want to register CPU hotplug callbacks, as well as perform
    initialization for the CPUs that are already online, often do it as shown
    below:
    
    	get_online_cpus();
    
    	for_each_online_cpu(cpu)
    		init_cpu(cpu);
    
    	register_cpu_notifier(&foobar_cpu_notifier);
    
    	put_online_cpus();
    
    This is wrong, since it is prone to ABBA deadlocks involving the
    cpu_add_remove_lock and the cpu_hotplug.lock (when running concurrently
    with CPU hotplug operations).
    
    Instead, the correct and race-free way of performing the callback
    registration is:
    
    	cpu_notifier_register_begin();
    
    	for_each_online_cpu(cpu)
    		init_cpu(cpu);
    
    	/* Note the use of the double underscored version of the API */
    	__register_cpu_notifier(&foobar_cpu_notifier);
    
    	cpu_notifier_register_done();
    
    Fix the perf subsystem's hotplug notifier by using this latter form of
    callback registration.
    
    Also provide a bare-bones version of perf_cpu_notifier() that doesn't
    invoke the notifiers for the already online CPUs. This would be useful
    for subsystems that need to perform a different set of initialization
    for the already online CPUs, or don't need the initialization altogether.
    
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
    Signed-off-by: NSrivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
    Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
    f0bdb5e0
perf_event.h 24.4 KB