• G
    thermal: rcar: Fix race condition between init and interrupt · 0b37a83a
    Geert Uytterhoeven 提交于
    As soon as the interrupt has been enabled by devm_request_irq(), the
    interrupt routine may be called, depending on the current status of the
    hardware.
    
    However, at that point rcar_thermal_common hasn't been initialized
    complely yet. E.g. rcar_thermal_common.base is still NULL, causing a
    NULL pointer dereference:
    
        Unable to handle kernel NULL pointer dereference at virtual address 0000000c
        pgd = c0004000
        [0000000c] *pgd=00000000
        Internal error: Oops: 5 [#1] SMP ARM
        CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc7-ape6evm-04564-gb6e46cb7cbe82389 #30
        Hardware name: Generic R8A73A4 (Flattened Device Tree)
        task: ee8953c0 ti: ee896000 task.ti: ee896000
        PC is at rcar_thermal_irq+0x1c/0xf0
        LR is at _raw_spin_lock_irqsave+0x48/0x54
    
    Postpone the call to devm_request_irq() until all initialization has
    been done to fix this.
    Signed-off-by: NGeert Uytterhoeven <geert+renesas@glider.be>
    Acked-by: NKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Signed-off-by: NEduardo Valentin <edubezval@gmail.com>
    0b37a83a
rcar_thermal.c 12.1 KB