• D
    scsi: Define usercopy region in scsi_sense_cache slab cache · 0afe76e8
    David Windsor 提交于
    SCSI sense buffers, stored in struct scsi_cmnd.sense and therefore
    contained in the scsi_sense_cache slab cache, need to be copied to/from
    userspace.
    
    cache object allocation:
        drivers/scsi/scsi_lib.c:
            scsi_select_sense_cache(...):
                return ... ? scsi_sense_isadma_cache : scsi_sense_cache
    
            scsi_alloc_sense_buffer(...):
                return kmem_cache_alloc_node(scsi_select_sense_cache(), ...);
    
            scsi_init_request(...):
                ...
                cmd->sense_buffer = scsi_alloc_sense_buffer(...);
                ...
                cmd->req.sense = cmd->sense_buffer
    
    example usage trace:
    
        block/scsi_ioctl.c:
            (inline from sg_io)
            blk_complete_sghdr_rq(...):
                struct scsi_request *req = scsi_req(rq);
                ...
                copy_to_user(..., req->sense, len)
    
            scsi_cmd_ioctl(...):
                sg_io(...);
    
    In support of usercopy hardening, this patch defines a region in
    the scsi_sense_cache slab cache in which userspace copy operations
    are allowed.
    
    This region is known as the slab cache's usercopy region. Slab caches
    can now check that each dynamically sized copy operation involving
    cache-managed memory falls entirely within the slab's usercopy region.
    Signed-off-by: NDavid Windsor <dave@nullcore.net>
    [kees: adjust commit log, provide usage trace]
    Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>
    Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
    Cc: linux-scsi@vger.kernel.org
    Signed-off-by: NKees Cook <keescook@chromium.org>
    0afe76e8
scsi_lib.c 90.7 KB