• T
    V4L/DVB (6334): cx88: Change (struct cx8802_dev)->drvlist to a list_head and fix bugs · 081c2fc8
    Trent Piepho 提交于
    It was a struct cx8802_driver for no apparent reason.  Nothing uses a
    cx8802_driver in the cx8802_dev struct.  The only field that was used was
    devlist, a list_head.
    
    The code in cx8802_remove() that removed any loaded sub-drivers was broken.
    It would delete the current list entry, but didn't use list_for_each_safe.  It
    also called list_del() on the list _head_ inside the list_for_each loop?  It
    would crash if it was run, which I don't think can ever happen.
    
    Since the cx8802 sub-drivers use the cx8802 driver, they have to be unloaded
    first.  So there isn't any way for a sub-driver to still be loaded when
    cx8802_remove() is called...  Except maybe with PCI hot-plug, if one removes
    the PCI card while the drivers are loaded?
    
    So I left some code in to handle that if it's actually possible.  It will
    remove the sub-drivers from the device cx8802_remove() was called on, and only
    that device.  If one has two DVB cards and unplugs one, there is no reason to
    unload the DVB drivers for both cards.  I have no way to test this, but it
    can't be worse than what was there before.
    
    cx8802_get_driver() is passed a cx8802_dev pointer and looks for the requested
    driver on that device.  It first loops over the cx8802 device list looking for
    the device it was passed, which is pointless.  It doesn't need to find the
    device pointer in the list, as it already has the pointer.
    
    The list_head in the cx8802_driver struct, which joins all the _drivers_
    attached to a device, was named devlist.  Changed that to drvlist, since the
    devlist is used for a list of _devices_ in other cx8802 structs.
    Signed-off-by: NTrent Piepho <xyzzy@speakeasy.org>
    Reviewed-by: NMichael Krufky <mkrufky@linuxtv.org>
    Signed-off-by: NMauro Carvalho Chehab <mchehab@infradead.org>
    081c2fc8
cx88.h 20.4 KB