• C
    dma-mapping: fix sync_single_range_* DMA debugging · 07a72309
    Clemens Ladisch 提交于
    Commit 5fd75a78 (dma-mapping: remove unnecessary sync_single_range_*
    in dma_map_ops) unified not only the dma_map_ops but also the
    corresponding debug_dma_sync_* calls.  This led to spurious WARN()ings
    like the following because the DMA debug code was no longer able to detect
    the DMA buffer base address without the separate offset parameter:
    
    WARNING: at lib/dma-debug.c:911 check_sync+0xce/0x446()
    firewire_ohci 0000:04:00.0: DMA-API: device driver tries to sync DMA memory it has not allocated [device address=0x00000000cedaa400] [size=1024 bytes]
    Call Trace: ...
     [<ffffffff811326a5>] check_sync+0xce/0x446
     [<ffffffff81132ad9>] debug_dma_sync_single_for_device+0x39/0x3b
     [<ffffffffa01d6e6a>] ohci_queue_iso+0x4f3/0x77d [firewire_ohci]
     ...
    
    To fix this, unshare the sync_single_* and sync_single_range_*
    implementations so that we are able to call the correct debug_dma_sync_*
    functions.
    
    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: NClemens Ladisch <clemens@ladisch.de>
    Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
    Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
    07a72309
dma-mapping-common.h 5.2 KB