dir.c 24.9 KB
Newer Older
M
Miklos Szeredi 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14
/*
 *
 * Copyright (C) 2011 Novell Inc.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 as published by
 * the Free Software Foundation.
 */

#include <linux/fs.h>
#include <linux/namei.h>
#include <linux/xattr.h>
#include <linux/security.h>
#include <linux/cred.h>
15
#include <linux/module.h>
16 17
#include <linux/posix_acl.h>
#include <linux/posix_acl_xattr.h>
18
#include <linux/atomic.h>
M
Miklos Szeredi 已提交
19
#include <linux/ratelimit.h>
M
Miklos Szeredi 已提交
20 21
#include "overlayfs.h"

22 23 24 25 26
static unsigned short ovl_redirect_max = 256;
module_param_named(redirect_max, ovl_redirect_max, ushort, 0644);
MODULE_PARM_DESC(ovl_redirect_max,
		 "Maximum length of absolute redirect xattr value");

M
Miklos Szeredi 已提交
27 28 29 30 31
void ovl_cleanup(struct inode *wdir, struct dentry *wdentry)
{
	int err;

	dget(wdentry);
32
	if (d_is_dir(wdentry))
M
Miklos Szeredi 已提交
33 34 35 36 37 38 39 40 41 42 43
		err = ovl_do_rmdir(wdir, wdentry);
	else
		err = ovl_do_unlink(wdir, wdentry);
	dput(wdentry);

	if (err) {
		pr_err("overlayfs: cleanup of '%pd2' failed (%i)\n",
		       wdentry, err);
	}
}

44
struct dentry *ovl_lookup_temp(struct dentry *workdir)
M
Miklos Szeredi 已提交
45 46 47
{
	struct dentry *temp;
	char name[20];
48
	static atomic_t temp_id = ATOMIC_INIT(0);
M
Miklos Szeredi 已提交
49

50 51
	/* counter is allowed to wrap, since temp dentries are ephemeral */
	snprintf(name, sizeof(name), "#%x", atomic_inc_return(&temp_id));
M
Miklos Szeredi 已提交
52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70

	temp = lookup_one_len(name, workdir, strlen(name));
	if (!IS_ERR(temp) && temp->d_inode) {
		pr_err("overlayfs: workdir/%s already exists\n", name);
		dput(temp);
		temp = ERR_PTR(-EIO);
	}

	return temp;
}

/* caller holds i_mutex on workdir */
static struct dentry *ovl_whiteout(struct dentry *workdir,
				   struct dentry *dentry)
{
	int err;
	struct dentry *whiteout;
	struct inode *wdir = workdir->d_inode;

71
	whiteout = ovl_lookup_temp(workdir);
M
Miklos Szeredi 已提交
72 73 74 75 76 77 78 79 80 81 82 83 84
	if (IS_ERR(whiteout))
		return whiteout;

	err = ovl_do_whiteout(wdir, whiteout);
	if (err) {
		dput(whiteout);
		whiteout = ERR_PTR(err);
	}

	return whiteout;
}

int ovl_create_real(struct inode *dir, struct dentry *newdentry,
A
Al Viro 已提交
85
		    struct cattr *attr, struct dentry *hardlink, bool debug)
M
Miklos Szeredi 已提交
86 87 88 89 90 91 92 93 94
{
	int err;

	if (newdentry->d_inode)
		return -ESTALE;

	if (hardlink) {
		err = ovl_do_link(hardlink, dir, newdentry, debug);
	} else {
A
Al Viro 已提交
95
		switch (attr->mode & S_IFMT) {
M
Miklos Szeredi 已提交
96
		case S_IFREG:
A
Al Viro 已提交
97
			err = ovl_do_create(dir, newdentry, attr->mode, debug);
M
Miklos Szeredi 已提交
98 99 100
			break;

		case S_IFDIR:
A
Al Viro 已提交
101
			err = ovl_do_mkdir(dir, newdentry, attr->mode, debug);
M
Miklos Szeredi 已提交
102 103 104 105 106 107 108
			break;

		case S_IFCHR:
		case S_IFBLK:
		case S_IFIFO:
		case S_IFSOCK:
			err = ovl_do_mknod(dir, newdentry,
A
Al Viro 已提交
109
					   attr->mode, attr->rdev, debug);
M
Miklos Szeredi 已提交
110 111 112
			break;

		case S_IFLNK:
A
Al Viro 已提交
113
			err = ovl_do_symlink(dir, newdentry, attr->link, debug);
M
Miklos Szeredi 已提交
114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129
			break;

		default:
			err = -EPERM;
		}
	}
	if (!err && WARN_ON(!newdentry->d_inode)) {
		/*
		 * Not quite sure if non-instantiated dentry is legal or not.
		 * VFS doesn't seem to care so check and warn here.
		 */
		err = -ENOENT;
	}
	return err;
}

130 131
static int ovl_set_opaque_xerr(struct dentry *dentry, struct dentry *upper,
			       int xerr)
M
Miklos Szeredi 已提交
132
{
M
Miklos Szeredi 已提交
133 134
	int err;

135
	err = ovl_check_setxattr(dentry, upper, OVL_XATTR_OPAQUE, "y", 1, xerr);
M
Miklos Szeredi 已提交
136 137 138 139
	if (!err)
		ovl_dentry_set_opaque(dentry);

	return err;
M
Miklos Szeredi 已提交
140 141
}

142 143 144 145 146 147 148 149 150 151
static int ovl_set_opaque(struct dentry *dentry, struct dentry *upperdentry)
{
	/*
	 * Fail with -EIO when trying to create opaque dir and upper doesn't
	 * support xattrs. ovl_rename() calls ovl_set_opaque_xerr(-EXDEV) to
	 * return a specific error for noxattr case.
	 */
	return ovl_set_opaque_xerr(dentry, upperdentry, -EIO);
}

152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167
static int ovl_set_impure(struct dentry *dentry, struct dentry *upperdentry)
{
	int err;

	/*
	 * Do not fail when upper doesn't support xattrs.
	 * Upper inodes won't have origin nor redirect xattr anyway.
	 */
	err = ovl_check_setxattr(dentry, upperdentry, OVL_XATTR_IMPURE,
				 "y", 1, 0);
	if (!err)
		ovl_dentry_set_impure(dentry);

	return err;
}

168 169
/* Common operations required to be done after creation of file on upper */
static void ovl_instantiate(struct dentry *dentry, struct inode *inode,
M
Miklos Szeredi 已提交
170
			    struct dentry *newdentry, bool hardlink)
171 172 173
{
	ovl_dentry_version_inc(dentry->d_parent);
	ovl_dentry_update(dentry, newdentry);
M
Miklos Szeredi 已提交
174 175 176 177 178 179 180
	if (!hardlink) {
		ovl_inode_update(inode, d_inode(newdentry));
		ovl_copyattr(newdentry->d_inode, inode);
	} else {
		WARN_ON(ovl_inode_real(inode, NULL) != d_inode(newdentry));
		inc_nlink(inode);
	}
181
	d_instantiate(dentry, inode);
182 183 184
	/* Force lookup of new upper hardlink to find its lower */
	if (hardlink)
		d_drop(dentry);
185 186
}

187 188 189 190 191
static bool ovl_type_merge(struct dentry *dentry)
{
	return OVL_TYPE_MERGE(ovl_path_type(dentry));
}

192 193 194 195 196
static bool ovl_type_origin(struct dentry *dentry)
{
	return OVL_TYPE_ORIGIN(ovl_path_type(dentry));
}

M
Miklos Szeredi 已提交
197
static int ovl_create_upper(struct dentry *dentry, struct inode *inode,
A
Al Viro 已提交
198
			    struct cattr *attr, struct dentry *hardlink)
M
Miklos Szeredi 已提交
199 200 201 202 203 204
{
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct dentry *newdentry;
	int err;

205
	if (!hardlink && !IS_POSIXACL(udir))
A
Al Viro 已提交
206
		attr->mode &= ~current_umask();
207

A
Al Viro 已提交
208
	inode_lock_nested(udir, I_MUTEX_PARENT);
M
Miklos Szeredi 已提交
209 210 211 212 213
	newdentry = lookup_one_len(dentry->d_name.name, upperdir,
				   dentry->d_name.len);
	err = PTR_ERR(newdentry);
	if (IS_ERR(newdentry))
		goto out_unlock;
A
Al Viro 已提交
214
	err = ovl_create_real(udir, newdentry, attr, hardlink, false);
M
Miklos Szeredi 已提交
215 216 217
	if (err)
		goto out_dput;

218
	if (ovl_type_merge(dentry->d_parent) && d_is_dir(newdentry)) {
219 220 221 222
		/* Setting opaque here is just an optimization, allow to fail */
		ovl_set_opaque(dentry, newdentry);
	}

M
Miklos Szeredi 已提交
223
	ovl_instantiate(dentry, inode, newdentry, !!hardlink);
M
Miklos Szeredi 已提交
224 225 226 227
	newdentry = NULL;
out_dput:
	dput(newdentry);
out_unlock:
A
Al Viro 已提交
228
	inode_unlock(udir);
M
Miklos Szeredi 已提交
229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264
	return err;
}

static int ovl_lock_rename_workdir(struct dentry *workdir,
				   struct dentry *upperdir)
{
	/* Workdir should not be the same as upperdir */
	if (workdir == upperdir)
		goto err;

	/* Workdir should not be subdir of upperdir and vice versa */
	if (lock_rename(workdir, upperdir) != NULL)
		goto err_unlock;

	return 0;

err_unlock:
	unlock_rename(workdir, upperdir);
err:
	pr_err("overlayfs: failed to lock workdir+upperdir\n");
	return -EIO;
}

static struct dentry *ovl_clear_empty(struct dentry *dentry,
				      struct list_head *list)
{
	struct dentry *workdir = ovl_workdir(dentry);
	struct inode *wdir = workdir->d_inode;
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct path upperpath;
	struct dentry *upper;
	struct dentry *opaquedir;
	struct kstat stat;
	int err;

265 266 267
	if (WARN_ON(!workdir))
		return ERR_PTR(-EROFS);

M
Miklos Szeredi 已提交
268 269 270 271 272
	err = ovl_lock_rename_workdir(workdir, upperdir);
	if (err)
		goto out;

	ovl_path_upper(dentry, &upperpath);
273 274
	err = vfs_getattr(&upperpath, &stat,
			  STATX_BASIC_STATS, AT_STATX_SYNC_AS_STAT);
M
Miklos Szeredi 已提交
275 276 277 278 279 280 281 282 283 284
	if (err)
		goto out_unlock;

	err = -ESTALE;
	if (!S_ISDIR(stat.mode))
		goto out_unlock;
	upper = upperpath.dentry;
	if (upper->d_parent->d_inode != udir)
		goto out_unlock;

285
	opaquedir = ovl_lookup_temp(workdir);
M
Miklos Szeredi 已提交
286 287 288 289
	err = PTR_ERR(opaquedir);
	if (IS_ERR(opaquedir))
		goto out_unlock;

A
Al Viro 已提交
290 291
	err = ovl_create_real(wdir, opaquedir,
			      &(struct cattr){.mode = stat.mode}, NULL, true);
M
Miklos Szeredi 已提交
292 293 294 295 296 297 298
	if (err)
		goto out_dput;

	err = ovl_copy_xattr(upper, opaquedir);
	if (err)
		goto out_cleanup;

M
Miklos Szeredi 已提交
299
	err = ovl_set_opaque(dentry, opaquedir);
M
Miklos Szeredi 已提交
300 301 302
	if (err)
		goto out_cleanup;

A
Al Viro 已提交
303
	inode_lock(opaquedir->d_inode);
M
Miklos Szeredi 已提交
304
	err = ovl_set_attr(opaquedir, &stat);
A
Al Viro 已提交
305
	inode_unlock(opaquedir->d_inode);
M
Miklos Szeredi 已提交
306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331
	if (err)
		goto out_cleanup;

	err = ovl_do_rename(wdir, opaquedir, udir, upper, RENAME_EXCHANGE);
	if (err)
		goto out_cleanup;

	ovl_cleanup_whiteouts(upper, list);
	ovl_cleanup(wdir, upper);
	unlock_rename(workdir, upperdir);

	/* dentry's upper doesn't match now, get rid of it */
	d_drop(dentry);

	return opaquedir;

out_cleanup:
	ovl_cleanup(wdir, opaquedir);
out_dput:
	dput(opaquedir);
out_unlock:
	unlock_rename(workdir, upperdir);
out:
	return ERR_PTR(err);
}

M
Miklos Szeredi 已提交
332
static struct dentry *ovl_check_empty_and_clear(struct dentry *dentry)
M
Miklos Szeredi 已提交
333 334 335
{
	int err;
	struct dentry *ret = NULL;
M
Miklos Szeredi 已提交
336
	enum ovl_path_type type = ovl_path_type(dentry);
M
Miklos Szeredi 已提交
337 338 339
	LIST_HEAD(list);

	err = ovl_check_empty_dir(dentry, &list);
M
Miklos Szeredi 已提交
340
	if (err) {
M
Miklos Szeredi 已提交
341
		ret = ERR_PTR(err);
M
Miklos Szeredi 已提交
342
		goto out_free;
M
Miklos Szeredi 已提交
343
	}
M
Miklos Szeredi 已提交
344

M
Miklos Szeredi 已提交
345 346 347 348 349 350 351 352 353 354 355 356 357 358
	/*
	 * When removing an empty opaque directory, then it makes no sense to
	 * replace it with an exact replica of itself.
	 *
	 * If no upperdentry then skip clearing whiteouts.
	 *
	 * Can race with copy-up, since we don't hold the upperdir mutex.
	 * Doesn't matter, since copy-up can't create a non-empty directory
	 * from an empty one.
	 */
	if (OVL_TYPE_UPPER(type) && OVL_TYPE_MERGE(type))
		ret = ovl_clear_empty(dentry, &list);

out_free:
M
Miklos Szeredi 已提交
359 360 361 362 363
	ovl_cache_free(&list);

	return ret;
}

364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389
static int ovl_set_upper_acl(struct dentry *upperdentry, const char *name,
			     const struct posix_acl *acl)
{
	void *buffer;
	size_t size;
	int err;

	if (!IS_ENABLED(CONFIG_FS_POSIX_ACL) || !acl)
		return 0;

	size = posix_acl_to_xattr(NULL, acl, NULL, 0);
	buffer = kmalloc(size, GFP_KERNEL);
	if (!buffer)
		return -ENOMEM;

	size = posix_acl_to_xattr(&init_user_ns, acl, buffer, size);
	err = size;
	if (err < 0)
		goto out_free;

	err = vfs_setxattr(upperdentry, name, buffer, size, XATTR_CREATE);
out_free:
	kfree(buffer);
	return err;
}

M
Miklos Szeredi 已提交
390
static int ovl_create_over_whiteout(struct dentry *dentry, struct inode *inode,
A
Al Viro 已提交
391
				    struct cattr *cattr,
M
Miklos Szeredi 已提交
392 393 394 395 396 397 398 399 400
				    struct dentry *hardlink)
{
	struct dentry *workdir = ovl_workdir(dentry);
	struct inode *wdir = workdir->d_inode;
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct dentry *upper;
	struct dentry *newdentry;
	int err;
401
	struct posix_acl *acl, *default_acl;
M
Miklos Szeredi 已提交
402

403 404 405
	if (WARN_ON(!workdir))
		return -EROFS;

406 407
	if (!hardlink) {
		err = posix_acl_create(dentry->d_parent->d_inode,
A
Al Viro 已提交
408
				       &cattr->mode, &default_acl, &acl);
409 410 411 412
		if (err)
			return err;
	}

M
Miklos Szeredi 已提交
413 414 415 416
	err = ovl_lock_rename_workdir(workdir, upperdir);
	if (err)
		goto out;

417
	newdentry = ovl_lookup_temp(workdir);
M
Miklos Szeredi 已提交
418 419 420 421 422 423 424 425 426 427
	err = PTR_ERR(newdentry);
	if (IS_ERR(newdentry))
		goto out_unlock;

	upper = lookup_one_len(dentry->d_name.name, upperdir,
			       dentry->d_name.len);
	err = PTR_ERR(upper);
	if (IS_ERR(upper))
		goto out_dput;

A
Al Viro 已提交
428
	err = ovl_create_real(wdir, newdentry, cattr, hardlink, true);
M
Miklos Szeredi 已提交
429 430 431
	if (err)
		goto out_dput2;

M
Miklos Szeredi 已提交
432 433 434
	/*
	 * mode could have been mutilated due to umask (e.g. sgid directory)
	 */
M
Miklos Szeredi 已提交
435
	if (!hardlink &&
A
Al Viro 已提交
436 437
	    !S_ISLNK(cattr->mode) &&
	    newdentry->d_inode->i_mode != cattr->mode) {
M
Miklos Szeredi 已提交
438 439
		struct iattr attr = {
			.ia_valid = ATTR_MODE,
A
Al Viro 已提交
440
			.ia_mode = cattr->mode,
M
Miklos Szeredi 已提交
441 442 443 444 445 446 447
		};
		inode_lock(newdentry->d_inode);
		err = notify_change(newdentry, &attr, NULL);
		inode_unlock(newdentry->d_inode);
		if (err)
			goto out_cleanup;
	}
448 449 450 451 452 453 454 455 456 457 458
	if (!hardlink) {
		err = ovl_set_upper_acl(newdentry, XATTR_NAME_POSIX_ACL_ACCESS,
					acl);
		if (err)
			goto out_cleanup;

		err = ovl_set_upper_acl(newdentry, XATTR_NAME_POSIX_ACL_DEFAULT,
					default_acl);
		if (err)
			goto out_cleanup;
	}
M
Miklos Szeredi 已提交
459

A
Al Viro 已提交
460
	if (!hardlink && S_ISDIR(cattr->mode)) {
M
Miklos Szeredi 已提交
461
		err = ovl_set_opaque(dentry, newdentry);
M
Miklos Szeredi 已提交
462 463 464 465 466 467 468 469 470 471 472 473 474 475
		if (err)
			goto out_cleanup;

		err = ovl_do_rename(wdir, newdentry, udir, upper,
				    RENAME_EXCHANGE);
		if (err)
			goto out_cleanup;

		ovl_cleanup(wdir, upper);
	} else {
		err = ovl_do_rename(wdir, newdentry, udir, upper, 0);
		if (err)
			goto out_cleanup;
	}
M
Miklos Szeredi 已提交
476
	ovl_instantiate(dentry, inode, newdentry, !!hardlink);
M
Miklos Szeredi 已提交
477 478 479 480 481 482 483 484
	newdentry = NULL;
out_dput2:
	dput(upper);
out_dput:
	dput(newdentry);
out_unlock:
	unlock_rename(workdir, upperdir);
out:
485 486 487 488
	if (!hardlink) {
		posix_acl_release(acl);
		posix_acl_release(default_acl);
	}
M
Miklos Szeredi 已提交
489 490 491 492 493 494 495
	return err;

out_cleanup:
	ovl_cleanup(wdir, newdentry);
	goto out_dput2;
}

M
Miklos Szeredi 已提交
496
static int ovl_create_or_link(struct dentry *dentry, struct inode *inode,
A
Al Viro 已提交
497
			      struct cattr *attr, struct dentry *hardlink)
M
Miklos Szeredi 已提交
498 499
{
	int err;
500 501
	const struct cred *old_cred;
	struct cred *override_cred;
M
Miklos Szeredi 已提交
502 503 504

	err = ovl_copy_up(dentry->d_parent);
	if (err)
M
Miklos Szeredi 已提交
505
		return err;
M
Miklos Szeredi 已提交
506

507 508 509 510
	old_cred = ovl_override_creds(dentry->d_sb);
	err = -ENOMEM;
	override_cred = prepare_creds();
	if (override_cred) {
M
Miklos Szeredi 已提交
511 512
		override_cred->fsuid = inode->i_uid;
		override_cred->fsgid = inode->i_gid;
513 514
		if (!hardlink) {
			err = security_dentry_create_files_as(dentry,
A
Al Viro 已提交
515
					attr->mode, &dentry->d_name, old_cred,
516 517 518 519 520 521
					override_cred);
			if (err) {
				put_cred(override_cred);
				goto out_revert_creds;
			}
		}
522 523 524
		put_cred(override_creds(override_cred));
		put_cred(override_cred);

M
Miklos Szeredi 已提交
525
		if (!ovl_dentry_is_whiteout(dentry))
A
Al Viro 已提交
526
			err = ovl_create_upper(dentry, inode, attr,
527 528
						hardlink);
		else
A
Al Viro 已提交
529 530
			err = ovl_create_over_whiteout(dentry, inode, attr,
							hardlink);
M
Miklos Szeredi 已提交
531
	}
532
out_revert_creds:
533
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
534 535 536 537 538 539 540
	if (!err) {
		struct inode *realinode = d_inode(ovl_dentry_upper(dentry));

		WARN_ON(inode->i_mode != realinode->i_mode);
		WARN_ON(!uid_eq(inode->i_uid, realinode->i_uid));
		WARN_ON(!gid_eq(inode->i_gid, realinode->i_gid));
	}
M
Miklos Szeredi 已提交
541 542 543 544 545 546 547
	return err;
}

static int ovl_create_object(struct dentry *dentry, int mode, dev_t rdev,
			     const char *link)
{
	int err;
M
Miklos Szeredi 已提交
548
	struct inode *inode;
A
Al Viro 已提交
549
	struct cattr attr = {
M
Miklos Szeredi 已提交
550
		.rdev = rdev,
A
Al Viro 已提交
551
		.link = link,
M
Miklos Szeredi 已提交
552
	};
M
Miklos Szeredi 已提交
553 554

	err = ovl_want_write(dentry);
M
Miklos Szeredi 已提交
555 556 557 558
	if (err)
		goto out;

	err = -ENOMEM;
559
	inode = ovl_new_inode(dentry->d_sb, mode, rdev);
M
Miklos Szeredi 已提交
560 561 562 563
	if (!inode)
		goto out_drop_write;

	inode_init_owner(inode, dentry->d_parent->d_inode, mode);
A
Al Viro 已提交
564
	attr.mode = inode->i_mode;
M
Miklos Szeredi 已提交
565

A
Al Viro 已提交
566
	err = ovl_create_or_link(dentry, inode, &attr, NULL);
M
Miklos Szeredi 已提交
567 568
	if (err)
		iput(inode);
M
Miklos Szeredi 已提交
569

M
Miklos Szeredi 已提交
570 571 572
out_drop_write:
	ovl_drop_write(dentry);
out:
M
Miklos Szeredi 已提交
573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606
	return err;
}

static int ovl_create(struct inode *dir, struct dentry *dentry, umode_t mode,
		      bool excl)
{
	return ovl_create_object(dentry, (mode & 07777) | S_IFREG, 0, NULL);
}

static int ovl_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
{
	return ovl_create_object(dentry, (mode & 07777) | S_IFDIR, 0, NULL);
}

static int ovl_mknod(struct inode *dir, struct dentry *dentry, umode_t mode,
		     dev_t rdev)
{
	/* Don't allow creation of "whiteout" on overlay */
	if (S_ISCHR(mode) && rdev == WHITEOUT_DEV)
		return -EPERM;

	return ovl_create_object(dentry, mode, rdev, NULL);
}

static int ovl_symlink(struct inode *dir, struct dentry *dentry,
		       const char *link)
{
	return ovl_create_object(dentry, S_IFLNK, 0, link);
}

static int ovl_link(struct dentry *old, struct inode *newdir,
		    struct dentry *new)
{
	int err;
M
Miklos Szeredi 已提交
607
	struct inode *inode;
M
Miklos Szeredi 已提交
608 609 610 611 612 613 614 615 616

	err = ovl_want_write(old);
	if (err)
		goto out;

	err = ovl_copy_up(old);
	if (err)
		goto out_drop_write;

M
Miklos Szeredi 已提交
617 618 619
	inode = d_inode(old);
	ihold(inode);

A
Al Viro 已提交
620
	err = ovl_create_or_link(new, inode, NULL, ovl_dentry_upper(old));
M
Miklos Szeredi 已提交
621 622
	if (err)
		iput(inode);
M
Miklos Szeredi 已提交
623 624 625 626 627 628 629

out_drop_write:
	ovl_drop_write(old);
out:
	return err;
}

M
Miklos Szeredi 已提交
630
static int ovl_remove_and_whiteout(struct dentry *dentry, bool is_dir)
M
Miklos Szeredi 已提交
631 632 633 634 635 636 637 638 639
{
	struct dentry *workdir = ovl_workdir(dentry);
	struct inode *wdir = workdir->d_inode;
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *udir = upperdir->d_inode;
	struct dentry *whiteout;
	struct dentry *upper;
	struct dentry *opaquedir = NULL;
	int err;
640
	int flags = 0;
M
Miklos Szeredi 已提交
641

642 643 644
	if (WARN_ON(!workdir))
		return -EROFS;

645
	if (is_dir) {
M
Miklos Szeredi 已提交
646 647 648 649
		opaquedir = ovl_check_empty_and_clear(dentry);
		err = PTR_ERR(opaquedir);
		if (IS_ERR(opaquedir))
			goto out;
M
Miklos Szeredi 已提交
650 651 652 653 654 655
	}

	err = ovl_lock_rename_workdir(workdir, upperdir);
	if (err)
		goto out_dput;

656 657 658 659
	upper = lookup_one_len(dentry->d_name.name, upperdir,
			       dentry->d_name.len);
	err = PTR_ERR(upper);
	if (IS_ERR(upper))
M
Miklos Szeredi 已提交
660 661
		goto out_unlock;

662 663 664 665 666 667
	err = -ESTALE;
	if ((opaquedir && upper != opaquedir) ||
	    (!opaquedir && ovl_dentry_upper(dentry) &&
	     upper != ovl_dentry_upper(dentry))) {
		goto out_dput_upper;
	}
M
Miklos Szeredi 已提交
668

669 670 671 672
	whiteout = ovl_whiteout(workdir, dentry);
	err = PTR_ERR(whiteout);
	if (IS_ERR(whiteout))
		goto out_dput_upper;
M
Miklos Szeredi 已提交
673

674 675
	if (d_is_dir(upper))
		flags = RENAME_EXCHANGE;
M
Miklos Szeredi 已提交
676

677 678 679 680 681
	err = ovl_do_rename(wdir, whiteout, udir, upper, flags);
	if (err)
		goto kill_whiteout;
	if (flags)
		ovl_cleanup(wdir, upper);
M
Miklos Szeredi 已提交
682 683 684 685 686

	ovl_dentry_version_inc(dentry->d_parent);
out_d_drop:
	d_drop(dentry);
	dput(whiteout);
687 688
out_dput_upper:
	dput(upper);
M
Miklos Szeredi 已提交
689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704
out_unlock:
	unlock_rename(workdir, upperdir);
out_dput:
	dput(opaquedir);
out:
	return err;

kill_whiteout:
	ovl_cleanup(wdir, whiteout);
	goto out_d_drop;
}

static int ovl_remove_upper(struct dentry *dentry, bool is_dir)
{
	struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
	struct inode *dir = upperdir->d_inode;
705
	struct dentry *upper;
706
	struct dentry *opaquedir = NULL;
M
Miklos Szeredi 已提交
707 708
	int err;

709 710 711 712 713 714 715 716
	/* Redirect dir can be !ovl_lower_positive && OVL_TYPE_MERGE */
	if (is_dir && ovl_dentry_get_redirect(dentry)) {
		opaquedir = ovl_check_empty_and_clear(dentry);
		err = PTR_ERR(opaquedir);
		if (IS_ERR(opaquedir))
			goto out;
	}

A
Al Viro 已提交
717
	inode_lock_nested(dir, I_MUTEX_PARENT);
718 719 720 721 722 723
	upper = lookup_one_len(dentry->d_name.name, upperdir,
			       dentry->d_name.len);
	err = PTR_ERR(upper);
	if (IS_ERR(upper))
		goto out_unlock;

M
Miklos Szeredi 已提交
724
	err = -ESTALE;
725 726 727 728 729 730 731 732 733
	if ((opaquedir && upper != opaquedir) ||
	    (!opaquedir && upper != ovl_dentry_upper(dentry)))
		goto out_dput_upper;

	if (is_dir)
		err = vfs_rmdir(dir, upper);
	else
		err = vfs_unlink(dir, upper, NULL);
	ovl_dentry_version_inc(dentry->d_parent);
M
Miklos Szeredi 已提交
734 735 736 737 738 739 740

	/*
	 * Keeping this dentry hashed would mean having to release
	 * upperpath/lowerpath, which could only be done if we are the
	 * sole user of this dentry.  Too tricky...  Just unhash for
	 * now.
	 */
741 742
	if (!err)
		d_drop(dentry);
743 744
out_dput_upper:
	dput(upper);
745
out_unlock:
A
Al Viro 已提交
746
	inode_unlock(dir);
747 748
	dput(opaquedir);
out:
M
Miklos Szeredi 已提交
749 750 751 752 753 754 755
	return err;
}

static int ovl_do_remove(struct dentry *dentry, bool is_dir)
{
	enum ovl_path_type type;
	int err;
756 757
	const struct cred *old_cred;

M
Miklos Szeredi 已提交
758 759 760 761 762 763 764 765 766 767
	err = ovl_want_write(dentry);
	if (err)
		goto out;

	err = ovl_copy_up(dentry->d_parent);
	if (err)
		goto out_drop_write;

	type = ovl_path_type(dentry);

768
	old_cred = ovl_override_creds(dentry->d_sb);
769
	if (!ovl_lower_positive(dentry))
770 771
		err = ovl_remove_upper(dentry, is_dir);
	else
M
Miklos Szeredi 已提交
772
		err = ovl_remove_and_whiteout(dentry, is_dir);
773
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
774 775 776 777 778 779
	if (!err) {
		if (is_dir)
			clear_nlink(dentry->d_inode);
		else
			drop_nlink(dentry->d_inode);
	}
M
Miklos Szeredi 已提交
780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795
out_drop_write:
	ovl_drop_write(dentry);
out:
	return err;
}

static int ovl_unlink(struct inode *dir, struct dentry *dentry)
{
	return ovl_do_remove(dentry, false);
}

static int ovl_rmdir(struct inode *dir, struct dentry *dentry)
{
	return ovl_do_remove(dentry, true);
}

796 797 798 799 800 801 802
static bool ovl_type_merge_or_lower(struct dentry *dentry)
{
	enum ovl_path_type type = ovl_path_type(dentry);

	return OVL_TYPE_MERGE(type) || !OVL_TYPE_UPPER(type);
}

M
Miklos Szeredi 已提交
803 804 805 806 807 808 809 810 811 812
static bool ovl_can_move(struct dentry *dentry)
{
	return ovl_redirect_dir(dentry->d_sb) ||
		!d_is_dir(dentry) || !ovl_type_merge_or_lower(dentry);
}

static char *ovl_get_redirect(struct dentry *dentry, bool samedir)
{
	char *buf, *ret;
	struct dentry *d, *tmp;
813
	int buflen = ovl_redirect_max + 1;
M
Miklos Szeredi 已提交
814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880

	if (samedir) {
		ret = kstrndup(dentry->d_name.name, dentry->d_name.len,
			       GFP_KERNEL);
		goto out;
	}

	buf = ret = kmalloc(buflen, GFP_TEMPORARY);
	if (!buf)
		goto out;

	buflen--;
	buf[buflen] = '\0';
	for (d = dget(dentry); !IS_ROOT(d);) {
		const char *name;
		int thislen;

		spin_lock(&d->d_lock);
		name = ovl_dentry_get_redirect(d);
		if (name) {
			thislen = strlen(name);
		} else {
			name = d->d_name.name;
			thislen = d->d_name.len;
		}

		/* If path is too long, fall back to userspace move */
		if (thislen + (name[0] != '/') > buflen) {
			ret = ERR_PTR(-EXDEV);
			spin_unlock(&d->d_lock);
			goto out_put;
		}

		buflen -= thislen;
		memcpy(&buf[buflen], name, thislen);
		tmp = dget_dlock(d->d_parent);
		spin_unlock(&d->d_lock);

		dput(d);
		d = tmp;

		/* Absolute redirect: finished */
		if (buf[buflen] == '/')
			break;
		buflen--;
		buf[buflen] = '/';
	}
	ret = kstrdup(&buf[buflen], GFP_KERNEL);
out_put:
	dput(d);
	kfree(buf);
out:
	return ret ? ret : ERR_PTR(-ENOMEM);
}

static int ovl_set_redirect(struct dentry *dentry, bool samedir)
{
	int err;
	const char *redirect = ovl_dentry_get_redirect(dentry);

	if (redirect && (samedir || redirect[0] == '/'))
		return 0;

	redirect = ovl_get_redirect(dentry, samedir);
	if (IS_ERR(redirect))
		return PTR_ERR(redirect);

881 882 883
	err = ovl_check_setxattr(dentry, ovl_dentry_upper(dentry),
				 OVL_XATTR_REDIRECT,
				 redirect, strlen(redirect), -EXDEV);
M
Miklos Szeredi 已提交
884 885 886 887 888 889
	if (!err) {
		spin_lock(&dentry->d_lock);
		ovl_dentry_set_redirect(dentry, redirect);
		spin_unlock(&dentry->d_lock);
	} else {
		kfree(redirect);
890
		pr_warn_ratelimited("overlay: failed to set redirect (%i)\n", err);
M
Miklos Szeredi 已提交
891 892 893 894 895 896
		/* Fall back to userspace copy-up */
		err = -EXDEV;
	}
	return err;
}

897 898 899
static int ovl_rename(struct inode *olddir, struct dentry *old,
		      struct inode *newdir, struct dentry *new,
		      unsigned int flags)
M
Miklos Szeredi 已提交
900 901 902 903 904 905 906 907 908 909 910
{
	int err;
	struct dentry *old_upperdir;
	struct dentry *new_upperdir;
	struct dentry *olddentry;
	struct dentry *newdentry;
	struct dentry *trap;
	bool old_opaque;
	bool new_opaque;
	bool cleanup_whiteout = false;
	bool overwrite = !(flags & RENAME_EXCHANGE);
911
	bool is_dir = d_is_dir(old);
912
	bool new_is_dir = d_is_dir(new);
M
Miklos Szeredi 已提交
913
	bool samedir = olddir == newdir;
M
Miklos Szeredi 已提交
914 915 916 917 918 919 920 921 922 923 924
	struct dentry *opaquedir = NULL;
	const struct cred *old_cred = NULL;

	err = -EINVAL;
	if (flags & ~(RENAME_EXCHANGE | RENAME_NOREPLACE))
		goto out;

	flags &= ~RENAME_NOREPLACE;

	/* Don't copy up directory trees */
	err = -EXDEV;
M
Miklos Szeredi 已提交
925
	if (!ovl_can_move(old))
926
		goto out;
M
Miklos Szeredi 已提交
927
	if (!overwrite && !ovl_can_move(new))
M
Miklos Szeredi 已提交
928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946
		goto out;

	err = ovl_want_write(old);
	if (err)
		goto out;

	err = ovl_copy_up(old);
	if (err)
		goto out_drop_write;

	err = ovl_copy_up(new->d_parent);
	if (err)
		goto out_drop_write;
	if (!overwrite) {
		err = ovl_copy_up(new);
		if (err)
			goto out_drop_write;
	}

947
	old_cred = ovl_override_creds(old->d_sb);
M
Miklos Szeredi 已提交
948

949
	if (overwrite && new_is_dir && ovl_type_merge_or_lower(new)) {
M
Miklos Szeredi 已提交
950
		opaquedir = ovl_check_empty_and_clear(new);
M
Miklos Szeredi 已提交
951 952 953 954 955 956 957 958
		err = PTR_ERR(opaquedir);
		if (IS_ERR(opaquedir)) {
			opaquedir = NULL;
			goto out_revert_creds;
		}
	}

	if (overwrite) {
959
		if (ovl_lower_positive(old)) {
M
Miklos Szeredi 已提交
960
			if (!ovl_dentry_is_whiteout(new)) {
M
Miklos Szeredi 已提交
961 962 963 964 965 966
				/* Whiteout source */
				flags |= RENAME_WHITEOUT;
			} else {
				/* Switch whiteouts */
				flags |= RENAME_EXCHANGE;
			}
M
Miklos Szeredi 已提交
967
		} else if (is_dir && ovl_dentry_is_whiteout(new)) {
M
Miklos Szeredi 已提交
968 969 970 971 972 973 974 975
			flags |= RENAME_EXCHANGE;
			cleanup_whiteout = true;
		}
	}

	old_upperdir = ovl_dentry_upper(old->d_parent);
	new_upperdir = ovl_dentry_upper(new->d_parent);

976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999
	if (!samedir) {
		/*
		 * When moving a merge dir or non-dir with copy up origin into
		 * a non-merge upper dir (a.k.a pure upper dir), we are making
		 * the target parent dir "impure". ovl_iterate() iterates pure
		 * upper dirs directly, because there is no need to filter out
		 * whiteouts and merge dir content with lower dir. But for the
		 * case of an "impure" upper dir, ovl_iterate() cannot iterate
		 * the real directory directly, because it looks for the inode
		 * numbers to fill d_ino in the entries origin inode.
		 */
		if (ovl_type_origin(old) && !ovl_type_merge(new->d_parent)) {
			err = ovl_set_impure(new->d_parent, new_upperdir);
			if (err)
				goto out_revert_creds;
		}
		if (!overwrite && ovl_type_origin(new) &&
		    !ovl_type_merge(old->d_parent)) {
			err = ovl_set_impure(old->d_parent, old_upperdir);
			if (err)
				goto out_revert_creds;
		}
	}

M
Miklos Szeredi 已提交
1000 1001
	trap = lock_rename(new_upperdir, old_upperdir);

1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017
	olddentry = lookup_one_len(old->d_name.name, old_upperdir,
				   old->d_name.len);
	err = PTR_ERR(olddentry);
	if (IS_ERR(olddentry))
		goto out_unlock;

	err = -ESTALE;
	if (olddentry != ovl_dentry_upper(old))
		goto out_dput_old;

	newdentry = lookup_one_len(new->d_name.name, new_upperdir,
				   new->d_name.len);
	err = PTR_ERR(newdentry);
	if (IS_ERR(newdentry))
		goto out_dput_old;

1018 1019 1020
	old_opaque = ovl_dentry_is_opaque(old);
	new_opaque = ovl_dentry_is_opaque(new);

1021 1022
	err = -ESTALE;
	if (ovl_dentry_upper(new)) {
M
Miklos Szeredi 已提交
1023
		if (opaquedir) {
1024 1025
			if (newdentry != opaquedir)
				goto out_dput;
M
Miklos Szeredi 已提交
1026
		} else {
1027 1028
			if (newdentry != ovl_dentry_upper(new))
				goto out_dput;
M
Miklos Szeredi 已提交
1029 1030
		}
	} else {
1031 1032 1033
		if (!d_is_negative(newdentry) &&
		    (!new_opaque || !ovl_is_whiteout(newdentry)))
			goto out_dput;
M
Miklos Szeredi 已提交
1034 1035 1036 1037 1038 1039 1040
	}

	if (olddentry == trap)
		goto out_dput;
	if (newdentry == trap)
		goto out_dput;

M
Miklos Szeredi 已提交
1041 1042 1043
	if (WARN_ON(olddentry->d_inode == newdentry->d_inode))
		goto out_dput;

M
Miklos Szeredi 已提交
1044
	err = 0;
M
Miklos Szeredi 已提交
1045
	if (is_dir) {
M
Miklos Szeredi 已提交
1046
		if (ovl_type_merge_or_lower(old))
M
Miklos Szeredi 已提交
1047
			err = ovl_set_redirect(old, samedir);
1048
		else if (!old_opaque && ovl_type_merge(new->d_parent))
1049
			err = ovl_set_opaque_xerr(old, olddentry, -EXDEV);
M
Miklos Szeredi 已提交
1050 1051
		if (err)
			goto out_dput;
M
Miklos Szeredi 已提交
1052
	}
M
Miklos Szeredi 已提交
1053
	if (!overwrite && new_is_dir) {
M
Miklos Szeredi 已提交
1054
		if (ovl_type_merge_or_lower(new))
M
Miklos Szeredi 已提交
1055
			err = ovl_set_redirect(new, samedir);
1056
		else if (!new_opaque && ovl_type_merge(old->d_parent))
1057
			err = ovl_set_opaque_xerr(new, newdentry, -EXDEV);
M
Miklos Szeredi 已提交
1058 1059
		if (err)
			goto out_dput;
M
Miklos Szeredi 已提交
1060 1061
	}

1062 1063 1064
	err = ovl_do_rename(old_upperdir->d_inode, olddentry,
			    new_upperdir->d_inode, newdentry, flags);
	if (err)
M
Miklos Szeredi 已提交
1065 1066 1067 1068 1069 1070 1071 1072 1073 1074
		goto out_dput;

	if (cleanup_whiteout)
		ovl_cleanup(old_upperdir->d_inode, newdentry);

	ovl_dentry_version_inc(old->d_parent);
	ovl_dentry_version_inc(new->d_parent);

out_dput:
	dput(newdentry);
1075 1076
out_dput_old:
	dput(olddentry);
M
Miklos Szeredi 已提交
1077 1078 1079
out_unlock:
	unlock_rename(new_upperdir, old_upperdir);
out_revert_creds:
1080
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093
out_drop_write:
	ovl_drop_write(old);
out:
	dput(opaquedir);
	return err;
}

const struct inode_operations ovl_dir_inode_operations = {
	.lookup		= ovl_lookup,
	.mkdir		= ovl_mkdir,
	.symlink	= ovl_symlink,
	.unlink		= ovl_unlink,
	.rmdir		= ovl_rmdir,
1094
	.rename		= ovl_rename,
M
Miklos Szeredi 已提交
1095 1096 1097 1098 1099
	.link		= ovl_link,
	.setattr	= ovl_setattr,
	.create		= ovl_create,
	.mknod		= ovl_mknod,
	.permission	= ovl_permission,
1100
	.getattr	= ovl_getattr,
M
Miklos Szeredi 已提交
1101
	.listxattr	= ovl_listxattr,
1102
	.get_acl	= ovl_get_acl,
M
Miklos Szeredi 已提交
1103
	.update_time	= ovl_update_time,
M
Miklos Szeredi 已提交
1104
};