device.c 17.1 KB
Newer Older
1
/*
2
 * Copyright(c) 2016 - 2017 Intel Corporation. All rights reserved.
3 4 5 6 7 8 9 10 11 12 13 14 15 16
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
 * published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * General Public License for more details.
 */
#include <linux/pagemap.h>
#include <linux/module.h>
#include <linux/device.h>
#include <linux/pfn_t.h>
D
Dan Williams 已提交
17
#include <linux/cdev.h>
18 19 20 21
#include <linux/slab.h>
#include <linux/dax.h>
#include <linux/fs.h>
#include <linux/mm.h>
22
#include <linux/mman.h>
23
#include "dax-private.h"
24
#include "dax.h"
25 26 27

static struct class *dax_class;

28 29 30 31 32
/*
 * Rely on the fact that drvdata is set before the attributes are
 * registered, and that the attributes are unregistered before drvdata
 * is cleared to assume that drvdata is always valid.
 */
33 34 35
static ssize_t id_show(struct device *dev,
		struct device_attribute *attr, char *buf)
{
36
	struct dax_region *dax_region = dev_get_drvdata(dev);
37

38
	return sprintf(buf, "%d\n", dax_region->id);
39 40 41 42 43 44
}
static DEVICE_ATTR_RO(id);

static ssize_t region_size_show(struct device *dev,
		struct device_attribute *attr, char *buf)
{
45
	struct dax_region *dax_region = dev_get_drvdata(dev);
46

47 48
	return sprintf(buf, "%llu\n", (unsigned long long)
			resource_size(&dax_region->res));
49 50 51 52 53 54 55
}
static struct device_attribute dev_attr_region_size = __ATTR(size, 0444,
		region_size_show, NULL);

static ssize_t align_show(struct device *dev,
		struct device_attribute *attr, char *buf)
{
56
	struct dax_region *dax_region = dev_get_drvdata(dev);
57

58
	return sprintf(buf, "%u\n", dax_region->align);
59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
}
static DEVICE_ATTR_RO(align);

static struct attribute *dax_region_attributes[] = {
	&dev_attr_region_size.attr,
	&dev_attr_align.attr,
	&dev_attr_id.attr,
	NULL,
};

static const struct attribute_group dax_region_attribute_group = {
	.name = "dax_region",
	.attrs = dax_region_attributes,
};

static const struct attribute_group *dax_region_attribute_groups[] = {
	&dax_region_attribute_group,
	NULL,
};

79 80 81 82 83 84 85 86 87 88 89 90 91 92
static void dax_region_free(struct kref *kref)
{
	struct dax_region *dax_region;

	dax_region = container_of(kref, struct dax_region, kref);
	kfree(dax_region);
}

void dax_region_put(struct dax_region *dax_region)
{
	kref_put(&dax_region->kref, dax_region_free);
}
EXPORT_SYMBOL_GPL(dax_region_put);

93 94 95 96 97 98 99 100 101
static void dax_region_unregister(void *region)
{
	struct dax_region *dax_region = region;

	sysfs_remove_groups(&dax_region->dev->kobj,
			dax_region_attribute_groups);
	dax_region_put(dax_region);
}

102 103 104 105 106 107
struct dax_region *alloc_dax_region(struct device *parent, int region_id,
		struct resource *res, unsigned int align, void *addr,
		unsigned long pfn_flags)
{
	struct dax_region *dax_region;

108 109 110 111 112 113 114 115 116 117
	/*
	 * The DAX core assumes that it can store its private data in
	 * parent->driver_data. This WARN is a reminder / safeguard for
	 * developers of device-dax drivers.
	 */
	if (dev_get_drvdata(parent)) {
		dev_WARN(parent, "dax core failed to setup private data\n");
		return NULL;
	}

118 119 120
	if (!IS_ALIGNED(res->start, align)
			|| !IS_ALIGNED(resource_size(res), align))
		return NULL;
121

122
	dax_region = kzalloc(sizeof(*dax_region), GFP_KERNEL);
123 124 125
	if (!dax_region)
		return NULL;

126
	dev_set_drvdata(parent, dax_region);
127 128 129 130 131 132 133 134
	memcpy(&dax_region->res, res, sizeof(*res));
	dax_region->pfn_flags = pfn_flags;
	kref_init(&dax_region->kref);
	dax_region->id = region_id;
	ida_init(&dax_region->ida);
	dax_region->align = align;
	dax_region->dev = parent;
	dax_region->base = addr;
135 136
	if (sysfs_create_groups(&parent->kobj, dax_region_attribute_groups)) {
		kfree(dax_region);
137
		return NULL;
138
	}
139

140 141 142
	kref_get(&dax_region->kref);
	if (devm_add_action_or_reset(parent, dax_region_unregister, dax_region))
		return NULL;
143 144 145 146
	return dax_region;
}
EXPORT_SYMBOL_GPL(alloc_dax_region);

147
static struct dev_dax *to_dev_dax(struct device *dev)
148
{
149
	return container_of(dev, struct dev_dax, dev);
150 151
}

152 153 154
static ssize_t size_show(struct device *dev,
		struct device_attribute *attr, char *buf)
{
155
	struct dev_dax *dev_dax = to_dev_dax(dev);
156 157 158
	unsigned long long size = 0;
	int i;

159 160
	for (i = 0; i < dev_dax->num_resources; i++)
		size += resource_size(&dev_dax->res[i]);
161 162 163 164 165

	return sprintf(buf, "%llu\n", size);
}
static DEVICE_ATTR_RO(size);

166
static struct attribute *dev_dax_attributes[] = {
167 168 169 170
	&dev_attr_size.attr,
	NULL,
};

171 172
static const struct attribute_group dev_dax_attribute_group = {
	.attrs = dev_dax_attributes,
173 174 175
};

static const struct attribute_group *dax_attribute_groups[] = {
176
	&dev_dax_attribute_group,
177 178 179
	NULL,
};

180
static int check_vma(struct dev_dax *dev_dax, struct vm_area_struct *vma,
181 182
		const char *func)
{
183 184
	struct dax_region *dax_region = dev_dax->region;
	struct device *dev = &dev_dax->dev;
185 186
	unsigned long mask;

187
	if (!dax_alive(dev_dax->dax_dev))
188 189
		return -ENXIO;

190
	/* prevent private mappings from being established */
191
	if ((vma->vm_flags & VM_MAYSHARE) != VM_MAYSHARE) {
192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220
		dev_info(dev, "%s: %s: fail, attempted private mapping\n",
				current->comm, func);
		return -EINVAL;
	}

	mask = dax_region->align - 1;
	if (vma->vm_start & mask || vma->vm_end & mask) {
		dev_info(dev, "%s: %s: fail, unaligned vma (%#lx - %#lx, %#lx)\n",
				current->comm, func, vma->vm_start, vma->vm_end,
				mask);
		return -EINVAL;
	}

	if ((dax_region->pfn_flags & (PFN_DEV|PFN_MAP)) == PFN_DEV
			&& (vma->vm_flags & VM_DONTCOPY) == 0) {
		dev_info(dev, "%s: %s: fail, dax range requires MADV_DONTFORK\n",
				current->comm, func);
		return -EINVAL;
	}

	if (!vma_is_dax(vma)) {
		dev_info(dev, "%s: %s: fail, vma is not DAX capable\n",
				current->comm, func);
		return -EINVAL;
	}

	return 0;
}

221
/* see "strong" declaration in tools/testing/nvdimm/dax-dev.c */
222
__weak phys_addr_t dax_pgoff_to_phys(struct dev_dax *dev_dax, pgoff_t pgoff,
223 224 225
		unsigned long size)
{
	struct resource *res;
226 227
	/* gcc-4.6.3-nolibc for i386 complains that this is uninitialized */
	phys_addr_t uninitialized_var(phys);
228 229
	int i;

230 231
	for (i = 0; i < dev_dax->num_resources; i++) {
		res = &dev_dax->res[i];
232 233 234 235 236 237
		phys = pgoff * PAGE_SIZE + res->start;
		if (phys >= res->start && phys <= res->end)
			break;
		pgoff -= PHYS_PFN(resource_size(res));
	}

238 239
	if (i < dev_dax->num_resources) {
		res = &dev_dax->res[i];
240 241 242 243 244 245 246
		if (phys + size - 1 <= res->end)
			return phys;
	}

	return -1;
}

247
static int __dev_dax_pte_fault(struct dev_dax *dev_dax, struct vm_fault *vmf)
248
{
249
	struct device *dev = &dev_dax->dev;
250 251 252 253
	struct dax_region *dax_region;
	int rc = VM_FAULT_SIGBUS;
	phys_addr_t phys;
	pfn_t pfn;
254
	unsigned int fault_size = PAGE_SIZE;
255

256
	if (check_vma(dev_dax, vmf->vma, __func__))
257 258
		return VM_FAULT_SIGBUS;

259
	dax_region = dev_dax->region;
260
	if (dax_region->align > PAGE_SIZE) {
261 262
		dev_dbg(dev, "alignment (%#x) > fault size (%#x)\n",
			dax_region->align, fault_size);
263 264 265
		return VM_FAULT_SIGBUS;
	}

266 267 268
	if (fault_size != dax_region->align)
		return VM_FAULT_SIGBUS;

269
	phys = dax_pgoff_to_phys(dev_dax, vmf->pgoff, PAGE_SIZE);
270
	if (phys == -1) {
271
		dev_dbg(dev, "pgoff_to_phys(%#lx) failed\n", vmf->pgoff);
272 273 274 275 276
		return VM_FAULT_SIGBUS;
	}

	pfn = phys_to_pfn_t(phys, dax_region->pfn_flags);

277
	rc = vm_insert_mixed(vmf->vma, vmf->address, pfn);
278 279 280 281 282 283 284 285 286

	if (rc == -ENOMEM)
		return VM_FAULT_OOM;
	if (rc < 0 && rc != -EBUSY)
		return VM_FAULT_SIGBUS;

	return VM_FAULT_NOPAGE;
}

287
static int __dev_dax_pmd_fault(struct dev_dax *dev_dax, struct vm_fault *vmf)
288
{
289
	unsigned long pmd_addr = vmf->address & PMD_MASK;
290
	struct device *dev = &dev_dax->dev;
291 292 293 294
	struct dax_region *dax_region;
	phys_addr_t phys;
	pgoff_t pgoff;
	pfn_t pfn;
295
	unsigned int fault_size = PMD_SIZE;
296

297
	if (check_vma(dev_dax, vmf->vma, __func__))
298 299
		return VM_FAULT_SIGBUS;

300
	dax_region = dev_dax->region;
301
	if (dax_region->align > PMD_SIZE) {
302 303
		dev_dbg(dev, "alignment (%#x) > fault size (%#x)\n",
			dax_region->align, fault_size);
304 305 306 307 308
		return VM_FAULT_SIGBUS;
	}

	/* dax pmd mappings require pfn_t_devmap() */
	if ((dax_region->pfn_flags & (PFN_DEV|PFN_MAP)) != (PFN_DEV|PFN_MAP)) {
309
		dev_dbg(dev, "region lacks devmap flags\n");
310 311 312
		return VM_FAULT_SIGBUS;
	}

313 314 315 316 317 318 319 320 321 322
	if (fault_size < dax_region->align)
		return VM_FAULT_SIGBUS;
	else if (fault_size > dax_region->align)
		return VM_FAULT_FALLBACK;

	/* if we are outside of the VMA */
	if (pmd_addr < vmf->vma->vm_start ||
			(pmd_addr + PMD_SIZE) > vmf->vma->vm_end)
		return VM_FAULT_SIGBUS;

323
	pgoff = linear_page_index(vmf->vma, pmd_addr);
324
	phys = dax_pgoff_to_phys(dev_dax, pgoff, PMD_SIZE);
325
	if (phys == -1) {
326
		dev_dbg(dev, "pgoff_to_phys(%#lx) failed\n", pgoff);
327 328 329 330 331
		return VM_FAULT_SIGBUS;
	}

	pfn = phys_to_pfn_t(phys, dax_region->pfn_flags);

332
	return vmf_insert_pfn_pmd(vmf->vma, vmf->address, vmf->pmd, pfn,
333
			vmf->flags & FAULT_FLAG_WRITE);
334 335
}

336
#ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD
337
static int __dev_dax_pud_fault(struct dev_dax *dev_dax, struct vm_fault *vmf)
338 339
{
	unsigned long pud_addr = vmf->address & PUD_MASK;
340
	struct device *dev = &dev_dax->dev;
341 342 343 344
	struct dax_region *dax_region;
	phys_addr_t phys;
	pgoff_t pgoff;
	pfn_t pfn;
345 346
	unsigned int fault_size = PUD_SIZE;

347

348
	if (check_vma(dev_dax, vmf->vma, __func__))
349 350
		return VM_FAULT_SIGBUS;

351
	dax_region = dev_dax->region;
352
	if (dax_region->align > PUD_SIZE) {
353 354
		dev_dbg(dev, "alignment (%#x) > fault size (%#x)\n",
			dax_region->align, fault_size);
355 356 357 358 359
		return VM_FAULT_SIGBUS;
	}

	/* dax pud mappings require pfn_t_devmap() */
	if ((dax_region->pfn_flags & (PFN_DEV|PFN_MAP)) != (PFN_DEV|PFN_MAP)) {
360
		dev_dbg(dev, "region lacks devmap flags\n");
361 362 363
		return VM_FAULT_SIGBUS;
	}

364 365 366 367 368 369 370 371 372 373
	if (fault_size < dax_region->align)
		return VM_FAULT_SIGBUS;
	else if (fault_size > dax_region->align)
		return VM_FAULT_FALLBACK;

	/* if we are outside of the VMA */
	if (pud_addr < vmf->vma->vm_start ||
			(pud_addr + PUD_SIZE) > vmf->vma->vm_end)
		return VM_FAULT_SIGBUS;

374
	pgoff = linear_page_index(vmf->vma, pud_addr);
375
	phys = dax_pgoff_to_phys(dev_dax, pgoff, PUD_SIZE);
376
	if (phys == -1) {
377
		dev_dbg(dev, "pgoff_to_phys(%#lx) failed\n", pgoff);
378 379 380 381 382 383 384 385 386
		return VM_FAULT_SIGBUS;
	}

	pfn = phys_to_pfn_t(phys, dax_region->pfn_flags);

	return vmf_insert_pfn_pud(vmf->vma, vmf->address, vmf->pud, pfn,
			vmf->flags & FAULT_FLAG_WRITE);
}
#else
387
static int __dev_dax_pud_fault(struct dev_dax *dev_dax, struct vm_fault *vmf)
388 389 390 391 392
{
	return VM_FAULT_FALLBACK;
}
#endif /* !CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD */

393
static int dev_dax_huge_fault(struct vm_fault *vmf,
394
		enum page_entry_size pe_size)
395
{
396
	int rc, id;
397
	struct file *filp = vmf->vma->vm_file;
398
	struct dev_dax *dev_dax = filp->private_data;
399

400 401
	dev_dbg(&dev_dax->dev, "%s: %s (%#lx - %#lx) size = %d\n", current->comm,
			(vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read",
402
			vmf->vma->vm_start, vmf->vma->vm_end, pe_size);
403

404
	id = dax_read_lock();
405 406
	switch (pe_size) {
	case PE_SIZE_PTE:
407
		rc = __dev_dax_pte_fault(dev_dax, vmf);
408
		break;
409
	case PE_SIZE_PMD:
410
		rc = __dev_dax_pmd_fault(dev_dax, vmf);
411
		break;
412
	case PE_SIZE_PUD:
413
		rc = __dev_dax_pud_fault(dev_dax, vmf);
414 415
		break;
	default:
416
		rc = VM_FAULT_SIGBUS;
417
	}
418
	dax_read_unlock(id);
419 420 421 422

	return rc;
}

423
static int dev_dax_fault(struct vm_fault *vmf)
424
{
425
	return dev_dax_huge_fault(vmf, PE_SIZE_PTE);
426 427
}

428 429 430 431 432 433 434 435 436 437 438
static int dev_dax_split(struct vm_area_struct *vma, unsigned long addr)
{
	struct file *filp = vma->vm_file;
	struct dev_dax *dev_dax = filp->private_data;
	struct dax_region *dax_region = dev_dax->region;

	if (!IS_ALIGNED(addr, dax_region->align))
		return -EINVAL;
	return 0;
}

439 440 441 442 443 444 445 446 447
static unsigned long dev_dax_pagesize(struct vm_area_struct *vma)
{
	struct file *filp = vma->vm_file;
	struct dev_dax *dev_dax = filp->private_data;
	struct dax_region *dax_region = dev_dax->region;

	return dax_region->align;
}

448 449 450
static const struct vm_operations_struct dax_vm_ops = {
	.fault = dev_dax_fault,
	.huge_fault = dev_dax_huge_fault,
451
	.split = dev_dax_split,
452
	.pagesize = dev_dax_pagesize,
453 454
};

455
static int dax_mmap(struct file *filp, struct vm_area_struct *vma)
456
{
457
	struct dev_dax *dev_dax = filp->private_data;
458
	int rc, id;
459

460
	dev_dbg(&dev_dax->dev, "trace\n");
461

462 463 464 465 466
	/*
	 * We lock to check dax_dev liveness and will re-check at
	 * fault time.
	 */
	id = dax_read_lock();
467
	rc = check_vma(dev_dax, vma, __func__);
468
	dax_read_unlock(id);
469 470 471
	if (rc)
		return rc;

472
	vma->vm_ops = &dax_vm_ops;
473 474
	vma->vm_flags |= VM_MIXEDMAP | VM_HUGEPAGE;
	return 0;
475 476 477
}

/* return an unmapped area aligned to the dax region specified alignment */
478
static unsigned long dax_get_unmapped_area(struct file *filp,
479 480 481 482
		unsigned long addr, unsigned long len, unsigned long pgoff,
		unsigned long flags)
{
	unsigned long off, off_end, off_align, len_align, addr_align, align;
483
	struct dev_dax *dev_dax = filp ? filp->private_data : NULL;
484 485
	struct dax_region *dax_region;

486
	if (!dev_dax || addr)
487 488
		goto out;

489
	dax_region = dev_dax->region;
490 491 492 493 494 495 496 497 498 499 500
	align = dax_region->align;
	off = pgoff << PAGE_SHIFT;
	off_end = off + len;
	off_align = round_up(off, align);

	if ((off_end <= off_align) || ((off_end - off_align) < align))
		goto out;

	len_align = len + align;
	if ((off + len_align) < off)
		goto out;
501

502 503 504 505 506 507 508 509 510 511
	addr_align = current->mm->get_unmapped_area(filp, addr, len_align,
			pgoff, flags);
	if (!IS_ERR_VALUE(addr_align)) {
		addr_align += (off - addr_align) & (align - 1);
		return addr_align;
	}
 out:
	return current->mm->get_unmapped_area(filp, addr, len, pgoff, flags);
}

512
static int dax_open(struct inode *inode, struct file *filp)
513
{
514 515 516
	struct dax_device *dax_dev = inode_dax(inode);
	struct inode *__dax_inode = dax_inode(dax_dev);
	struct dev_dax *dev_dax = dax_get_private(dax_dev);
517

518
	dev_dbg(&dev_dax->dev, "trace\n");
519 520
	inode->i_mapping = __dax_inode->i_mapping;
	inode->i_mapping->host = __dax_inode;
521
	filp->f_mapping = inode->i_mapping;
522
	filp->f_wb_err = filemap_sample_wb_err(filp->f_mapping);
523
	filp->private_data = dev_dax;
524
	inode->i_flags = S_DAX;
525 526 527

	return 0;
}
528

529
static int dax_release(struct inode *inode, struct file *filp)
530
{
531
	struct dev_dax *dev_dax = filp->private_data;
532

533
	dev_dbg(&dev_dax->dev, "trace\n");
534
	return 0;
535 536
}

537 538 539
static const struct file_operations dax_fops = {
	.llseek = noop_llseek,
	.owner = THIS_MODULE,
540 541 542 543
	.open = dax_open,
	.release = dax_release,
	.get_unmapped_area = dax_get_unmapped_area,
	.mmap = dax_mmap,
544
	.mmap_supported_flags = MAP_SYNC,
545 546
};

547
static void dev_dax_release(struct device *dev)
548
{
549 550
	struct dev_dax *dev_dax = to_dev_dax(dev);
	struct dax_region *dax_region = dev_dax->region;
551
	struct dax_device *dax_dev = dev_dax->dax_dev;
552

553 554
	if (dev_dax->id >= 0)
		ida_simple_remove(&dax_region->ida, dev_dax->id);
555
	dax_region_put(dax_region);
556
	put_dax(dax_dev);
557
	kfree(dev_dax);
558 559
}

560
static void kill_dev_dax(struct dev_dax *dev_dax)
561
{
562 563 564 565 566
	struct dax_device *dax_dev = dev_dax->dax_dev;
	struct inode *inode = dax_inode(dax_dev);

	kill_dax(dax_dev);
	unmap_mapping_range(inode->i_mapping, 0, 0, 1);
567 568
}

569
static void unregister_dev_dax(void *dev)
570
{
571
	struct dev_dax *dev_dax = to_dev_dax(dev);
572 573 574
	struct dax_device *dax_dev = dev_dax->dax_dev;
	struct inode *inode = dax_inode(dax_dev);
	struct cdev *cdev = inode->i_cdev;
575

576
	dev_dbg(dev, "trace\n");
577

578
	kill_dev_dax(dev_dax);
579
	cdev_device_del(cdev, dev);
580
	put_device(dev);
581 582
}

583
struct dev_dax *devm_create_dev_dax(struct dax_region *dax_region,
584
		int id, struct resource *res, int count)
585 586
{
	struct device *parent = dax_region->dev;
587
	struct dax_device *dax_dev;
588
	struct dev_dax *dev_dax;
589
	struct inode *inode;
590
	struct device *dev;
D
Dan Williams 已提交
591
	struct cdev *cdev;
592 593 594 595
	int rc, i;

	if (!count)
		return ERR_PTR(-EINVAL);
596

597
	dev_dax = kzalloc(struct_size(dev_dax, res, count), GFP_KERNEL);
598
	if (!dev_dax)
599
		return ERR_PTR(-ENOMEM);
600

601 602 603 604 605 606 607
	for (i = 0; i < count; i++) {
		if (!IS_ALIGNED(res[i].start, dax_region->align)
				|| !IS_ALIGNED(resource_size(&res[i]),
					dax_region->align)) {
			rc = -EINVAL;
			break;
		}
608 609
		dev_dax->res[i].start = res[i].start;
		dev_dax->res[i].end = res[i].end;
610 611 612 613 614
	}

	if (i < count)
		goto err_id;

615 616 617 618 619 620 621 622 623 624
	if (id < 0) {
		id = ida_simple_get(&dax_region->ida, 0, 0, GFP_KERNEL);
		dev_dax->id = id;
		if (id < 0) {
			rc = id;
			goto err_id;
		}
	} else {
		/* region provider owns @id lifetime */
		dev_dax->id = -1;
625 626
	}

D
Dan Williams 已提交
627 628 629 630 631
	/*
	 * No 'host' or dax_operations since there is no access to this
	 * device outside of mmap of the resulting character device.
	 */
	dax_dev = alloc_dax(dev_dax, NULL, NULL);
632 633
	if (!dax_dev) {
		rc = -ENOMEM;
634
		goto err_dax;
635
	}
636

637
	/* from here on we're committed to teardown via dax_dev_release() */
638
	dev = &dev_dax->dev;
639
	device_initialize(dev);
D
Dan Williams 已提交
640

641 642
	inode = dax_inode(dax_dev);
	cdev = inode->i_cdev;
D
Dan Williams 已提交
643 644 645
	cdev_init(cdev, &dax_fops);
	cdev->owner = parent->driver->owner;

646
	dev_dax->num_resources = count;
647
	dev_dax->dax_dev = dax_dev;
648
	dev_dax->region = dax_region;
D
Dan Williams 已提交
649 650
	kref_get(&dax_region->kref);

651
	dev->devt = inode->i_rdev;
652 653 654
	dev->class = dax_class;
	dev->parent = parent;
	dev->groups = dax_attribute_groups;
655
	dev->release = dev_dax_release;
656
	dev_set_name(dev, "dax%d.%d", dax_region->id, id);
657 658

	rc = cdev_device_add(cdev, dev);
659
	if (rc) {
660
		kill_dev_dax(dev_dax);
661
		put_device(dev);
662
		return ERR_PTR(rc);
663
	}
664

665
	rc = devm_add_action_or_reset(dax_region->dev, unregister_dev_dax, dev);
666 667 668
	if (rc)
		return ERR_PTR(rc);

669
	return dev_dax;
670

671
 err_dax:
672 673
	if (dev_dax->id >= 0)
		ida_simple_remove(&dax_region->ida, dev_dax->id);
674
 err_id:
675
	kfree(dev_dax);
676

677
	return ERR_PTR(rc);
678
}
679
EXPORT_SYMBOL_GPL(devm_create_dev_dax);
680

681 682 683
static int __init dax_init(void)
{
	dax_class = class_create(THIS_MODULE, "dax");
684
	return PTR_ERR_OR_ZERO(dax_class);
685 686 687 688 689 690 691 692 693 694 695
}

static void __exit dax_exit(void)
{
	class_destroy(dax_class);
}

MODULE_AUTHOR("Intel Corporation");
MODULE_LICENSE("GPL v2");
subsys_initcall(dax_init);
module_exit(dax_exit);