namei.c 19.0 KB
Newer Older
M
Miklos Szeredi 已提交
1 2 3 4 5 6 7 8 9 10
/*
 * Copyright (C) 2011 Novell Inc.
 * Copyright (C) 2016 Red Hat, Inc.
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 as published by
 * the Free Software Foundation.
 */

#include <linux/fs.h>
11
#include <linux/cred.h>
M
Miklos Szeredi 已提交
12 13
#include <linux/namei.h>
#include <linux/xattr.h>
M
Miklos Szeredi 已提交
14
#include <linux/ratelimit.h>
15 16
#include <linux/mount.h>
#include <linux/exportfs.h>
M
Miklos Szeredi 已提交
17 18
#include "overlayfs.h"

19 20 21 22 23 24
struct ovl_lookup_data {
	struct qstr name;
	bool is_dir;
	bool opaque;
	bool stop;
	bool last;
M
Miklos Szeredi 已提交
25
	char *redirect;
26
};
M
Miklos Szeredi 已提交
27

M
Miklos Szeredi 已提交
28 29 30 31 32 33 34 35 36 37 38 39
static int ovl_check_redirect(struct dentry *dentry, struct ovl_lookup_data *d,
			      size_t prelen, const char *post)
{
	int res;
	char *s, *next, *buf = NULL;

	res = vfs_getxattr(dentry, OVL_XATTR_REDIRECT, NULL, 0);
	if (res < 0) {
		if (res == -ENODATA || res == -EOPNOTSUPP)
			return 0;
		goto fail;
	}
40
	buf = kzalloc(prelen + res + strlen(post) + 1, GFP_KERNEL);
M
Miklos Szeredi 已提交
41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84
	if (!buf)
		return -ENOMEM;

	if (res == 0)
		goto invalid;

	res = vfs_getxattr(dentry, OVL_XATTR_REDIRECT, buf, res);
	if (res < 0)
		goto fail;
	if (res == 0)
		goto invalid;
	if (buf[0] == '/') {
		for (s = buf; *s++ == '/'; s = next) {
			next = strchrnul(s, '/');
			if (s == next)
				goto invalid;
		}
	} else {
		if (strchr(buf, '/') != NULL)
			goto invalid;

		memmove(buf + prelen, buf, res);
		memcpy(buf, d->name.name, prelen);
	}

	strcat(buf, post);
	kfree(d->redirect);
	d->redirect = buf;
	d->name.name = d->redirect;
	d->name.len = strlen(d->redirect);

	return 0;

err_free:
	kfree(buf);
	return 0;
fail:
	pr_warn_ratelimited("overlayfs: failed to get redirect (%i)\n", res);
	goto err_free;
invalid:
	pr_warn_ratelimited("overlayfs: invalid redirect (%s)\n", buf);
	goto err_free;
}

85 86 87 88 89
static int ovl_acceptable(void *ctx, struct dentry *dentry)
{
	return 1;
}

90
static struct ovl_fh *ovl_get_origin_fh(struct dentry *dentry)
91 92 93 94 95 96 97 98 99 100 101 102 103 104
{
	int res;
	struct ovl_fh *fh = NULL;

	res = vfs_getxattr(dentry, OVL_XATTR_ORIGIN, NULL, 0);
	if (res < 0) {
		if (res == -ENODATA || res == -EOPNOTSUPP)
			return NULL;
		goto fail;
	}
	/* Zero size value means "copied up but origin unknown" */
	if (res == 0)
		return NULL;

105
	fh  = kzalloc(res, GFP_KERNEL);
106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127
	if (!fh)
		return ERR_PTR(-ENOMEM);

	res = vfs_getxattr(dentry, OVL_XATTR_ORIGIN, fh, res);
	if (res < 0)
		goto fail;

	if (res < sizeof(struct ovl_fh) || res < fh->len)
		goto invalid;

	if (fh->magic != OVL_FH_MAGIC)
		goto invalid;

	/* Treat larger version and unknown flags as "origin unknown" */
	if (fh->version > OVL_FH_VERSION || fh->flags & ~OVL_FH_FLAG_ALL)
		goto out;

	/* Treat endianness mismatch as "origin unknown" */
	if (!(fh->flags & OVL_FH_FLAG_ANY_ENDIAN) &&
	    (fh->flags & OVL_FH_FLAG_BIG_ENDIAN) != OVL_FH_FLAG_CPU_ENDIAN)
		goto out;

128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150
	return fh;

out:
	kfree(fh);
	return NULL;

fail:
	pr_warn_ratelimited("overlayfs: failed to get origin (%i)\n", res);
	goto out;
invalid:
	pr_warn_ratelimited("overlayfs: invalid origin (%*phN)\n", res, fh);
	goto out;
}

static struct dentry *ovl_get_origin(struct dentry *dentry,
				     struct vfsmount *mnt)
{
	struct dentry *origin = NULL;
	struct ovl_fh *fh = ovl_get_origin_fh(dentry);
	int bytes;

	if (IS_ERR_OR_NULL(fh))
		return (struct dentry *)fh;
151 152 153 154 155

	/*
	 * Make sure that the stored uuid matches the uuid of the lower
	 * layer where file handle will be decoded.
	 */
156
	if (!uuid_equal(&fh->uuid, &mnt->mnt_sb->s_uuid))
157 158
		goto out;

159
	bytes = (fh->len - offsetof(struct ovl_fh, fid));
160 161 162 163 164 165 166 167 168 169 170
	origin = exportfs_decode_fh(mnt, (struct fid *)fh->fid,
				    bytes >> 2, (int)fh->type,
				    ovl_acceptable, NULL);
	if (IS_ERR(origin)) {
		/* Treat stale file handle as "origin unknown" */
		if (origin == ERR_PTR(-ESTALE))
			origin = NULL;
		goto out;
	}

	if (ovl_dentry_weird(origin) ||
171
	    ((d_inode(origin)->i_mode ^ d_inode(dentry)->i_mode) & S_IFMT))
172 173 174 175 176 177 178
		goto invalid;

out:
	kfree(fh);
	return origin;

invalid:
179 180 181
	pr_warn_ratelimited("overlayfs: invalid origin (%pd2)\n", origin);
	dput(origin);
	origin = NULL;
182 183 184
	goto out;
}

185 186 187 188 189
static bool ovl_is_opaquedir(struct dentry *dentry)
{
	return ovl_check_dir_xattr(dentry, OVL_XATTR_OPAQUE);
}

190 191
static int ovl_lookup_single(struct dentry *base, struct ovl_lookup_data *d,
			     const char *name, unsigned int namelen,
M
Miklos Szeredi 已提交
192
			     size_t prelen, const char *post,
193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228
			     struct dentry **ret)
{
	struct dentry *this;
	int err;

	this = lookup_one_len_unlocked(name, base, namelen);
	if (IS_ERR(this)) {
		err = PTR_ERR(this);
		this = NULL;
		if (err == -ENOENT || err == -ENAMETOOLONG)
			goto out;
		goto out_err;
	}
	if (!this->d_inode)
		goto put_and_out;

	if (ovl_dentry_weird(this)) {
		/* Don't support traversing automounts and other weirdness */
		err = -EREMOTE;
		goto out_err;
	}
	if (ovl_is_whiteout(this)) {
		d->stop = d->opaque = true;
		goto put_and_out;
	}
	if (!d_can_lookup(this)) {
		d->stop = true;
		if (d->is_dir)
			goto put_and_out;
		goto out;
	}
	d->is_dir = true;
	if (!d->last && ovl_is_opaquedir(this)) {
		d->stop = d->opaque = true;
		goto out;
	}
M
Miklos Szeredi 已提交
229 230 231
	err = ovl_check_redirect(this, d, prelen, post);
	if (err)
		goto out_err;
232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248
out:
	*ret = this;
	return 0;

put_and_out:
	dput(this);
	this = NULL;
	goto out;

out_err:
	dput(this);
	return err;
}

static int ovl_lookup_layer(struct dentry *base, struct ovl_lookup_data *d,
			    struct dentry **ret)
{
249 250
	/* Counting down from the end, since the prefix can change */
	size_t rem = d->name.len - 1;
M
Miklos Szeredi 已提交
251 252 253
	struct dentry *dentry = NULL;
	int err;

254
	if (d->name.name[0] != '/')
M
Miklos Szeredi 已提交
255 256 257
		return ovl_lookup_single(base, d, d->name.name, d->name.len,
					 0, "", ret);

258 259
	while (!IS_ERR_OR_NULL(base) && d_can_lookup(base)) {
		const char *s = d->name.name + d->name.len - rem;
M
Miklos Szeredi 已提交
260
		const char *next = strchrnul(s, '/');
261 262
		size_t thislen = next - s;
		bool end = !next[0];
M
Miklos Szeredi 已提交
263

264 265
		/* Verify we did not go off the rails */
		if (WARN_ON(s[-1] != '/'))
M
Miklos Szeredi 已提交
266 267
			return -EIO;

268 269
		err = ovl_lookup_single(base, d, s, thislen,
					d->name.len - rem, next, &base);
M
Miklos Szeredi 已提交
270 271 272 273
		dput(dentry);
		if (err)
			return err;
		dentry = base;
274 275 276 277 278 279 280
		if (end)
			break;

		rem -= thislen + 1;

		if (WARN_ON(rem >= d->name.len))
			return -EIO;
M
Miklos Szeredi 已提交
281 282 283
	}
	*ret = dentry;
	return 0;
284 285
}

286

287
static int ovl_check_origin(struct dentry *upperdentry,
288 289
			    struct ovl_path *lower, unsigned int numlower,
			    struct ovl_path **stackp, unsigned int *ctrp)
290 291
{
	struct vfsmount *mnt;
292 293
	struct dentry *origin = NULL;
	int i;
294

295
	for (i = 0; i < numlower; i++) {
296
		mnt = lower[i].layer->mnt;
297 298 299 300 301 302 303 304 305 306
		origin = ovl_get_origin(upperdentry, mnt);
		if (IS_ERR(origin))
			return PTR_ERR(origin);

		if (origin)
			break;
	}

	if (!origin)
		return 0;
307

308 309
	BUG_ON(*ctrp);
	if (!*stackp)
310
		*stackp = kmalloc(sizeof(struct ovl_path), GFP_KERNEL);
311 312 313 314
	if (!*stackp) {
		dput(origin);
		return -ENOMEM;
	}
315
	**stackp = (struct ovl_path){.dentry = origin, .layer = lower[i].layer};
316 317 318 319 320
	*ctrp = 1;

	return 0;
}

321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350
/*
 * Verify that @fh matches the origin file handle stored in OVL_XATTR_ORIGIN.
 * Return 0 on match, -ESTALE on mismatch, < 0 on error.
 */
static int ovl_verify_origin_fh(struct dentry *dentry, const struct ovl_fh *fh)
{
	struct ovl_fh *ofh = ovl_get_origin_fh(dentry);
	int err = 0;

	if (!ofh)
		return -ENODATA;

	if (IS_ERR(ofh))
		return PTR_ERR(ofh);

	if (fh->len != ofh->len || memcmp(fh, ofh, fh->len))
		err = -ESTALE;

	kfree(ofh);
	return err;
}

/*
 * Verify that an inode matches the origin file handle stored in upper inode.
 *
 * If @set is true and there is no stored file handle, encode and store origin
 * file handle in OVL_XATTR_ORIGIN.
 *
 * Return 0 on match, -ESTALE on mismatch, < 0 on error.
 */
351 352
int ovl_verify_origin(struct dentry *dentry, struct dentry *origin,
		      bool is_upper, bool set)
353 354 355 356 357
{
	struct inode *inode;
	struct ovl_fh *fh;
	int err;

358
	fh = ovl_encode_fh(origin, is_upper);
359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379
	err = PTR_ERR(fh);
	if (IS_ERR(fh))
		goto fail;

	err = ovl_verify_origin_fh(dentry, fh);
	if (set && err == -ENODATA)
		err = ovl_do_setxattr(dentry, OVL_XATTR_ORIGIN, fh, fh->len, 0);
	if (err)
		goto fail;

out:
	kfree(fh);
	return err;

fail:
	inode = d_inode(origin);
	pr_warn_ratelimited("overlayfs: failed to verify origin (%pd2, ino=%lu, err=%i)\n",
			    origin, inode ? inode->i_ino : 0, err);
	goto out;
}

380 381 382 383 384
/*
 * Verify that an index entry name matches the origin file handle stored in
 * OVL_XATTR_ORIGIN and that origin file handle can be decoded to lower path.
 * Return 0 on match, -ESTALE on mismatch or stale origin, < 0 on error.
 */
385
int ovl_verify_index(struct dentry *index, struct ovl_path *lower,
386 387 388 389
		     unsigned int numlower)
{
	struct ovl_fh *fh = NULL;
	size_t len;
390 391
	struct ovl_path origin = { };
	struct ovl_path *stack = &origin;
392 393 394 395 396 397
	unsigned int ctr = 0;
	int err;

	if (!d_inode(index))
		return 0;

398 399 400 401 402 403 404 405
	/*
	 * Directory index entries are going to be used for looking up
	 * redirected upper dirs by lower dir fh when decoding an overlay
	 * file handle of a merge dir. Whiteout index entries are going to be
	 * used as an indication that an exported overlay file handle should
	 * be treated as stale (i.e. after unlink of the overlay inode).
	 * We don't know the verification rules for directory and whiteout
	 * index entries, because they have not been implemented yet, so return
406 407
	 * EINVAL if those entries are found to abort the mount to avoid
	 * corrupting an index that was created by a newer kernel.
408
	 */
409
	err = -EINVAL;
410
	if (d_is_dir(index) || ovl_is_whiteout(index))
411 412 413 414 415 416 417
		goto fail;

	if (index->d_name.len < sizeof(struct ovl_fh)*2)
		goto fail;

	err = -ENOMEM;
	len = index->d_name.len / 2;
418
	fh = kzalloc(len, GFP_KERNEL);
419 420 421 422 423 424 425 426 427 428 429
	if (!fh)
		goto fail;

	err = -EINVAL;
	if (hex2bin((u8 *)fh, index->d_name.name, len) || len != fh->len)
		goto fail;

	err = ovl_verify_origin_fh(index, fh);
	if (err)
		goto fail;

430
	err = ovl_check_origin(index, lower, numlower, &stack, &ctr);
431 432 433 434 435
	if (!err && !ctr)
		err = -ESTALE;
	if (err)
		goto fail;

436 437
	/* Check if index is orphan and don't warn before cleaning it */
	if (d_inode(index)->i_nlink == 1 &&
438
	    ovl_get_nlink(origin.dentry, index, 0) == 0)
439 440
		err = -ENOENT;

441 442 443 444 445 446
	dput(origin.dentry);
out:
	kfree(fh);
	return err;

fail:
447 448
	pr_warn_ratelimited("overlayfs: failed to verify index (%pd2, ftype=%x, err=%i)\n",
			    index, d_inode(index)->i_mode & S_IFMT, err);
449 450 451
	goto out;
}

452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477
/*
 * Lookup in indexdir for the index entry of a lower real inode or a copy up
 * origin inode. The index entry name is the hex representation of the lower
 * inode file handle.
 *
 * If the index dentry in negative, then either no lower aliases have been
 * copied up yet, or aliases have been copied up in older kernels and are
 * not indexed.
 *
 * If the index dentry for a copy up origin inode is positive, but points
 * to an inode different than the upper inode, then either the upper inode
 * has been copied up and not indexed or it was indexed, but since then
 * index dir was cleared. Either way, that index cannot be used to indentify
 * the overlay inode.
 */
int ovl_get_index_name(struct dentry *origin, struct qstr *name)
{
	int err;
	struct ovl_fh *fh;
	char *n, *s;

	fh = ovl_encode_fh(origin, false);
	if (IS_ERR(fh))
		return PTR_ERR(fh);

	err = -ENOMEM;
478
	n = kzalloc(fh->len * 2, GFP_KERNEL);
479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505
	if (n) {
		s  = bin2hex(n, fh, fh->len);
		*name = (struct qstr) QSTR_INIT(n, s - n);
		err = 0;
	}
	kfree(fh);

	return err;

}

static struct dentry *ovl_lookup_index(struct dentry *dentry,
				       struct dentry *upper,
				       struct dentry *origin)
{
	struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
	struct dentry *index;
	struct inode *inode;
	struct qstr name;
	int err;

	err = ovl_get_index_name(origin, &name);
	if (err)
		return ERR_PTR(err);

	index = lookup_one_len_unlocked(name.name, ofs->indexdir, name.len);
	if (IS_ERR(index)) {
506
		err = PTR_ERR(index);
507 508 509 510
		if (err == -ENOENT) {
			index = NULL;
			goto out;
		}
511 512 513 514 515 516 517
		pr_warn_ratelimited("overlayfs: failed inode index lookup (ino=%lu, key=%*s, err=%i);\n"
				    "overlayfs: mount with '-o index=off' to disable inodes index.\n",
				    d_inode(origin)->i_ino, name.len, name.name,
				    err);
		goto out;
	}

518
	inode = d_inode(index);
519
	if (d_is_negative(index)) {
520
		goto out_dput;
521
	} else if (upper && d_inode(upper) != inode) {
522
		goto out_dput;
523 524 525 526 527 528 529 530 531 532 533 534
	} else if (ovl_dentry_weird(index) || ovl_is_whiteout(index) ||
		   ((inode->i_mode ^ d_inode(origin)->i_mode) & S_IFMT)) {
		/*
		 * Index should always be of the same file type as origin
		 * except for the case of a whiteout index. A whiteout
		 * index should only exist if all lower aliases have been
		 * unlinked, which means that finding a lower origin on lookup
		 * whose index is a whiteout should be treated as an error.
		 */
		pr_warn_ratelimited("overlayfs: bad index found (index=%pd2, ftype=%x, origin ftype=%x).\n",
				    index, d_inode(index)->i_mode & S_IFMT,
				    d_inode(origin)->i_mode & S_IFMT);
535 536 537 538 539 540 541
		goto fail;
	}

out:
	kfree(name.name);
	return index;

542 543 544 545 546
out_dput:
	dput(index);
	index = NULL;
	goto out;

547 548 549 550 551 552
fail:
	dput(index);
	index = ERR_PTR(-EIO);
	goto out;
}

M
Miklos Szeredi 已提交
553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568
/*
 * Returns next layer in stack starting from top.
 * Returns -1 if this is the last layer.
 */
int ovl_path_next(int idx, struct dentry *dentry, struct path *path)
{
	struct ovl_entry *oe = dentry->d_fsdata;

	BUG_ON(idx < 0);
	if (idx == 0) {
		ovl_path_upper(dentry, path);
		if (path->dentry)
			return oe->numlower ? 1 : -1;
		idx++;
	}
	BUG_ON(idx > oe->numlower);
569 570
	path->dentry = oe->lowerstack[idx - 1].dentry;
	path->mnt = oe->lowerstack[idx - 1].layer->mnt;
M
Miklos Szeredi 已提交
571 572 573 574

	return (idx < oe->numlower) ? idx + 1 : -1;
}

575 576 577 578 579 580 581 582 583 584 585 586
static int ovl_find_layer(struct ovl_fs *ofs, struct ovl_path *path)
{
	int i;

	for (i = 0; i < ofs->numlower; i++) {
		if (ofs->lower_layers[i].mnt == path->layer->mnt)
			break;
	}

	return i;
}

M
Miklos Szeredi 已提交
587 588 589 590 591
struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
			  unsigned int flags)
{
	struct ovl_entry *oe;
	const struct cred *old_cred;
M
Miklos Szeredi 已提交
592
	struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
M
Miklos Szeredi 已提交
593
	struct ovl_entry *poe = dentry->d_parent->d_fsdata;
594
	struct ovl_entry *roe = dentry->d_sb->s_root->d_fsdata;
595
	struct ovl_path *stack = NULL;
M
Miklos Szeredi 已提交
596
	struct dentry *upperdir, *upperdentry = NULL;
597
	struct dentry *index = NULL;
M
Miklos Szeredi 已提交
598 599 600
	unsigned int ctr = 0;
	struct inode *inode = NULL;
	bool upperopaque = false;
M
Miklos Szeredi 已提交
601
	char *upperredirect = NULL;
M
Miklos Szeredi 已提交
602 603 604
	struct dentry *this;
	unsigned int i;
	int err;
605 606 607 608 609 610
	struct ovl_lookup_data d = {
		.name = dentry->d_name,
		.is_dir = false,
		.opaque = false,
		.stop = false,
		.last = !poe->numlower,
M
Miklos Szeredi 已提交
611
		.redirect = NULL,
612
	};
M
Miklos Szeredi 已提交
613

M
Miklos Szeredi 已提交
614 615 616
	if (dentry->d_name.len > ofs->namelen)
		return ERR_PTR(-ENAMETOOLONG);

M
Miklos Szeredi 已提交
617
	old_cred = ovl_override_creds(dentry->d_sb);
618
	upperdir = ovl_dentry_upper(dentry->d_parent);
M
Miklos Szeredi 已提交
619
	if (upperdir) {
620 621
		err = ovl_lookup_layer(upperdir, &d, &upperdentry);
		if (err)
M
Miklos Szeredi 已提交
622 623
			goto out;

624 625 626 627
		if (upperdentry && unlikely(ovl_dentry_remote(upperdentry))) {
			dput(upperdentry);
			err = -EREMOTE;
			goto out;
M
Miklos Szeredi 已提交
628
		}
629 630
		if (upperdentry && !d.is_dir) {
			BUG_ON(!d.stop || d.redirect);
631 632 633 634 635 636 637 638 639 640
			/*
			 * Lookup copy up origin by decoding origin file handle.
			 * We may get a disconnected dentry, which is fine,
			 * because we only need to hold the origin inode in
			 * cache and use its inode number.  We may even get a
			 * connected dentry, that is not under any of the lower
			 * layers root.  That is also fine for using it's inode
			 * number - it's the same as if we held a reference
			 * to a dentry in lower layer that was moved under us.
			 */
641 642
			err = ovl_check_origin(upperdentry, roe->lowerstack,
					       roe->numlower, &stack, &ctr);
643
			if (err)
644
				goto out_put_upper;
645
		}
M
Miklos Szeredi 已提交
646 647

		if (d.redirect) {
648
			err = -ENOMEM;
M
Miklos Szeredi 已提交
649 650 651 652
			upperredirect = kstrdup(d.redirect, GFP_KERNEL);
			if (!upperredirect)
				goto out_put_upper;
			if (d.redirect[0] == '/')
653
				poe = roe;
M
Miklos Szeredi 已提交
654
		}
655
		upperopaque = d.opaque;
M
Miklos Szeredi 已提交
656 657
	}

658
	if (!d.stop && poe->numlower) {
M
Miklos Szeredi 已提交
659
		err = -ENOMEM;
660
		stack = kcalloc(ofs->numlower, sizeof(struct ovl_path),
661
				GFP_KERNEL);
M
Miklos Szeredi 已提交
662 663 664 665
		if (!stack)
			goto out_put_upper;
	}

666
	for (i = 0; !d.stop && i < poe->numlower; i++) {
667
		struct ovl_path lower = poe->lowerstack[i];
M
Miklos Szeredi 已提交
668

669
		d.last = i == poe->numlower - 1;
670
		err = ovl_lookup_layer(lower.dentry, &d, &this);
671
		if (err)
M
Miklos Szeredi 已提交
672
			goto out_put;
M
Miklos Szeredi 已提交
673

M
Miklos Szeredi 已提交
674 675 676 677
		if (!this)
			continue;

		stack[ctr].dentry = this;
678
		stack[ctr].layer = lower.layer;
M
Miklos Szeredi 已提交
679
		ctr++;
M
Miklos Szeredi 已提交
680 681 682 683

		if (d.stop)
			break;

684 685 686 687 688 689 690 691 692 693 694 695
		/*
		 * Following redirects can have security consequences: it's like
		 * a symlink into the lower layer without the permission checks.
		 * This is only a problem if the upper layer is untrusted (e.g
		 * comes from an USB drive).  This can allow a non-readable file
		 * or directory to become readable.
		 *
		 * Only following redirects when redirects are enabled disables
		 * this attack vector when not necessary.
		 */
		err = -EPERM;
		if (d.redirect && !ofs->config.redirect_follow) {
696 697
			pr_warn_ratelimited("overlayfs: refusing to follow redirect for (%pd2)\n",
					    dentry);
698 699 700
			goto out_put;
		}

701 702
		if (d.redirect && d.redirect[0] == '/' && poe != roe) {
			poe = roe;
M
Miklos Szeredi 已提交
703 704

			/* Find the current layer on the root dentry */
705 706
			i = ovl_find_layer(ofs, &lower);
			if (WARN_ON(i == ofs->numlower))
M
Miklos Szeredi 已提交
707 708
				break;
		}
M
Miklos Szeredi 已提交
709 710
	}

711 712 713 714 715 716 717 718 719 720 721 722
	/* Lookup index by lower inode and verify it matches upper inode */
	if (ctr && !d.is_dir && ovl_indexdir(dentry->d_sb)) {
		struct dentry *origin = stack[0].dentry;

		index = ovl_lookup_index(dentry, upperdentry, origin);
		if (IS_ERR(index)) {
			err = PTR_ERR(index);
			index = NULL;
			goto out_put;
		}
	}

M
Miklos Szeredi 已提交
723 724 725 726 727
	oe = ovl_alloc_entry(ctr);
	err = -ENOMEM;
	if (!oe)
		goto out_put;

M
Miklos Szeredi 已提交
728
	oe->opaque = upperopaque;
729
	memcpy(oe->lowerstack, stack, sizeof(struct ovl_path) * ctr);
M
Miklos Szeredi 已提交
730
	dentry->d_fsdata = oe;
M
Miklos Szeredi 已提交
731

732 733 734
	if (upperdentry)
		ovl_dentry_set_upper_alias(dentry);
	else if (index)
735 736
		upperdentry = dget(index);

M
Miklos Szeredi 已提交
737
	if (upperdentry || ctr) {
738
		inode = ovl_get_inode(dentry, upperdentry, index);
739 740
		err = PTR_ERR(inode);
		if (IS_ERR(inode))
M
Miklos Szeredi 已提交
741
			goto out_free_oe;
M
Miklos Szeredi 已提交
742 743

		OVL_I(inode)->redirect = upperredirect;
744 745
		if (index)
			ovl_set_flag(OVL_INDEX, inode);
M
Miklos Szeredi 已提交
746 747 748
	}

	revert_creds(old_cred);
749
	dput(index);
M
Miklos Szeredi 已提交
750
	kfree(stack);
M
Miklos Szeredi 已提交
751
	kfree(d.redirect);
M
Miklos Szeredi 已提交
752 753 754 755 756
	d_add(dentry, inode);

	return NULL;

out_free_oe:
M
Miklos Szeredi 已提交
757
	dentry->d_fsdata = NULL;
M
Miklos Szeredi 已提交
758 759
	kfree(oe);
out_put:
760
	dput(index);
M
Miklos Szeredi 已提交
761 762 763 764 765
	for (i = 0; i < ctr; i++)
		dput(stack[i].dentry);
	kfree(stack);
out_put_upper:
	dput(upperdentry);
M
Miklos Szeredi 已提交
766
	kfree(upperredirect);
M
Miklos Szeredi 已提交
767
out:
M
Miklos Szeredi 已提交
768
	kfree(d.redirect);
M
Miklos Szeredi 已提交
769 770 771 772 773 774 775 776 777
	revert_creds(old_cred);
	return ERR_PTR(err);
}

bool ovl_lower_positive(struct dentry *dentry)
{
	struct ovl_entry *oe = dentry->d_fsdata;
	struct ovl_entry *poe = dentry->d_parent->d_fsdata;
	const struct qstr *name = &dentry->d_name;
778
	const struct cred *old_cred;
M
Miklos Szeredi 已提交
779 780 781 782 783 784 785 786 787 788 789 790
	unsigned int i;
	bool positive = false;
	bool done = false;

	/*
	 * If dentry is negative, then lower is positive iff this is a
	 * whiteout.
	 */
	if (!dentry->d_inode)
		return oe->opaque;

	/* Negative upper -> positive lower */
791
	if (!ovl_dentry_upper(dentry))
M
Miklos Szeredi 已提交
792 793
		return true;

794
	old_cred = ovl_override_creds(dentry->d_sb);
M
Miklos Szeredi 已提交
795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823
	/* Positive upper -> have to look up lower to see whether it exists */
	for (i = 0; !done && !positive && i < poe->numlower; i++) {
		struct dentry *this;
		struct dentry *lowerdir = poe->lowerstack[i].dentry;

		this = lookup_one_len_unlocked(name->name, lowerdir,
					       name->len);
		if (IS_ERR(this)) {
			switch (PTR_ERR(this)) {
			case -ENOENT:
			case -ENAMETOOLONG:
				break;

			default:
				/*
				 * Assume something is there, we just couldn't
				 * access it.
				 */
				positive = true;
				break;
			}
		} else {
			if (this->d_inode) {
				positive = !ovl_is_whiteout(this);
				done = true;
			}
			dput(this);
		}
	}
824
	revert_creds(old_cred);
M
Miklos Szeredi 已提交
825 826 827

	return positive;
}