omap_crtc.c 17.6 KB
Newer Older
1
/*
R
Rob Clark 已提交
2
 * drivers/gpu/drm/omapdrm/omap_crtc.c
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19
 *
 * Copyright (C) 2011 Texas Instruments
 * Author: Rob Clark <rob@ti.com>
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 as published by
 * the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 * more details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program.  If not, see <http://www.gnu.org/licenses/>.
 */

20 21
#include <linux/completion.h>

22 23
#include "omap_drv.h"

24
#include <drm/drm_mode.h>
25
#include <drm/drm_plane_helper.h>
26 27 28 29 30 31 32
#include "drm_crtc.h"
#include "drm_crtc_helper.h"

#define to_omap_crtc(x) container_of(x, struct omap_crtc, base)

struct omap_crtc {
	struct drm_crtc base;
33

34
	const char *name;
35 36 37
	int pipe;
	enum omap_channel channel;
	struct omap_overlay_manager_info info;
38
	struct drm_encoder *current_encoder;
39 40 41 42 43 44 45

	/*
	 * Temporary: eventually this will go away, but it is needed
	 * for now to keep the output's happy.  (They only need
	 * mgr->id.)  Eventually this will be replaced w/ something
	 * more common-panel-framework-y
	 */
46
	struct omap_overlay_manager *mgr;
47 48 49 50

	struct omap_video_timings timings;
	bool enabled;

51
	struct omap_drm_irq vblank_irq;
52 53
	struct omap_drm_irq error_irq;

54 55
	/* list of framebuffers to unpin */
	struct list_head pending_unpins;
56

57
	/* if there is a pending flip, these will be non-null: */
58
	struct drm_pending_vblank_event *event;
59
	struct drm_framebuffer *old_fb;
60

61 62
	struct completion completion;

63 64 65 66 67 68
	/* for handling page flips without caring about what
	 * the callback is called from.  Possibly we should just
	 * make omap_gem always call the cb from the worker so
	 * we don't have to care about this..
	 */
	struct work_struct page_flip_work;
69 70

	bool ignore_digit_sync_lost;
71 72
};

73 74 75 76 77
struct omap_framebuffer_unpin {
	struct list_head list;
	struct drm_framebuffer *fb;
};

78 79 80 81
/* -----------------------------------------------------------------------------
 * Helper Functions
 */

82 83 84 85 86 87 88
uint32_t pipe2vbl(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);

	return dispc_mgr_get_vsync_irq(omap_crtc->channel);
}

89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104
const struct omap_video_timings *omap_crtc_timings(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	return &omap_crtc->timings;
}

enum omap_channel omap_crtc_channel(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	return omap_crtc->channel;
}

/* -----------------------------------------------------------------------------
 * DSS Manager Functions
 */

105 106 107 108 109 110 111 112 113
/*
 * Manager-ops, callbacks from output when they need to configure
 * the upstream part of the video pipe.
 *
 * Most of these we can ignore until we add support for command-mode
 * panels.. for video-mode the crtc-helpers already do an adequate
 * job of sequencing the setup of the video pipe in the proper order
 */

114 115 116
/* ovl-mgr-id -> crtc */
static struct omap_crtc *omap_crtcs[8];

117
/* we can probably ignore these until we support command-mode panels: */
118
static int omap_crtc_connect(struct omap_overlay_manager *mgr,
119
		struct omap_dss_device *dst)
120 121 122 123 124 125 126 127 128 129 130 131 132 133
{
	if (mgr->output)
		return -EINVAL;

	if ((mgr->supported_outputs & dst->id) == 0)
		return -EINVAL;

	dst->manager = mgr;
	mgr->output = dst;

	return 0;
}

static void omap_crtc_disconnect(struct omap_overlay_manager *mgr,
134
		struct omap_dss_device *dst)
135 136 137 138 139
{
	mgr->output->manager = NULL;
	mgr->output = NULL;
}

140 141 142 143
static void omap_crtc_start_update(struct omap_overlay_manager *mgr)
{
}

144
/* Called only from omap_crtc_setup and suspend/resume handlers. */
145 146 147 148 149 150 151 152 153 154 155 156
static void omap_crtc_set_enabled(struct drm_crtc *crtc, bool enable)
{
	struct drm_device *dev = crtc->dev;
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	enum omap_channel channel = omap_crtc->channel;
	struct omap_irq_wait *wait;
	u32 framedone_irq, vsync_irq;
	int ret;

	if (dispc_mgr_is_enabled(channel) == enable)
		return;

157 158 159 160 161 162 163
	if (omap_crtc->channel == OMAP_DSS_CHANNEL_DIGIT) {
		/*
		 * Digit output produces some sync lost interrupts during the
		 * first frame when enabling, so we need to ignore those.
		 */
		omap_crtc->ignore_digit_sync_lost = true;
	}
164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193

	framedone_irq = dispc_mgr_get_framedone_irq(channel);
	vsync_irq = dispc_mgr_get_vsync_irq(channel);

	if (enable) {
		wait = omap_irq_wait_init(dev, vsync_irq, 1);
	} else {
		/*
		 * When we disable the digit output, we need to wait for
		 * FRAMEDONE to know that DISPC has finished with the output.
		 *
		 * OMAP2/3 does not have FRAMEDONE irq for digit output, and in
		 * that case we need to use vsync interrupt, and wait for both
		 * even and odd frames.
		 */

		if (framedone_irq)
			wait = omap_irq_wait_init(dev, framedone_irq, 1);
		else
			wait = omap_irq_wait_init(dev, vsync_irq, 2);
	}

	dispc_mgr_enable(channel, enable);

	ret = omap_irq_wait(dev, wait, msecs_to_jiffies(100));
	if (ret) {
		dev_err(dev->dev, "%s: timeout waiting for %s\n",
				omap_crtc->name, enable ? "enable" : "disable");
	}

194 195 196 197 198
	if (omap_crtc->channel == OMAP_DSS_CHANNEL_DIGIT) {
		omap_crtc->ignore_digit_sync_lost = false;
		/* make sure the irq handler sees the value above */
		mb();
	}
199 200
}

201

202 203
static int omap_crtc_enable(struct omap_overlay_manager *mgr)
{
204 205 206 207 208
	struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];

	dispc_mgr_setup(omap_crtc->channel, &omap_crtc->info);
	dispc_mgr_set_timings(omap_crtc->channel,
			&omap_crtc->timings);
209
	omap_crtc_set_enabled(&omap_crtc->base, true);
210

211 212 213 214 215
	return 0;
}

static void omap_crtc_disable(struct omap_overlay_manager *mgr)
{
216 217
	struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];

218
	omap_crtc_set_enabled(&omap_crtc->base, false);
219 220 221 222 223
}

static void omap_crtc_set_timings(struct omap_overlay_manager *mgr,
		const struct omap_video_timings *timings)
{
224
	struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];
225 226 227 228 229 230 231
	DBG("%s", omap_crtc->name);
	omap_crtc->timings = *timings;
}

static void omap_crtc_set_lcd_config(struct omap_overlay_manager *mgr,
		const struct dss_lcd_mgr_config *config)
{
232
	struct omap_crtc *omap_crtc = omap_crtcs[mgr->id];
233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250
	DBG("%s", omap_crtc->name);
	dispc_mgr_set_lcd_config(omap_crtc->channel, config);
}

static int omap_crtc_register_framedone_handler(
		struct omap_overlay_manager *mgr,
		void (*handler)(void *), void *data)
{
	return 0;
}

static void omap_crtc_unregister_framedone_handler(
		struct omap_overlay_manager *mgr,
		void (*handler)(void *), void *data)
{
}

static const struct dss_mgr_ops mgr_ops = {
251 252 253 254 255 256 257 258 259
	.connect = omap_crtc_connect,
	.disconnect = omap_crtc_disconnect,
	.start_update = omap_crtc_start_update,
	.enable = omap_crtc_enable,
	.disable = omap_crtc_disable,
	.set_timings = omap_crtc_set_timings,
	.set_lcd_config = omap_crtc_set_lcd_config,
	.register_framedone_handler = omap_crtc_register_framedone_handler,
	.unregister_framedone_handler = omap_crtc_unregister_framedone_handler,
260 261
};

262
/* -----------------------------------------------------------------------------
263
 * Setup and Flush
264 265 266 267 268 269
 */

static void omap_crtc_error_irq(struct omap_drm_irq *irq, uint32_t irqstatus)
{
	struct omap_crtc *omap_crtc =
			container_of(irq, struct omap_crtc, error_irq);
270 271 272 273 274 275 276

	if (omap_crtc->ignore_digit_sync_lost) {
		irqstatus &= ~DISPC_IRQ_SYNC_LOST_DIGIT;
		if (!irqstatus)
			return;
	}

277
	DRM_ERROR_RATELIMITED("%s: errors: %08x\n", omap_crtc->name, irqstatus);
278 279
}

280
static void omap_crtc_vblank_irq(struct omap_drm_irq *irq, uint32_t irqstatus)
281 282
{
	struct omap_crtc *omap_crtc =
283 284 285
			container_of(irq, struct omap_crtc, vblank_irq);
	struct drm_device *dev = omap_crtc->base.dev;
	unsigned long flags;
286

287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304
	if (dispc_mgr_go_busy(omap_crtc->channel))
		return;

	DBG("%s: apply done", omap_crtc->name);
	__omap_irq_unregister(dev, &omap_crtc->vblank_irq);

	spin_lock_irqsave(&dev->event_lock, flags);

	/* wakeup userspace */
	if (omap_crtc->event)
		drm_send_vblank_event(dev, omap_crtc->pipe, omap_crtc->event);

	omap_crtc->event = NULL;
	omap_crtc->old_fb = NULL;

	spin_unlock_irqrestore(&dev->event_lock, flags);

	complete(&omap_crtc->completion);
305 306
}

307
int omap_crtc_flush(struct drm_crtc *crtc)
308
{
309 310
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	struct omap_framebuffer_unpin *fb, *next;
311

312
	DBG("%s: GO", omap_crtc->name);
313

314 315
	WARN_ON(!drm_modeset_is_locked(&crtc->mutex));
	WARN_ON(omap_crtc->vblank_irq.registered);
316

317
	dispc_runtime_get();
318

319 320 321
	if (dispc_mgr_is_enabled(omap_crtc->channel)) {
		dispc_mgr_go(omap_crtc->channel);
		omap_irq_register(crtc->dev, &omap_crtc->vblank_irq);
322

323 324 325 326
		WARN_ON(!wait_for_completion_timeout(&omap_crtc->completion,
						     msecs_to_jiffies(100)));
		reinit_completion(&omap_crtc->completion);
	}
327

328
	dispc_runtime_put();
329

330 331 332 333 334 335
	/* Unpin and unreference pending framebuffers. */
	list_for_each_entry_safe(fb, next, &omap_crtc->pending_unpins, list) {
		omap_framebuffer_unpin(fb->fb);
		drm_framebuffer_unreference(fb->fb);
		list_del(&fb->list);
		kfree(fb);
336 337
	}

338
	return 0;
339 340
}

341
int omap_crtc_queue_unpin(struct drm_crtc *crtc, struct drm_framebuffer *fb)
342 343
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
344
	struct omap_framebuffer_unpin *unpin;
345

346 347 348
	unpin = kzalloc(sizeof(*unpin), GFP_KERNEL);
	if (!unpin)
		return -ENOMEM;
349

350 351
	unpin->fb = fb;
	list_add_tail(&unpin->list, &omap_crtc->pending_unpins);
352 353 354 355

	return 0;
}

356
static void omap_crtc_setup(struct drm_crtc *crtc)
357
{
358
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
359 360 361 362 363 364
	struct omap_drm_private *priv = crtc->dev->dev_private;
	struct drm_encoder *encoder = NULL;
	unsigned int i;

	DBG("%s: enabled=%d", omap_crtc->name, omap_crtc->enabled);

365 366
	dispc_runtime_get();

367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390
	for (i = 0; i < priv->num_encoders; i++) {
		if (priv->encoders[i]->crtc == crtc) {
			encoder = priv->encoders[i];
			break;
		}
	}

	if (omap_crtc->current_encoder && encoder != omap_crtc->current_encoder)
		omap_encoder_set_enabled(omap_crtc->current_encoder, false);

	omap_crtc->current_encoder = encoder;

	if (!omap_crtc->enabled) {
		if (encoder)
			omap_encoder_set_enabled(encoder, false);
	} else {
		if (encoder) {
			omap_encoder_set_enabled(encoder, false);
			omap_encoder_update(encoder, omap_crtc->mgr,
					&omap_crtc->timings);
			omap_encoder_set_enabled(encoder, true);
		}
	}

391
	dispc_runtime_put();
392 393 394 395
}

/* -----------------------------------------------------------------------------
 * CRTC Functions
396 397
 */

398 399 400
static void omap_crtc_destroy(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
401 402 403

	DBG("%s", omap_crtc->name);

404
	WARN_ON(omap_crtc->vblank_irq.registered);
405 406
	omap_irq_unregister(crtc->dev, &omap_crtc->error_irq);

407
	drm_crtc_cleanup(crtc);
408

409 410 411 412 413
	kfree(omap_crtc);
}

static void omap_crtc_dpms(struct drm_crtc *crtc, int mode)
{
414
	struct omap_drm_private *priv = crtc->dev->dev_private;
415
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
416
	bool enabled = (mode == DRM_MODE_DPMS_ON);
417
	int i;
418

419 420
	DBG("%s: %d", omap_crtc->name, mode);

421 422
	if (enabled == omap_crtc->enabled)
		return;
423

424 425 426 427 428 429
	/* Enable/disable all planes associated with the CRTC. */
	for (i = 0; i < priv->num_planes; i++) {
		struct drm_plane *plane = priv->planes[i];

		if (plane->crtc == crtc)
			WARN_ON(omap_plane_set_enable(plane, enabled));
430
	}
431 432 433 434 435

	omap_crtc->enabled = enabled;

	omap_crtc_setup(crtc);
	omap_crtc_flush(crtc);
436 437 438
}

static bool omap_crtc_mode_fixup(struct drm_crtc *crtc,
439
		const struct drm_display_mode *mode,
440
		struct drm_display_mode *adjusted_mode)
441 442 443 444 445
{
	return true;
}

static int omap_crtc_mode_set(struct drm_crtc *crtc,
446 447 448 449
		struct drm_display_mode *mode,
		struct drm_display_mode *adjusted_mode,
		int x, int y,
		struct drm_framebuffer *old_fb)
450 451 452
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);

453 454 455 456 457 458 459 460 461 462 463 464 465
	mode = adjusted_mode;

	DBG("%s: set mode: %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x",
			omap_crtc->name, mode->base.id, mode->name,
			mode->vrefresh, mode->clock,
			mode->hdisplay, mode->hsync_start,
			mode->hsync_end, mode->htotal,
			mode->vdisplay, mode->vsync_start,
			mode->vsync_end, mode->vtotal,
			mode->type, mode->flags);

	copy_timings_drm_to_omap(&omap_crtc->timings, mode);

466 467 468 469 470 471 472
	/*
	 * The primary plane CRTC can be reset if the plane is disabled directly
	 * through the universal plane API. Set it again here.
	 */
	crtc->primary->crtc = crtc;

	return omap_plane_mode_set(crtc->primary, crtc, crtc->primary->fb,
473
				   0, 0, mode->hdisplay, mode->vdisplay,
474
				   x, y, mode->hdisplay, mode->vdisplay);
475 476 477 478 479
}

static void omap_crtc_prepare(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
480
	DBG("%s", omap_crtc->name);
481 482 483 484 485 486
	omap_crtc_dpms(crtc, DRM_MODE_DPMS_OFF);
}

static void omap_crtc_commit(struct drm_crtc *crtc)
{
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
487
	DBG("%s", omap_crtc->name);
488 489 490 491
	omap_crtc_dpms(crtc, DRM_MODE_DPMS_ON);
}

static int omap_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y,
492
		struct drm_framebuffer *old_fb)
493
{
494
	struct drm_plane *plane = crtc->primary;
495
	struct drm_display_mode *mode = &crtc->mode;
496
	int ret;
497

498 499 500 501 502
	ret = omap_plane_mode_set(plane, crtc, crtc->primary->fb,
				  0, 0, mode->hdisplay, mode->vdisplay,
				  x, y, mode->hdisplay, mode->vdisplay);
	if (ret < 0)
		return ret;
T
Tomi Valkeinen 已提交
503

504
	return omap_crtc_flush(crtc);
505 506
}

507
static void page_flip_worker(struct work_struct *work)
508
{
509 510 511 512
	struct omap_crtc *omap_crtc =
			container_of(work, struct omap_crtc, page_flip_work);
	struct drm_crtc *crtc = &omap_crtc->base;
	struct drm_display_mode *mode = &crtc->mode;
513
	struct drm_gem_object *bo;
514

515
	drm_modeset_lock(&crtc->mutex, NULL);
516
	omap_plane_mode_set(crtc->primary, crtc, crtc->primary->fb,
517
			    0, 0, mode->hdisplay, mode->vdisplay,
518 519
			    crtc->x, crtc->y, mode->hdisplay, mode->vdisplay);
	omap_crtc_flush(crtc);
520
	drm_modeset_unlock(&crtc->mutex);
521

522
	bo = omap_framebuffer_bo(crtc->primary->fb, 0);
523
	drm_gem_object_unreference_unlocked(bo);
524
	drm_framebuffer_unreference(crtc->primary->fb);
525 526
}

527 528 529 530 531 532 533 534 535 536
static void page_flip_cb(void *arg)
{
	struct drm_crtc *crtc = arg;
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
	struct omap_drm_private *priv = crtc->dev->dev_private;

	/* avoid assumptions about what ctxt we are called from: */
	queue_work(priv->wq, &omap_crtc->page_flip_work);
}

537 538
static int omap_crtc_page_flip_locked(struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
539 540
		 struct drm_pending_vblank_event *event,
		 uint32_t page_flip_flags)
541 542 543
{
	struct drm_device *dev = crtc->dev;
	struct omap_crtc *omap_crtc = to_omap_crtc(crtc);
544
	struct drm_plane *primary = crtc->primary;
545
	struct drm_gem_object *bo;
546
	unsigned long flags;
547

548
	DBG("%d -> %d (event=%p)", primary->fb ? primary->fb->base.id : -1,
549
			fb->base.id, event);
550

551 552
	spin_lock_irqsave(&dev->event_lock, flags);

553
	if (omap_crtc->old_fb) {
554
		spin_unlock_irqrestore(&dev->event_lock, flags);
555
		dev_err(dev->dev, "already a pending flip\n");
556
		return -EBUSY;
557 558 559
	}

	omap_crtc->event = event;
560
	omap_crtc->old_fb = primary->fb = fb;
T
Tomi Valkeinen 已提交
561
	drm_framebuffer_reference(omap_crtc->old_fb);
562

563 564
	spin_unlock_irqrestore(&dev->event_lock, flags);

565 566 567 568 569 570 571 572 573
	/*
	 * Hold a reference temporarily until the crtc is updated
	 * and takes the reference to the bo.  This avoids it
	 * getting freed from under us:
	 */
	bo = omap_framebuffer_bo(fb, 0);
	drm_gem_object_reference(bo);

	omap_gem_op_async(bo, OMAP_GEM_READ, page_flip_cb, crtc);
574 575 576 577

	return 0;
}

578 579 580
static int omap_crtc_set_property(struct drm_crtc *crtc,
		struct drm_property *property, uint64_t val)
{
581
	if (property == crtc->dev->mode_config.rotation_property) {
582 583 584 585
		crtc->invert_dimensions =
				!!(val & ((1LL << DRM_ROTATE_90) | (1LL << DRM_ROTATE_270)));
	}

586
	return omap_plane_set_property(crtc->primary, property, val);
587 588
}

589 590 591 592
static const struct drm_crtc_funcs omap_crtc_funcs = {
	.set_config = drm_crtc_helper_set_config,
	.destroy = omap_crtc_destroy,
	.page_flip = omap_crtc_page_flip_locked,
593
	.set_property = omap_crtc_set_property,
594 595 596 597 598 599 600 601 602 603 604
};

static const struct drm_crtc_helper_funcs omap_crtc_helper_funcs = {
	.dpms = omap_crtc_dpms,
	.mode_fixup = omap_crtc_mode_fixup,
	.mode_set = omap_crtc_mode_set,
	.prepare = omap_crtc_prepare,
	.commit = omap_crtc_commit,
	.mode_set_base = omap_crtc_mode_set_base,
};

605 606 607
/* -----------------------------------------------------------------------------
 * Init and Cleanup
 */
608

609
static const char *channel_names[] = {
610 611 612 613
	[OMAP_DSS_CHANNEL_LCD] = "lcd",
	[OMAP_DSS_CHANNEL_DIGIT] = "tv",
	[OMAP_DSS_CHANNEL_LCD2] = "lcd2",
	[OMAP_DSS_CHANNEL_LCD3] = "lcd3",
614 615
};

616 617 618 619 620
void omap_crtc_pre_init(void)
{
	dss_install_mgr_ops(&mgr_ops);
}

621 622 623 624 625
void omap_crtc_pre_uninit(void)
{
	dss_uninstall_mgr_ops();
}

626 627
/* initialize crtc */
struct drm_crtc *omap_crtc_init(struct drm_device *dev,
628
		struct drm_plane *plane, enum omap_channel channel, int id)
629 630
{
	struct drm_crtc *crtc = NULL;
631 632
	struct omap_crtc *omap_crtc;
	struct omap_overlay_manager_info *info;
633
	int ret;
634 635

	DBG("%s", channel_names[channel]);
636

637
	omap_crtc = kzalloc(sizeof(*omap_crtc), GFP_KERNEL);
638
	if (!omap_crtc)
639
		return NULL;
640 641

	crtc = &omap_crtc->base;
642

643 644
	INIT_WORK(&omap_crtc->page_flip_work, page_flip_worker);

645
	INIT_LIST_HEAD(&omap_crtc->pending_unpins);
646

647
	init_completion(&omap_crtc->completion);
648

649 650 651 652
	omap_crtc->channel = channel;
	omap_crtc->name = channel_names[channel];
	omap_crtc->pipe = id;

653 654
	omap_crtc->vblank_irq.irqmask = pipe2vbl(crtc);
	omap_crtc->vblank_irq.irq = omap_crtc_vblank_irq;
655 656 657 658 659 660 661

	omap_crtc->error_irq.irqmask =
			dispc_mgr_get_sync_lost_irq(channel);
	omap_crtc->error_irq.irq = omap_crtc_error_irq;
	omap_irq_register(dev, &omap_crtc->error_irq);

	/* temporary: */
662
	omap_crtc->mgr = omap_dss_get_overlay_manager(channel);
663 664 665 666 667 668 669

	/* TODO: fix hard-coded setup.. add properties! */
	info = &omap_crtc->info;
	info->default_color = 0x00000000;
	info->trans_key = 0x00000000;
	info->trans_key_type = OMAP_DSS_COLOR_KEY_GFX_DST;
	info->trans_enabled = false;
670

671 672 673 674 675 676 677
	ret = drm_crtc_init_with_planes(dev, crtc, plane, NULL,
					&omap_crtc_funcs);
	if (ret < 0) {
		kfree(omap_crtc);
		return NULL;
	}

678 679
	drm_crtc_helper_add(crtc, &omap_crtc_helper_funcs);

680
	omap_plane_install_properties(crtc->primary, &crtc->base);
681

682 683
	omap_crtcs[channel] = omap_crtc;

684 685
	return crtc;
}