ec.c 30.4 KB
Newer Older
L
Linus Torvalds 已提交
1
/*
2
 *  ec.c - ACPI Embedded Controller Driver (v2.2)
L
Linus Torvalds 已提交
3
 *
4 5 6 7 8 9 10 11
 *  Copyright (C) 2001-2014 Intel Corporation
 *    Author: 2014       Lv Zheng <lv.zheng@intel.com>
 *            2006, 2007 Alexey Starikovskiy <alexey.y.starikovskiy@intel.com>
 *            2006       Denis Sadykov <denis.m.sadykov@intel.com>
 *            2004       Luming Yu <luming.yu@intel.com>
 *            2001, 2002 Andy Grover <andrew.grover@intel.com>
 *            2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com>
 *  Copyright (C) 2008      Alexey Starikovskiy <astarikovskiy@suse.de>
L
Linus Torvalds 已提交
12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31
 *
 * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or (at
 *  your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful, but
 *  WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 *  General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License along
 *  with this program; if not, write to the Free Software Foundation, Inc.,
 *  59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
 *
 * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 */

32
/* Uncomment next line to get verbose printout */
33
/* #define DEBUG */
34
#define pr_fmt(fmt) "ACPI : EC: " fmt
35

L
Linus Torvalds 已提交
36 37 38 39 40
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/types.h>
#include <linux/delay.h>
D
Dmitry Torokhov 已提交
41
#include <linux/interrupt.h>
42
#include <linux/list.h>
43
#include <linux/spinlock.h>
44
#include <linux/slab.h>
45
#include <linux/acpi.h>
46
#include <linux/dmi.h>
47
#include <asm/io.h>
L
Linus Torvalds 已提交
48

49 50
#include "internal.h"

L
Linus Torvalds 已提交
51 52 53
#define ACPI_EC_CLASS			"embedded_controller"
#define ACPI_EC_DEVICE_NAME		"Embedded Controller"
#define ACPI_EC_FILE_INFO		"info"
54

55
/* EC status register */
L
Linus Torvalds 已提交
56 57
#define ACPI_EC_FLAG_OBF	0x01	/* Output buffer full */
#define ACPI_EC_FLAG_IBF	0x02	/* Input buffer full */
58
#define ACPI_EC_FLAG_CMD	0x08	/* Input buffer contains a command */
D
Dmitry Torokhov 已提交
59
#define ACPI_EC_FLAG_BURST	0x10	/* burst mode */
L
Linus Torvalds 已提交
60
#define ACPI_EC_FLAG_SCI	0x20	/* EC-SCI occurred */
61

62
/* EC commands */
63
enum ec_command {
A
Alexey Starikovskiy 已提交
64 65 66 67 68
	ACPI_EC_COMMAND_READ = 0x80,
	ACPI_EC_COMMAND_WRITE = 0x81,
	ACPI_EC_BURST_ENABLE = 0x82,
	ACPI_EC_BURST_DISABLE = 0x83,
	ACPI_EC_COMMAND_QUERY = 0x84,
69
};
70

71
#define ACPI_EC_DELAY		500	/* Wait 500ms max. during EC ops */
72
#define ACPI_EC_UDELAY_GLK	1000	/* Wait 1ms max. to get global lock */
73
#define ACPI_EC_MSI_UDELAY	550	/* Wait 550us for MSI EC */
74 75
#define ACPI_EC_CLEAR_MAX	100	/* Maximum number of events to query
					 * when trying to clear the EC */
76

77 78
enum {
	EC_FLAGS_QUERY_PENDING,		/* Query is pending */
79
	EC_FLAGS_GPE_STORM,		/* GPE storm detected */
80
	EC_FLAGS_HANDLERS_INSTALLED,	/* Handlers for GPE and
81
					 * OpReg are installed */
82
	EC_FLAGS_BLOCKED,		/* Transactions are blocked */
L
Linus Torvalds 已提交
83
};
84

85 86 87
#define ACPI_EC_COMMAND_POLL		0x01 /* Available for command byte */
#define ACPI_EC_COMMAND_COMPLETE	0x02 /* Completed last byte */

88 89 90 91 92
/* ec.c is compiled in acpi namespace so this shows up as acpi.ec_delay param */
static unsigned int ec_delay __read_mostly = ACPI_EC_DELAY;
module_param(ec_delay, uint, 0644);
MODULE_PARM_DESC(ec_delay, "Timeout(ms) waited until an EC command completes");

93 94 95 96 97 98 99 100 101
/*
 * If the number of false interrupts per one transaction exceeds
 * this threshold, will think there is a GPE storm happened and
 * will disable the GPE for normal transaction.
 */
static unsigned int ec_storm_threshold  __read_mostly = 8;
module_param(ec_storm_threshold, uint, 0644);
MODULE_PARM_DESC(ec_storm_threshold, "Maxim false GPE numbers not considered as GPE storm");

102 103 104 105 106 107 108 109
struct acpi_ec_query_handler {
	struct list_head node;
	acpi_ec_query_func func;
	acpi_handle handle;
	void *data;
	u8 query_bit;
};

110
struct transaction {
111 112 113
	const u8 *wdata;
	u8 *rdata;
	unsigned short irq_count;
114
	u8 command;
115 116
	u8 wi;
	u8 ri;
117 118
	u8 wlen;
	u8 rlen;
119
	u8 flags;
120 121
};

122 123
struct acpi_ec *boot_ec, *first_ec;
EXPORT_SYMBOL(first_ec);
124

125
static int EC_FLAGS_MSI; /* Out-of-spec MSI controller */
A
Alexey Starikovskiy 已提交
126
static int EC_FLAGS_VALIDATE_ECDT; /* ASUStec ECDTs need to be validated */
127
static int EC_FLAGS_SKIP_DSDT_SCAN; /* Not all BIOS survive early DSDT scan */
128
static int EC_FLAGS_CLEAR_ON_RESUME; /* Needs acpi_ec_clear() on boot/resume */
129

L
Linus Torvalds 已提交
130 131 132 133
/* --------------------------------------------------------------------------
                             Transaction Management
   -------------------------------------------------------------------------- */

134
static inline u8 acpi_ec_read_status(struct acpi_ec *ec)
L
Linus Torvalds 已提交
135
{
136
	u8 x = inb(ec->command_addr);
137 138 139 140 141 142 143 144
	pr_debug("EC_SC(R) = 0x%2.2x "
		 "SCI_EVT=%d BURST=%d CMD=%d IBF=%d OBF=%d\n",
		 x,
		 !!(x & ACPI_EC_FLAG_SCI),
		 !!(x & ACPI_EC_FLAG_BURST),
		 !!(x & ACPI_EC_FLAG_CMD),
		 !!(x & ACPI_EC_FLAG_IBF),
		 !!(x & ACPI_EC_FLAG_OBF));
145
	return x;
D
Dmitry Torokhov 已提交
146 147
}

148
static inline u8 acpi_ec_read_data(struct acpi_ec *ec)
149
{
150
	u8 x = inb(ec->data_addr);
151
	pr_debug("EC_DATA(R) = 0x%2.2x\n", x);
152
	return x;
153 154
}

155
static inline void acpi_ec_write_cmd(struct acpi_ec *ec, u8 command)
L
Luming Yu 已提交
156
{
157
	pr_debug("EC_SC(W) = 0x%2.2x\n", command);
158
	outb(command, ec->command_addr);
L
Luming Yu 已提交
159 160
}

161
static inline void acpi_ec_write_data(struct acpi_ec *ec, u8 data)
L
Luming Yu 已提交
162
{
163
	pr_debug("EC_DATA(W) = 0x%2.2x\n", data);
164
	outb(data, ec->data_addr);
165
}
L
Luming Yu 已提交
166

167
static int ec_transaction_completed(struct acpi_ec *ec)
168
{
169 170
	unsigned long flags;
	int ret = 0;
171
	spin_lock_irqsave(&ec->lock, flags);
172
	if (ec->curr && (ec->curr->flags & ACPI_EC_COMMAND_COMPLETE))
173
		ret = 1;
174
	spin_unlock_irqrestore(&ec->lock, flags);
175
	return ret;
L
Luming Yu 已提交
176
}
D
Dmitry Torokhov 已提交
177

178
static bool advance_transaction(struct acpi_ec *ec)
179
{
180
	struct transaction *t;
181
	u8 status;
182
	bool wakeup = false;
183

184 185
	pr_debug("===== %s =====\n", in_interrupt() ? "IRQ" : "TASK");
	status = acpi_ec_read_status(ec);
186
	t = ec->curr;
187
	if (!t)
188 189 190 191 192 193 194 195 196 197
		goto err;
	if (t->flags & ACPI_EC_COMMAND_POLL) {
		if (t->wlen > t->wi) {
			if ((status & ACPI_EC_FLAG_IBF) == 0)
				acpi_ec_write_data(ec, t->wdata[t->wi++]);
			else
				goto err;
		} else if (t->rlen > t->ri) {
			if ((status & ACPI_EC_FLAG_OBF) == 1) {
				t->rdata[t->ri++] = acpi_ec_read_data(ec);
198
				if (t->rlen == t->ri) {
199
					t->flags |= ACPI_EC_COMMAND_COMPLETE;
200 201
					if (t->command == ACPI_EC_COMMAND_QUERY)
						pr_debug("hardware QR_EC completion\n");
202 203
					wakeup = true;
				}
204 205 206
			} else
				goto err;
		} else if (t->wlen == t->wi &&
207
			   (status & ACPI_EC_FLAG_IBF) == 0) {
208
			t->flags |= ACPI_EC_COMMAND_COMPLETE;
209 210 211
			wakeup = true;
		}
		return wakeup;
212
	} else {
213 214 215 216 217 218 219 220 221 222 223 224 225 226
		/*
		 * There is firmware refusing to respond QR_EC when SCI_EVT
		 * is not set, for which case, we complete the QR_EC
		 * without issuing it to the firmware.
		 * https://bugzilla.kernel.org/show_bug.cgi?id=86211
		 */
		if (!(status & ACPI_EC_FLAG_SCI) &&
		    (t->command == ACPI_EC_COMMAND_QUERY)) {
			t->flags |= ACPI_EC_COMMAND_POLL;
			t->rdata[t->ri++] = 0x00;
			t->flags |= ACPI_EC_COMMAND_COMPLETE;
			pr_debug("software QR_EC completion\n");
			wakeup = true;
		} else if ((status & ACPI_EC_FLAG_IBF) == 0) {
227 228
			acpi_ec_write_cmd(ec, t->command);
			t->flags |= ACPI_EC_COMMAND_POLL;
229
		} else
230
			goto err;
231
		return wakeup;
232
	}
233
err:
234 235 236 237
	/*
	 * If SCI bit is set, then don't think it's a false IRQ
	 * otherwise will take a not handled IRQ as a false one.
	 */
238 239 240 241
	if (!(status & ACPI_EC_FLAG_SCI)) {
		if (in_interrupt() && t)
			++t->irq_count;
	}
242
	return wakeup;
243
}
244

245 246 247 248
static void start_transaction(struct acpi_ec *ec)
{
	ec->curr->irq_count = ec->curr->wi = ec->curr->ri = 0;
	ec->curr->flags = 0;
249
	(void)advance_transaction(ec);
A
Alexey Starikovskiy 已提交
250
}
251

252
static int acpi_ec_sync_query(struct acpi_ec *ec, u8 *data);
253

254
static int ec_check_sci_sync(struct acpi_ec *ec, u8 state)
255
{
256 257
	if (state & ACPI_EC_FLAG_SCI) {
		if (!test_and_set_bit(EC_FLAGS_QUERY_PENDING, &ec->flags))
258
			return acpi_ec_sync_query(ec, NULL);
259 260 261 262 263 264
	}
	return 0;
}

static int ec_poll(struct acpi_ec *ec)
{
265
	unsigned long flags;
266
	int repeat = 5; /* number of command restarts */
267 268
	while (repeat--) {
		unsigned long delay = jiffies +
269
			msecs_to_jiffies(ec_delay);
270 271 272 273
		do {
			/* don't sleep with disabled interrupts */
			if (EC_FLAGS_MSI || irqs_disabled()) {
				udelay(ACPI_EC_MSI_UDELAY);
274
				if (ec_transaction_completed(ec))
275 276 277
					return 0;
			} else {
				if (wait_event_timeout(ec->wait,
278
						ec_transaction_completed(ec),
279 280 281
						msecs_to_jiffies(1)))
					return 0;
			}
282
			spin_lock_irqsave(&ec->lock, flags);
283
			(void)advance_transaction(ec);
284
			spin_unlock_irqrestore(&ec->lock, flags);
285
		} while (time_before(jiffies, delay));
286
		pr_debug("controller reset, restart transaction\n");
287
		spin_lock_irqsave(&ec->lock, flags);
288
		start_transaction(ec);
289
		spin_unlock_irqrestore(&ec->lock, flags);
290
	}
291
	return -ETIME;
L
Linus Torvalds 已提交
292 293
}

294
static int acpi_ec_transaction_unlocked(struct acpi_ec *ec,
295
					struct transaction *t)
L
Luming Yu 已提交
296
{
297 298
	unsigned long tmp;
	int ret = 0;
299
	if (EC_FLAGS_MSI)
300
		udelay(ACPI_EC_MSI_UDELAY);
301
	/* start transaction */
302
	spin_lock_irqsave(&ec->lock, tmp);
303
	/* following two actions should be kept atomic */
304
	ec->curr = t;
305
	start_transaction(ec);
306
	spin_unlock_irqrestore(&ec->lock, tmp);
307
	ret = ec_poll(ec);
308
	spin_lock_irqsave(&ec->lock, tmp);
309 310
	if (ec->curr->command == ACPI_EC_COMMAND_QUERY)
		clear_bit(EC_FLAGS_QUERY_PENDING, &ec->flags);
311
	ec->curr = NULL;
312
	spin_unlock_irqrestore(&ec->lock, tmp);
313 314 315
	return ret;
}

316
static int acpi_ec_transaction(struct acpi_ec *ec, struct transaction *t)
L
Linus Torvalds 已提交
317
{
318
	int status;
L
Len Brown 已提交
319
	u32 glk;
320
	if (!ec || (!t) || (t->wlen && !t->wdata) || (t->rlen && !t->rdata))
321
		return -EINVAL;
322 323
	if (t->rdata)
		memset(t->rdata, 0, t->rlen);
324
	mutex_lock(&ec->mutex);
325
	if (test_bit(EC_FLAGS_BLOCKED, &ec->flags)) {
326 327 328
		status = -EINVAL;
		goto unlock;
	}
329
	if (ec->global_lock) {
L
Linus Torvalds 已提交
330
		status = acpi_acquire_global_lock(ACPI_EC_UDELAY_GLK, &glk);
331
		if (ACPI_FAILURE(status)) {
332 333
			status = -ENODEV;
			goto unlock;
334
		}
L
Linus Torvalds 已提交
335
	}
336
	pr_debug("transaction start (cmd=0x%02x, addr=0x%02x)\n",
337
			t->command, t->wdata ? t->wdata[0] : 0);
338 339
	/* disable GPE during transaction if storm is detected */
	if (test_bit(EC_FLAGS_GPE_STORM, &ec->flags)) {
340 341
		/* It has to be disabled, so that it doesn't trigger. */
		acpi_disable_gpe(NULL, ec->gpe);
342 343
	}

344
	status = acpi_ec_transaction_unlocked(ec, t);
345 346 347 348

	/* check if we received SCI during transaction */
	ec_check_sci_sync(ec, acpi_ec_read_status(ec));
	if (test_bit(EC_FLAGS_GPE_STORM, &ec->flags)) {
349
		msleep(1);
350 351
		/* It is safe to enable the GPE outside of the transaction. */
		acpi_enable_gpe(NULL, ec->gpe);
352
	} else if (t->irq_count > ec_storm_threshold) {
353
		pr_info("GPE storm detected(%d GPEs), "
354 355
			"transactions will use polling mode\n",
			t->irq_count);
356 357
		set_bit(EC_FLAGS_GPE_STORM, &ec->flags);
	}
358
	pr_debug("transaction end\n");
359
	if (ec->global_lock)
L
Linus Torvalds 已提交
360
		acpi_release_global_lock(glk);
361
unlock:
362
	mutex_unlock(&ec->mutex);
363
	return status;
L
Linus Torvalds 已提交
364 365
}

366
static int acpi_ec_burst_enable(struct acpi_ec *ec)
367 368
{
	u8 d;
369 370 371 372
	struct transaction t = {.command = ACPI_EC_BURST_ENABLE,
				.wdata = NULL, .rdata = &d,
				.wlen = 0, .rlen = 1};

373
	return acpi_ec_transaction(ec, &t);
374 375
}

376
static int acpi_ec_burst_disable(struct acpi_ec *ec)
377
{
378 379 380 381
	struct transaction t = {.command = ACPI_EC_BURST_DISABLE,
				.wdata = NULL, .rdata = NULL,
				.wlen = 0, .rlen = 0};

382
	return (acpi_ec_read_status(ec) & ACPI_EC_FLAG_BURST) ?
383
				acpi_ec_transaction(ec, &t) : 0;
384 385
}

A
Alexey Starikovskiy 已提交
386
static int acpi_ec_read(struct acpi_ec *ec, u8 address, u8 * data)
387 388 389
{
	int result;
	u8 d;
390 391 392
	struct transaction t = {.command = ACPI_EC_COMMAND_READ,
				.wdata = &address, .rdata = &d,
				.wlen = 1, .rlen = 1};
393

394
	result = acpi_ec_transaction(ec, &t);
395 396 397
	*data = d;
	return result;
}
398

399 400
static int acpi_ec_write(struct acpi_ec *ec, u8 address, u8 data)
{
A
Alexey Starikovskiy 已提交
401
	u8 wdata[2] = { address, data };
402 403 404 405
	struct transaction t = {.command = ACPI_EC_COMMAND_WRITE,
				.wdata = wdata, .rdata = NULL,
				.wlen = 2, .rlen = 0};

406
	return acpi_ec_transaction(ec, &t);
407 408
}

409
int ec_read(u8 addr, u8 *val)
L
Linus Torvalds 已提交
410 411
{
	int err;
412
	u8 temp_data;
L
Linus Torvalds 已提交
413 414 415 416

	if (!first_ec)
		return -ENODEV;

417
	err = acpi_ec_read(first_ec, addr, &temp_data);
L
Linus Torvalds 已提交
418 419 420 421

	if (!err) {
		*val = temp_data;
		return 0;
L
Len Brown 已提交
422
	} else
L
Linus Torvalds 已提交
423 424
		return err;
}
L
Len Brown 已提交
425

L
Linus Torvalds 已提交
426 427
EXPORT_SYMBOL(ec_read);

L
Len Brown 已提交
428
int ec_write(u8 addr, u8 val)
L
Linus Torvalds 已提交
429 430 431 432 433 434
{
	int err;

	if (!first_ec)
		return -ENODEV;

435
	err = acpi_ec_write(first_ec, addr, val);
L
Linus Torvalds 已提交
436 437 438

	return err;
}
L
Len Brown 已提交
439

L
Linus Torvalds 已提交
440 441
EXPORT_SYMBOL(ec_write);

442
int ec_transaction(u8 command,
443
		   const u8 * wdata, unsigned wdata_len,
T
Thomas Renninger 已提交
444
		   u8 * rdata, unsigned rdata_len)
L
Luming Yu 已提交
445
{
446 447 448
	struct transaction t = {.command = command,
				.wdata = wdata, .rdata = rdata,
				.wlen = wdata_len, .rlen = rdata_len};
449 450
	if (!first_ec)
		return -ENODEV;
L
Luming Yu 已提交
451

452
	return acpi_ec_transaction(first_ec, &t);
L
Luming Yu 已提交
453
}
L
Linus Torvalds 已提交
454

455 456
EXPORT_SYMBOL(ec_transaction);

S
Seth Forshee 已提交
457 458 459 460 461 462 463 464 465 466
/* Get the handle to the EC device */
acpi_handle ec_get_handle(void)
{
	if (!first_ec)
		return NULL;
	return first_ec->handle;
}

EXPORT_SYMBOL(ec_get_handle);

467
/*
468
 * Process _Q events that might have accumulated in the EC.
469 470 471 472 473 474 475 476
 * Run with locked ec mutex.
 */
static void acpi_ec_clear(struct acpi_ec *ec)
{
	int i, status;
	u8 value = 0;

	for (i = 0; i < ACPI_EC_CLEAR_MAX; i++) {
477
		status = acpi_ec_sync_query(ec, &value);
478 479 480 481 482 483 484 485 486 487
		if (status || !value)
			break;
	}

	if (unlikely(i == ACPI_EC_CLEAR_MAX))
		pr_warn("Warning: Maximum of %d stale EC events cleared\n", i);
	else
		pr_info("%d stale EC events cleared\n", i);
}

488
void acpi_ec_block_transactions(void)
489 490 491 492 493 494
{
	struct acpi_ec *ec = first_ec;

	if (!ec)
		return;

495
	mutex_lock(&ec->mutex);
496
	/* Prevent transactions from being carried out */
497
	set_bit(EC_FLAGS_BLOCKED, &ec->flags);
498
	mutex_unlock(&ec->mutex);
499 500
}

501
void acpi_ec_unblock_transactions(void)
502 503 504 505 506 507
{
	struct acpi_ec *ec = first_ec;

	if (!ec)
		return;

508
	mutex_lock(&ec->mutex);
509
	/* Allow transactions to be carried out again */
510
	clear_bit(EC_FLAGS_BLOCKED, &ec->flags);
511 512 513 514

	if (EC_FLAGS_CLEAR_ON_RESUME)
		acpi_ec_clear(ec);

515
	mutex_unlock(&ec->mutex);
516 517
}

518
void acpi_ec_unblock_transactions_early(void)
519 520 521 522 523 524
{
	/*
	 * Allow transactions to happen again (this function is called from
	 * atomic context during wakeup, so we don't need to acquire the mutex).
	 */
	if (first_ec)
525
		clear_bit(EC_FLAGS_BLOCKED, &first_ec->flags);
526 527
}

528
static int acpi_ec_query_unlocked(struct acpi_ec *ec, u8 * data)
529 530
{
	int result;
A
Alexey Starikovskiy 已提交
531
	u8 d;
532 533 534
	struct transaction t = {.command = ACPI_EC_COMMAND_QUERY,
				.wdata = NULL, .rdata = &d,
				.wlen = 0, .rlen = 1};
A
Alexey Starikovskiy 已提交
535 536 537 538 539 540 541
	if (!ec || !data)
		return -EINVAL;
	/*
	 * Query the EC to find out which _Qxx method we need to evaluate.
	 * Note that successful completion of the query causes the ACPI_EC_SCI
	 * bit to be cleared (and thus clearing the interrupt source).
	 */
542
	result = acpi_ec_transaction_unlocked(ec, &t);
A
Alexey Starikovskiy 已提交
543 544 545 546 547 548
	if (result)
		return result;
	if (!d)
		return -ENODATA;
	*data = d;
	return 0;
L
Linus Torvalds 已提交
549 550 551 552 553
}

/* --------------------------------------------------------------------------
                                Event Management
   -------------------------------------------------------------------------- */
554 555 556 557 558 559 560 561 562 563 564 565 566
int acpi_ec_add_query_handler(struct acpi_ec *ec, u8 query_bit,
			      acpi_handle handle, acpi_ec_query_func func,
			      void *data)
{
	struct acpi_ec_query_handler *handler =
	    kzalloc(sizeof(struct acpi_ec_query_handler), GFP_KERNEL);
	if (!handler)
		return -ENOMEM;

	handler->query_bit = query_bit;
	handler->handle = handle;
	handler->func = func;
	handler->data = data;
567
	mutex_lock(&ec->mutex);
568
	list_add(&handler->node, &ec->list);
569
	mutex_unlock(&ec->mutex);
570 571 572 573 574 575 576
	return 0;
}

EXPORT_SYMBOL_GPL(acpi_ec_add_query_handler);

void acpi_ec_remove_query_handler(struct acpi_ec *ec, u8 query_bit)
{
A
Adrian Bunk 已提交
577
	struct acpi_ec_query_handler *handler, *tmp;
578
	mutex_lock(&ec->mutex);
A
Adrian Bunk 已提交
579
	list_for_each_entry_safe(handler, tmp, &ec->list, node) {
580 581 582 583 584
		if (query_bit == handler->query_bit) {
			list_del(&handler->node);
			kfree(handler);
		}
	}
585
	mutex_unlock(&ec->mutex);
586 587 588
}

EXPORT_SYMBOL_GPL(acpi_ec_remove_query_handler);
L
Linus Torvalds 已提交
589

590
static void acpi_ec_run(void *cxt)
L
Luming Yu 已提交
591
{
592 593
	struct acpi_ec_query_handler *handler = cxt;
	if (!handler)
594
		return;
595
	pr_debug("start query execution\n");
596 597 598 599
	if (handler->func)
		handler->func(handler->data);
	else if (handler->handle)
		acpi_evaluate_object(handler->handle, NULL, NULL, NULL);
600
	pr_debug("stop query execution\n");
601 602 603
	kfree(handler);
}

604
static int acpi_ec_sync_query(struct acpi_ec *ec, u8 *data)
605 606 607 608
{
	u8 value = 0;
	int status;
	struct acpi_ec_query_handler *handler, *copy;
609 610 611 612 613

	status = acpi_ec_query_unlocked(ec, &value);
	if (data)
		*data = value;
	if (status)
614
		return status;
615

616 617 618
	list_for_each_entry(handler, &ec->list, node) {
		if (value == handler->query_bit) {
			/* have custom handler for this bit */
619 620 621 622
			copy = kmalloc(sizeof(*handler), GFP_KERNEL);
			if (!copy)
				return -ENOMEM;
			memcpy(copy, handler, sizeof(*copy));
623 624
			pr_debug("push query execution (0x%2x) on queue\n",
				value);
625 626
			return acpi_os_execute((copy->func) ?
				OSL_NOTIFY_HANDLER : OSL_GPE_HANDLER,
627
				acpi_ec_run, copy);
628 629
		}
	}
630 631 632 633 634 635 636 637
	return 0;
}

static void acpi_ec_gpe_query(void *ec_cxt)
{
	struct acpi_ec *ec = ec_cxt;
	if (!ec)
		return;
638
	mutex_lock(&ec->mutex);
639
	acpi_ec_sync_query(ec, NULL);
640
	mutex_unlock(&ec->mutex);
L
Luming Yu 已提交
641
}
L
Linus Torvalds 已提交
642

643 644 645 646
static int ec_check_sci(struct acpi_ec *ec, u8 state)
{
	if (state & ACPI_EC_FLAG_SCI) {
		if (!test_and_set_bit(EC_FLAGS_QUERY_PENDING, &ec->flags)) {
647
			pr_debug("push gpe query to the queue\n");
648 649 650 651 652 653 654
			return acpi_os_execute(OSL_NOTIFY_HANDLER,
				acpi_ec_gpe_query, ec);
		}
	}
	return 0;
}

655 656
static u32 acpi_ec_gpe_handler(acpi_handle gpe_device,
	u32 gpe_number, void *data)
L
Linus Torvalds 已提交
657
{
658
	unsigned long flags;
659
	struct acpi_ec *ec = data;
660

661
	spin_lock_irqsave(&ec->lock, flags);
662
	if (advance_transaction(ec))
663
		wake_up(&ec->wait);
664 665
	spin_unlock_irqrestore(&ec->lock, flags);
	ec_check_sci(ec, acpi_ec_read_status(ec));
L
Lin Ming 已提交
666
	return ACPI_INTERRUPT_HANDLED | ACPI_REENABLE_GPE;
A
Alexey Starikovskiy 已提交
667 668
}

L
Linus Torvalds 已提交
669 670 671 672 673
/* --------------------------------------------------------------------------
                             Address Space Management
   -------------------------------------------------------------------------- */

static acpi_status
674
acpi_ec_space_handler(u32 function, acpi_physical_address address,
675
		      u32 bits, u64 *value64,
L
Len Brown 已提交
676
		      void *handler_context, void *region_context)
L
Linus Torvalds 已提交
677
{
678
	struct acpi_ec *ec = handler_context;
679 680
	int result = 0, i, bytes = bits / 8;
	u8 *value = (u8 *)value64;
L
Linus Torvalds 已提交
681 682

	if ((address > 0xFF) || !value || !handler_context)
683
		return AE_BAD_PARAMETER;
L
Linus Torvalds 已提交
684

685
	if (function != ACPI_READ && function != ACPI_WRITE)
686
		return AE_BAD_PARAMETER;
L
Linus Torvalds 已提交
687

688
	if (EC_FLAGS_MSI || bits > 8)
689
		acpi_ec_burst_enable(ec);
690

691 692 693 694
	for (i = 0; i < bytes; ++i, ++address, ++value)
		result = (function == ACPI_READ) ?
			acpi_ec_read(ec, address, value) :
			acpi_ec_write(ec, address, *value);
L
Linus Torvalds 已提交
695

696
	if (EC_FLAGS_MSI || bits > 8)
697
		acpi_ec_burst_disable(ec);
698

L
Linus Torvalds 已提交
699 700
	switch (result) {
	case -EINVAL:
701
		return AE_BAD_PARAMETER;
L
Linus Torvalds 已提交
702 703
		break;
	case -ENODEV:
704
		return AE_NOT_FOUND;
L
Linus Torvalds 已提交
705 706
		break;
	case -ETIME:
707
		return AE_TIME;
L
Linus Torvalds 已提交
708 709
		break;
	default:
710
		return AE_OK;
L
Linus Torvalds 已提交
711 712 713 714 715 716
	}
}

/* --------------------------------------------------------------------------
                               Driver Interface
   -------------------------------------------------------------------------- */
717 718 719 720 721 722 723 724
static acpi_status
ec_parse_io_ports(struct acpi_resource *resource, void *context);

static struct acpi_ec *make_acpi_ec(void)
{
	struct acpi_ec *ec = kzalloc(sizeof(struct acpi_ec), GFP_KERNEL);
	if (!ec)
		return NULL;
725
	ec->flags = 1 << EC_FLAGS_QUERY_PENDING;
726
	mutex_init(&ec->mutex);
727
	init_waitqueue_head(&ec->wait);
728
	INIT_LIST_HEAD(&ec->list);
729
	spin_lock_init(&ec->lock);
730 731
	return ec;
}
732

733 734 735 736
static acpi_status
acpi_ec_register_query_methods(acpi_handle handle, u32 level,
			       void *context, void **return_value)
{
737 738
	char node_name[5];
	struct acpi_buffer buffer = { sizeof(node_name), node_name };
739 740
	struct acpi_ec *ec = context;
	int value = 0;
741 742 743 744 745
	acpi_status status;

	status = acpi_get_name(handle, ACPI_SINGLE_NAME, &buffer);

	if (ACPI_SUCCESS(status) && sscanf(node_name, "_Q%x", &value) == 1) {
746 747 748 749 750
		acpi_ec_add_query_handler(ec, value, handle, NULL, NULL);
	}
	return AE_OK;
}

751 752
static acpi_status
ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval)
753
{
754
	acpi_status status;
755
	unsigned long long tmp = 0;
756 757

	struct acpi_ec *ec = context;
758 759 760 761

	/* clear addr values, ec_parse_io_ports depend on it */
	ec->command_addr = ec->data_addr = 0;

762 763 764 765
	status = acpi_walk_resources(handle, METHOD_NAME__CRS,
				     ec_parse_io_ports, ec);
	if (ACPI_FAILURE(status))
		return status;
766 767 768

	/* Get GPE bit assignment (EC events). */
	/* TODO: Add support for _GPE returning a package */
769
	status = acpi_evaluate_integer(handle, "_GPE", NULL, &tmp);
770 771
	if (ACPI_FAILURE(status))
		return status;
772
	ec->gpe = tmp;
773
	/* Use the global lock for all EC transactions? */
774
	tmp = 0;
775 776
	acpi_evaluate_integer(handle, "_GLK", NULL, &tmp);
	ec->global_lock = tmp;
777
	ec->handle = handle;
778
	return AE_CTRL_TERMINATE;
779 780
}

781 782 783 784 785 786 787 788 789 790
static int ec_install_handlers(struct acpi_ec *ec)
{
	acpi_status status;
	if (test_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags))
		return 0;
	status = acpi_install_gpe_handler(NULL, ec->gpe,
				  ACPI_GPE_EDGE_TRIGGERED,
				  &acpi_ec_gpe_handler, ec);
	if (ACPI_FAILURE(status))
		return -ENODEV;
791

792
	acpi_enable_gpe(NULL, ec->gpe);
793 794 795 796 797 798 799 800 801 802 803
	status = acpi_install_address_space_handler(ec->handle,
						    ACPI_ADR_SPACE_EC,
						    &acpi_ec_space_handler,
						    NULL, ec);
	if (ACPI_FAILURE(status)) {
		if (status == AE_NOT_FOUND) {
			/*
			 * Maybe OS fails in evaluating the _REG object.
			 * The AE_NOT_FOUND error will be ignored and OS
			 * continue to initialize EC.
			 */
804
			pr_err("Fail in evaluating the _REG object"
805 806
				" of EC device. Broken bios is suspected.\n");
		} else {
807
			acpi_disable_gpe(NULL, ec->gpe);
808 809 810 811 812 813 814 815 816 817
			acpi_remove_gpe_handler(NULL, ec->gpe,
				&acpi_ec_gpe_handler);
			return -ENODEV;
		}
	}

	set_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags);
	return 0;
}

818 819
static void ec_remove_handlers(struct acpi_ec *ec)
{
820
	acpi_disable_gpe(NULL, ec->gpe);
821 822
	if (ACPI_FAILURE(acpi_remove_address_space_handler(ec->handle,
				ACPI_ADR_SPACE_EC, &acpi_ec_space_handler)))
823
		pr_err("failed to remove space handler\n");
824 825
	if (ACPI_FAILURE(acpi_remove_gpe_handler(NULL, ec->gpe,
				&acpi_ec_gpe_handler)))
826
		pr_err("failed to remove gpe handler\n");
827
	clear_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags);
828 829
}

830
static int acpi_ec_add(struct acpi_device *device)
L
Linus Torvalds 已提交
831
{
832
	struct acpi_ec *ec = NULL;
B
Bjorn Helgaas 已提交
833
	int ret;
L
Luming Yu 已提交
834

835 836 837
	strcpy(acpi_device_name(device), ACPI_EC_DEVICE_NAME);
	strcpy(acpi_device_class(device), ACPI_EC_CLASS);

838
	/* Check for boot EC */
839 840 841 842 843 844 845 846 847
	if (boot_ec &&
	    (boot_ec->handle == device->handle ||
	     boot_ec->handle == ACPI_ROOT_OBJECT)) {
		ec = boot_ec;
		boot_ec = NULL;
	} else {
		ec = make_acpi_ec();
		if (!ec)
			return -ENOMEM;
848 849 850
	}
	if (ec_parse_device(device->handle, 0, ec, NULL) !=
		AE_CTRL_TERMINATE) {
851 852
			kfree(ec);
			return -EINVAL;
853 854
	}

855 856
	/* Find and register all query methods */
	acpi_walk_namespace(ACPI_TYPE_METHOD, ec->handle, 1,
857
			    acpi_ec_register_query_methods, NULL, ec, NULL);
858

859 860
	if (!first_ec)
		first_ec = ec;
861
	device->driver_data = ec;
862

863 864 865 866
	ret = !!request_region(ec->data_addr, 1, "EC data");
	WARN(!ret, "Could not request EC data io port 0x%lx", ec->data_addr);
	ret = !!request_region(ec->command_addr, 1, "EC cmd");
	WARN(!ret, "Could not request EC cmd io port 0x%lx", ec->command_addr);
867

868
	pr_info("GPE = 0x%lx, I/O: command/status = 0x%lx, data = 0x%lx\n",
869
			  ec->gpe, ec->command_addr, ec->data_addr);
870 871 872 873 874

	ret = ec_install_handlers(ec);

	/* EC is fully operational, allow queries */
	clear_bit(EC_FLAGS_QUERY_PENDING, &ec->flags);
875 876 877 878 879 880 881

	/* Clear stale _Q events if hardware might require that */
	if (EC_FLAGS_CLEAR_ON_RESUME) {
		mutex_lock(&ec->mutex);
		acpi_ec_clear(ec);
		mutex_unlock(&ec->mutex);
	}
882
	return ret;
L
Linus Torvalds 已提交
883 884
}

885
static int acpi_ec_remove(struct acpi_device *device)
L
Linus Torvalds 已提交
886
{
887
	struct acpi_ec *ec;
888
	struct acpi_ec_query_handler *handler, *tmp;
L
Linus Torvalds 已提交
889 890

	if (!device)
891
		return -EINVAL;
L
Linus Torvalds 已提交
892 893

	ec = acpi_driver_data(device);
B
Bjorn Helgaas 已提交
894
	ec_remove_handlers(ec);
895
	mutex_lock(&ec->mutex);
896
	list_for_each_entry_safe(handler, tmp, &ec->list, node) {
897 898 899
		list_del(&handler->node);
		kfree(handler);
	}
900
	mutex_unlock(&ec->mutex);
901 902
	release_region(ec->data_addr, 1);
	release_region(ec->command_addr, 1);
903
	device->driver_data = NULL;
904
	if (ec == first_ec)
905
		first_ec = NULL;
906
	kfree(ec);
907
	return 0;
L
Linus Torvalds 已提交
908 909 910
}

static acpi_status
911
ec_parse_io_ports(struct acpi_resource *resource, void *context)
L
Linus Torvalds 已提交
912
{
913
	struct acpi_ec *ec = context;
L
Linus Torvalds 已提交
914

915
	if (resource->type != ACPI_RESOURCE_TYPE_IO)
L
Linus Torvalds 已提交
916 917 918 919 920 921 922
		return AE_OK;

	/*
	 * The first address region returned is the data port, and
	 * the second address region returned is the status/command
	 * port.
	 */
923
	if (ec->data_addr == 0)
924
		ec->data_addr = resource->data.io.minimum;
925
	else if (ec->command_addr == 0)
926
		ec->command_addr = resource->data.io.minimum;
927
	else
L
Linus Torvalds 已提交
928 929 930 931 932
		return AE_CTRL_TERMINATE;

	return AE_OK;
}

933 934
int __init acpi_boot_ec_enable(void)
{
935
	if (!boot_ec || test_bit(EC_FLAGS_HANDLERS_INSTALLED, &boot_ec->flags))
936 937 938 939 940 941 942 943
		return 0;
	if (!ec_install_handlers(boot_ec)) {
		first_ec = boot_ec;
		return 0;
	}
	return -EFAULT;
}

944 945 946 947 948
static const struct acpi_device_id ec_device_ids[] = {
	{"PNP0C09", 0},
	{"", 0},
};

949 950 951 952 953 954 955
/* Some BIOS do not survive early DSDT scan, skip it */
static int ec_skip_dsdt_scan(const struct dmi_system_id *id)
{
	EC_FLAGS_SKIP_DSDT_SCAN = 1;
	return 0;
}

A
Alexey Starikovskiy 已提交
956 957 958 959 960 961 962 963 964 965
/* ASUStek often supplies us with broken ECDT, validate it */
static int ec_validate_ecdt(const struct dmi_system_id *id)
{
	EC_FLAGS_VALIDATE_ECDT = 1;
	return 0;
}

/* MSI EC needs special treatment, enable it */
static int ec_flag_msi(const struct dmi_system_id *id)
{
966
	pr_debug("Detected MSI hardware, enabling workarounds.\n");
A
Alexey Starikovskiy 已提交
967 968 969 970 971
	EC_FLAGS_MSI = 1;
	EC_FLAGS_VALIDATE_ECDT = 1;
	return 0;
}

972 973 974 975 976 977 978 979 980 981 982
/*
 * Clevo M720 notebook actually works ok with IRQ mode, if we lifted
 * the GPE storm threshold back to 20
 */
static int ec_enlarge_storm_threshold(const struct dmi_system_id *id)
{
	pr_debug("Setting the EC GPE storm threshold to 20\n");
	ec_storm_threshold  = 20;
	return 0;
}

983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006
/*
 * On some hardware it is necessary to clear events accumulated by the EC during
 * sleep. These ECs stop reporting GPEs until they are manually polled, if too
 * many events are accumulated. (e.g. Samsung Series 5/9 notebooks)
 *
 * https://bugzilla.kernel.org/show_bug.cgi?id=44161
 *
 * Ideally, the EC should also be instructed NOT to accumulate events during
 * sleep (which Windows seems to do somehow), but the interface to control this
 * behaviour is not known at this time.
 *
 * Models known to be affected are Samsung 530Uxx/535Uxx/540Uxx/550Pxx/900Xxx,
 * however it is very likely that other Samsung models are affected.
 *
 * On systems which don't accumulate _Q events during sleep, this extra check
 * should be harmless.
 */
static int ec_clear_on_resume(const struct dmi_system_id *id)
{
	pr_debug("Detected system needing EC poll on resume.\n");
	EC_FLAGS_CLEAR_ON_RESUME = 1;
	return 0;
}

1007
static struct dmi_system_id ec_dmi_table[] __initdata = {
1008 1009 1010 1011
	{
	ec_skip_dsdt_scan, "Compal JFL92", {
	DMI_MATCH(DMI_BIOS_VENDOR, "COMPAL"),
	DMI_MATCH(DMI_BOARD_NAME, "JFL92") }, NULL},
A
Alexey Starikovskiy 已提交
1012 1013
	{
	ec_flag_msi, "MSI hardware", {
1014 1015 1016 1017 1018 1019 1020
	DMI_MATCH(DMI_BIOS_VENDOR, "Micro-Star")}, NULL},
	{
	ec_flag_msi, "MSI hardware", {
	DMI_MATCH(DMI_SYS_VENDOR, "Micro-Star")}, NULL},
	{
	ec_flag_msi, "MSI hardware", {
	DMI_MATCH(DMI_CHASSIS_VENDOR, "MICRO-Star")}, NULL},
A
Alexey Starikovskiy 已提交
1021
	{
1022 1023 1024
	ec_flag_msi, "MSI hardware", {
	DMI_MATCH(DMI_CHASSIS_VENDOR, "MICRO-STAR")}, NULL},
	{
1025 1026 1027 1028 1029 1030 1031 1032
	ec_flag_msi, "Quanta hardware", {
	DMI_MATCH(DMI_SYS_VENDOR, "Quanta"),
	DMI_MATCH(DMI_PRODUCT_NAME, "TW8/SW8/DW8"),}, NULL},
	{
	ec_flag_msi, "Quanta hardware", {
	DMI_MATCH(DMI_SYS_VENDOR, "Quanta"),
	DMI_MATCH(DMI_PRODUCT_NAME, "TW9/SW9"),}, NULL},
	{
A
Alexey Starikovskiy 已提交
1033 1034
	ec_validate_ecdt, "ASUS hardware", {
	DMI_MATCH(DMI_BIOS_VENDOR, "ASUS") }, NULL},
1035 1036 1037
	{
	ec_validate_ecdt, "ASUS hardware", {
	DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer Inc.") }, NULL},
1038 1039 1040 1041
	{
	ec_enlarge_storm_threshold, "CLEVO hardware", {
	DMI_MATCH(DMI_SYS_VENDOR, "CLEVO Co."),
	DMI_MATCH(DMI_PRODUCT_NAME, "M720T/M730T"),}, NULL},
1042 1043 1044 1045
	{
	ec_skip_dsdt_scan, "HP Folio 13", {
	DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
	DMI_MATCH(DMI_PRODUCT_NAME, "HP Folio 13"),}, NULL},
1046 1047 1048 1049
	{
	ec_validate_ecdt, "ASUS hardware", {
	DMI_MATCH(DMI_SYS_VENDOR, "ASUSTek Computer Inc."),
	DMI_MATCH(DMI_PRODUCT_NAME, "L4R"),}, NULL},
1050 1051 1052
	{
	ec_clear_on_resume, "Samsung hardware", {
	DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD.")}, NULL},
A
Alexey Starikovskiy 已提交
1053 1054 1055
	{},
};

1056 1057 1058
int __init acpi_ec_ecdt_probe(void)
{
	acpi_status status;
1059
	struct acpi_ec *saved_ec = NULL;
L
Len Brown 已提交
1060
	struct acpi_table_ecdt *ecdt_ptr;
L
Luming Yu 已提交
1061

1062 1063
	boot_ec = make_acpi_ec();
	if (!boot_ec)
1064 1065 1066 1067
		return -ENOMEM;
	/*
	 * Generate a boot ec context
	 */
A
Alexey Starikovskiy 已提交
1068
	dmi_check_system(ec_dmi_table);
1069 1070
	status = acpi_get_table(ACPI_SIG_ECDT, 1,
				(struct acpi_table_header **)&ecdt_ptr);
1071
	if (ACPI_SUCCESS(status)) {
1072
		pr_info("EC description table is found, configuring boot EC\n");
1073 1074 1075
		boot_ec->command_addr = ecdt_ptr->control.address;
		boot_ec->data_addr = ecdt_ptr->data.address;
		boot_ec->gpe = ecdt_ptr->gpe;
1076
		boot_ec->handle = ACPI_ROOT_OBJECT;
1077
		acpi_get_handle(ACPI_ROOT_OBJECT, ecdt_ptr->id, &boot_ec->handle);
1078
		/* Don't trust ECDT, which comes from ASUSTek */
A
Alexey Starikovskiy 已提交
1079
		if (!EC_FLAGS_VALIDATE_ECDT)
1080
			goto install;
J
Julia Lawall 已提交
1081
		saved_ec = kmemdup(boot_ec, sizeof(struct acpi_ec), GFP_KERNEL);
1082 1083
		if (!saved_ec)
			return -ENOMEM;
1084
	/* fall through */
1085
	}
A
Alexey Starikovskiy 已提交
1086

1087 1088
	if (EC_FLAGS_SKIP_DSDT_SCAN) {
		kfree(saved_ec);
1089
		return -ENODEV;
1090
	}
1091

1092 1093
	/* This workaround is needed only on some broken machines,
	 * which require early EC, but fail to provide ECDT */
1094
	pr_debug("Look up EC in DSDT\n");
1095 1096 1097 1098 1099
	status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
					boot_ec, NULL);
	/* Check that acpi_get_devices actually find something */
	if (ACPI_FAILURE(status) || !boot_ec->handle)
		goto error;
1100 1101 1102 1103 1104 1105
	if (saved_ec) {
		/* try to find good ECDT from ASUSTek */
		if (saved_ec->command_addr != boot_ec->command_addr ||
		    saved_ec->data_addr != boot_ec->data_addr ||
		    saved_ec->gpe != boot_ec->gpe ||
		    saved_ec->handle != boot_ec->handle)
1106
			pr_info("ASUSTek keeps feeding us with broken "
1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117
			"ECDT tables, which are very hard to workaround. "
			"Trying to use DSDT EC info instead. Please send "
			"output of acpidump to linux-acpi@vger.kernel.org\n");
		kfree(saved_ec);
		saved_ec = NULL;
	} else {
		/* We really need to limit this workaround, the only ASUS,
		* which needs it, has fake EC._INI method, so use it as flag.
		* Keep boot_ec struct as it will be needed soon.
		*/
		if (!dmi_name_in_vendors("ASUS") ||
1118
		    !acpi_has_method(boot_ec->handle, "_INI"))
1119 1120
			return -ENODEV;
	}
1121 1122
install:
	if (!ec_install_handlers(boot_ec)) {
1123
		first_ec = boot_ec;
1124
		return 0;
1125
	}
1126
error:
1127
	kfree(boot_ec);
1128
	kfree(saved_ec);
1129
	boot_ec = NULL;
L
Linus Torvalds 已提交
1130 1131 1132
	return -ENODEV;
}

1133 1134 1135 1136 1137 1138 1139 1140 1141 1142
static struct acpi_driver acpi_ec_driver = {
	.name = "ec",
	.class = ACPI_EC_CLASS,
	.ids = ec_device_ids,
	.ops = {
		.add = acpi_ec_add,
		.remove = acpi_ec_remove,
		},
};

1143
int __init acpi_ec_init(void)
L
Linus Torvalds 已提交
1144
{
L
Len Brown 已提交
1145
	int result = 0;
L
Linus Torvalds 已提交
1146 1147 1148

	/* Now register the driver for the EC */
	result = acpi_bus_register_driver(&acpi_ec_driver);
1149
	if (result < 0)
1150
		return -ENODEV;
L
Linus Torvalds 已提交
1151

1152
	return result;
L
Linus Torvalds 已提交
1153 1154 1155 1156
}

/* EC driver currently not unloadable */
#if 0
L
Len Brown 已提交
1157
static void __exit acpi_ec_exit(void)
L
Linus Torvalds 已提交
1158 1159 1160
{

	acpi_bus_unregister_driver(&acpi_ec_driver);
1161
	return;
L
Linus Torvalds 已提交
1162
}
1163
#endif	/* 0 */