build-id.c 16.9 KB
Newer Older
1 2 3 4 5 6 7 8
/*
 * build-id.c
 *
 * build-id support
 *
 * Copyright (C) 2009, 2010 Red Hat Inc.
 * Copyright (C) 2009, 2010 Arnaldo Carvalho de Melo <acme@redhat.com>
 */
9 10
#include "util.h"
#include <stdio.h>
11 12 13 14
#include "build-id.h"
#include "event.h"
#include "symbol.h"
#include <linux/kernel.h>
15
#include "debug.h"
16
#include "session.h"
17
#include "tool.h"
18 19
#include "header.h"
#include "vdso.h"
20
#include "probe-file.h"
21

22 23 24

static bool no_buildid_cache;

25 26
int build_id__mark_dso_hit(struct perf_tool *tool __maybe_unused,
			   union perf_event *event,
27
			   struct perf_sample *sample,
28 29
			   struct perf_evsel *evsel __maybe_unused,
			   struct machine *machine)
30 31
{
	struct addr_location al;
32
	struct thread *thread = machine__findnew_thread(machine, sample->pid,
33
							sample->tid);
34 35 36 37 38 39 40

	if (thread == NULL) {
		pr_err("problem processing %d event, skipping it.\n",
			event->header.type);
		return -1;
	}

41
	thread__find_addr_map(thread, sample->cpumode, MAP__FUNCTION, sample->ip, &al);
42 43 44 45

	if (al.map != NULL)
		al.map->dso->hit = 1;

46
	thread__put(thread);
47 48 49
	return 0;
}

50
static int perf_event__exit_del_thread(struct perf_tool *tool __maybe_unused,
51
				       union perf_event *event,
52 53
				       struct perf_sample *sample
				       __maybe_unused,
54
				       struct machine *machine)
55
{
56 57 58
	struct thread *thread = machine__findnew_thread(machine,
							event->fork.pid,
							event->fork.tid);
59

60 61
	dump_printf("(%d:%d):(%d:%d)\n", event->fork.pid, event->fork.tid,
		    event->fork.ppid, event->fork.ptid);
62

63
	if (thread) {
64
		machine__remove_thread(machine, thread);
65 66
		thread__put(thread);
	}
67 68 69 70

	return 0;
}

71
struct perf_tool build_id__mark_dso_hit_ops = {
72
	.sample	= build_id__mark_dso_hit,
73
	.mmap	= perf_event__process_mmap,
74
	.mmap2	= perf_event__process_mmap2,
75
	.fork	= perf_event__process_fork,
76
	.exit	= perf_event__exit_del_thread,
77 78
	.attr		 = perf_event__process_attr,
	.build_id	 = perf_event__process_build_id,
79
	.ordered_events	 = true,
80
};
81

82 83 84 85 86 87 88 89 90 91 92 93
int build_id__sprintf(const u8 *build_id, int len, char *bf)
{
	char *bid = bf;
	const u8 *raw = build_id;
	int i;

	for (i = 0; i < len; ++i) {
		sprintf(bid, "%02x", *raw);
		++raw;
		bid += 2;
	}

94
	return (bid - bf) + 1;
95 96
}

97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128
int sysfs__sprintf_build_id(const char *root_dir, char *sbuild_id)
{
	char notes[PATH_MAX];
	u8 build_id[BUILD_ID_SIZE];
	int ret;

	if (!root_dir)
		root_dir = "";

	scnprintf(notes, sizeof(notes), "%s/sys/kernel/notes", root_dir);

	ret = sysfs__read_build_id(notes, build_id, sizeof(build_id));
	if (ret < 0)
		return ret;

	return build_id__sprintf(build_id, sizeof(build_id), sbuild_id);
}

int filename__sprintf_build_id(const char *pathname, char *sbuild_id)
{
	u8 build_id[BUILD_ID_SIZE];
	int ret;

	ret = filename__read_build_id(pathname, build_id, sizeof(build_id));
	if (ret < 0)
		return ret;
	else if (ret != sizeof(build_id))
		return -EINVAL;

	return build_id__sprintf(build_id, sizeof(build_id), sbuild_id);
}

129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147
/* asnprintf consolidates asprintf and snprintf */
static int asnprintf(char **strp, size_t size, const char *fmt, ...)
{
	va_list ap;
	int ret;

	if (!strp)
		return -EINVAL;

	va_start(ap, fmt);
	if (*strp)
		ret = vsnprintf(*strp, size, fmt, ap);
	else
		ret = vasprintf(strp, fmt, ap);
	va_end(ap);

	return ret;
}

148 149 150 151 152
char *build_id_cache__kallsyms_path(const char *sbuild_id, char *bf,
				    size_t size)
{
	bool retry_old = true;

153 154
	snprintf(bf, size, "%s/%s/%s/kallsyms",
		 buildid_dir, DSO__NAME_KALLSYMS, sbuild_id);
155 156 157 158 159
retry:
	if (!access(bf, F_OK))
		return bf;
	if (retry_old) {
		/* Try old style kallsyms cache */
160 161
		snprintf(bf, size, "%s/%s/%s",
			 buildid_dir, DSO__NAME_KALLSYMS, sbuild_id);
162 163 164 165 166 167 168
		retry_old = false;
		goto retry;
	}

	return NULL;
}

169
char *build_id_cache__linkname(const char *sbuild_id, char *bf, size_t size)
170 171 172 173 174 175 176 177 178
{
	char *tmp = bf;
	int ret = asnprintf(&bf, size, "%s/.build-id/%.2s/%s", buildid_dir,
			    sbuild_id, sbuild_id + 2);
	if (ret < 0 || (tmp && size < (unsigned int)ret))
		return NULL;
	return bf;
}

179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208
char *build_id_cache__origname(const char *sbuild_id)
{
	char *linkname;
	char buf[PATH_MAX];
	char *ret = NULL, *p;
	size_t offs = 5;	/* == strlen("../..") */

	linkname = build_id_cache__linkname(sbuild_id, NULL, 0);
	if (!linkname)
		return NULL;

	if (readlink(linkname, buf, PATH_MAX) < 0)
		goto out;
	/* The link should be "../..<origpath>/<sbuild_id>" */
	p = strrchr(buf, '/');	/* Cut off the "/<sbuild_id>" */
	if (p && (p > buf + offs)) {
		*p = '\0';
		if (buf[offs + 1] == '[')
			offs++;	/*
				 * This is a DSO name, like [kernel.kallsyms].
				 * Skip the first '/', since this is not the
				 * cache of a regular file.
				 */
		ret = strdup(buf + offs);	/* Skip "../..[/]" */
	}
out:
	free(linkname);
	return ret;
}

209 210 211 212 213
static const char *build_id_cache__basename(bool is_kallsyms, bool is_vdso)
{
	return is_kallsyms ? "kallsyms" : (is_vdso ? "vdso" : "elf");
}

214
char *dso__build_id_filename(const struct dso *dso, char *bf, size_t size)
215
{
216 217 218 219 220 221
	bool is_kallsyms = dso__is_kallsyms((struct dso *)dso);
	bool is_vdso = dso__is_vdso((struct dso *)dso);
	char sbuild_id[SBUILD_ID_SIZE];
	char *linkname;
	bool alloc = (bf == NULL);
	int ret;
222

223
	if (!dso->has_build_id)
224 225
		return NULL;

226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241
	build_id__sprintf(dso->build_id, sizeof(dso->build_id), sbuild_id);
	linkname = build_id_cache__linkname(sbuild_id, NULL, 0);
	if (!linkname)
		return NULL;

	/* Check if old style build_id cache */
	if (is_regular_file(linkname))
		ret = asnprintf(&bf, size, "%s", linkname);
	else
		ret = asnprintf(&bf, size, "%s/%s", linkname,
			 build_id_cache__basename(is_kallsyms, is_vdso));
	if (ret < 0 || (!alloc && size < (unsigned int)ret))
		bf = NULL;
	free(linkname);

	return bf;
242
}
243

244 245
bool dso__build_id_is_kmod(const struct dso *dso, char *bf, size_t size)
{
246
	char *id_name = NULL, *ch;
247
	struct stat sb;
248 249 250 251
	char sbuild_id[SBUILD_ID_SIZE];

	if (!dso->has_build_id)
		goto err;
252

253 254
	build_id__sprintf(dso->build_id, sizeof(dso->build_id), sbuild_id);
	id_name = build_id_cache__linkname(sbuild_id, NULL, 0);
255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277
	if (!id_name)
		goto err;
	if (access(id_name, F_OK))
		goto err;
	if (lstat(id_name, &sb) == -1)
		goto err;
	if ((size_t)sb.st_size > size - 1)
		goto err;
	if (readlink(id_name, bf, size - 1) < 0)
		goto err;

	bf[sb.st_size] = '\0';

	/*
	 * link should be:
	 * ../../lib/modules/4.4.0-rc4/kernel/net/ipv4/netfilter/nf_nat_ipv4.ko/a09fe3eb3147dafa4e3b31dbd6257e4d696bdc92
	 */
	ch = strrchr(bf, '/');
	if (!ch)
		goto err;
	if (ch - 3 < bf)
		goto err;

278
	free(id_name);
279 280 281 282 283 284
	return strncmp(".ko", ch - 3, 3) == 0;
err:
	pr_err("Invalid build id: %s\n", id_name ? :
					 dso->long_name ? :
					 dso->short_name ? :
					 "[unknown]");
285
	free(id_name);
286 287 288
	return false;
}

289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317
#define dsos__for_each_with_build_id(pos, head)	\
	list_for_each_entry(pos, head, node)	\
		if (!pos->has_build_id)		\
			continue;		\
		else

static int write_buildid(const char *name, size_t name_len, u8 *build_id,
			 pid_t pid, u16 misc, int fd)
{
	int err;
	struct build_id_event b;
	size_t len;

	len = name_len + 1;
	len = PERF_ALIGN(len, NAME_ALIGN);

	memset(&b, 0, sizeof(b));
	memcpy(&b.build_id, build_id, BUILD_ID_SIZE);
	b.pid = pid;
	b.header.misc = misc;
	b.header.size = sizeof(b) + len;

	err = writen(fd, &b, sizeof(b));
	if (err < 0)
		return err;

	return write_padded(fd, name, name_len + 1, len);
}

318
static int machine__write_buildid_table(struct machine *machine, int fd)
319
{
320
	int err = 0;
321 322
	char nm[PATH_MAX];
	struct dso *pos;
323 324 325 326 327 328 329
	u16 kmisc = PERF_RECORD_MISC_KERNEL,
	    umisc = PERF_RECORD_MISC_USER;

	if (!machine__is_host(machine)) {
		kmisc = PERF_RECORD_MISC_GUEST_KERNEL;
		umisc = PERF_RECORD_MISC_GUEST_USER;
	}
330

331
	dsos__for_each_with_build_id(pos, &machine->dsos.head) {
332 333
		const char *name;
		size_t name_len;
334
		bool in_kernel = false;
335

336
		if (!pos->hit && !dso__is_vdso(pos))
337 338 339 340
			continue;

		if (dso__is_vdso(pos)) {
			name = pos->short_name;
341
			name_len = pos->short_name_len;
342 343 344
		} else if (dso__is_kcore(pos)) {
			machine__mmap_name(machine, nm, sizeof(nm));
			name = nm;
345
			name_len = strlen(nm);
346 347
		} else {
			name = pos->long_name;
348
			name_len = pos->long_name_len;
349 350
		}

351 352 353
		in_kernel = pos->kernel ||
				is_kernel_module(name,
					PERF_RECORD_MISC_CPUMODE_UNKNOWN);
354
		err = write_buildid(name, name_len, pos->build_id, machine->pid,
355
				    in_kernel ? kmisc : umisc, fd);
356
		if (err)
357
			break;
358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
	}

	return err;
}

int perf_session__write_buildid_table(struct perf_session *session, int fd)
{
	struct rb_node *nd;
	int err = machine__write_buildid_table(&session->machines.host, fd);

	if (err)
		return err;

	for (nd = rb_first(&session->machines.guests); nd; nd = rb_next(nd)) {
		struct machine *pos = rb_entry(nd, struct machine, rb_node);
		err = machine__write_buildid_table(pos, fd);
		if (err)
			break;
	}
	return err;
}

static int __dsos__hit_all(struct list_head *head)
{
	struct dso *pos;

	list_for_each_entry(pos, head, node)
		pos->hit = true;

	return 0;
}

static int machine__hit_all_dsos(struct machine *machine)
{
392
	return __dsos__hit_all(&machine->dsos.head);
393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414
}

int dsos__hit_all(struct perf_session *session)
{
	struct rb_node *nd;
	int err;

	err = machine__hit_all_dsos(&session->machines.host);
	if (err)
		return err;

	for (nd = rb_first(&session->machines.guests); nd; nd = rb_next(nd)) {
		struct machine *pos = rb_entry(nd, struct machine, rb_node);

		err = machine__hit_all_dsos(pos);
		if (err)
			return err;
	}

	return 0;
}

415 416 417 418 419
void disable_buildid_cache(void)
{
	no_buildid_cache = true;
}

420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494
static bool lsdir_bid_head_filter(const char *name __maybe_unused,
				  struct dirent *d __maybe_unused)
{
	return (strlen(d->d_name) == 2) &&
		isxdigit(d->d_name[0]) && isxdigit(d->d_name[1]);
}

static bool lsdir_bid_tail_filter(const char *name __maybe_unused,
				  struct dirent *d __maybe_unused)
{
	int i = 0;
	while (isxdigit(d->d_name[i]) && i < SBUILD_ID_SIZE - 3)
		i++;
	return (i == SBUILD_ID_SIZE - 3) && (d->d_name[i] == '\0');
}

struct strlist *build_id_cache__list_all(void)
{
	struct strlist *toplist, *linklist = NULL, *bidlist;
	struct str_node *nd, *nd2;
	char *topdir, *linkdir = NULL;
	char sbuild_id[SBUILD_ID_SIZE];

	/* Open the top-level directory */
	if (asprintf(&topdir, "%s/.build-id/", buildid_dir) < 0)
		return NULL;

	bidlist = strlist__new(NULL, NULL);
	if (!bidlist)
		goto out;

	toplist = lsdir(topdir, lsdir_bid_head_filter);
	if (!toplist) {
		pr_debug("Error in lsdir(%s): %d\n", topdir, errno);
		/* If there is no buildid cache, return an empty list */
		if (errno == ENOENT)
			goto out;
		goto err_out;
	}

	strlist__for_each_entry(nd, toplist) {
		if (asprintf(&linkdir, "%s/%s", topdir, nd->s) < 0)
			goto err_out;
		/* Open the lower-level directory */
		linklist = lsdir(linkdir, lsdir_bid_tail_filter);
		if (!linklist) {
			pr_debug("Error in lsdir(%s): %d\n", linkdir, errno);
			goto err_out;
		}
		strlist__for_each_entry(nd2, linklist) {
			if (snprintf(sbuild_id, SBUILD_ID_SIZE, "%s%s",
				     nd->s, nd2->s) != SBUILD_ID_SIZE - 1)
				goto err_out;
			if (strlist__add(bidlist, sbuild_id) < 0)
				goto err_out;
		}
		strlist__delete(linklist);
		zfree(&linkdir);
	}

out_free:
	strlist__delete(toplist);
out:
	free(topdir);

	return bidlist;

err_out:
	strlist__delete(linklist);
	zfree(&linkdir);
	strlist__delete(bidlist);
	bidlist = NULL;
	goto out_free;
}

495 496
char *build_id_cache__cachedir(const char *sbuild_id, const char *name,
			       bool is_kallsyms, bool is_vdso)
497 498 499 500 501 502 503 504 505 506
{
	char *realname = (char *)name, *filename;
	bool slash = is_kallsyms || is_vdso;

	if (!slash) {
		realname = realpath(name, NULL);
		if (!realname)
			return NULL;
	}

507 508 509
	if (asprintf(&filename, "%s%s%s%s%s", buildid_dir, slash ? "/" : "",
		     is_vdso ? DSO__NAME_VDSO : realname,
		     sbuild_id ? "/" : "", sbuild_id ?: "") < 0)
510 511 512 513 514 515 516 517 518 519 520 521 522 523
		filename = NULL;

	if (!slash)
		free(realname);

	return filename;
}

int build_id_cache__list_build_ids(const char *pathname,
				   struct strlist **result)
{
	char *dir_name;
	int ret = 0;

524
	dir_name = build_id_cache__cachedir(NULL, pathname, false, false);
525 526
	if (!dir_name)
		return -ENOMEM;
527

528 529
	*result = lsdir(dir_name, lsdir_no_dot_filter);
	if (!*result)
530 531 532 533 534 535
		ret = -errno;
	free(dir_name);

	return ret;
}

536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559
#ifdef HAVE_LIBELF_SUPPORT
static int build_id_cache__add_sdt_cache(const char *sbuild_id,
					  const char *realname)
{
	struct probe_cache *cache;
	int ret;

	cache = probe_cache__new(sbuild_id);
	if (!cache)
		return -1;

	ret = probe_cache__scan_sdt(cache, realname);
	if (ret >= 0) {
		pr_debug("Found %d SDTs in %s\n", ret, realname);
		if (probe_cache__commit(cache) < 0)
			ret = -1;
	}
	probe_cache__delete(cache);
	return ret;
}
#else
#define build_id_cache__add_sdt_cache(sbuild_id, realname) (0)
#endif

560 561
int build_id_cache__add_s(const char *sbuild_id, const char *name,
			  bool is_kallsyms, bool is_vdso)
562 563
{
	const size_t size = PATH_MAX;
564
	char *realname = NULL, *filename = NULL, *dir_name = NULL,
565
	     *linkname = zalloc(size), *tmp;
566
	int err = -1;
567

568
	if (!is_kallsyms) {
569
		realname = realpath(name, NULL);
570 571 572
		if (!realname)
			goto out_free;
	}
573

574 575
	dir_name = build_id_cache__cachedir(sbuild_id, name,
					    is_kallsyms, is_vdso);
576
	if (!dir_name)
577 578
		goto out_free;

579 580 581 582 583
	/* Remove old style build-id cache */
	if (is_regular_file(dir_name))
		if (unlink(dir_name))
			goto out_free;

584
	if (mkdir_p(dir_name, 0755))
585 586
		goto out_free;

587 588 589
	/* Save the allocated buildid dirname */
	if (asprintf(&filename, "%s/%s", dir_name,
		     build_id_cache__basename(is_kallsyms, is_vdso)) < 0) {
590 591 592
		filename = NULL;
		goto out_free;
	}
593 594 595 596 597

	if (access(filename, F_OK)) {
		if (is_kallsyms) {
			 if (copyfile("/proc/kallsyms", filename))
				goto out_free;
598 599
		} else if (link(realname, filename) && errno != EEXIST &&
				copyfile(name, filename))
600 601 602
			goto out_free;
	}

603
	if (!build_id_cache__linkname(sbuild_id, linkname, size))
604 605 606
		goto out_free;
	tmp = strrchr(linkname, '/');
	*tmp = '\0';
607 608 609 610

	if (access(linkname, X_OK) && mkdir_p(linkname, 0755))
		goto out_free;

611
	*tmp = '/';
612 613
	tmp = dir_name + strlen(buildid_dir) - 5;
	memcpy(tmp, "../..", 5);
614

615
	if (symlink(tmp, linkname) == 0)
616
		err = 0;
617 618 619 620 621

	/* Update SDT cache : error is just warned */
	if (build_id_cache__add_sdt_cache(sbuild_id, realname) < 0)
		pr_debug("Failed to update/scan SDT cache for %s\n", realname);

622 623 624 625
out_free:
	if (!is_kallsyms)
		free(realname);
	free(filename);
626
	free(dir_name);
627 628 629 630 631
	free(linkname);
	return err;
}

static int build_id_cache__add_b(const u8 *build_id, size_t build_id_size,
632 633
				 const char *name, bool is_kallsyms,
				 bool is_vdso)
634
{
635
	char sbuild_id[SBUILD_ID_SIZE];
636 637 638

	build_id__sprintf(build_id, build_id_size, sbuild_id);

639
	return build_id_cache__add_s(sbuild_id, name, is_kallsyms, is_vdso);
640 641
}

642 643 644
bool build_id_cache__cached(const char *sbuild_id)
{
	bool ret = false;
645
	char *filename = build_id_cache__linkname(sbuild_id, NULL, 0);
646 647 648 649 650 651 652 653

	if (filename && !access(filename, F_OK))
		ret = true;
	free(filename);

	return ret;
}

654
int build_id_cache__remove_s(const char *sbuild_id)
655 656 657
{
	const size_t size = PATH_MAX;
	char *filename = zalloc(size),
658
	     *linkname = zalloc(size), *tmp;
659 660 661 662 663
	int err = -1;

	if (filename == NULL || linkname == NULL)
		goto out_free;

664
	if (!build_id_cache__linkname(sbuild_id, linkname, size))
665
		goto out_free;
666 667 668 669 670 671 672 673 674 675 676 677 678

	if (access(linkname, F_OK))
		goto out_free;

	if (readlink(linkname, filename, size - 1) < 0)
		goto out_free;

	if (unlink(linkname))
		goto out_free;

	/*
	 * Since the link is relative, we must make it absolute:
	 */
679 680
	tmp = strrchr(linkname, '/') + 1;
	snprintf(tmp, size - (tmp - linkname), "%s", filename);
681

682
	if (rm_rf(linkname))
683 684 685 686 687 688 689 690 691
		goto out_free;

	err = 0;
out_free:
	free(filename);
	free(linkname);
	return err;
}

692
static int dso__cache_build_id(struct dso *dso, struct machine *machine)
693
{
694
	bool is_kallsyms = dso__is_kallsyms(dso);
695 696 697 698 699 700 701 702 703 704
	bool is_vdso = dso__is_vdso(dso);
	const char *name = dso->long_name;
	char nm[PATH_MAX];

	if (dso__is_kcore(dso)) {
		is_kallsyms = true;
		machine__mmap_name(machine, nm, sizeof(nm));
		name = nm;
	}
	return build_id_cache__add_b(dso->build_id, sizeof(dso->build_id), name,
705
				     is_kallsyms, is_vdso);
706 707 708
}

static int __dsos__cache_build_ids(struct list_head *head,
709
				   struct machine *machine)
710 711 712 713 714
{
	struct dso *pos;
	int err = 0;

	dsos__for_each_with_build_id(pos, head)
715
		if (dso__cache_build_id(pos, machine))
716 717 718 719 720
			err = -1;

	return err;
}

721
static int machine__cache_build_ids(struct machine *machine)
722
{
723
	return __dsos__cache_build_ids(&machine->dsos.head, machine);
724 725 726 727 728 729 730
}

int perf_session__cache_build_ids(struct perf_session *session)
{
	struct rb_node *nd;
	int ret;

731 732 733
	if (no_buildid_cache)
		return 0;

734
	if (mkdir(buildid_dir, 0755) != 0 && errno != EEXIST)
735 736
		return -1;

737
	ret = machine__cache_build_ids(&session->machines.host);
738 739 740

	for (nd = rb_first(&session->machines.guests); nd; nd = rb_next(nd)) {
		struct machine *pos = rb_entry(nd, struct machine, rb_node);
741
		ret |= machine__cache_build_ids(pos);
742 743 744 745 746 747
	}
	return ret ? -1 : 0;
}

static bool machine__read_build_ids(struct machine *machine, bool with_hits)
{
748
	return __dsos__read_build_ids(&machine->dsos.head, with_hits);
749 750 751 752 753 754 755 756 757 758 759 760 761 762
}

bool perf_session__read_build_ids(struct perf_session *session, bool with_hits)
{
	struct rb_node *nd;
	bool ret = machine__read_build_ids(&session->machines.host, with_hits);

	for (nd = rb_first(&session->machines.guests); nd; nd = rb_next(nd)) {
		struct machine *pos = rb_entry(nd, struct machine, rb_node);
		ret |= machine__read_build_ids(pos, with_hits);
	}

	return ret;
}