apply.c 28.1 KB
Newer Older
T
Tomi Valkeinen 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33
/*
 * Copyright (C) 2011 Texas Instruments
 * Author: Tomi Valkeinen <tomi.valkeinen@ti.com>
 *
 * This program is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 as published by
 * the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 * more details.
 *
 * You should have received a copy of the GNU General Public License along with
 * this program.  If not, see <http://www.gnu.org/licenses/>.
 */

#define DSS_SUBSYS_NAME "APPLY"

#include <linux/kernel.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/jiffies.h>

#include <video/omapdss.h>

#include "dss.h"
#include "dss_features.h"

/*
 * We have 4 levels of cache for the dispc settings. First two are in SW and
 * the latter two in HW.
 *
34 35
 *       set_info()
 *          v
T
Tomi Valkeinen 已提交
36
 * +--------------------+
37
 * |     user_info      |
T
Tomi Valkeinen 已提交
38 39 40 41 42
 * +--------------------+
 *          v
 *        apply()
 *          v
 * +--------------------+
43
 * |       info         |
T
Tomi Valkeinen 已提交
44 45
 * +--------------------+
 *          v
46
 *      write_regs()
T
Tomi Valkeinen 已提交
47 48 49 50 51 52 53 54 55 56 57 58
 *          v
 * +--------------------+
 * |  shadow registers  |
 * +--------------------+
 *          v
 * VFP or lcd/digit_enable
 *          v
 * +--------------------+
 * |      registers     |
 * +--------------------+
 */

59
struct ovl_priv_data {
60 61 62 63

	bool user_info_dirty;
	struct omap_overlay_info user_info;

64
	bool info_dirty;
T
Tomi Valkeinen 已提交
65 66
	struct omap_overlay_info info;

67 68
	bool shadow_info_dirty;

69 70 71 72
	bool extra_info_dirty;
	bool shadow_extra_info_dirty;

	bool enabled;
73
	enum omap_channel channel;
74
	u32 fifo_low, fifo_high;
T
Tomi Valkeinen 已提交
75 76
};

77
struct mgr_priv_data {
78 79 80 81

	bool user_info_dirty;
	struct omap_overlay_manager_info user_info;

82
	bool info_dirty;
T
Tomi Valkeinen 已提交
83 84
	struct omap_overlay_manager_info info;

85 86
	bool shadow_info_dirty;

87 88 89 90
	/* If true, GO bit is up and shadow registers cannot be written.
	 * Never true for manual update displays */
	bool busy;

T
Tomi Valkeinen 已提交
91 92 93
	/* If true, dispc output is enabled */
	bool updating;

94 95
	/* If true, a display is enabled using this manager */
	bool enabled;
T
Tomi Valkeinen 已提交
96 97 98
};

static struct {
99
	struct ovl_priv_data ovl_priv_data_array[MAX_DSS_OVERLAYS];
100
	struct mgr_priv_data mgr_priv_data_array[MAX_DSS_MANAGERS];
T
Tomi Valkeinen 已提交
101 102

	bool irq_enabled;
103
} dss_data;
T
Tomi Valkeinen 已提交
104

105
/* protects dss_data */
106
static spinlock_t data_lock;
T
Tomi Valkeinen 已提交
107 108
/* lock for blocking functions */
static DEFINE_MUTEX(apply_lock);
109
static DECLARE_COMPLETION(extra_updated_completion);
110

111 112
static void dss_register_vsync_isr(void);

113 114
static struct ovl_priv_data *get_ovl_priv(struct omap_overlay *ovl)
{
115
	return &dss_data.ovl_priv_data_array[ovl->id];
116 117
}

118 119
static struct mgr_priv_data *get_mgr_priv(struct omap_overlay_manager *mgr)
{
120
	return &dss_data.mgr_priv_data_array[mgr->id];
121 122
}

T
Tomi Valkeinen 已提交
123 124
void dss_apply_init(void)
{
125 126 127
	const int num_ovls = dss_feat_get_num_ovls();
	int i;

128
	spin_lock_init(&data_lock);
129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156

	for (i = 0; i < num_ovls; ++i) {
		struct ovl_priv_data *op;

		op = &dss_data.ovl_priv_data_array[i];

		op->info.global_alpha = 255;

		switch (i) {
		case 0:
			op->info.zorder = 0;
			break;
		case 1:
			op->info.zorder =
				dss_has_feature(FEAT_ALPHA_FREE_ZORDER) ? 3 : 0;
			break;
		case 2:
			op->info.zorder =
				dss_has_feature(FEAT_ALPHA_FREE_ZORDER) ? 2 : 0;
			break;
		case 3:
			op->info.zorder =
				dss_has_feature(FEAT_ALPHA_FREE_ZORDER) ? 1 : 0;
			break;
		}

		op->user_info = op->info;
	}
T
Tomi Valkeinen 已提交
157 158 159 160 161 162 163 164 165 166 167 168
}

static bool ovl_manual_update(struct omap_overlay *ovl)
{
	return ovl->manager->device->caps & OMAP_DSS_DISPLAY_CAP_MANUAL_UPDATE;
}

static bool mgr_manual_update(struct omap_overlay_manager *mgr)
{
	return mgr->device->caps & OMAP_DSS_DISPLAY_CAP_MANUAL_UPDATE;
}

169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331
/* Check if overlay parameters are compatible with display */
static int dss_ovl_check(struct omap_overlay *ovl,
		struct omap_overlay_info *info, struct omap_dss_device *dssdev)
{
	u16 outw, outh;
	u16 dw, dh;

	if (dssdev == NULL)
		return 0;

	dssdev->driver->get_resolution(dssdev, &dw, &dh);

	if ((ovl->caps & OMAP_DSS_OVL_CAP_SCALE) == 0) {
		outw = info->width;
		outh = info->height;
	} else {
		if (info->out_width == 0)
			outw = info->width;
		else
			outw = info->out_width;

		if (info->out_height == 0)
			outh = info->height;
		else
			outh = info->out_height;
	}

	if (dw < info->pos_x + outw) {
		DSSERR("overlay %d horizontally not inside the display area "
				"(%d + %d >= %d)\n",
				ovl->id, info->pos_x, outw, dw);
		return -EINVAL;
	}

	if (dh < info->pos_y + outh) {
		DSSERR("overlay %d vertically not inside the display area "
				"(%d + %d >= %d)\n",
				ovl->id, info->pos_y, outh, dh);
		return -EINVAL;
	}

	return 0;
}

static int dss_mgr_check_zorder(struct omap_overlay_manager *mgr,
		struct omap_overlay_info **overlay_infos)
{
	struct omap_overlay *ovl1, *ovl2;
	struct ovl_priv_data *op1, *op2;
	struct omap_overlay_info *info1, *info2;

	list_for_each_entry(ovl1, &mgr->overlays, list) {
		op1 = get_ovl_priv(ovl1);
		info1 = overlay_infos[ovl1->id];

		if (info1 == NULL)
			continue;

		list_for_each_entry(ovl2, &mgr->overlays, list) {
			if (ovl1 == ovl2)
				continue;

			op2 = get_ovl_priv(ovl2);
			info2 = overlay_infos[ovl2->id];

			if (info2 == NULL)
				continue;

			if (info1->zorder == info2->zorder) {
				DSSERR("overlays %d and %d have the same "
						"zorder %d\n",
					ovl1->id, ovl2->id, info1->zorder);
				return -EINVAL;
			}
		}
	}

	return 0;
}

static int dss_mgr_check(struct omap_overlay_manager *mgr,
		struct omap_dss_device *dssdev,
		struct omap_overlay_manager_info *info,
		struct omap_overlay_info **overlay_infos)
{
	struct omap_overlay *ovl;
	int r;

	if (dss_has_feature(FEAT_ALPHA_FREE_ZORDER)) {
		r = dss_mgr_check_zorder(mgr, overlay_infos);
		if (r)
			return r;
	}

	list_for_each_entry(ovl, &mgr->overlays, list) {
		struct omap_overlay_info *oi;
		int r;

		oi = overlay_infos[ovl->id];

		if (oi == NULL)
			continue;

		r = dss_ovl_check(ovl, oi, dssdev);
		if (r)
			return r;
	}

	return 0;
}
static int dss_check_settings_low(struct omap_overlay_manager *mgr,
		struct omap_dss_device *dssdev, bool applying)
{
	struct omap_overlay_info *oi;
	struct omap_overlay_manager_info *mi;
	struct omap_overlay *ovl;
	struct omap_overlay_info *ois[MAX_DSS_OVERLAYS];
	struct ovl_priv_data *op;
	struct mgr_priv_data *mp;

	mp = get_mgr_priv(mgr);

	if (applying && mp->user_info_dirty)
		mi = &mp->user_info;
	else
		mi = &mp->info;

	/* collect the infos to be tested into the array */
	list_for_each_entry(ovl, &mgr->overlays, list) {
		op = get_ovl_priv(ovl);

		if (!op->enabled)
			oi = NULL;
		else if (applying && op->user_info_dirty)
			oi = &op->user_info;
		else
			oi = &op->info;

		ois[ovl->id] = oi;
	}

	return dss_mgr_check(mgr, dssdev, mi, ois);
}

/*
 * check manager and overlay settings using overlay_info from data->info
 */
static int dss_check_settings(struct omap_overlay_manager *mgr,
		struct omap_dss_device *dssdev)
{
	return dss_check_settings_low(mgr, dssdev, false);
}

/*
 * check manager and overlay settings using overlay_info from ovl->info if
 * dirty and from data->info otherwise
 */
static int dss_check_settings_apply(struct omap_overlay_manager *mgr,
		struct omap_dss_device *dssdev)
{
	return dss_check_settings_low(mgr, dssdev, true);
}

332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347
static bool need_isr(void)
{
	const int num_mgrs = dss_feat_get_num_mgrs();
	int i;

	for (i = 0; i < num_mgrs; ++i) {
		struct omap_overlay_manager *mgr;
		struct mgr_priv_data *mp;
		struct omap_overlay *ovl;

		mgr = omap_dss_get_overlay_manager(i);
		mp = get_mgr_priv(mgr);

		if (!mp->enabled)
			continue;

T
Tomi Valkeinen 已提交
348 349 350 351 352 353 354 355
		if (mgr_manual_update(mgr)) {
			/* to catch FRAMEDONE */
			if (mp->updating)
				return true;
		} else {
			/* to catch GO bit going down */
			if (mp->busy)
				return true;
356

T
Tomi Valkeinen 已提交
357
			/* to write new values to registers */
358
			if (mp->info_dirty)
T
Tomi Valkeinen 已提交
359
				return true;
360

T
Tomi Valkeinen 已提交
361 362
			list_for_each_entry(ovl, &mgr->overlays, list) {
				struct ovl_priv_data *op;
363

T
Tomi Valkeinen 已提交
364
				op = get_ovl_priv(ovl);
365

T
Tomi Valkeinen 已提交
366 367
				if (!op->enabled)
					continue;
368

T
Tomi Valkeinen 已提交
369
				/* to write new values to registers */
370
				if (op->info_dirty || op->extra_info_dirty)
T
Tomi Valkeinen 已提交
371 372
					return true;
			}
373 374 375 376 377 378 379 380 381 382 383 384 385 386
		}
	}

	return false;
}

static bool need_go(struct omap_overlay_manager *mgr)
{
	struct omap_overlay *ovl;
	struct mgr_priv_data *mp;
	struct ovl_priv_data *op;

	mp = get_mgr_priv(mgr);

387
	if (mp->shadow_info_dirty)
388 389 390 391
		return true;

	list_for_each_entry(ovl, &mgr->overlays, list) {
		op = get_ovl_priv(ovl);
392
		if (op->shadow_info_dirty || op->shadow_extra_info_dirty)
393 394 395 396 397 398
			return true;
	}

	return false;
}

399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462
/* returns true if an extra_info field is currently being updated */
static bool extra_info_update_ongoing(void)
{
	const int num_ovls = omap_dss_get_num_overlays();
	struct ovl_priv_data *op;
	struct omap_overlay *ovl;
	struct mgr_priv_data *mp;
	int i;
	bool eid;

	for (i = 0; i < num_ovls; ++i) {
		ovl = omap_dss_get_overlay(i);
		op = get_ovl_priv(ovl);

		if (!op->enabled)
			continue;

		mp = get_mgr_priv(ovl->manager);

		if (!mp->enabled)
			continue;

		eid = op->extra_info_dirty || op->shadow_extra_info_dirty;

		if (!eid)
			continue;

		if (ovl_manual_update(ovl) && !mp->updating)
			continue;

		return true;
	}

	return false;
}

/* wait until no extra_info updates are pending */
static void wait_pending_extra_info_updates(void)
{
	bool updating;
	unsigned long flags;
	unsigned long t;

	spin_lock_irqsave(&data_lock, flags);

	updating = extra_info_update_ongoing();

	if (!updating) {
		spin_unlock_irqrestore(&data_lock, flags);
		return;
	}

	init_completion(&extra_updated_completion);

	spin_unlock_irqrestore(&data_lock, flags);

	t = msecs_to_jiffies(500);
	wait_for_completion_timeout(&extra_updated_completion, t);

	updating = extra_info_update_ongoing();

	WARN_ON(updating);
}

T
Tomi Valkeinen 已提交
463 464 465
int dss_mgr_wait_for_go(struct omap_overlay_manager *mgr)
{
	unsigned long timeout = msecs_to_jiffies(500);
466
	struct mgr_priv_data *mp;
T
Tomi Valkeinen 已提交
467 468 469 470 471 472 473 474 475 476 477
	u32 irq;
	int r;
	int i;
	struct omap_dss_device *dssdev = mgr->device;

	if (!dssdev || dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
		return 0;

	if (mgr_manual_update(mgr))
		return 0;

478
	irq = dispc_mgr_get_vsync_irq(mgr->id);
T
Tomi Valkeinen 已提交
479

480
	mp = get_mgr_priv(mgr);
T
Tomi Valkeinen 已提交
481 482 483 484 485
	i = 0;
	while (1) {
		unsigned long flags;
		bool shadow_dirty, dirty;

486
		spin_lock_irqsave(&data_lock, flags);
487 488
		dirty = mp->info_dirty;
		shadow_dirty = mp->shadow_info_dirty;
489
		spin_unlock_irqrestore(&data_lock, flags);
T
Tomi Valkeinen 已提交
490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523

		if (!dirty && !shadow_dirty) {
			r = 0;
			break;
		}

		/* 4 iterations is the worst case:
		 * 1 - initial iteration, dirty = true (between VFP and VSYNC)
		 * 2 - first VSYNC, dirty = true
		 * 3 - dirty = false, shadow_dirty = true
		 * 4 - shadow_dirty = false */
		if (i++ == 3) {
			DSSERR("mgr(%d)->wait_for_go() not finishing\n",
					mgr->id);
			r = 0;
			break;
		}

		r = omap_dispc_wait_for_irq_interruptible_timeout(irq, timeout);
		if (r == -ERESTARTSYS)
			break;

		if (r) {
			DSSERR("mgr(%d)->wait_for_go() timeout\n", mgr->id);
			break;
		}
	}

	return r;
}

int dss_mgr_wait_for_go_ovl(struct omap_overlay *ovl)
{
	unsigned long timeout = msecs_to_jiffies(500);
524
	struct ovl_priv_data *op;
T
Tomi Valkeinen 已提交
525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540
	struct omap_dss_device *dssdev;
	u32 irq;
	int r;
	int i;

	if (!ovl->manager)
		return 0;

	dssdev = ovl->manager->device;

	if (!dssdev || dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
		return 0;

	if (ovl_manual_update(ovl))
		return 0;

541
	irq = dispc_mgr_get_vsync_irq(ovl->manager->id);
T
Tomi Valkeinen 已提交
542

543
	op = get_ovl_priv(ovl);
T
Tomi Valkeinen 已提交
544 545 546 547 548
	i = 0;
	while (1) {
		unsigned long flags;
		bool shadow_dirty, dirty;

549
		spin_lock_irqsave(&data_lock, flags);
550 551
		dirty = op->info_dirty;
		shadow_dirty = op->shadow_info_dirty;
552
		spin_unlock_irqrestore(&data_lock, flags);
T
Tomi Valkeinen 已提交
553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583

		if (!dirty && !shadow_dirty) {
			r = 0;
			break;
		}

		/* 4 iterations is the worst case:
		 * 1 - initial iteration, dirty = true (between VFP and VSYNC)
		 * 2 - first VSYNC, dirty = true
		 * 3 - dirty = false, shadow_dirty = true
		 * 4 - shadow_dirty = false */
		if (i++ == 3) {
			DSSERR("ovl(%d)->wait_for_go() not finishing\n",
					ovl->id);
			r = 0;
			break;
		}

		r = omap_dispc_wait_for_irq_interruptible_timeout(irq, timeout);
		if (r == -ERESTARTSYS)
			break;

		if (r) {
			DSSERR("ovl(%d)->wait_for_go() timeout\n", ovl->id);
			break;
		}
	}

	return r;
}

584
static void dss_ovl_write_regs(struct omap_overlay *ovl)
T
Tomi Valkeinen 已提交
585
{
586
	struct ovl_priv_data *op = get_ovl_priv(ovl);
T
Tomi Valkeinen 已提交
587 588
	struct omap_overlay_info *oi;
	bool ilace, replication;
T
Tomi Valkeinen 已提交
589
	struct mgr_priv_data *mp;
T
Tomi Valkeinen 已提交
590 591
	int r;

592
	DSSDBGF("%d", ovl->id);
T
Tomi Valkeinen 已提交
593

594
	if (!op->enabled || !op->info_dirty)
595
		return;
T
Tomi Valkeinen 已提交
596

597
	oi = &op->info;
T
Tomi Valkeinen 已提交
598 599 600 601 602

	replication = dss_use_replication(ovl->manager->device, oi->color_mode);

	ilace = ovl->manager->device->type == OMAP_DISPLAY_TYPE_VENC;

603
	r = dispc_ovl_setup(ovl->id, oi, ilace, replication);
T
Tomi Valkeinen 已提交
604
	if (r) {
605 606 607 608
		/*
		 * We can't do much here, as this function can be called from
		 * vsync interrupt.
		 */
609
		DSSERR("dispc_ovl_setup failed for ovl %d\n", ovl->id);
610 611 612 613 614

		/* This will leave fifo configurations in a nonoptimal state */
		op->enabled = false;
		dispc_ovl_enable(ovl->id, false);
		return;
T
Tomi Valkeinen 已提交
615 616
	}

T
Tomi Valkeinen 已提交
617 618
	mp = get_mgr_priv(ovl->manager);

619
	op->info_dirty = false;
T
Tomi Valkeinen 已提交
620
	if (mp->updating)
621
		op->shadow_info_dirty = true;
T
Tomi Valkeinen 已提交
622 623
}

624 625 626
static void dss_ovl_write_regs_extra(struct omap_overlay *ovl)
{
	struct ovl_priv_data *op = get_ovl_priv(ovl);
T
Tomi Valkeinen 已提交
627
	struct mgr_priv_data *mp;
628 629 630

	DSSDBGF("%d", ovl->id);

631 632 633
	if (!op->extra_info_dirty)
		return;

634 635 636 637
	/* note: write also when op->enabled == false, so that the ovl gets
	 * disabled */

	dispc_ovl_enable(ovl->id, op->enabled);
638
	dispc_ovl_set_channel_out(ovl->id, op->channel);
639
	dispc_ovl_set_fifo_threshold(ovl->id, op->fifo_low, op->fifo_high);
640

T
Tomi Valkeinen 已提交
641 642
	mp = get_mgr_priv(ovl->manager);

643
	op->extra_info_dirty = false;
T
Tomi Valkeinen 已提交
644 645
	if (mp->updating)
		op->shadow_extra_info_dirty = true;
646 647
}

648
static void dss_mgr_write_regs(struct omap_overlay_manager *mgr)
T
Tomi Valkeinen 已提交
649
{
650 651
	struct mgr_priv_data *mp = get_mgr_priv(mgr);
	struct omap_overlay *ovl;
T
Tomi Valkeinen 已提交
652

653
	DSSDBGF("%d", mgr->id);
T
Tomi Valkeinen 已提交
654

655 656
	if (!mp->enabled)
		return;
T
Tomi Valkeinen 已提交
657

658
	WARN_ON(mp->busy);
T
Tomi Valkeinen 已提交
659 660

	/* Commit overlay settings */
661 662
	list_for_each_entry(ovl, &mgr->overlays, list) {
		dss_ovl_write_regs(ovl);
663 664 665
		dss_ovl_write_regs_extra(ovl);
	}

666
	if (mp->info_dirty) {
667
		dispc_mgr_setup(mgr->id, &mp->info);
T
Tomi Valkeinen 已提交
668

669
		mp->info_dirty = false;
T
Tomi Valkeinen 已提交
670
		if (mp->updating)
671
			mp->shadow_info_dirty = true;
T
Tomi Valkeinen 已提交
672
	}
673 674 675 676 677 678
}

static void dss_write_regs(void)
{
	const int num_mgrs = omap_dss_get_num_overlay_managers();
	int i;
T
Tomi Valkeinen 已提交
679 680

	for (i = 0; i < num_mgrs; ++i) {
681 682
		struct omap_overlay_manager *mgr;
		struct mgr_priv_data *mp;
683
		int r;
684

685 686
		mgr = omap_dss_get_overlay_manager(i);
		mp = get_mgr_priv(mgr);
T
Tomi Valkeinen 已提交
687

688
		if (!mp->enabled || mgr_manual_update(mgr) || mp->busy)
T
Tomi Valkeinen 已提交
689 690
			continue;

691 692 693 694 695 696 697
		r = dss_check_settings(mgr, mgr->device);
		if (r) {
			DSSERR("cannot write registers for manager %s: "
					"illegal configuration\n", mgr->name);
			continue;
		}

698 699 700
		dss_mgr_write_regs(mgr);

		if (need_go(mgr)) {
701
			mp->busy = true;
T
Tomi Valkeinen 已提交
702

703 704
			if (!dss_data.irq_enabled && need_isr())
				dss_register_vsync_isr();
T
Tomi Valkeinen 已提交
705

706 707 708
			dispc_mgr_go(mgr->id);
		}
	}
T
Tomi Valkeinen 已提交
709 710 711 712
}

void dss_mgr_start_update(struct omap_overlay_manager *mgr)
{
713
	struct mgr_priv_data *mp = get_mgr_priv(mgr);
714
	unsigned long flags;
715
	int r;
716 717

	spin_lock_irqsave(&data_lock, flags);
T
Tomi Valkeinen 已提交
718

T
Tomi Valkeinen 已提交
719 720
	WARN_ON(mp->updating);

721 722 723 724 725 726 727
	r = dss_check_settings(mgr, mgr->device);
	if (r) {
		DSSERR("cannot start manual update: illegal configuration\n");
		spin_unlock_irqrestore(&data_lock, flags);
		return;
	}

728
	dss_mgr_write_regs(mgr);
T
Tomi Valkeinen 已提交
729

T
Tomi Valkeinen 已提交
730
	mp->updating = true;
T
Tomi Valkeinen 已提交
731

T
Tomi Valkeinen 已提交
732 733
	if (!dss_data.irq_enabled && need_isr())
		dss_register_vsync_isr();
T
Tomi Valkeinen 已提交
734

735
	dispc_mgr_enable(mgr->id, true);
736 737

	spin_unlock_irqrestore(&data_lock, flags);
T
Tomi Valkeinen 已提交
738 739
}

740 741 742 743
static void dss_apply_irq_handler(void *data, u32 mask);

static void dss_register_vsync_isr(void)
{
744
	const int num_mgrs = dss_feat_get_num_mgrs();
745
	u32 mask;
746
	int r, i;
747

748 749 750
	mask = 0;
	for (i = 0; i < num_mgrs; ++i)
		mask |= dispc_mgr_get_vsync_irq(i);
751

T
Tomi Valkeinen 已提交
752 753 754
	for (i = 0; i < num_mgrs; ++i)
		mask |= dispc_mgr_get_framedone_irq(i);

755 756 757
	r = omap_dispc_register_isr(dss_apply_irq_handler, NULL, mask);
	WARN_ON(r);

758
	dss_data.irq_enabled = true;
759 760 761 762
}

static void dss_unregister_vsync_isr(void)
{
763
	const int num_mgrs = dss_feat_get_num_mgrs();
764
	u32 mask;
765
	int r, i;
766

767 768 769
	mask = 0;
	for (i = 0; i < num_mgrs; ++i)
		mask |= dispc_mgr_get_vsync_irq(i);
770

T
Tomi Valkeinen 已提交
771 772 773
	for (i = 0; i < num_mgrs; ++i)
		mask |= dispc_mgr_get_framedone_irq(i);

774 775 776
	r = omap_dispc_unregister_isr(dss_apply_irq_handler, NULL, mask);
	WARN_ON(r);

777
	dss_data.irq_enabled = false;
778 779
}

780
static void mgr_clear_shadow_dirty(struct omap_overlay_manager *mgr)
T
Tomi Valkeinen 已提交
781
{
782
	struct omap_overlay *ovl;
783
	struct mgr_priv_data *mp;
784
	struct ovl_priv_data *op;
785 786

	mp = get_mgr_priv(mgr);
787
	mp->shadow_info_dirty = false;
788 789 790

	list_for_each_entry(ovl, &mgr->overlays, list) {
		op = get_ovl_priv(ovl);
791
		op->shadow_info_dirty = false;
792 793 794 795 796 797
		op->shadow_extra_info_dirty = false;
	}
}

static void dss_apply_irq_handler(void *data, u32 mask)
{
T
Tomi Valkeinen 已提交
798
	const int num_mgrs = dss_feat_get_num_mgrs();
799
	int i;
800
	bool extra_updating;
T
Tomi Valkeinen 已提交
801

802
	spin_lock(&data_lock);
T
Tomi Valkeinen 已提交
803

804
	/* clear busy, updating flags, shadow_dirty flags */
805
	for (i = 0; i < num_mgrs; i++) {
806 807 808
		struct omap_overlay_manager *mgr;
		struct mgr_priv_data *mp;

809 810 811
		mgr = omap_dss_get_overlay_manager(i);
		mp = get_mgr_priv(mgr);

812
		if (!mp->enabled)
813 814
			continue;

815
		mp->updating = dispc_mgr_is_enabled(i);
T
Tomi Valkeinen 已提交
816

817 818
		if (!mgr_manual_update(mgr)) {
			mp->busy = dispc_mgr_go_busy(i);
819

820 821 822 823 824 825
			if (!mp->busy)
				mgr_clear_shadow_dirty(mgr);
		} else {
			if (!mp->updating)
				mgr_clear_shadow_dirty(mgr);
		}
T
Tomi Valkeinen 已提交
826 827
	}

828
	dss_write_regs();
T
Tomi Valkeinen 已提交
829

830 831 832 833
	extra_updating = extra_info_update_ongoing();
	if (!extra_updating)
		complete_all(&extra_updated_completion);

834 835
	if (!need_isr())
		dss_unregister_vsync_isr();
T
Tomi Valkeinen 已提交
836

837
	spin_unlock(&data_lock);
T
Tomi Valkeinen 已提交
838 839
}

840
static void omap_dss_mgr_apply_ovl(struct omap_overlay *ovl)
T
Tomi Valkeinen 已提交
841
{
842
	struct ovl_priv_data *op;
T
Tomi Valkeinen 已提交
843

844
	op = get_ovl_priv(ovl);
T
Tomi Valkeinen 已提交
845

846
	if (!op->user_info_dirty)
847
		return;
T
Tomi Valkeinen 已提交
848

849
	op->user_info_dirty = false;
850
	op->info_dirty = true;
851
	op->info = op->user_info;
T
Tomi Valkeinen 已提交
852 853 854 855
}

static void omap_dss_mgr_apply_mgr(struct omap_overlay_manager *mgr)
{
856
	struct mgr_priv_data *mp;
T
Tomi Valkeinen 已提交
857

858
	mp = get_mgr_priv(mgr);
T
Tomi Valkeinen 已提交
859

860
	if (!mp->user_info_dirty)
T
Tomi Valkeinen 已提交
861 862
		return;

863
	mp->user_info_dirty = false;
864
	mp->info_dirty = true;
865
	mp->info = mp->user_info;
T
Tomi Valkeinen 已提交
866 867
}

868
int omap_dss_mgr_apply(struct omap_overlay_manager *mgr)
T
Tomi Valkeinen 已提交
869
{
870 871
	unsigned long flags;
	struct omap_overlay *ovl;
872
	int r;
873 874 875 876 877

	DSSDBG("omap_dss_mgr_apply(%s)\n", mgr->name);

	spin_lock_irqsave(&data_lock, flags);

878 879 880 881 882 883 884
	r = dss_check_settings_apply(mgr, mgr->device);
	if (r) {
		spin_unlock_irqrestore(&data_lock, flags);
		DSSERR("failed to apply settings: illegal configuration.\n");
		return r;
	}

885 886 887 888 889 890 891 892 893 894 895
	/* Configure overlays */
	list_for_each_entry(ovl, &mgr->overlays, list)
		omap_dss_mgr_apply_ovl(ovl);

	/* Configure manager */
	omap_dss_mgr_apply_mgr(mgr);

	dss_write_regs();

	spin_unlock_irqrestore(&data_lock, flags);

896
	return 0;
897 898
}

899 900 901 902 903 904 905 906 907 908 909 910 911
static void dss_apply_ovl_enable(struct omap_overlay *ovl, bool enable)
{
	struct ovl_priv_data *op;

	op = get_ovl_priv(ovl);

	if (op->enabled == enable)
		return;

	op->enabled = enable;
	op->extra_info_dirty = true;
}

912 913 914
static void dss_ovl_setup_fifo(struct omap_overlay *ovl)
{
	struct ovl_priv_data *op = get_ovl_priv(ovl);
T
Tomi Valkeinen 已提交
915 916
	struct omap_dss_device *dssdev;
	u32 size, burst_size;
917
	u32 fifo_low, fifo_high;
T
Tomi Valkeinen 已提交
918 919 920 921 922 923 924 925 926 927 928 929 930 931

	dssdev = ovl->manager->device;

	size = dispc_ovl_get_fifo_size(ovl->id);

	burst_size = dispc_ovl_get_burst_size(ovl->id);

	switch (dssdev->type) {
	case OMAP_DISPLAY_TYPE_DPI:
	case OMAP_DISPLAY_TYPE_DBI:
	case OMAP_DISPLAY_TYPE_SDI:
	case OMAP_DISPLAY_TYPE_VENC:
	case OMAP_DISPLAY_TYPE_HDMI:
		default_get_overlay_fifo_thresholds(ovl->id, size,
932
				burst_size, &fifo_low, &fifo_high);
T
Tomi Valkeinen 已提交
933 934 935 936
		break;
#ifdef CONFIG_OMAP2_DSS_DSI
	case OMAP_DISPLAY_TYPE_DSI:
		dsi_get_overlay_fifo_thresholds(ovl->id, size,
937
				burst_size, &fifo_low, &fifo_high);
T
Tomi Valkeinen 已提交
938 939 940 941 942
		break;
#endif
	default:
		BUG();
	}
943 944 945 946

	op->fifo_low = fifo_low;
	op->fifo_high = fifo_high;
	op->extra_info_dirty = true;
T
Tomi Valkeinen 已提交
947 948
}

949
static void dss_mgr_setup_fifos(struct omap_overlay_manager *mgr)
T
Tomi Valkeinen 已提交
950
{
951
	struct omap_overlay *ovl;
952 953
	struct ovl_priv_data *op;
	struct mgr_priv_data *mp;
T
Tomi Valkeinen 已提交
954

955
	mp = get_mgr_priv(mgr);
T
Tomi Valkeinen 已提交
956

957 958
	if (!mp->enabled)
		return;
T
Tomi Valkeinen 已提交
959

960 961
	list_for_each_entry(ovl, &mgr->overlays, list) {
		op = get_ovl_priv(ovl);
T
Tomi Valkeinen 已提交
962

963 964
		if (!op->enabled)
			continue;
T
Tomi Valkeinen 已提交
965

966 967
		dss_ovl_setup_fifo(ovl);
	}
T
Tomi Valkeinen 已提交
968 969
}

970 971
void dss_mgr_enable(struct omap_overlay_manager *mgr)
{
972 973
	struct mgr_priv_data *mp = get_mgr_priv(mgr);
	unsigned long flags;
974
	int r;
975

T
Tomi Valkeinen 已提交
976 977
	mutex_lock(&apply_lock);

978 979 980
	if (mp->enabled)
		goto out;

981 982
	spin_lock_irqsave(&data_lock, flags);

983 984 985 986 987 988 989 990 991 992
	mp->enabled = true;
	r = dss_check_settings(mgr, mgr->device);
	mp->enabled = false;
	if (r) {
		DSSERR("failed to enable manager %d: check_settings failed\n",
				mgr->id);
		spin_unlock_irqrestore(&data_lock, flags);
		goto out;
	}

993 994
	mp->enabled = true;

995 996
	dss_mgr_setup_fifos(mgr);

997 998
	dss_write_regs();

T
Tomi Valkeinen 已提交
999 1000 1001
	if (!mgr_manual_update(mgr))
		mp->updating = true;

1002
	spin_unlock_irqrestore(&data_lock, flags);
T
Tomi Valkeinen 已提交
1003

1004 1005 1006
	if (!mgr_manual_update(mgr))
		dispc_mgr_enable(mgr->id, true);

1007
out:
T
Tomi Valkeinen 已提交
1008
	mutex_unlock(&apply_lock);
1009 1010 1011 1012
}

void dss_mgr_disable(struct omap_overlay_manager *mgr)
{
1013 1014 1015
	struct mgr_priv_data *mp = get_mgr_priv(mgr);
	unsigned long flags;

T
Tomi Valkeinen 已提交
1016 1017
	mutex_lock(&apply_lock);

1018 1019 1020
	if (!mp->enabled)
		goto out;

1021 1022
	if (!mgr_manual_update(mgr))
		dispc_mgr_enable(mgr->id, false);
1023 1024 1025

	spin_lock_irqsave(&data_lock, flags);

T
Tomi Valkeinen 已提交
1026
	mp->updating = false;
1027 1028 1029
	mp->enabled = false;

	spin_unlock_irqrestore(&data_lock, flags);
T
Tomi Valkeinen 已提交
1030

1031
out:
T
Tomi Valkeinen 已提交
1032
	mutex_unlock(&apply_lock);
1033 1034
}

1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053
static int dss_mgr_simple_check(struct omap_overlay_manager *mgr,
		const struct omap_overlay_manager_info *info)
{
	if (dss_has_feature(FEAT_ALPHA_FIXED_ZORDER)) {
		/*
		 * OMAP3 supports only graphics source transparency color key
		 * and alpha blending simultaneously. See TRM 15.4.2.4.2.2
		 * Alpha Mode.
		 */
		if (info->partial_alpha_enabled && info->trans_enabled
			&& info->trans_key_type != OMAP_DSS_COLOR_KEY_GFX_DST) {
			DSSERR("check_manager: illegal transparency key\n");
			return -EINVAL;
		}
	}

	return 0;
}

1054 1055 1056
int dss_mgr_set_info(struct omap_overlay_manager *mgr,
		struct omap_overlay_manager_info *info)
{
1057
	struct mgr_priv_data *mp = get_mgr_priv(mgr);
1058
	unsigned long flags;
1059 1060 1061 1062 1063
	int r;

	r = dss_mgr_simple_check(mgr, info);
	if (r)
		return r;
1064 1065 1066

	spin_lock_irqsave(&data_lock, flags);

1067 1068
	mp->user_info = *info;
	mp->user_info_dirty = true;
1069

1070 1071
	spin_unlock_irqrestore(&data_lock, flags);

1072 1073 1074 1075 1076 1077
	return 0;
}

void dss_mgr_get_info(struct omap_overlay_manager *mgr,
		struct omap_overlay_manager_info *info)
{
1078
	struct mgr_priv_data *mp = get_mgr_priv(mgr);
1079 1080 1081 1082
	unsigned long flags;

	spin_lock_irqsave(&data_lock, flags);

1083
	*info = mp->user_info;
1084 1085

	spin_unlock_irqrestore(&data_lock, flags);
1086 1087 1088 1089 1090 1091 1092
}

int dss_mgr_set_device(struct omap_overlay_manager *mgr,
		struct omap_dss_device *dssdev)
{
	int r;

T
Tomi Valkeinen 已提交
1093 1094
	mutex_lock(&apply_lock);

1095 1096 1097
	if (dssdev->manager) {
		DSSERR("display '%s' already has a manager '%s'\n",
			       dssdev->name, dssdev->manager->name);
T
Tomi Valkeinen 已提交
1098 1099
		r = -EINVAL;
		goto err;
1100 1101 1102 1103 1104
	}

	if ((mgr->supported_displays & dssdev->type) == 0) {
		DSSERR("display '%s' does not support manager '%s'\n",
			       dssdev->name, mgr->name);
T
Tomi Valkeinen 已提交
1105 1106
		r = -EINVAL;
		goto err;
1107 1108 1109 1110 1111
	}

	dssdev->manager = mgr;
	mgr->device = dssdev;

T
Tomi Valkeinen 已提交
1112 1113
	mutex_unlock(&apply_lock);

1114
	return 0;
T
Tomi Valkeinen 已提交
1115 1116 1117
err:
	mutex_unlock(&apply_lock);
	return r;
1118 1119 1120 1121
}

int dss_mgr_unset_device(struct omap_overlay_manager *mgr)
{
T
Tomi Valkeinen 已提交
1122 1123 1124 1125
	int r;

	mutex_lock(&apply_lock);

1126 1127
	if (!mgr->device) {
		DSSERR("failed to unset display, display not set.\n");
T
Tomi Valkeinen 已提交
1128 1129
		r = -EINVAL;
		goto err;
1130 1131 1132 1133 1134 1135
	}

	/*
	 * Don't allow currently enabled displays to have the overlay manager
	 * pulled out from underneath them
	 */
T
Tomi Valkeinen 已提交
1136 1137 1138 1139
	if (mgr->device->state != OMAP_DSS_DISPLAY_DISABLED) {
		r = -EINVAL;
		goto err;
	}
1140 1141 1142 1143

	mgr->device->manager = NULL;
	mgr->device = NULL;

T
Tomi Valkeinen 已提交
1144 1145
	mutex_unlock(&apply_lock);

1146
	return 0;
T
Tomi Valkeinen 已提交
1147 1148 1149
err:
	mutex_unlock(&apply_lock);
	return r;
1150 1151 1152
}


1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187
static int dss_ovl_simple_check(struct omap_overlay *ovl,
		const struct omap_overlay_info *info)
{
	if (info->paddr == 0) {
		DSSERR("check_overlay: paddr cannot be 0\n");
		return -EINVAL;
	}

	if ((ovl->caps & OMAP_DSS_OVL_CAP_SCALE) == 0) {
		if (info->out_width != 0 && info->width != info->out_width) {
			DSSERR("check_overlay: overlay %d doesn't support "
					"scaling\n", ovl->id);
			return -EINVAL;
		}

		if (info->out_height != 0 && info->height != info->out_height) {
			DSSERR("check_overlay: overlay %d doesn't support "
					"scaling\n", ovl->id);
			return -EINVAL;
		}
	}

	if ((ovl->supported_modes & info->color_mode) == 0) {
		DSSERR("check_overlay: overlay %d doesn't support mode %d\n",
				ovl->id, info->color_mode);
		return -EINVAL;
	}

	if (info->zorder >= omap_dss_get_num_overlays()) {
		DSSERR("check_overlay: zorder %d too high\n", info->zorder);
		return -EINVAL;
	}

	return 0;
}
1188

1189 1190 1191
int dss_ovl_set_info(struct omap_overlay *ovl,
		struct omap_overlay_info *info)
{
1192
	struct ovl_priv_data *op = get_ovl_priv(ovl);
1193
	unsigned long flags;
1194 1195 1196 1197 1198
	int r;

	r = dss_ovl_simple_check(ovl, info);
	if (r)
		return r;
1199 1200 1201

	spin_lock_irqsave(&data_lock, flags);

1202 1203
	op->user_info = *info;
	op->user_info_dirty = true;
1204

1205 1206
	spin_unlock_irqrestore(&data_lock, flags);

1207 1208 1209 1210 1211 1212
	return 0;
}

void dss_ovl_get_info(struct omap_overlay *ovl,
		struct omap_overlay_info *info)
{
1213
	struct ovl_priv_data *op = get_ovl_priv(ovl);
1214 1215 1216 1217
	unsigned long flags;

	spin_lock_irqsave(&data_lock, flags);

1218
	*info = op->user_info;
1219 1220

	spin_unlock_irqrestore(&data_lock, flags);
1221 1222 1223 1224 1225
}

int dss_ovl_set_manager(struct omap_overlay *ovl,
		struct omap_overlay_manager *mgr)
{
1226 1227
	struct ovl_priv_data *op = get_ovl_priv(ovl);
	unsigned long flags;
T
Tomi Valkeinen 已提交
1228 1229
	int r;

1230 1231 1232
	if (!mgr)
		return -EINVAL;

T
Tomi Valkeinen 已提交
1233 1234
	mutex_lock(&apply_lock);

1235 1236 1237
	if (ovl->manager) {
		DSSERR("overlay '%s' already has a manager '%s'\n",
				ovl->name, ovl->manager->name);
T
Tomi Valkeinen 已提交
1238 1239
		r = -EINVAL;
		goto err;
1240 1241
	}

1242 1243 1244 1245
	spin_lock_irqsave(&data_lock, flags);

	if (op->enabled) {
		spin_unlock_irqrestore(&data_lock, flags);
1246
		DSSERR("overlay has to be disabled to change the manager\n");
T
Tomi Valkeinen 已提交
1247 1248
		r = -EINVAL;
		goto err;
1249 1250
	}

1251 1252 1253
	op->channel = mgr->id;
	op->extra_info_dirty = true;

1254 1255 1256
	ovl->manager = mgr;
	list_add_tail(&ovl->list, &mgr->overlays);

1257 1258
	spin_unlock_irqrestore(&data_lock, flags);

1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271
	/* XXX: When there is an overlay on a DSI manual update display, and
	 * the overlay is first disabled, then moved to tv, and enabled, we
	 * seem to get SYNC_LOST_DIGIT error.
	 *
	 * Waiting doesn't seem to help, but updating the manual update display
	 * after disabling the overlay seems to fix this. This hints that the
	 * overlay is perhaps somehow tied to the LCD output until the output
	 * is updated.
	 *
	 * Userspace workaround for this is to update the LCD after disabling
	 * the overlay, but before moving the overlay to TV.
	 */

T
Tomi Valkeinen 已提交
1272 1273
	mutex_unlock(&apply_lock);

1274
	return 0;
T
Tomi Valkeinen 已提交
1275 1276 1277
err:
	mutex_unlock(&apply_lock);
	return r;
1278 1279 1280 1281
}

int dss_ovl_unset_manager(struct omap_overlay *ovl)
{
1282 1283
	struct ovl_priv_data *op = get_ovl_priv(ovl);
	unsigned long flags;
T
Tomi Valkeinen 已提交
1284 1285 1286 1287
	int r;

	mutex_lock(&apply_lock);

1288 1289
	if (!ovl->manager) {
		DSSERR("failed to detach overlay: manager not set\n");
T
Tomi Valkeinen 已提交
1290 1291
		r = -EINVAL;
		goto err;
1292 1293
	}

1294 1295 1296 1297
	spin_lock_irqsave(&data_lock, flags);

	if (op->enabled) {
		spin_unlock_irqrestore(&data_lock, flags);
1298
		DSSERR("overlay has to be disabled to unset the manager\n");
T
Tomi Valkeinen 已提交
1299 1300
		r = -EINVAL;
		goto err;
1301 1302
	}

1303 1304
	op->channel = -1;

1305 1306 1307
	ovl->manager = NULL;
	list_del(&ovl->list);

1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340
	spin_unlock_irqrestore(&data_lock, flags);

	mutex_unlock(&apply_lock);

	return 0;
err:
	mutex_unlock(&apply_lock);
	return r;
}

bool dss_ovl_is_enabled(struct omap_overlay *ovl)
{
	struct ovl_priv_data *op = get_ovl_priv(ovl);
	unsigned long flags;
	bool e;

	spin_lock_irqsave(&data_lock, flags);

	e = op->enabled;

	spin_unlock_irqrestore(&data_lock, flags);

	return e;
}

int dss_ovl_enable(struct omap_overlay *ovl)
{
	struct ovl_priv_data *op = get_ovl_priv(ovl);
	unsigned long flags;
	int r;

	mutex_lock(&apply_lock);

1341 1342
	if (op->enabled) {
		r = 0;
1343
		goto err1;
1344 1345
	}

1346 1347
	if (ovl->manager == NULL || ovl->manager->device == NULL) {
		r = -EINVAL;
1348
		goto err1;
1349 1350 1351 1352
	}

	spin_lock_irqsave(&data_lock, flags);

1353 1354 1355 1356 1357 1358 1359 1360 1361
	op->enabled = true;
	r = dss_check_settings(ovl->manager, ovl->manager->device);
	op->enabled = false;
	if (r) {
		DSSERR("failed to enable overlay %d: check_settings failed\n",
				ovl->id);
		goto err2;
	}

1362
	dss_apply_ovl_enable(ovl, true);
1363

1364 1365
	dss_ovl_setup_fifo(ovl);

1366 1367
	dss_write_regs();

1368 1369 1370 1371 1372
	spin_unlock_irqrestore(&data_lock, flags);

	mutex_unlock(&apply_lock);

	return 0;
1373 1374 1375
err2:
	spin_unlock_irqrestore(&data_lock, flags);
err1:
1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387
	mutex_unlock(&apply_lock);
	return r;
}

int dss_ovl_disable(struct omap_overlay *ovl)
{
	struct ovl_priv_data *op = get_ovl_priv(ovl);
	unsigned long flags;
	int r;

	mutex_lock(&apply_lock);

1388 1389 1390 1391 1392
	if (!op->enabled) {
		r = 0;
		goto err;
	}

1393 1394 1395 1396 1397 1398 1399
	if (ovl->manager == NULL || ovl->manager->device == NULL) {
		r = -EINVAL;
		goto err;
	}

	spin_lock_irqsave(&data_lock, flags);

1400
	dss_apply_ovl_enable(ovl, false);
1401

1402 1403
	dss_write_regs();

1404 1405
	spin_unlock_irqrestore(&data_lock, flags);

T
Tomi Valkeinen 已提交
1406 1407
	mutex_unlock(&apply_lock);

1408
	return 0;
1409

T
Tomi Valkeinen 已提交
1410 1411 1412
err:
	mutex_unlock(&apply_lock);
	return r;
1413 1414
}