main.c 16.6 KB
Newer Older
S
Simon Horman 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34
/*
 * Copyright (C) 2017 Netronome Systems, Inc.
 *
 * This software is dual licensed under the GNU General License Version 2,
 * June 1991 as shown in the file COPYING in the top-level directory of this
 * source tree or the BSD 2-Clause License provided below.  You have the
 * option to license this software under the complete terms of either license.
 *
 * The BSD 2-Clause License:
 *
 *     Redistribution and use in source and binary forms, with or
 *     without modification, are permitted provided that the following
 *     conditions are met:
 *
 *      1. Redistributions of source code must retain the above
 *         copyright notice, this list of conditions and the following
 *         disclaimer.
 *
 *      2. Redistributions in binary form must reproduce the above
 *         copyright notice, this list of conditions and the following
 *         disclaimer in the documentation and/or other materials
 *         provided with the distribution.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
 * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
 * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

#include <linux/etherdevice.h>
35
#include <linux/lockdep.h>
S
Simon Horman 已提交
36 37
#include <linux/pci.h>
#include <linux/skbuff.h>
38
#include <linux/vmalloc.h>
S
Simon Horman 已提交
39 40 41
#include <net/devlink.h>
#include <net/dst_metadata.h>

42
#include "main.h"
S
Simon Horman 已提交
43
#include "../nfpcore/nfp_cpp.h"
44
#include "../nfpcore/nfp_nffw.h"
S
Simon Horman 已提交
45 46 47 48 49 50 51 52
#include "../nfpcore/nfp_nsp.h"
#include "../nfp_app.h"
#include "../nfp_main.h"
#include "../nfp_net.h"
#include "../nfp_net_repr.h"
#include "../nfp_port.h"
#include "./cmsg.h"

53 54
#define NFP_FLOWER_ALLOWED_VER 0x0001000000010000UL

S
Simon Horman 已提交
55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101
static const char *nfp_flower_extra_cap(struct nfp_app *app, struct nfp_net *nn)
{
	return "FLOWER";
}

static enum devlink_eswitch_mode eswitch_mode_get(struct nfp_app *app)
{
	return DEVLINK_ESWITCH_MODE_SWITCHDEV;
}

static enum nfp_repr_type
nfp_flower_repr_get_type_and_port(struct nfp_app *app, u32 port_id, u8 *port)
{
	switch (FIELD_GET(NFP_FLOWER_CMSG_PORT_TYPE, port_id)) {
	case NFP_FLOWER_CMSG_PORT_TYPE_PHYS_PORT:
		*port = FIELD_GET(NFP_FLOWER_CMSG_PORT_PHYS_PORT_NUM,
				  port_id);
		return NFP_REPR_TYPE_PHYS_PORT;

	case NFP_FLOWER_CMSG_PORT_TYPE_PCIE_PORT:
		*port = FIELD_GET(NFP_FLOWER_CMSG_PORT_VNIC, port_id);
		if (FIELD_GET(NFP_FLOWER_CMSG_PORT_VNIC_TYPE, port_id) ==
		    NFP_FLOWER_CMSG_PORT_VNIC_TYPE_PF)
			return NFP_REPR_TYPE_PF;
		else
			return NFP_REPR_TYPE_VF;
	}

	return NFP_FLOWER_CMSG_PORT_TYPE_UNSPEC;
}

static struct net_device *
nfp_flower_repr_get(struct nfp_app *app, u32 port_id)
{
	enum nfp_repr_type repr_type;
	struct nfp_reprs *reprs;
	u8 port = 0;

	repr_type = nfp_flower_repr_get_type_and_port(app, port_id, &port);

	reprs = rcu_dereference(app->reprs[repr_type]);
	if (!reprs)
		return NULL;

	if (port >= reprs->num_reprs)
		return NULL;

102
	return rcu_dereference(reprs->reprs[port]);
S
Simon Horman 已提交
103 104
}

105 106 107 108 109 110 111 112 113 114 115 116
static int
nfp_flower_reprs_reify(struct nfp_app *app, enum nfp_repr_type type,
		       bool exists)
{
	struct nfp_reprs *reprs;
	int i, err, count = 0;

	reprs = rcu_dereference_protected(app->reprs[type],
					  lockdep_is_held(&app->pf->lock));
	if (!reprs)
		return 0;

117 118 119 120 121 122
	for (i = 0; i < reprs->num_reprs; i++) {
		struct net_device *netdev;

		netdev = nfp_repr_get_locked(app, reprs, i);
		if (netdev) {
			struct nfp_repr *repr = netdev_priv(netdev);
123 124 125 126 127 128

			err = nfp_flower_cmsg_portreify(repr, exists);
			if (err)
				return err;
			count++;
		}
129
	}
130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154

	return count;
}

static int
nfp_flower_wait_repr_reify(struct nfp_app *app, atomic_t *replies, int tot_repl)
{
	struct nfp_flower_priv *priv = app->priv;
	int err;

	if (!tot_repl)
		return 0;

	lockdep_assert_held(&app->pf->lock);
	err = wait_event_interruptible_timeout(priv->reify_wait_queue,
					       atomic_read(replies) >= tot_repl,
					       msecs_to_jiffies(10));
	if (err <= 0) {
		nfp_warn(app->cpp, "Not all reprs responded to reify\n");
		return -EIO;
	}

	return 0;
}

155 156
static int
nfp_flower_repr_netdev_open(struct nfp_app *app, struct nfp_repr *repr)
S
Simon Horman 已提交
157 158 159
{
	int err;

160
	err = nfp_flower_cmsg_portmod(repr, true, repr->netdev->mtu, false);
S
Simon Horman 已提交
161 162 163
	if (err)
		return err;

164
	netif_tx_wake_all_queues(repr->netdev);
S
Simon Horman 已提交
165 166 167 168

	return 0;
}

169 170
static int
nfp_flower_repr_netdev_stop(struct nfp_app *app, struct nfp_repr *repr)
S
Simon Horman 已提交
171
{
172
	netif_tx_disable(repr->netdev);
S
Simon Horman 已提交
173

174
	return nfp_flower_cmsg_portmod(repr, false, repr->netdev->mtu, false);
S
Simon Horman 已提交
175 176
}

177 178 179 180 181 182 183 184 185 186 187 188 189 190 191
static int
nfp_flower_repr_netdev_init(struct nfp_app *app, struct net_device *netdev)
{
	return tc_setup_cb_egdev_register(netdev,
					  nfp_flower_setup_tc_egress_cb,
					  netdev_priv(netdev));
}

static void
nfp_flower_repr_netdev_clean(struct nfp_app *app, struct net_device *netdev)
{
	tc_setup_cb_egdev_unregister(netdev, nfp_flower_setup_tc_egress_cb,
				     netdev_priv(netdev));
}

192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209
static void
nfp_flower_repr_netdev_preclean(struct nfp_app *app, struct net_device *netdev)
{
	struct nfp_repr *repr = netdev_priv(netdev);
	struct nfp_flower_priv *priv = app->priv;
	atomic_t *replies = &priv->reify_replies;
	int err;

	atomic_set(replies, 0);
	err = nfp_flower_cmsg_portreify(repr, false);
	if (err) {
		nfp_warn(app->cpp, "Failed to notify firmware about repr destruction\n");
		return;
	}

	nfp_flower_wait_repr_reify(app, replies, 1);
}

210 211
static void nfp_flower_sriov_disable(struct nfp_app *app)
{
212 213 214 215 216
	struct nfp_flower_priv *priv = app->priv;

	if (!priv->nn)
		return;

217 218 219 220 221 222 223 224 225 226
	nfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_VF);
}

static int
nfp_flower_spawn_vnic_reprs(struct nfp_app *app,
			    enum nfp_flower_cmsg_port_vnic_type vnic_type,
			    enum nfp_repr_type repr_type, unsigned int cnt)
{
	u8 nfp_pcie = nfp_cppcore_pcie_unit(app->pf->cpp);
	struct nfp_flower_priv *priv = app->priv;
227
	atomic_t *replies = &priv->reify_replies;
228
	enum nfp_port_type port_type;
229
	struct nfp_reprs *reprs;
230
	int i, err, reify_cnt;
231 232
	const u8 queue = 0;

233 234 235
	port_type = repr_type == NFP_REPR_TYPE_PF ? NFP_PORT_PF_PORT :
						    NFP_PORT_VF_PORT;

236 237 238 239 240
	reprs = nfp_reprs_alloc(cnt);
	if (!reprs)
		return -ENOMEM;

	for (i = 0; i < cnt; i++) {
241
		struct net_device *repr;
242
		struct nfp_port *port;
243 244
		u32 port_id;

245 246
		repr = nfp_repr_alloc(app);
		if (!repr) {
247 248 249 250
			err = -ENOMEM;
			goto err_reprs_clean;
		}

251 252 253
		/* For now we only support 1 PF */
		WARN_ON(repr_type == NFP_REPR_TYPE_PF && i);

254
		port = nfp_port_alloc(app, port_type, repr);
255 256 257 258 259
		if (IS_ERR(port)) {
			err = PTR_ERR(port);
			nfp_repr_free(repr);
			goto err_reprs_clean;
		}
260 261
		if (repr_type == NFP_REPR_TYPE_PF) {
			port->pf_id = i;
262
			port->vnic = priv->nn->dp.ctrl_bar;
263
		} else {
264
			port->pf_id = 0;
265
			port->vf_id = i;
266 267
			port->vnic =
				app->pf->vf_cfg_mem + i * NFP_NET_CFG_BAR_SZ;
268 269
		}

270
		eth_hw_addr_random(repr);
271 272 273

		port_id = nfp_flower_cmsg_pcie_port(nfp_pcie, vnic_type,
						    i, queue);
274
		err = nfp_repr_init(app, repr,
275 276 277
				    port_id, port, priv->nn->dp.netdev);
		if (err) {
			nfp_port_free(port);
278
			nfp_repr_free(repr);
279
			goto err_reprs_clean;
280
		}
281

282
		RCU_INIT_POINTER(reprs->reprs[i], repr);
283 284
		nfp_info(app->cpp, "%s%d Representor(%s) created\n",
			 repr_type == NFP_REPR_TYPE_PF ? "PF" : "VF", i,
285
			 repr->name);
286 287
	}

288
	nfp_app_reprs_set(app, repr_type, reprs);
289

290 291 292 293 294 295 296 297 298 299 300 301
	atomic_set(replies, 0);
	reify_cnt = nfp_flower_reprs_reify(app, repr_type, true);
	if (reify_cnt < 0) {
		err = reify_cnt;
		nfp_warn(app->cpp, "Failed to notify firmware about repr creation\n");
		goto err_reprs_remove;
	}

	err = nfp_flower_wait_repr_reify(app, replies, reify_cnt);
	if (err)
		goto err_reprs_remove;

302
	return 0;
303 304
err_reprs_remove:
	reprs = nfp_app_reprs_set(app, repr_type, NULL);
305
err_reprs_clean:
306
	nfp_reprs_clean_and_free(app, reprs);
307 308 309 310 311
	return err;
}

static int nfp_flower_sriov_enable(struct nfp_app *app, int num_vfs)
{
312 313 314 315 316
	struct nfp_flower_priv *priv = app->priv;

	if (!priv->nn)
		return 0;

317 318 319 320 321 322 323
	return nfp_flower_spawn_vnic_reprs(app,
					   NFP_FLOWER_CMSG_PORT_VNIC_TYPE_VF,
					   NFP_REPR_TYPE_VF, num_vfs);
}

static int
nfp_flower_spawn_phy_reprs(struct nfp_app *app, struct nfp_flower_priv *priv)
S
Simon Horman 已提交
324 325
{
	struct nfp_eth_table *eth_tbl = app->pf->eth_tbl;
326
	atomic_t *replies = &priv->reify_replies;
327
	struct sk_buff *ctrl_skb;
328
	struct nfp_reprs *reprs;
329
	int err, reify_cnt;
S
Simon Horman 已提交
330 331
	unsigned int i;

332 333
	ctrl_skb = nfp_flower_cmsg_mac_repr_start(app, eth_tbl->count);
	if (!ctrl_skb)
S
Simon Horman 已提交
334 335
		return -ENOMEM;

336 337 338 339 340 341
	reprs = nfp_reprs_alloc(eth_tbl->max_index + 1);
	if (!reprs) {
		err = -ENOMEM;
		goto err_free_ctrl_skb;
	}

S
Simon Horman 已提交
342
	for (i = 0; i < eth_tbl->count; i++) {
343
		unsigned int phys_port = eth_tbl->ports[i].index;
344
		struct net_device *repr;
S
Simon Horman 已提交
345 346 347
		struct nfp_port *port;
		u32 cmsg_port_id;

348 349
		repr = nfp_repr_alloc(app);
		if (!repr) {
S
Simon Horman 已提交
350 351 352 353
			err = -ENOMEM;
			goto err_reprs_clean;
		}

354
		port = nfp_port_alloc(app, NFP_PORT_PHYS_PORT, repr);
S
Simon Horman 已提交
355 356
		if (IS_ERR(port)) {
			err = PTR_ERR(port);
357
			nfp_repr_free(repr);
S
Simon Horman 已提交
358 359 360 361 362
			goto err_reprs_clean;
		}
		err = nfp_port_init_phy_port(app->pf, app, port, i);
		if (err) {
			nfp_port_free(port);
363
			nfp_repr_free(repr);
S
Simon Horman 已提交
364 365 366
			goto err_reprs_clean;
		}

367
		SET_NETDEV_DEV(repr, &priv->nn->pdev->dev);
368
		nfp_net_get_mac_addr(app->pf, repr, port);
S
Simon Horman 已提交
369 370

		cmsg_port_id = nfp_flower_cmsg_phys_port(phys_port);
371
		err = nfp_repr_init(app, repr,
S
Simon Horman 已提交
372 373 374
				    cmsg_port_id, port, priv->nn->dp.netdev);
		if (err) {
			nfp_port_free(port);
375
			nfp_repr_free(repr);
S
Simon Horman 已提交
376 377 378
			goto err_reprs_clean;
		}

379 380 381 382 383
		nfp_flower_cmsg_mac_repr_add(ctrl_skb, i,
					     eth_tbl->ports[i].nbi,
					     eth_tbl->ports[i].base,
					     phys_port);

384
		RCU_INIT_POINTER(reprs->reprs[phys_port], repr);
S
Simon Horman 已提交
385
		nfp_info(app->cpp, "Phys Port %d Representor(%s) created\n",
386
			 phys_port, repr->name);
S
Simon Horman 已提交
387 388
	}

389
	nfp_app_reprs_set(app, NFP_REPR_TYPE_PHYS_PORT, reprs);
S
Simon Horman 已提交
390

391
	/* The REIFY/MAC_REPR control messages should be sent after the MAC
392 393 394 395 396 397
	 * representors are registered using nfp_app_reprs_set().  This is
	 * because the firmware may respond with control messages for the
	 * MAC representors, f.e. to provide the driver with information
	 * about their state, and without registration the driver will drop
	 * any such messages.
	 */
398 399 400 401 402 403 404 405 406 407 408 409
	atomic_set(replies, 0);
	reify_cnt = nfp_flower_reprs_reify(app, NFP_REPR_TYPE_PHYS_PORT, true);
	if (reify_cnt < 0) {
		err = reify_cnt;
		nfp_warn(app->cpp, "Failed to notify firmware about repr creation\n");
		goto err_reprs_remove;
	}

	err = nfp_flower_wait_repr_reify(app, replies, reify_cnt);
	if (err)
		goto err_reprs_remove;

410 411
	nfp_ctrl_tx(app->ctrl, ctrl_skb);

S
Simon Horman 已提交
412
	return 0;
413 414
err_reprs_remove:
	reprs = nfp_app_reprs_set(app, NFP_REPR_TYPE_PHYS_PORT, NULL);
S
Simon Horman 已提交
415
err_reprs_clean:
416
	nfp_reprs_clean_and_free(app, reprs);
417 418
err_free_ctrl_skb:
	kfree_skb(ctrl_skb);
S
Simon Horman 已提交
419 420 421
	return err;
}

422 423
static int nfp_flower_vnic_alloc(struct nfp_app *app, struct nfp_net *nn,
				 unsigned int id)
S
Simon Horman 已提交
424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439
{
	if (id > 0) {
		nfp_warn(app->cpp, "FlowerNIC doesn't support more than one data vNIC\n");
		goto err_invalid_port;
	}

	eth_hw_addr_random(nn->dp.netdev);
	netif_keep_dst(nn->dp.netdev);

	return 0;

err_invalid_port:
	nn->port = nfp_port_alloc(app, NFP_PORT_INVALID, nn->dp.netdev);
	return PTR_ERR_OR_ZERO(nn->port);
}

440 441 442 443
static void nfp_flower_vnic_clean(struct nfp_app *app, struct nfp_net *nn)
{
	struct nfp_flower_priv *priv = app->priv;

444 445 446 447 448
	if (app->pf->num_vfs)
		nfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_VF);
	nfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_PF);
	nfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_PHYS_PORT);

449 450 451 452 453 454
	priv->nn = NULL;
}

static int nfp_flower_vnic_init(struct nfp_app *app, struct nfp_net *nn)
{
	struct nfp_flower_priv *priv = app->priv;
455
	int err;
456 457 458

	priv->nn = nn;

459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477
	err = nfp_flower_spawn_phy_reprs(app, app->priv);
	if (err)
		goto err_clear_nn;

	err = nfp_flower_spawn_vnic_reprs(app,
					  NFP_FLOWER_CMSG_PORT_VNIC_TYPE_PF,
					  NFP_REPR_TYPE_PF, 1);
	if (err)
		goto err_destroy_reprs_phy;

	if (app->pf->num_vfs) {
		err = nfp_flower_spawn_vnic_reprs(app,
						  NFP_FLOWER_CMSG_PORT_VNIC_TYPE_VF,
						  NFP_REPR_TYPE_VF,
						  app->pf->num_vfs);
		if (err)
			goto err_destroy_reprs_pf;
	}

478
	return 0;
479 480 481 482 483 484 485 486

err_destroy_reprs_pf:
	nfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_PF);
err_destroy_reprs_phy:
	nfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_PHYS_PORT);
err_clear_nn:
	priv->nn = NULL;
	return err;
487 488
}

S
Simon Horman 已提交
489 490 491
static int nfp_flower_init(struct nfp_app *app)
{
	const struct nfp_pf *pf = app->pf;
492
	struct nfp_flower_priv *app_priv;
493
	u64 version, features;
494
	int err;
S
Simon Horman 已提交
495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510

	if (!pf->eth_tbl) {
		nfp_warn(app->cpp, "FlowerNIC requires eth table\n");
		return -EINVAL;
	}

	if (!pf->mac_stats_bar) {
		nfp_warn(app->cpp, "FlowerNIC requires mac_stats BAR\n");
		return -EINVAL;
	}

	if (!pf->vf_cfg_bar) {
		nfp_warn(app->cpp, "FlowerNIC requires vf_cfg BAR\n");
		return -EINVAL;
	}

511 512 513 514 515 516 517 518 519 520 521 522
	version = nfp_rtsym_read_le(app->pf->rtbl, "hw_flower_version", &err);
	if (err) {
		nfp_warn(app->cpp, "FlowerNIC requires hw_flower_version memory symbol\n");
		return err;
	}

	/* We need to ensure hardware has enough flower capabilities. */
	if (version != NFP_FLOWER_ALLOWED_VER) {
		nfp_warn(app->cpp, "FlowerNIC: unsupported firmware version\n");
		return -EINVAL;
	}

523 524
	app_priv = vzalloc(sizeof(struct nfp_flower_priv));
	if (!app_priv)
525 526
		return -ENOMEM;

527
	app->priv = app_priv;
528
	app_priv->app = app;
529 530
	skb_queue_head_init(&app_priv->cmsg_skbs_high);
	skb_queue_head_init(&app_priv->cmsg_skbs_low);
531
	INIT_WORK(&app_priv->cmsg_work, nfp_flower_cmsg_process_rx);
532
	init_waitqueue_head(&app_priv->reify_wait_queue);
533

534 535 536
	init_waitqueue_head(&app_priv->mtu_conf.wait_q);
	spin_lock_init(&app_priv->mtu_conf.lock);

537 538 539 540
	err = nfp_flower_metadata_init(app);
	if (err)
		goto err_free_app_priv;

541 542 543 544 545 546 547 548
	/* Extract the extra features supported by the firmware. */
	features = nfp_rtsym_read_le(app->pf->rtbl,
				     "_abi_flower_extra_features", &err);
	if (err)
		app_priv->flower_ext_feats = 0;
	else
		app_priv->flower_ext_feats = features;

S
Simon Horman 已提交
549
	return 0;
550 551 552 553

err_free_app_priv:
	vfree(app->priv);
	return err;
S
Simon Horman 已提交
554 555
}

556 557
static void nfp_flower_clean(struct nfp_app *app)
{
558 559
	struct nfp_flower_priv *app_priv = app->priv;

560 561
	skb_queue_purge(&app_priv->cmsg_skbs_high);
	skb_queue_purge(&app_priv->cmsg_skbs_low);
562 563
	flush_work(&app_priv->cmsg_work);

564
	nfp_flower_metadata_cleanup(app);
565
	vfree(app->priv);
566 567 568
	app->priv = NULL;
}

569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627
static bool nfp_flower_check_ack(struct nfp_flower_priv *app_priv)
{
	bool ret;

	spin_lock_bh(&app_priv->mtu_conf.lock);
	ret = app_priv->mtu_conf.ack;
	spin_unlock_bh(&app_priv->mtu_conf.lock);

	return ret;
}

static int
nfp_flower_repr_change_mtu(struct nfp_app *app, struct net_device *netdev,
			   int new_mtu)
{
	struct nfp_flower_priv *app_priv = app->priv;
	struct nfp_repr *repr = netdev_priv(netdev);
	int err, ack;

	/* Only need to config FW for physical port MTU change. */
	if (repr->port->type != NFP_PORT_PHYS_PORT)
		return 0;

	if (!(app_priv->flower_ext_feats & NFP_FL_NBI_MTU_SETTING)) {
		nfp_err(app->cpp, "Physical port MTU setting not supported\n");
		return -EINVAL;
	}

	spin_lock_bh(&app_priv->mtu_conf.lock);
	app_priv->mtu_conf.ack = false;
	app_priv->mtu_conf.requested_val = new_mtu;
	app_priv->mtu_conf.portnum = repr->dst->u.port_info.port_id;
	spin_unlock_bh(&app_priv->mtu_conf.lock);

	err = nfp_flower_cmsg_portmod(repr, netif_carrier_ok(netdev), new_mtu,
				      true);
	if (err) {
		spin_lock_bh(&app_priv->mtu_conf.lock);
		app_priv->mtu_conf.requested_val = 0;
		spin_unlock_bh(&app_priv->mtu_conf.lock);
		return err;
	}

	/* Wait for fw to ack the change. */
	ack = wait_event_timeout(app_priv->mtu_conf.wait_q,
				 nfp_flower_check_ack(app_priv),
				 msecs_to_jiffies(10));

	if (!ack) {
		spin_lock_bh(&app_priv->mtu_conf.lock);
		app_priv->mtu_conf.requested_val = 0;
		spin_unlock_bh(&app_priv->mtu_conf.lock);
		nfp_warn(app->cpp, "MTU change not verified with fw\n");
		return -EIO;
	}

	return 0;
}

628 629 630 631 632 633 634 635 636 637
static int nfp_flower_start(struct nfp_app *app)
{
	return nfp_tunnel_config_start(app);
}

static void nfp_flower_stop(struct nfp_app *app)
{
	nfp_tunnel_config_stop(app);
}

S
Simon Horman 已提交
638 639 640
const struct nfp_app_type app_flower = {
	.id		= NFP_APP_FLOWER_NIC,
	.name		= "flower",
641 642

	.ctrl_cap_mask	= ~0U,
S
Simon Horman 已提交
643 644 645 646 647
	.ctrl_has_meta	= true,

	.extra_cap	= nfp_flower_extra_cap,

	.init		= nfp_flower_init,
648
	.clean		= nfp_flower_clean,
S
Simon Horman 已提交
649

650 651
	.repr_change_mtu  = nfp_flower_repr_change_mtu,

652
	.vnic_alloc	= nfp_flower_vnic_alloc,
S
Simon Horman 已提交
653
	.vnic_init	= nfp_flower_vnic_init,
654
	.vnic_clean	= nfp_flower_vnic_clean,
S
Simon Horman 已提交
655

656
	.repr_init	= nfp_flower_repr_netdev_init,
657
	.repr_preclean	= nfp_flower_repr_netdev_preclean,
658 659
	.repr_clean	= nfp_flower_repr_netdev_clean,

660 661 662
	.repr_open	= nfp_flower_repr_netdev_open,
	.repr_stop	= nfp_flower_repr_netdev_stop,

663 664 665
	.start		= nfp_flower_start,
	.stop		= nfp_flower_stop,

S
Simon Horman 已提交
666 667
	.ctrl_msg_rx	= nfp_flower_cmsg_rx,

668 669 670
	.sriov_enable	= nfp_flower_sriov_enable,
	.sriov_disable	= nfp_flower_sriov_disable,

S
Simon Horman 已提交
671 672
	.eswitch_mode_get  = eswitch_mode_get,
	.repr_get	= nfp_flower_repr_get,
673 674

	.setup_tc	= nfp_flower_setup_tc,
S
Simon Horman 已提交
675
};