PULL_REQUEST_TEMPLATE.md 1.6 KB
Newer Older
B
Bernard Xiong 已提交
1
### Summary of this Pull Request (PR) 拉取/合并请求的简述  
P
panrunyu 已提交
2

B
Bernard Xiong 已提交
3
**Add description here.** **请在这里加入描述**
P
panrunyu 已提交
4

B
Bernard Xiong 已提交
5
### Intent for your PR 拉取/合并请求的目的  
P
panrunyu 已提交
6

P
panrunyu 已提交
7
Choose one (Mandatory): 必须选择一项  
P
panrunyu 已提交
8

B
Bernard Xiong 已提交
9 10
- [ ] This PR is for a code-review and is intended to get feedback 本拉取/合并请求是一个草稿版本  
- [ ] This PR is mature, and ready to be integrated into the repo 本拉取/合并请求是一个成熟版本  
P
panrunyu 已提交
11 12 13

### Reviewers (Mandatory): 代码审阅者(必须指定)

B
Bernard Xiong 已提交
14
(@<github.com username(s)> Ex: @user1, @user2)  
P
panrunyu 已提交
15 16

### Code Quality: 代码质量  
B
Bernard Xiong 已提交
17

P
panrunyu 已提交
18
As part of this pull request, I've considered the following:  
B
Bernard Xiong 已提交
19 20 21 22 23 24 25 26
我在这个拉取/合并请求中已经考虑了:

- [ ] Already check the difference between PR and old code 已经仔细查看过代码改动的对比
- [ ] Style guide is adhered to, including spacing, naming and other style 代码风格正确,包括缩进空格,命名及其他风格
- [ ] All redundant code is removed and cleaned up 没有垃圾代码,代码尽量精简,不包含`#if 0`代码,不包含已经被注释了的代码
- [ ] All modifications are justified and not affect other components or BSP 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP
- [ ] I've commented appropriately where code is tricky 对难懂代码均提供对应的注释
- [ ] Code in this PR is of high quality 本拉取/合并请求代码是高质量的
P
panrunyu 已提交
27 28 29 30

### Testing:代码测试

I've tested the code using the following test programs (provide list here):  
B
Bernard Xiong 已提交
31
我已经在如下场合跑过对应的测试:  
P
panrunyu 已提交
32 33 34 35

- [ ] application 1
- [ ] application 2
- [ ] ...(add others here)