• M
    qom: Put name parameter before value / visitor parameter · 5325cc34
    Markus Armbruster 提交于
    The object_property_set_FOO() setters take property name and value in
    an unusual order:
    
        void object_property_set_FOO(Object *obj, FOO_TYPE value,
                                     const char *name, Error **errp)
    
    Having to pass value before name feels grating.  Swap them.
    
    Same for object_property_set(), object_property_get(), and
    object_property_parse().
    
    Convert callers with this Coccinelle script:
    
        @@
        identifier fun = {
            object_property_get, object_property_parse, object_property_set_str,
            object_property_set_link, object_property_set_bool,
            object_property_set_int, object_property_set_uint, object_property_set,
            object_property_set_qobject
        };
        expression obj, v, name, errp;
        @@
        -    fun(obj, v, name, errp)
        +    fun(obj, name, v, errp)
    
    Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
    message "no position information".  Convert that one manually.
    
    Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
    ARMSSE being used both as typedef and function-like macro there.
    Convert manually.
    
    Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
    by RXCPU being used both as typedef and function-like macro there.
    Convert manually.  The other files using RXCPU that way don't need
    conversion.
    Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: NEric Blake <eblake@redhat.com>
    Reviewed-by: NVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Message-Id: <20200707160613.848843-27-armbru@redhat.com>
    [Straightforwad conflict with commit 2336172d "audio: set default
    value for pcspk.iobase property" resolved]
    5325cc34
pc_q35.c 19.1 KB