Support search with default params (#24516)

Signed-off-by: Ncai.zhang <cai.zhang@zilliz.com>

internal/core/src/index/VectorDiskIndex.cpp

@@ -152,13 +152,7 @@ VectorDiskAnnIndex<T>::Query(const DatasetPtr dataset, const SearchInfo& search_
 
     // set search list
     auto search_list_size = GetValueFromConfig<uint32_t>(search_info.search_params_, DISK_ANN_QUERY_LIST);
-    AssertInfo(search_list_size.has_value(), "param " + std::string(DISK_ANN_QUERY_LIST) + "is empty");
-    query_config.search_list_size = search_list_size.value();
-
-    AssertInfo(query_config.search_list_size >= topk, "search_list should be greater than or equal to topk");
-    AssertInfo(query_config.search_list_size <= std::max(uint32_t(topk * 10), uint32_t(kSearchListMaxValue1)) &&
-                   query_config.search_list_size <= uint32_t(kSearchListMaxValue2),
-               "search_list should be less than max(topk*10, 200) and less than 65535");
+    query_config.search_list_size = search_list_size.has_value() ? search_list_size.value() : 0;
 
     // set beamwidth
     query_config.beamwidth = search_beamwidth_;

internal/core/src/index/VectorMemIndex.cpp

@@ -205,7 +205,7 @@ VectorMemIndex::parse_config(Config& config) {
     CheckParameter<int>(config, knowhere::indexparam::NBITS, stoi_closure, std::nullopt);
 
     /************************** PQ Params *****************************/
-    CheckParameter<int>(config, knowhere::indexparam::PQ_M, stoi_closure, std::nullopt);
+    //    CheckParameter<int>(config, knowhere::indexparam::PQ_M, stoi_closure, std::nullopt);
 
     /************************** HNSW Params *****************************/
     CheckParameter<int>(config, knowhere::indexparam::EFCONSTRUCTION, stoi_closure, std::nullopt);

internal/core/thirdparty/knowhere/CMakeLists.txt

@@ -11,14 +11,14 @@
 # or implied. See the License for the specific language governing permissions and limitations under the License.
 #-------------------------------------------------------------------------------
 
-set( KNOWHERE_VERSION v1.3.14 )
-set( KNOWHERE_SOURCE_MD5 "5a6200d57bfd3d525f4988ee8f5b412e" )
+set(KNOWHERE_VERSION v1.3.15)
+set(KNOWHERE_SOURCE_MD5 "e7f0d153d5f60dc95167820d7bd2e478")
 
-if ( DEFINED ENV{MILVUS_KNOWHERE_URL} )
-    set( KNOWHERE_SOURCE_URL "$ENV{MILVUS_KNOWHERE_URL}" )
+if (DEFINED ENV{MILVUS_KNOWHERE_URL})
+    set(KNOWHERE_SOURCE_URL "$ENV{MILVUS_KNOWHERE_URL}")
 else ()
-    set( KNOWHERE_SOURCE_URL
-        "https://github.com/milvus-io/knowhere/archive/refs/tags/${KNOWHERE_VERSION}.tar.gz" )
+    set(KNOWHERE_SOURCE_URL
+            "https://github.com/milvus-io/knowhere/archive/refs/tags/${KNOWHERE_VERSION}.tar.gz")
 endif ()
 
 macro(build_knowhere)

internal/proxy/task_search.go

@@ -150,7 +150,7 @@ func parseSearchInfo(searchParamsPair []*commonpb.KeyValuePair) (*planpb.QueryIn
 	}
 	searchParamStr, err := funcutil.GetAttrByKeyFromRepeatedKV(SearchParamsKey, searchParamsPair)
 	if err != nil {
-		return nil, 0, err
+		searchParamStr = ""
 	}
 	return &planpb.QueryInfo{
 		Topk:         queryTopK,

internal/proxy/task_search_test.go

@@ -1922,6 +1922,7 @@ func TestSearchTask_ErrExecute(t *testing.T) {
 }
 
 func TestTaskSearch_parseQueryInfo(t *testing.T) {
+	Params.InitOnce()
 	t.Run("parseSearchInfo no error", func(t *testing.T) {
 		var targetOffset int64 = 200
 
@@ -2007,7 +2008,7 @@ func TestTaskSearch_parseQueryInfo(t *testing.T) {
 			{"Invalid_topk_65536", spInvalidTopk65536},
 			{"Invalid_topk_plus_offset", spInvalidTopkPlusOffset},
 			{"No_Metric_type", spNoMetricType},
-			{"No_search_params", spNoSearchParams},
+			//{"No_search_params", spNoSearchParams},
 			{"Invalid_round_decimal", spInvalidRoundDecimal},
 			{"Invalid_round_decimal_1000", spInvalidRoundDecimal2},
 			{"Invalid_offset_not_int", spInvalidOffsetNoInt},