未验证 提交 e8b1b564 编写于 作者: D dragondriver 提交者: GitHub

Refine log of DescribeCollection (#12619)

Signed-off-by: Ndragondriver <jiquan.long@zilliz.com>
上级 a2ee8298
...@@ -545,6 +545,11 @@ func (node *Proxy) DescribeCollection(ctx context.Context, request *milvuspb.Des ...@@ -545,6 +545,11 @@ func (node *Proxy) DescribeCollection(ctx context.Context, request *milvuspb.Des
Status: unhealthyStatus(), Status: unhealthyStatus(),
}, nil }, nil
} }
sp, ctx := trace.StartSpanFromContextWithOperationName(ctx, "Proxy-Insert")
defer sp.Finish()
traceID, _, _ := trace.InfoFromSpan(sp)
dct := &describeCollectionTask{ dct := &describeCollectionTask{
ctx: ctx, ctx: ctx,
Condition: NewTaskCondition(ctx), Condition: NewTaskCondition(ctx),
...@@ -552,12 +557,20 @@ func (node *Proxy) DescribeCollection(ctx context.Context, request *milvuspb.Des ...@@ -552,12 +557,20 @@ func (node *Proxy) DescribeCollection(ctx context.Context, request *milvuspb.Des
rootCoord: node.rootCoord, rootCoord: node.rootCoord,
} }
log.Debug("DescribeCollection enqueue", log.Debug("DescribeCollection received",
zap.String("traceID", traceID),
zap.String("role", Params.RoleName), zap.String("role", Params.RoleName),
zap.String("db", request.DbName), zap.String("db", request.DbName),
zap.String("collection", request.CollectionName)) zap.String("collection", request.CollectionName))
err := node.sched.ddQueue.Enqueue(dct)
if err != nil { if err := node.sched.ddQueue.Enqueue(dct); err != nil {
log.Warn("DescribeCollection failed to enqueue",
zap.Error(err),
zap.String("traceID", traceID),
zap.String("role", Params.RoleName),
zap.String("db", request.DbName),
zap.String("collection", request.CollectionName))
return &milvuspb.DescribeCollectionResponse{ return &milvuspb.DescribeCollectionResponse{
Status: &commonpb.Status{ Status: &commonpb.Status{
ErrorCode: commonpb.ErrorCode_UnexpectedError, ErrorCode: commonpb.ErrorCode_UnexpectedError,
...@@ -566,24 +579,26 @@ func (node *Proxy) DescribeCollection(ctx context.Context, request *milvuspb.Des ...@@ -566,24 +579,26 @@ func (node *Proxy) DescribeCollection(ctx context.Context, request *milvuspb.Des
}, nil }, nil
} }
log.Debug("DescribeCollection", log.Debug("DescribeCollection enqueued",
zap.String("traceID", traceID),
zap.String("role", Params.RoleName), zap.String("role", Params.RoleName),
zap.Int64("msgID", request.Base.MsgID), zap.Int64("MsgID", dct.ID()),
zap.Uint64("timestamp", request.Base.Timestamp), zap.Uint64("BeginTS", dct.BeginTs()),
zap.Uint64("EndTS", dct.EndTs()),
zap.String("db", request.DbName), zap.String("db", request.DbName),
zap.String("collection", request.CollectionName)) zap.String("collection", request.CollectionName))
defer func() {
log.Debug("DescribeCollection Done", if err := dct.WaitToFinish(); err != nil {
log.Warn("DescribeCollection failed to WaitToFinish",
zap.Error(err), zap.Error(err),
zap.String("traceID", traceID),
zap.String("role", Params.RoleName), zap.String("role", Params.RoleName),
zap.Int64("msgID", request.Base.MsgID), zap.Int64("MsgID", dct.ID()),
zap.Uint64("timestamp", request.Base.Timestamp), zap.Uint64("BeginTS", dct.BeginTs()),
zap.Uint64("EndTS", dct.EndTs()),
zap.String("db", request.DbName), zap.String("db", request.DbName),
zap.String("collection", request.CollectionName)) zap.String("collection", request.CollectionName))
}()
err = dct.WaitToFinish()
if err != nil {
return &milvuspb.DescribeCollectionResponse{ return &milvuspb.DescribeCollectionResponse{
Status: &commonpb.Status{ Status: &commonpb.Status{
ErrorCode: commonpb.ErrorCode_UnexpectedError, ErrorCode: commonpb.ErrorCode_UnexpectedError,
...@@ -592,6 +607,15 @@ func (node *Proxy) DescribeCollection(ctx context.Context, request *milvuspb.Des ...@@ -592,6 +607,15 @@ func (node *Proxy) DescribeCollection(ctx context.Context, request *milvuspb.Des
}, nil }, nil
} }
log.Debug("DescribeCollection done",
zap.String("traceID", traceID),
zap.String("role", Params.RoleName),
zap.Int64("MsgID", dct.ID()),
zap.Uint64("BeginTS", dct.BeginTs()),
zap.Uint64("EndTS", dct.EndTs()),
zap.String("db", request.DbName),
zap.String("collection", request.CollectionName))
return dct.result, nil return dct.result, nil
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册