Forbid deleting entities by non-pk field (#21459) (#21472)

Signed-off-by: Nlongjiquan <jiquan.long@zilliz.com>

internal/proxy/task_delete.go

@@ -122,6 +122,10 @@ func getPrimaryKeysFromExpr(schema *schemapb.CollectionSchema, expr string) (res
 		return res, 0, fmt.Errorf("invalid plan node type, only pk in [1, 2] supported")
 	}
 
+	if !termExpr.TermExpr.GetColumnInfo().GetIsPrimaryKey() {
+		return res, 0, fmt.Errorf("invalid expression, we only support to delete by pk, expr: %s", expr)
+	}
+
 	res = &schemapb.IDs{}
 	rowNum = int64(len(termExpr.TermExpr.Values))
 	switch termExpr.TermExpr.ColumnInfo.GetDataType() {

internal/proxy/task_delete_test.go

+package proxy
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+
+	"github.com/milvus-io/milvus-proto/go-api/schemapb"
+	"github.com/milvus-io/milvus/internal/common"
+)
+
+func Test_getPrimaryKeysFromExpr(t *testing.T) {
+	t.Run("delete on non-pk field", func(t *testing.T) {
+		schema := &schemapb.CollectionSchema{
+			Name:        "test_delete",
+			Description: "",
+			AutoID:      false,
+			Fields: []*schemapb.FieldSchema{
+				{
+					FieldID:      common.StartOfUserFieldID,
+					Name:         "pk",
+					IsPrimaryKey: true,
+					DataType:     schemapb.DataType_Int64,
+				},
+				{
+					FieldID:      common.StartOfUserFieldID + 1,
+					Name:         "non_pk",
+					IsPrimaryKey: false,
+					DataType:     schemapb.DataType_Int64,
+				},
+			},
+		}
+
+		expr := "non_pk in [1, 2, 3]"
+
+		_, _, err := getPrimaryKeysFromExpr(schema, expr)
+		assert.Error(t, err)
+	})
+}