未验证 提交 d13ca544 编写于 作者: S SimFG 提交者: GitHub

Change the default gracefulStopTimeout and only warn when fail to refresh policy cache (#26450)

Signed-off-by: NSimFG <bang.fu@zilliz.com>
上级 44fc9069
...@@ -290,7 +290,6 @@ queryNode: ...@@ -290,7 +290,6 @@ queryNode:
enableCrossUserGrouping: false # false by default Enable Cross user grouping when using user-task-polling policy. (close it if task of any user can not merge others). enableCrossUserGrouping: false # false by default Enable Cross user grouping when using user-task-polling policy. (close it if task of any user can not merge others).
maxPendingTaskPerUser: 1024 # 50 by default, max pending task in scheduler per user. maxPendingTaskPerUser: 1024 # 50 by default, max pending task in scheduler per user.
gracefulStopTimeout: 30
port: 21123 port: 21123
grpc: grpc:
serverMaxSendSize: 536870912 serverMaxSendSize: 536870912
...@@ -312,7 +311,6 @@ indexNode: ...@@ -312,7 +311,6 @@ indexNode:
buildParallel: 1 buildParallel: 1
enableDisk: true # enable index node build disk vector index enableDisk: true # enable index node build disk vector index
maxDiskUsagePercentage: 95 maxDiskUsagePercentage: 95
gracefulStopTimeout: 30
port: 21121 port: 21121
grpc: grpc:
serverMaxSendSize: 536870912 serverMaxSendSize: 536870912
...@@ -467,7 +465,7 @@ common: ...@@ -467,7 +465,7 @@ common:
LoadNumThreadRatio: 8 LoadNumThreadRatio: 8
BeamWidthRatio: 4 BeamWidthRatio: 4
gracefulTime: 5000 # milliseconds. it represents the interval (in ms) by which the request arrival time needs to be subtracted in the case of Bounded Consistency. gracefulTime: 5000 # milliseconds. it represents the interval (in ms) by which the request arrival time needs to be subtracted in the case of Bounded Consistency.
gracefulStopTimeout: 30 # seconds. it will force quit the server if the graceful stop process is not completed during this time. gracefulStopTimeout: 1800 # seconds. it will force quit the server if the graceful stop process is not completed during this time.
storageType: minio # please adjust in embedded Milvus: local storageType: minio # please adjust in embedded Milvus: local
# Default value: auto # Default value: auto
# Valid values: [auto, avx512, avx2, avx, sse4_2] # Valid values: [auto, avx512, avx2, avx, sse4_2]
......
...@@ -642,12 +642,12 @@ func (c *Core) startInternal() error { ...@@ -642,12 +642,12 @@ func (c *Core) startInternal() error {
if err := c.proxyClientManager.RefreshPolicyInfoCache(c.ctx, &proxypb.RefreshPolicyInfoCacheRequest{ if err := c.proxyClientManager.RefreshPolicyInfoCache(c.ctx, &proxypb.RefreshPolicyInfoCacheRequest{
OpType: int32(typeutil.CacheRefresh), OpType: int32(typeutil.CacheRefresh),
}); err != nil { }); err != nil {
log.Warn("fail to refresh policy info cache", zap.Error(err)) log.Info("fail to refresh policy info cache", zap.Error(err))
return err return err
} }
return nil return nil
}, retry.Attempts(100), retry.Sleep(time.Second)); err != nil { }, retry.Attempts(100), retry.Sleep(time.Second)); err != nil {
log.Panic("fail to refresh policy info cache", zap.Error(err)) log.Warn("fail to refresh policy info cache", zap.Error(err))
} }
}() }()
......
...@@ -35,7 +35,7 @@ const ( ...@@ -35,7 +35,7 @@ const (
// DefaultIndexSliceSize defines the default slice size of index file when serializing. // DefaultIndexSliceSize defines the default slice size of index file when serializing.
DefaultIndexSliceSize = 16 DefaultIndexSliceSize = 16
DefaultGracefulTime = 5000 // ms DefaultGracefulTime = 5000 // ms
DefaultGracefulStopTimeout = 30 // s DefaultGracefulStopTimeout = 1800 // s
DefaultHighPriorityThreadCoreCoefficient = 100 DefaultHighPriorityThreadCoreCoefficient = 100
DefaultMiddlePriorityThreadCoreCoefficient = 50 DefaultMiddlePriorityThreadCoreCoefficient = 50
DefaultLowPriorityThreadCoreCoefficient = 10 DefaultLowPriorityThreadCoreCoefficient = 10
...@@ -475,7 +475,7 @@ This configuration is only used by querynode and indexnode, it selects CPU instr ...@@ -475,7 +475,7 @@ This configuration is only used by querynode and indexnode, it selects CPU instr
p.GracefulStopTimeout = ParamItem{ p.GracefulStopTimeout = ParamItem{
Key: "common.gracefulStopTimeout", Key: "common.gracefulStopTimeout",
Version: "2.2.1", Version: "2.2.1",
DefaultValue: "30", DefaultValue: strconv.Itoa(DefaultGracefulStopTimeout),
Doc: "seconds. it will force quit the server if the graceful stop process is not completed during this time.", Doc: "seconds. it will force quit the server if the graceful stop process is not completed during this time.",
Export: true, Export: true,
} }
......
...@@ -484,6 +484,7 @@ func DefaultParams() map[string]string { ...@@ -484,6 +484,7 @@ func DefaultParams() map[string]string {
params.LocalStorageCfg.Path.Key: path.Join("/tmp", testPath), params.LocalStorageCfg.Path.Key: path.Join("/tmp", testPath),
params.CommonCfg.StorageType.Key: "local", params.CommonCfg.StorageType.Key: "local",
params.DataNodeCfg.MemoryForceSyncEnable.Key: "false", // local execution will print too many logs params.DataNodeCfg.MemoryForceSyncEnable.Key: "false", // local execution will print too many logs
params.CommonCfg.GracefulStopTimeout.Key: "10",
} }
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册