未验证 提交 d05c24a0 编写于 作者: Z zhenshan.cao 提交者: GitHub

Delete unused code (#17182)

Signed-off-by: Nzhenshan.cao <zhenshan.cao@zilliz.com>
上级 2512e668
此差异已折叠。
此差异已折叠。
......@@ -18,9 +18,7 @@ package querynode
import (
"context"
"errors"
"fmt"
"math"
"go.uber.org/zap"
......@@ -129,27 +127,6 @@ func (tp tsType) String() string {
return ""
}
func (q *queryShard) getNewTSafe(tp tsType) (Timestamp, error) {
var channel string
switch tp {
case tsTypeDML:
channel = q.channel
case tsTypeDelta:
channel = q.deltaChannel
default:
return 0, errors.New("invalid ts type")
}
t := Timestamp(math.MaxInt64)
ts, err := q.tSafeReplica.getTSafe(channel)
if err != nil {
return 0, err
}
if ts <= t {
t = ts
}
return t, nil
}
func (q *queryShard) getServiceableTime(tp tsType) (Timestamp, error) {
var channel string
switch tp {
......
......@@ -119,7 +119,7 @@ func TestQueryShard_Close(t *testing.T) {
qs.Close()
}
func TestQueryShard_waitNewTSafe(t *testing.T) {
func TestQueryShard_getServiceableTime(t *testing.T) {
qs, err := genSimpleQueryShard(context.Background())
assert.NoError(t, err)
......@@ -127,11 +127,11 @@ func TestQueryShard_waitNewTSafe(t *testing.T) {
err = updateQueryShardTSafe(qs, timestamp)
assert.NoError(t, err)
dmlTimestamp, err := qs.getNewTSafe(tsTypeDML)
dmlTimestamp, err := qs.getServiceableTime(tsTypeDML)
assert.NoError(t, err)
assert.Equal(t, timestamp, dmlTimestamp)
deltaTimestamp, err := qs.getNewTSafe(tsTypeDelta)
deltaTimestamp, err := qs.getServiceableTime(tsTypeDelta)
assert.NoError(t, err)
assert.Equal(t, timestamp, deltaTimestamp)
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册