Rename Params to ClientParams for all component clients (#13743)

Signed-off-by: Nyudong.cai <yudong.cai@zilliz.com>

internal/distributed/datacoord/client/client.go

@@ -35,7 +35,7 @@ import (
 	"github.com/milvus-io/milvus/internal/util/typeutil"
 )
 
-var Params paramtable.GrpcClientConfig
+var ClientParams paramtable.GrpcClientConfig
 
 // Client is the datacoord grpc client
 type Client struct {
@@ -51,11 +51,11 @@ func NewClient(ctx context.Context, metaRoot string, etcdEndpoints []string) (*C
 		log.Debug("DataCoordClient NewClient failed", zap.Error(err))
 		return nil, err
 	}
-	Params.InitOnce(typeutil.DataCoordRole)
+	ClientParams.InitOnce(typeutil.DataCoordRole)
 	client := &Client{
 		grpcClient: &grpcclient.ClientBase{
-			ClientMaxRecvSize: Params.ClientMaxRecvSize,
-			ClientMaxSendSize: Params.ClientMaxSendSize,
+			ClientMaxRecvSize: ClientParams.ClientMaxRecvSize,
+			ClientMaxSendSize: ClientParams.ClientMaxSendSize,
 		},
 		sess: sess,
 	}

internal/distributed/datanode/client/client.go

@@ -32,7 +32,7 @@ import (
 	"github.com/milvus-io/milvus/internal/util/typeutil"
 )
 
-var Params paramtable.GrpcClientConfig
+var ClientParams paramtable.GrpcClientConfig
 
 // Client is the grpc client for DataNode
 type Client struct {
@@ -45,12 +45,12 @@ func NewClient(ctx context.Context, addr string) (*Client, error) {
 	if addr == "" {
 		return nil, fmt.Errorf("address is empty")
 	}
-	Params.InitOnce(typeutil.DataNodeRole)
+	ClientParams.InitOnce(typeutil.DataNodeRole)
 	client := &Client{
 		addr: addr,
 		grpcClient: &grpcclient.ClientBase{
-			ClientMaxRecvSize: Params.ClientMaxRecvSize,
-			ClientMaxSendSize: Params.ClientMaxSendSize,
+			ClientMaxRecvSize: ClientParams.ClientMaxRecvSize,
+			ClientMaxSendSize: ClientParams.ClientMaxSendSize,
 		},
 	}
 	client.grpcClient.SetRole(typeutil.DataNodeRole)

internal/distributed/indexcoord/client/client.go

@@ -35,7 +35,7 @@ import (
 	"github.com/milvus-io/milvus/internal/util/typeutil"
 )
 
-var Params paramtable.GrpcClientConfig
+var ClientParams paramtable.GrpcClientConfig
 
 // Client is the grpc client of IndexCoord.
 type Client struct {
@@ -51,11 +51,11 @@ func NewClient(ctx context.Context, metaRoot string, etcdEndpoints []string) (*C
 		log.Debug("IndexCoordClient NewClient failed", zap.Error(err))
 		return nil, err
 	}
-	Params.InitOnce(typeutil.IndexCoordRole)
+	ClientParams.InitOnce(typeutil.IndexCoordRole)
 	client := &Client{
 		grpcClient: &grpcclient.ClientBase{
-			ClientMaxRecvSize: Params.ClientMaxRecvSize,
-			ClientMaxSendSize: Params.ClientMaxSendSize,
+			ClientMaxRecvSize: ClientParams.ClientMaxRecvSize,
+			ClientMaxSendSize: ClientParams.ClientMaxSendSize,
 		},
 		sess: sess,
 	}

internal/distributed/indexcoord/client/client_test.go

@@ -31,7 +31,7 @@ import (
 )
 
 func TestIndexCoordClient(t *testing.T) {
-	Params.InitOnce(typeutil.IndexCoordRole)
+	ClientParams.InitOnce(typeutil.IndexCoordRole)
 	ctx := context.Background()
 	server, err := grpcindexcoord.NewServer(ctx)
 	assert.Nil(t, err)

internal/distributed/indexnode/client/client.go

@@ -31,7 +31,7 @@ import (
 	"google.golang.org/grpc"
 )
 
-var Params paramtable.GrpcClientConfig
+var ClientParams paramtable.GrpcClientConfig
 
 // Client is the grpc client of IndexNode.
 type Client struct {
@@ -44,12 +44,12 @@ func NewClient(ctx context.Context, addr string) (*Client, error) {
 	if addr == "" {
 		return nil, fmt.Errorf("address is empty")
 	}
-	Params.InitOnce(typeutil.IndexNodeRole)
+	ClientParams.InitOnce(typeutil.IndexNodeRole)
 	client := &Client{
 		addr: addr,
 		grpcClient: &grpcclient.ClientBase{
-			ClientMaxRecvSize: Params.ClientMaxRecvSize,
-			ClientMaxSendSize: Params.ClientMaxSendSize,
+			ClientMaxRecvSize: ClientParams.ClientMaxRecvSize,
+			ClientMaxSendSize: ClientParams.ClientMaxSendSize,
 		},
 	}
 	client.grpcClient.SetRole(typeutil.IndexNodeRole)

internal/distributed/indexnode/client/client_test.go

@@ -21,21 +21,20 @@ import (
 	"errors"
 	"testing"
 
-	"github.com/milvus-io/milvus/internal/util/metricsinfo"
-
-	"github.com/milvus-io/milvus/internal/util/mock"
-	"google.golang.org/grpc"
-
 	grpcindexnode "github.com/milvus-io/milvus/internal/distributed/indexnode"
 	"github.com/milvus-io/milvus/internal/indexnode"
 	"github.com/milvus-io/milvus/internal/proto/commonpb"
 	"github.com/milvus-io/milvus/internal/proto/indexpb"
 	"github.com/milvus-io/milvus/internal/proto/internalpb"
+	"github.com/milvus-io/milvus/internal/util/metricsinfo"
+	"github.com/milvus-io/milvus/internal/util/mock"
+	"github.com/milvus-io/milvus/internal/util/typeutil"
 	"github.com/stretchr/testify/assert"
+	"google.golang.org/grpc"
 )
 
 func Test_NewClient(t *testing.T) {
-	Params.Init()
+	ClientParams.InitOnce(typeutil.IndexNodeRole)
 	ctx := context.Background()
 	client, err := NewClient(ctx, "")
 	assert.Nil(t, client)

internal/distributed/proxy/client/client.go

@@ -31,7 +31,7 @@ import (
 	"google.golang.org/grpc"
 )
 
-var Params paramtable.GrpcClientConfig
+var ClientParams paramtable.GrpcClientConfig
 
 // Client is the grpc client for Proxy
 type Client struct {
@@ -44,12 +44,12 @@ func NewClient(ctx context.Context, addr string) (*Client, error) {
 	if addr == "" {
 		return nil, fmt.Errorf("address is empty")
 	}
-	Params.InitOnce(typeutil.ProxyRole)
+	ClientParams.InitOnce(typeutil.ProxyRole)
 	client := &Client{
 		addr: addr,
 		grpcClient: &grpcclient.ClientBase{
-			ClientMaxRecvSize: Params.ClientMaxRecvSize,
-			ClientMaxSendSize: Params.ClientMaxSendSize,
+			ClientMaxRecvSize: ClientParams.ClientMaxRecvSize,
+			ClientMaxSendSize: ClientParams.ClientMaxSendSize,
 		},
 	}
 	client.grpcClient.SetRole(typeutil.ProxyRole)

internal/distributed/querycoord/client/client.go

@@ -34,7 +34,7 @@ import (
 	"google.golang.org/grpc"
 )
 
-var Params paramtable.GrpcClientConfig
+var ClientParams paramtable.GrpcClientConfig
 
 // Client is the grpc client of QueryCoord.
 type Client struct {
@@ -50,11 +50,11 @@ func NewClient(ctx context.Context, metaRoot string, etcdEndpoints []string) (*C
 		log.Debug("QueryCoordClient NewClient failed", zap.Error(err))
 		return nil, err
 	}
-	Params.InitOnce(typeutil.QueryCoordRole)
+	ClientParams.InitOnce(typeutil.QueryCoordRole)
 	client := &Client{
 		grpcClient: &grpcclient.ClientBase{
-			ClientMaxRecvSize: Params.ClientMaxRecvSize,
-			ClientMaxSendSize: Params.ClientMaxSendSize,
+			ClientMaxRecvSize: ClientParams.ClientMaxRecvSize,
+			ClientMaxSendSize: ClientParams.ClientMaxSendSize,
 		},
 		sess: sess,
 	}

internal/distributed/querynode/client/client.go

@@ -31,7 +31,7 @@ import (
 	"google.golang.org/grpc"
 )
 
-var Params paramtable.GrpcClientConfig
+var ClientParams paramtable.GrpcClientConfig
 
 // Client is the grpc client of QueryNode.
 type Client struct {
@@ -44,12 +44,12 @@ func NewClient(ctx context.Context, addr string) (*Client, error) {
 	if addr == "" {
 		return nil, fmt.Errorf("addr is empty")
 	}
-	Params.InitOnce(typeutil.QueryNodeRole)
+	ClientParams.InitOnce(typeutil.QueryNodeRole)
 	client := &Client{
 		addr: addr,
 		grpcClient: &grpcclient.ClientBase{
-			ClientMaxRecvSize: Params.ClientMaxRecvSize,
-			ClientMaxSendSize: Params.ClientMaxSendSize,
+			ClientMaxRecvSize: ClientParams.ClientMaxRecvSize,
+			ClientMaxSendSize: ClientParams.ClientMaxSendSize,
 		},
 	}
 	client.grpcClient.SetRole(typeutil.QueryNodeRole)

internal/distributed/querynode/client/client_test.go

@@ -21,11 +21,11 @@ import (
 	"errors"
 	"testing"
 
-	"github.com/milvus-io/milvus/internal/util/mock"
-	"google.golang.org/grpc"
-
 	"github.com/milvus-io/milvus/internal/proxy"
+	"github.com/milvus-io/milvus/internal/util/mock"
+	"github.com/milvus-io/milvus/internal/util/typeutil"
 	"github.com/stretchr/testify/assert"
+	"google.golang.org/grpc"
 )
 
 func Test_NewClient(t *testing.T) {
@@ -40,7 +40,7 @@ func Test_NewClient(t *testing.T) {
 	assert.Nil(t, err)
 	assert.NotNil(t, client)
 
-	Params.Init()
+	ClientParams.InitOnce(typeutil.QueryNodeRole)
 
 	err = client.Start()
 	assert.Nil(t, err)

internal/distributed/rootcoord/client/client.go

@@ -36,7 +36,7 @@ import (
 	"google.golang.org/grpc"
 )
 
-var Params paramtable.GrpcClientConfig
+var ClientParams paramtable.GrpcClientConfig
 
 // Client grpc client
 type Client struct {
@@ -56,11 +56,11 @@ func NewClient(ctx context.Context, metaRoot string, etcdEndpoints []string) (*C
 		log.Debug("QueryCoordClient NewClient failed", zap.Error(err))
 		return nil, err
 	}
-	Params.InitOnce(typeutil.RootCoordRole)
+	ClientParams.InitOnce(typeutil.RootCoordRole)
 	client := &Client{
 		grpcClient: &grpcclient.ClientBase{
-			ClientMaxRecvSize: Params.ClientMaxRecvSize,
-			ClientMaxSendSize: Params.ClientMaxSendSize,
+			ClientMaxRecvSize: ClientParams.ClientMaxRecvSize,
+			ClientMaxSendSize: ClientParams.ClientMaxSendSize,
 		},
 		sess: sess,
 	}