Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
milvus
milvus
提交
51d55dc5
M
milvus
项目概览
milvus
/
milvus
12 个月 前同步成功
通知
261
Star
22476
Fork
2472
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
M
milvus
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
51d55dc5
编写于
12月 06, 2021
作者:
X
Xiangyu Wang
提交者:
GitHub
12月 06, 2021
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Improve logs in proxy (#12762)
Signed-off-by:
N
Xiangyu Wang
<
xiangyu.wang@zilliz.com
>
上级
43ef945b
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
43 addition
and
84 deletion
+43
-84
internal/proxy/impl.go
internal/proxy/impl.go
+43
-84
未找到文件。
internal/proxy/impl.go
浏览文件 @
51d55dc5
...
...
@@ -1395,26 +1395,18 @@ func (node *Proxy) GetIndexState(ctx context.Context, request *milvuspb.GetIndex
// Insert insert records into collection.
func
(
node
*
Proxy
)
Insert
(
ctx
context
.
Context
,
request
*
milvuspb
.
InsertRequest
)
(
*
milvuspb
.
MutationResult
,
error
)
{
sp
,
ctx
:=
trace
.
StartSpanFromContextWithOperationName
(
ctx
,
"Proxy-Insert"
)
defer
sp
.
Finish
()
traceID
,
_
,
_
:=
trace
.
InfoFromSpan
(
sp
)
log
.
Info
(
"Start processing insert request in Proxy"
,
zap
.
String
(
"traceID"
,
traceID
))
defer
log
.
Info
(
"Finish processing insert request in Proxy"
,
zap
.
String
(
"traceID"
,
traceID
))
if
!
node
.
checkHealthy
()
{
return
&
milvuspb
.
MutationResult
{
Status
:
unhealthyStatus
(),
},
nil
}
sp
,
ctx
:=
trace
.
StartSpanFromContextWithOperationName
(
ctx
,
"Proxy-Insert"
)
defer
sp
.
Finish
()
traceID
,
_
,
_
:=
trace
.
InfoFromSpan
(
sp
)
log
.
Debug
(
"Insert received"
,
zap
.
String
(
"traceID"
,
traceID
),
zap
.
String
(
"role"
,
Params
.
RoleName
),
zap
.
String
(
"db"
,
request
.
DbName
),
zap
.
String
(
"collection"
,
request
.
CollectionName
),
zap
.
String
(
"partition"
,
request
.
PartitionName
),
zap
.
Int
(
"len(FieldsData)"
,
len
(
request
.
FieldsData
)),
zap
.
Int
(
"len(HashKeys)"
,
len
(
request
.
HashKeys
)),
zap
.
Uint32
(
"NumRows"
,
request
.
NumRows
))
it
:=
&
insertTask
{
ctx
:
ctx
,
Condition
:
NewTaskCondition
(
ctx
),
...
...
@@ -1439,49 +1431,27 @@ func (node *Proxy) Insert(ctx context.Context, request *milvuspb.InsertRequest)
chTicker
:
node
.
chTicker
,
}
var
err
error
if
len
(
it
.
PartitionName
)
<=
0
{
it
.
PartitionName
=
Params
.
DefaultPartitionName
}
result
:=
&
milvuspb
.
MutationResult
{
Status
:
&
commonpb
.
Status
{
ErrorCode
:
commonpb
.
ErrorCode_Success
,
},
}
err
=
node
.
sched
.
dmQueue
.
Enqueue
(
it
)
if
err
!=
nil
{
log
.
Debug
(
"Insert failed to enqueue"
,
zap
.
Error
(
err
),
zap
.
String
(
"traceID"
,
traceID
),
zap
.
String
(
"role"
,
Params
.
RoleName
),
zap
.
String
(
"db"
,
request
.
DbName
),
zap
.
String
(
"collection"
,
request
.
CollectionName
),
zap
.
String
(
"partition"
,
request
.
PartitionName
),
zap
.
Int
(
"len(FieldsData)"
,
len
(
request
.
FieldsData
)),
zap
.
Int
(
"len(HashKeys)"
,
len
(
request
.
HashKeys
)),
zap
.
Uint32
(
"NumRows"
,
request
.
NumRows
))
result
.
Status
.
ErrorCode
=
commonpb
.
ErrorCode_UnexpectedError
result
.
Status
.
Reason
=
err
.
Error
()
constructFailedResponse
:=
func
(
err
error
)
*
milvuspb
.
MutationResult
{
numRows
:=
it
.
req
.
NumRows
errIndex
:=
make
([]
uint32
,
numRows
)
for
i
:=
uint32
(
0
);
i
<
numRows
;
i
++
{
errIndex
[
i
]
=
i
}
result
.
ErrIndex
=
errIndex
return
result
,
nil
return
&
milvuspb
.
MutationResult
{
Status
:
&
commonpb
.
Status
{
ErrorCode
:
commonpb
.
ErrorCode_UnexpectedError
,
Reason
:
err
.
Error
(),
},
ErrIndex
:
errIndex
,
}
}
log
.
Debug
(
"Insert enqueued"
,
zap
.
String
(
"traceID"
,
traceID
),
log
.
Debug
(
"Enqueue insert request in Proxy"
,
zap
.
String
(
"role"
,
Params
.
RoleName
),
zap
.
Int64
(
"MsgID"
,
it
.
ID
()),
zap
.
Uint64
(
"BeginTS"
,
it
.
BeginTs
()),
zap
.
Uint64
(
"EndTS"
,
it
.
EndTs
()),
zap
.
String
(
"db"
,
request
.
DbName
),
zap
.
String
(
"collection"
,
request
.
CollectionName
),
zap
.
String
(
"partition"
,
request
.
PartitionName
),
...
...
@@ -1489,47 +1459,14 @@ func (node *Proxy) Insert(ctx context.Context, request *milvuspb.InsertRequest)
zap
.
Int
(
"len(HashKeys)"
,
len
(
request
.
HashKeys
)),
zap
.
Uint32
(
"NumRows"
,
request
.
NumRows
))
err
=
it
.
WaitToFinish
()
if
err
!=
nil
{
log
.
Debug
(
"Insert failed to WaitToFinish"
,
zap
.
Error
(
err
),
zap
.
String
(
"traceID"
,
traceID
),
zap
.
String
(
"role"
,
Params
.
RoleName
),
zap
.
Int64
(
"MsgID"
,
it
.
ID
()),
zap
.
Uint64
(
"BeginTS"
,
it
.
BeginTs
()),
zap
.
Uint64
(
"EndTS"
,
it
.
EndTs
()),
zap
.
String
(
"db"
,
request
.
DbName
),
zap
.
String
(
"collection"
,
request
.
CollectionName
),
zap
.
String
(
"partition"
,
request
.
PartitionName
),
zap
.
Int
(
"len(FieldsData)"
,
len
(
request
.
FieldsData
)),
zap
.
Int
(
"len(HashKeys)"
,
len
(
request
.
HashKeys
)),
zap
.
Uint32
(
"NumRows"
,
request
.
NumRows
))
result
.
Status
.
ErrorCode
=
commonpb
.
ErrorCode_UnexpectedError
result
.
Status
.
Reason
=
err
.
Error
()
numRows
:=
it
.
req
.
NumRows
errIndex
:=
make
([]
uint32
,
numRows
)
for
i
:=
uint32
(
0
);
i
<
numRows
;
i
++
{
errIndex
[
i
]
=
i
}
result
.
ErrIndex
=
errIndex
return
result
,
nil
if
err
:=
node
.
sched
.
dmQueue
.
Enqueue
(
it
);
err
!=
nil
{
log
.
Debug
(
"Failed to enqueue insert task: "
+
err
.
Error
())
return
constructFailedResponse
(
err
),
nil
}
if
it
.
result
.
Status
.
ErrorCode
!=
commonpb
.
ErrorCode_Success
{
numRows
:=
it
.
req
.
NumRows
errIndex
:=
make
([]
uint32
,
numRows
)
for
i
:=
uint32
(
0
);
i
<
numRows
;
i
++
{
errIndex
[
i
]
=
i
}
it
.
result
.
ErrIndex
=
errIndex
}
it
.
result
.
InsertCnt
=
int64
(
it
.
req
.
NumRows
)
log
.
Debug
(
"Insert done"
,
zap
.
String
(
"traceID"
,
traceID
),
log
.
Debug
(
"Detail of insert request in Proxy"
,
zap
.
String
(
"role"
,
Params
.
RoleName
),
zap
.
Int64
(
"
MsgID"
,
it
.
ID
()
),
zap
.
Int64
(
"
msgID"
,
it
.
Base
.
MsgID
),
zap
.
Uint64
(
"BeginTS"
,
it
.
BeginTs
()),
zap
.
Uint64
(
"EndTS"
,
it
.
EndTs
()),
zap
.
String
(
"db"
,
request
.
DbName
),
...
...
@@ -1537,7 +1474,29 @@ func (node *Proxy) Insert(ctx context.Context, request *milvuspb.InsertRequest)
zap
.
String
(
"partition"
,
request
.
PartitionName
),
zap
.
Int
(
"len(FieldsData)"
,
len
(
request
.
FieldsData
)),
zap
.
Int
(
"len(HashKeys)"
,
len
(
request
.
HashKeys
)),
zap
.
Uint32
(
"NumRows"
,
request
.
NumRows
))
zap
.
Uint32
(
"NumRows"
,
request
.
NumRows
),
zap
.
String
(
"traceID"
,
traceID
))
if
err
:=
it
.
WaitToFinish
();
err
!=
nil
{
log
.
Debug
(
"Failed to execute insert task in task scheduler: "
+
err
.
Error
(),
zap
.
String
(
"traceID"
,
traceID
))
return
constructFailedResponse
(
err
),
nil
}
if
it
.
result
.
Status
.
ErrorCode
!=
commonpb
.
ErrorCode_Success
{
setErrorIndex
:=
func
()
{
numRows
:=
it
.
req
.
NumRows
errIndex
:=
make
([]
uint32
,
numRows
)
for
i
:=
uint32
(
0
);
i
<
numRows
;
i
++
{
errIndex
[
i
]
=
i
}
it
.
result
.
ErrIndex
=
errIndex
}
setErrorIndex
()
}
// InsertCnt always equals to the number of entities in the request
it
.
result
.
InsertCnt
=
int64
(
it
.
req
.
NumRows
)
return
it
.
result
,
nil
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录