未验证 提交 2bca6959 编写于 作者: C congqixia 提交者: GitHub

Add some comment for SegmentsInfo (#7995)

Signed-off-by: NCongqi Xia <congqi.xia@zilliz.com>
上级 c76f9123
...@@ -9,10 +9,12 @@ import ( ...@@ -9,10 +9,12 @@ import (
"github.com/milvus-io/milvus/internal/proto/internalpb" "github.com/milvus-io/milvus/internal/proto/internalpb"
) )
// SegmentsInfo wraps a map, which maintains ID to SegmentInfo relation
type SegmentsInfo struct { type SegmentsInfo struct {
segments map[UniqueID]*SegmentInfo segments map[UniqueID]*SegmentInfo
} }
// SegmentInfo wraps datapb.SegmentInfo and patches some extra info on it
type SegmentInfo struct { type SegmentInfo struct {
*datapb.SegmentInfo *datapb.SegmentInfo
currRows int64 currRows int64
...@@ -32,10 +34,13 @@ func NewSegmentInfo(info *datapb.SegmentInfo) *SegmentInfo { ...@@ -32,10 +34,13 @@ func NewSegmentInfo(info *datapb.SegmentInfo) *SegmentInfo {
} }
} }
// NewSegmentsInfo create `SegmentsInfo` instance, which makes sure internal map is initialized
// note that no mutex is wrapper so external concurrent control is needed
func NewSegmentsInfo() *SegmentsInfo { func NewSegmentsInfo() *SegmentsInfo {
return &SegmentsInfo{segments: make(map[UniqueID]*SegmentInfo)} return &SegmentsInfo{segments: make(map[UniqueID]*SegmentInfo)}
} }
// GetSegment returns SegmentInfo
func (s *SegmentsInfo) GetSegment(segmentID UniqueID) *SegmentInfo { func (s *SegmentsInfo) GetSegment(segmentID UniqueID) *SegmentInfo {
segment, ok := s.segments[segmentID] segment, ok := s.segments[segmentID]
if !ok { if !ok {
...@@ -44,6 +49,8 @@ func (s *SegmentsInfo) GetSegment(segmentID UniqueID) *SegmentInfo { ...@@ -44,6 +49,8 @@ func (s *SegmentsInfo) GetSegment(segmentID UniqueID) *SegmentInfo {
return segment return segment
} }
// GetSegments iterates internal map and returns all SegmentInfo in a slice
// no deep copy applied
func (s *SegmentsInfo) GetSegments() []*SegmentInfo { func (s *SegmentsInfo) GetSegments() []*SegmentInfo {
segments := make([]*SegmentInfo, 0, len(s.segments)) segments := make([]*SegmentInfo, 0, len(s.segments))
for _, segment := range s.segments { for _, segment := range s.segments {
...@@ -52,32 +59,43 @@ func (s *SegmentsInfo) GetSegments() []*SegmentInfo { ...@@ -52,32 +59,43 @@ func (s *SegmentsInfo) GetSegments() []*SegmentInfo {
return segments return segments
} }
// DropSegment deletes provided segmentID
// no extra method is taken when segmentID not exists
func (s *SegmentsInfo) DropSegment(segmentID UniqueID) { func (s *SegmentsInfo) DropSegment(segmentID UniqueID) {
delete(s.segments, segmentID) delete(s.segments, segmentID)
} }
// SetSegment sets SegmentInfo with segmentID, perform overwrite if already exists
func (s *SegmentsInfo) SetSegment(segmentID UniqueID, segment *SegmentInfo) { func (s *SegmentsInfo) SetSegment(segmentID UniqueID, segment *SegmentInfo) {
s.segments[segmentID] = segment s.segments[segmentID] = segment
} }
// SetRowCount sets rowCount info for SegmentInfo with provided segmentID
// if SegmentInfo not found, do nothing
func (s *SegmentsInfo) SetRowCount(segmentID UniqueID, rowCount int64) { func (s *SegmentsInfo) SetRowCount(segmentID UniqueID, rowCount int64) {
if segment, ok := s.segments[segmentID]; ok { if segment, ok := s.segments[segmentID]; ok {
s.segments[segmentID] = segment.ShadowClone(SetRowCount(rowCount)) s.segments[segmentID] = segment.ShadowClone(SetRowCount(rowCount))
} }
} }
// SetStates sets Segment State info for SegmentInfo with provided segmentID
// if SegmentInfo not found, do nothing
func (s *SegmentsInfo) SetState(segmentID UniqueID, state commonpb.SegmentState) { func (s *SegmentsInfo) SetState(segmentID UniqueID, state commonpb.SegmentState) {
if segment, ok := s.segments[segmentID]; ok { if segment, ok := s.segments[segmentID]; ok {
s.segments[segmentID] = segment.ShadowClone(SetState(state)) s.segments[segmentID] = segment.ShadowClone(SetState(state))
} }
} }
// SetDmlPosition sets DmlPosition info (checkpoint for recovery) for SegmentInfo with provided segmentID
// if SegmentInfo not found, do nothing
func (s *SegmentsInfo) SetDmlPosition(segmentID UniqueID, pos *internalpb.MsgPosition) { func (s *SegmentsInfo) SetDmlPosition(segmentID UniqueID, pos *internalpb.MsgPosition) {
if segment, ok := s.segments[segmentID]; ok { if segment, ok := s.segments[segmentID]; ok {
s.segments[segmentID] = segment.Clone(SetDmlPosition(pos)) s.segments[segmentID] = segment.Clone(SetDmlPosition(pos))
} }
} }
// SetStartPosition sets StartPosition info (recovery info when no checkout point found) for SegmentInfo with provided segmentID
// if SegmentInfo not found, do nothing
func (s *SegmentsInfo) SetStartPosition(segmentID UniqueID, pos *internalpb.MsgPosition) { func (s *SegmentsInfo) SetStartPosition(segmentID UniqueID, pos *internalpb.MsgPosition) {
if segment, ok := s.segments[segmentID]; ok { if segment, ok := s.segments[segmentID]; ok {
s.segments[segmentID] = segment.Clone(SetStartPosition(pos)) s.segments[segmentID] = segment.Clone(SetStartPosition(pos))
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册