fix build index log error (#3928)

* fix build index log error
Signed-off-by: Ngroot <yihua.mo@zilliz.com>

* reduce unnecessary log
Signed-off-by: Ngroot <yihua.mo@zilliz.com>

core/src/db/engine/ExecutionEngineImpl.cpp

@@ -132,7 +132,7 @@ ExecutionEngineImpl::Load(const TargetFields& field_names) {
         segment_ptr->GetFieldType(name, field_type);
 
         bool index_exist = false;
-        if (field_type == DataType::VECTOR_FLOAT || field_type == DataType::VECTOR_BINARY) {
+        if (utils::IsVectorType(field_type)) {
             bool valid_metric_type = false;
             if (!context_.query_ptr_) {
                 valid_metric_type = true;

core/src/segment/SegmentReader.cpp

@@ -517,13 +517,13 @@ SegmentReader::LoadBloomFilter(segment::IdBloomFilterPtr& id_bloom_filter_ptr) {
         if (data_obj == nullptr) {
             auto& ss_codec = codec::Codec::instance();
             STATUS_CHECK(ss_codec.GetIdBloomFilterFormat()->Read(fs_ptr_, file_path, id_bloom_filter_ptr));
+            cache::CpuCacheMgr::GetInstance().InsertItem(file_path, id_bloom_filter_ptr);  // put into cache
         } else {
             id_bloom_filter_ptr = std::static_pointer_cast<segment::IdBloomFilter>(data_obj);
         }
 
         if (id_bloom_filter_ptr) {
             segment_ptr_->SetBloomFilter(id_bloom_filter_ptr);
-            cache::CpuCacheMgr::GetInstance().InsertItem(file_path, id_bloom_filter_ptr);  // put into cache
         }
     } catch (std::exception& e) {
         std::string err_msg = "Failed to load bloom filter: " + std::string(e.what());
@@ -556,13 +556,13 @@ SegmentReader::LoadDeletedDocs(segment::DeletedDocsPtr& deleted_docs_ptr) {
         if (data_obj == nullptr) {
             auto& ss_codec = codec::Codec::instance();
             STATUS_CHECK(ss_codec.GetDeletedDocsFormat()->Read(fs_ptr_, file_path, deleted_docs_ptr));
+            cache::CpuCacheMgr::GetInstance().InsertItem(file_path, deleted_docs_ptr);  // put into cache
         } else {
             deleted_docs_ptr = std::static_pointer_cast<segment::DeletedDocs>(data_obj);
         }
 
         if (deleted_docs_ptr) {
             segment_ptr_->SetDeletedDocs(deleted_docs_ptr);
-            cache::CpuCacheMgr::GetInstance().InsertItem(file_path, deleted_docs_ptr);  // put into cache
         }
     } catch (std::exception& e) {
         std::string err_msg = "Failed to load deleted docs: " + std::string(e.what());

core/src/segment/SegmentWriter.cpp

@@ -230,7 +230,7 @@ SegmentWriter::Merge(const SegmentReaderPtr& segment_reader) {
     }
 
     // check conflict
-    int64_t src_id = 0, target_id = 0;
+    int64_t src_id = -1, target_id = -2;
     auto status = GetSegmentID(target_id);
     if (!status.ok()) {
         return status;

core/src/server/delivery/request/CreateIndexReq.cpp

@@ -121,6 +121,11 @@ CreateIndexReq::OnExecute() {
             index.index_type_ = index_type;
         }
 
+        // avoid empty index name
+        if (index.index_name_.empty()) {
+            index.index_name_ = index.index_type_;
+        }
+
         STATUS_CHECK(DBWrapper::DB()->CreateIndex(context_, collection_name_, field_name_, index));
         rc.ElapseFromBegin("done");
     } catch (std::exception& ex) {