Refine method name from BroadCastXx to BroadcastXx (#19700)

Signed-off-by: Nyun.zhang <yun.zhang@zilliz.com>
Signed-off-by: Nyun.zhang <yun.zhang@zilliz.com>

internal/datacoord/services.go

@@ -1359,7 +1359,7 @@ func (s *Server) MarkSegmentsDropped(ctx context.Context, req *datapb.MarkSegmen
 	}, nil
 }
 
-func (s *Server) BroadCastAlteredCollection(ctx context.Context,
+func (s *Server) BroadcastAlteredCollection(ctx context.Context,
 	req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
 	errResp := &commonpb.Status{
 		ErrorCode: commonpb.ErrorCode_UnexpectedError,

internal/datanode/mock_test.go

@@ -271,7 +271,7 @@ func (ds *DataCoordFactory) MarkSegmentsDropped(context.Context, *datapb.MarkSeg
 	}, nil
 }
 
-func (ds *DataCoordFactory) BroadCastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
+func (ds *DataCoordFactory) BroadcastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
 	return &commonpb.Status{
 		ErrorCode: commonpb.ErrorCode_Success,
 	}, nil

internal/distributed/datacoord/client/client.go

@@ -630,13 +630,13 @@ func (c *Client) MarkSegmentsDropped(ctx context.Context, req *datapb.MarkSegmen
 	return ret.(*commonpb.Status), err
 }
 
-// BroadCastAlteredCollection is the DataCoord client side code for BroadCastAlteredCollection call.
-func (c *Client) BroadCastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
+// BroadcastAlteredCollection is the DataCoord client side code for BroadcastAlteredCollection call.
+func (c *Client) BroadcastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
 	ret, err := c.grpcClient.ReCall(ctx, func(client interface{}) (interface{}, error) {
 		if !funcutil.CheckCtxValid(ctx) {
 			return nil, ctx.Err()
 		}
-		return client.(datapb.DataCoordClient).BroadCastAlteredCollection(ctx, req)
+		return client.(datapb.DataCoordClient).BroadcastAlteredCollection(ctx, req)
 	})
 	if err != nil || ret == nil {
 		return nil, err

internal/distributed/datacoord/client/client_test.go

@@ -146,7 +146,7 @@ func Test_NewClient(t *testing.T) {
 		retCheck(retNotNil, r31, err)
 
 		{
-			ret, err := client.BroadCastAlteredCollection(ctx, nil)
+			ret, err := client.BroadcastAlteredCollection(ctx, nil)
 			retCheck(retNotNil, ret, err)
 		}
 	}

internal/distributed/datacoord/service.go

@@ -398,6 +398,6 @@ func (s *Server) MarkSegmentsDropped(ctx context.Context, req *datapb.MarkSegmen
 	return s.dataCoord.MarkSegmentsDropped(ctx, req)
 }
 
-func (s *Server) BroadCastAlteredCollection(ctx context.Context, request *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
-	return s.dataCoord.BroadCastAlteredCollection(ctx, request)
+func (s *Server) BroadcastAlteredCollection(ctx context.Context, request *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
+	return s.dataCoord.BroadcastAlteredCollection(ctx, request)
 }

internal/distributed/datacoord/service_test.go

@@ -220,7 +220,7 @@ func (m *MockDataCoord) MarkSegmentsDropped(ctx context.Context, req *datapb.Mar
 	return m.markSegmentsDroppedResp, m.err
 }
 
-func (m *MockDataCoord) BroadCastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
+func (m *MockDataCoord) BroadcastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
 	return m.broadCastResp, m.err
 }
 
@@ -524,6 +524,15 @@ func Test_NewServer(t *testing.T) {
 		assert.NotNil(t, resp)
 	})
 
+	t.Run("broadcast altered collection", func(t *testing.T) {
+		server.dataCoord = &MockDataCoord{
+			broadCastResp: &commonpb.Status{},
+		}
+		resp, err := server.BroadcastAlteredCollection(ctx, nil)
+		assert.Nil(t, err)
+		assert.NotNil(t, resp)
+	})
+
 	err := server.Stop()
 	assert.Nil(t, err)
 }

internal/distributed/proxy/service_test.go

@@ -582,7 +582,7 @@ func (m *MockDataCoord) ReleaseSegmentLock(ctx context.Context, req *datapb.Rele
 	return nil, nil
 }
 
-func (m *MockDataCoord) BroadCastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
+func (m *MockDataCoord) BroadcastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
 	return nil, nil
 }
 

internal/mocks/mock_datacoord.go

@@ -123,7 +123,7 @@ func (_c *DataCoord_AssignSegmentID_Call) Return(_a0 *datapb.AssignSegmentIDResp
 	return _c
 }
 
-func (_m *DataCoord) BroadCastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
+func (_m *DataCoord) BroadcastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
 	ret := _m.Called(ctx, req)
 
 	var r0 *commonpb.Status
@@ -145,26 +145,26 @@ func (_m *DataCoord) BroadCastAlteredCollection(ctx context.Context, req *milvus
 	return r0, r1
 }
 
-// DataCoord_BroadCastAlteredCollection_Call is a *mock.Call that shadows Run/Return methods with type explicit version for method 'DataCoord_BroadCastAlteredCollection_Call'
-type DataCoord_BroadCastAlteredCollection_Call struct {
+// DataCoord_BroadcastAlteredCollection_Call is a *mock.Call that shadows Run/Return methods with type explicit version for method 'DataCoord_BroadcastAlteredCollection_Call'
+type DataCoord_BroadcastAlteredCollection_Call struct {
 	*mock.Call
 }
 
 // AddSegment is a helper method to define mock.On call
 //  - ctx context.Context
 //  - req *datapb.AddSegmentRequest
-func (_e *DataCoord_Expecter) BroadCastAlteredCollection(ctx interface{}, req interface{}) *DataCoord_BroadCastAlteredCollection_Call {
-	return &DataCoord_BroadCastAlteredCollection_Call{Call: _e.mock.On("BroadCastAlteredCollection", ctx, req)}
+func (_e *DataCoord_Expecter) BroadcastAlteredCollection(ctx interface{}, req interface{}) *DataCoord_BroadcastAlteredCollection_Call {
+	return &DataCoord_BroadcastAlteredCollection_Call{Call: _e.mock.On("BroadcastAlteredCollection", ctx, req)}
 }
 
-func (_c *DataCoord_BroadCastAlteredCollection_Call) Run(run func(ctx context.Context, req *milvuspb.AlterCollectionRequest)) *DataCoord_BroadCastAlteredCollection_Call {
+func (_c *DataCoord_BroadcastAlteredCollection_Call) Run(run func(ctx context.Context, req *milvuspb.AlterCollectionRequest)) *DataCoord_BroadcastAlteredCollection_Call {
 	_c.Call.Run(func(args mock.Arguments) {
 		run(args[0].(context.Context), args[1].(*milvuspb.AlterCollectionRequest))
 	})
 	return _c
 }
 
-func (_c *DataCoord_BroadCastAlteredCollection_Call) Return(_a0 *commonpb.Status, _a1 error) *DataCoord_BroadCastAlteredCollection_Call {
+func (_c *DataCoord_BroadcastAlteredCollection_Call) Return(_a0 *commonpb.Status, _a1 error) *DataCoord_BroadcastAlteredCollection_Call {
 	_c.Call.Return(_a0, _a1)
 	return _c
 }

internal/proto/data_coord.proto

@@ -64,7 +64,7 @@ service DataCoord {
   rpc UnsetIsImportingState(UnsetIsImportingStateRequest) returns(common.Status) {}
   rpc MarkSegmentsDropped(MarkSegmentsDroppedRequest) returns(common.Status) {}
 
-  rpc BroadCastAlteredCollection(milvus.AlterCollectionRequest) returns (common.Status) {}
+  rpc BroadcastAlteredCollection(milvus.AlterCollectionRequest) returns (common.Status) {}
 }
 
 service DataNode {

internal/proxy/data_coord_mock_test.go

@@ -126,7 +126,7 @@ func (coord *DataCoordMock) MarkSegmentsDropped(ctx context.Context, req *datapb
 	panic("implement me")
 }
 
-func (coord *DataCoordMock) BroadCastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
+func (coord *DataCoordMock) BroadcastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
 	panic("implement me")
 }
 

internal/rootcoord/alter_collection_task_test.go

@@ -95,7 +95,7 @@ func Test_alterCollectionTask_Execute(t *testing.T) {
 		}
 
 		broker := newMockBroker()
-		broker.BroadCastAlteredCollectionFunc = func(ctx context.Context, req *milvuspb.AlterCollectionRequest) error {
+		broker.BroadcastAlteredCollectionFunc = func(ctx context.Context, req *milvuspb.AlterCollectionRequest) error {
 			return errors.New("err")
 		}
 
@@ -123,7 +123,7 @@ func Test_alterCollectionTask_Execute(t *testing.T) {
 		}
 
 		broker := newMockBroker()
-		broker.BroadCastAlteredCollectionFunc = func(ctx context.Context, req *milvuspb.AlterCollectionRequest) error {
+		broker.BroadcastAlteredCollectionFunc = func(ctx context.Context, req *milvuspb.AlterCollectionRequest) error {
 			return nil
 		}
 

internal/rootcoord/broker.go

@@ -45,7 +45,7 @@ type Broker interface {
 	GetSegmentIndexState(ctx context.Context, collID UniqueID, indexName string, segIDs []UniqueID) ([]*indexpb.SegmentIndexState, error)
 	DescribeIndex(ctx context.Context, colID UniqueID) (*indexpb.DescribeIndexResponse, error)
 
-	BroadCastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) error
+	BroadcastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) error
 }
 
 type ServerBroker struct {
@@ -230,8 +230,9 @@ func (b *ServerBroker) GetSegmentIndexState(ctx context.Context, collID UniqueID
 	return resp.GetStates(), nil
 }
 
-func (b *ServerBroker) BroadCastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) error {
-	resp, err := b.s.dataCoord.BroadCastAlteredCollection(ctx, req)
+func (b *ServerBroker) BroadcastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) error {
+	log.Info("")
+	resp, err := b.s.dataCoord.BroadcastAlteredCollection(ctx, req)
 	if err != nil {
 		return err
 	}

internal/rootcoord/broker_test.go

@@ -279,12 +279,12 @@ func TestServerBroker_GetSegmentIndexState(t *testing.T) {
 	})
 }
 
-func TestServerBroker_BroadCastAlteredCollection(t *testing.T) {
+func TestServerBroker_BroadcastAlteredCollection(t *testing.T) {
 	t.Run("failed to execute", func(t *testing.T) {
 		c := newTestCore(withInvalidDataCoord())
 		b := newServerBroker(c)
 		ctx := context.Background()
-		err := b.BroadCastAlteredCollection(ctx, &milvuspb.AlterCollectionRequest{})
+		err := b.BroadcastAlteredCollection(ctx, &milvuspb.AlterCollectionRequest{})
 		assert.Error(t, err)
 	})
 
@@ -292,7 +292,7 @@ func TestServerBroker_BroadCastAlteredCollection(t *testing.T) {
 		c := newTestCore(withFailedDataCoord())
 		b := newServerBroker(c)
 		ctx := context.Background()
-		err := b.BroadCastAlteredCollection(ctx, &milvuspb.AlterCollectionRequest{})
+		err := b.BroadcastAlteredCollection(ctx, &milvuspb.AlterCollectionRequest{})
 		assert.Error(t, err)
 	})
 
@@ -300,7 +300,7 @@ func TestServerBroker_BroadCastAlteredCollection(t *testing.T) {
 		c := newTestCore(withValidDataCoord())
 		b := newServerBroker(c)
 		ctx := context.Background()
-		err := b.BroadCastAlteredCollection(ctx, &milvuspb.AlterCollectionRequest{})
+		err := b.BroadcastAlteredCollection(ctx, &milvuspb.AlterCollectionRequest{})
 		assert.NoError(t, err)
 	})
 }

internal/rootcoord/mock_test.go

@@ -198,7 +198,7 @@ func (m *mockDataCoord) UnsetIsImportingState(ctx context.Context, req *datapb.U
 	return m.UnsetIsImportingStateFunc(ctx, req)
 }
 
-func (m *mockDataCoord) BroadCastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
+func (m *mockDataCoord) BroadcastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error) {
 	return m.broadCastAlteredCollectionFunc(ctx, req)
 }
 
@@ -805,7 +805,7 @@ type mockBroker struct {
 	DescribeIndexFunc        func(ctx context.Context, colID UniqueID) (*indexpb.DescribeIndexResponse, error)
 	GetSegmentIndexStateFunc func(ctx context.Context, collID UniqueID, indexName string, segIDs []UniqueID) ([]*indexpb.SegmentIndexState, error)
 
-	BroadCastAlteredCollectionFunc func(ctx context.Context, req *milvuspb.AlterCollectionRequest) error
+	BroadcastAlteredCollectionFunc func(ctx context.Context, req *milvuspb.AlterCollectionRequest) error
 }
 
 func newMockBroker() *mockBroker {
@@ -836,8 +836,8 @@ func (b mockBroker) GetSegmentIndexState(ctx context.Context, collID UniqueID, i
 	return b.GetSegmentIndexStateFunc(ctx, collID, indexName, segIDs)
 }
 
-func (b mockBroker) BroadCastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) error {
-	return b.BroadCastAlteredCollectionFunc(ctx, req)
+func (b mockBroker) BroadcastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) error {
+	return b.BroadcastAlteredCollectionFunc(ctx, req)
 }
 
 func withBroker(b Broker) Opt {

internal/rootcoord/step.go

@@ -367,7 +367,7 @@ type BroadcastAlteredCollectionStep struct {
 func (b *BroadcastAlteredCollectionStep) Execute(ctx context.Context) ([]nestedStep, error) {
 	// TODO: support online schema change mechanism
 	// It only broadcast collection properties to DataCoord service
-	err := b.core.broker.BroadCastAlteredCollection(ctx, b.req)
+	err := b.core.broker.BroadcastAlteredCollection(ctx, b.req)
 	return nil, err
 }
 

internal/types/types.go

@@ -325,7 +325,7 @@ type DataCoord interface {
 	// MarkSegmentsDropped marks the given segments as `dropped` state.
 	MarkSegmentsDropped(ctx context.Context, req *datapb.MarkSegmentsDroppedRequest) (*commonpb.Status, error)
 
-	BroadCastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error)
+	BroadcastAlteredCollection(ctx context.Context, req *milvuspb.AlterCollectionRequest) (*commonpb.Status, error)
 }
 
 // DataCoordComponent defines the interface of DataCoord component.

internal/util/mock/grpc_datacoord_client.go

@@ -161,7 +161,7 @@ func (m *GrpcDataCoordClient) MarkSegmentsDropped(context.Context, *datapb.MarkS
 	return &commonpb.Status{}, m.Err
 }
 
-func (m *GrpcDataCoordClient) BroadCastAlteredCollection(ctx context.Context, in *milvuspb.AlterCollectionRequest, opts ...grpc.CallOption) (*commonpb.Status, error) {
+func (m *GrpcDataCoordClient) BroadcastAlteredCollection(ctx context.Context, in *milvuspb.AlterCollectionRequest, opts ...grpc.CallOption) (*commonpb.Status, error) {
 	return &commonpb.Status{}, m.Err
 
 }