1. 27 6月, 2020 4 次提交
  2. 26 6月, 2020 25 次提交
  3. 25 6月, 2020 11 次提交
    • M
      Merge pull request #45347 from mavasani/NewApi_CompilationWithAnalyzers · 38eb489a
      Manish Vasani 提交于
      Add new public APIs to CompilationWithAnalyzers to fetch syntax and s…
      38eb489a
    • A
      Merge pull request #44581 from allisonchou/SwitchExpressionError · 25cc3f3d
      Allison Chou 提交于
      Fix for incorrect IDE0007 implicit type diagnostic being reported in switch expressions
      25cc3f3d
    • F
      70b1410f
    • J
      Update xlf files with notes · 41671b2e
      Jason Malinowski 提交于
      41671b2e
    • A
      Temporarily restore warning · 988813b6
      Allison Chou 提交于
      988813b6
    • A
      Merge pull request #45035 from akhera99/bug_11510 · 82aac2c7
      Ankita Khera 提交于
      Bug 11510
      82aac2c7
    • F
      Removed unused declaration. · c8b7158d
      Fredric Silberberg 提交于
      c8b7158d
    • F
      Remove the OperationConstantValue wrapper type and push the WeakReference... · 6f9c8b61
      Fredric Silberberg 提交于
      Remove the OperationConstantValue wrapper type and push the WeakReference logic into string specialized ConstantValue implemention. Optimized internal calls to `ConstantValue.HasValue` to get the underlying instance to avoid realizing strings for these cases.
      6f9c8b61
    • M
      Address feedback · 45f802e2
      Manish Vasani 提交于
      45f802e2
    • J
      Don't fetch output paths for some Intellisense projects · 2210f339
      Jason Malinowski 提交于
      Web projects based on the legacy project system use special projects
      called "intellisense projects" which are fake projects that are used
      to act as a container for some contained languages. These are usually
      created with the same IVsHierarchy as a regular project, which has an
      unfortunate side effect. We get our build output paths from the
      IVsHierarchy, so it would mean both the "real" project and the
      Intellisense project would get the same output path.
      
      In VS 2017, we would use that build output path to potentially convert
      metadata references on disk back to project references. The ambiguous
      path was problematic, but there was a bug: if the metadata reference
      was converted to a project reference when there was only one project
      (i.e. before you opened the file with a contained document), we
      converted it but then left that project converted; if a later project
      came along and outputted to the same output path the connection would
      be left around. If the reference got added after the duplicate project,
      it'd potentially stay a metadata reference.
      
      In VS 2019, we rewrote the whole system that did
      metadata-reference-to-project-reference conversion, and this time wrote
      it "correctly" in that the end state didn't depend on the order of
      events you took to get there; if you have two projects outputting the
      same path, then we just don't convert a metadata reference to a project
      reference.
      
      The fix being taken here is to recognize when the projects we are being
      handed are IVsIntellisenseProjects which means we can distinguish the
      projects that don't need an output path from ones that do. This ensures
      we don't end up with these projects having output paths at all, which
      probably wouldn't end well since they don't correspond to the actual
      code ultimately emitted to disk. We'll only ignore the project if
      it also has a duplicate IVsHierarchy, to avoid breaking project types
      (like database projects) that do create an IVsIntellisenseProject for
      some files, but it's not a secondary project but rather the only
      project.
      2210f339
    • J
      Delete some dead code · ad347e02
      Jason Malinowski 提交于
      ad347e02