Merge 16.8 preview 1 vs-deps back into master-vs-deps

Merge master to master-vs-deps

Merge pull request #45401 from dotnet/merges/release/dev16.8-preview1-to-release/dev16.8-preview1-vs-deps

Merge release/dev16.8-preview1 to release/dev16.8-preview1-vs-deps

Update configs for 16.7 preview 4 snap

Revert "Move SymbolSearch down to EditorFeatures (#45505)"

Co-authored-by: NJoey Robichaud <joseph.robichaud@microsoft.com>

Co-authored-by: NJoey Robichaud <joseph.robichaud@microsoft.com>

Inline rename highlight color in Dark Theme only has a contrast ratio of 1.238:1, and the target is 1.5:1

Original Color: #A6F1A6
New Color: #D3F8D3

Contrast ratio is 1.485:1 with new color

Resolves: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1139737

This reverts commit f755e8a8. That
change meant our EditorFeatures code was using DllImports in the
cross-platform binary, and we weren't sure what that would do in
VS for Mac if that code ran. It also brought a dependency on
Microsoft.VisualStudio.RemoteControl, which also seems to depend on
various Windows specific APIs.

We'll finish up the decision of what to do in
https://github.com/dotnet/roslyn/pull/45115

Prevent trying to convert metadata references into circular project references

Co-authored-by: NAlekseyTs <AlekseyTs@users.noreply.github.com>

If you have two projects that reference each other with metadata
references, we should avoid converting both of them into project
references as that causes a circularity in the Workspace layer.
The workspace API correctly throws exceptions if you try to do this,
but the Visual Studio project system layer wasn't checking, and so it'd
call into the Workspace APIs and throw exceptions. Unfortunately this
often resulted in us getting into corrupted states where the data
structures got out of sync, which might later result in other exceptions
too.

This fix isn't entirely correct in that we're not going to re-convert
the metadata reference to the project reference if something else breaks
the circularity; that's better than crashing so this is an improvement
either way.

Fixes https://github.com/dotnet/roslyn/issues/39904
Fixes https://github.com/dotnet/roslyn/issues/43633

Merge master to master-vs-deps

Align addition of a synthesized override of object.Equals(object? obj) in records with the latest design. (#45475)

* Align addition of a synthesized override of object.Equals(object? obj) in records with the latest design.

Related to #45296.

From specification:
The record type includes a synthesized override of object.Equals(object? obj). It is an error if the override is declared explicitly. The synthesized override returns Equals(other as R) where R is the record type.

* Move SymbolSearch down to EditorFeatures

* RemoteControl package reference

Fix up nondeterminism in serializing naming style preferences

Update Language Feature Status

Reduce memory required for document change processing queues

Function pointer bug fixes

We have two members in TypeKind that point to the same value, Struct
and Structure. Because of this, Enum.ToString(), which under the covers
uses a binary search, isn't stable which one it will pick and it can
change if other TypeKinds are added. This ensures we keep using the
same string consistently.

We also have a few members in MethodKind that are also duplicates, but
it appears those have kept stable. To be safe, we now serialize
explicitly.

Fixes https://github.com/dotnet/roslyn/issues/44714

Microsoft.DotNet.Arcade.Sdk
 From Version 1.0.0-beta.20302.3 -> To Version 1.0.0-beta.20326.2
Co-authored-by: Ndotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

Merge branch 'release/dev16.8-preview1-vs-deps' into merges/release/dev16.8-preview1-to-release/dev16.8-preview1-vs-deps

* Additional tests for nested function contexts.
* Override VisitFunctionPointerLoad in MethodToClassRewriter.
* Adjust debug asserts.

Fix inconsistencies in handling CompilerVisibleItemMetadata

Perf improvement for completion of unimported extension methods