Co-Authored-By: NManish Vasani <mavasani@microsoft.com>

Co-Authored-By: NManish Vasani <mavasani@microsoft.com>

Co-Authored-By: NManish Vasani <mavasani@microsoft.com>

Co-Authored-By: NManish Vasani <mavasani@microsoft.com>

* Move "is telemetry allowed" flag to DiagnosticAnalyzerInfoCache

* Clean up DiagnosticService

* Fixes

* Remove analyzer exception telemetry reporting.

* Remove reporting analyzer exceptions from SupportedDiagnostics.

The diagnostics will be reported when the compiler runs the analyzer on the compilation.

* Remove unused parameter

* Clean up analyzer telemetry reporting.

* Test fixes

* Feedback

Related to https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1047906

When renaming a document, we ensure that the name is unique
but include the old document name in the check. Since that's
the document that's name is changing, we can ignore it
when comparing names for uniqueness.

My recent change #40814 causes a crash in code fix service when there are duplicate diagnostics with same location and ID. This change adds a unit test to verify the regression and fixes the crash by using a SortedSet with a comparer.

Fixes #41116

Previously we reported diagnostics caused by the debuggee not allowing edits in the corresponding module in EnC diagnostic analyzer.
A module does not support edits if any of its instances does not support the edits. There are scenarios in which module instances may be loaded while in break mode.
E.g. if the user attaches to a secondary process while debugging a primary process, the secondary process might have a module instance loaded of the same module loaded to the primary process.
To handle these cases we hooked up debugger module load/unload events and invalidated the reported diagnostics.

This approach has a few problems:
1) EnC analyzer is now non-deterministic, as it can give different answers for the same inputs depending on the state of the debuggee
2) Turns out that the debugger does not deliver module load/unload events in all cases (e.g. when the secondary process is killed).
3) It's a bit complicated and would get even more complicated once we moved EnC to OOP/Cloud

Instead, we don't report these errors until the user triggers the "continue" action. At this point the VS and all processes being debugged are blocked until the changes analyzed and applied.
Since this situation is not very common the slight regression in interactivity is acceptable.