Fixes #45661
* Add test from contributor at #45742
Fixes #43834

Fixes #44263

* Refactor tuple implementation

* Tweaks

* Address PR feedback

* Pass tuple data in constructors

* Address more feedback

* Tweak comparison

* Restore constructWithTypeParameters flag to avoid overflow

* Assert that tuple parameter matches TupleUnderlyingType somewhat

* Rename to TupleData. Address some IDE feedback

* Remaining TODO2's

* Fix last IDE test!

* Factor array comparison

* Tweak WithTupleData and EqualsIgnoringTupleUnderlyingType

* Expand a test

* Remove duplicate line

* Remove an EE test for badly formed ValueTuple type

* PR feedback from Neal

* Restore an IDE test without ValueTuple

* Rename constants

* Restore formatting

Since ValueTuple type is not allowed in using alias

* Parsing index operator

* Binding index operator

* Parsing range expression

* Binding range expressions

* Range IOperation

* Fix Build Break

* Lowring indexes and ranges

* Fix failing tests

* Extension Indexers hack

* Address PR comments

* More PR Comments

* Clean up

* Initial UseConditional work.

* Initial UseConditional work.

* Working replacement.

* Extract common code.

* Make 'var' work properly in the simplifier service.

* Move types to their own files.

* Provide a way to create types that are not simplified to 'var'.

* Update test options.

* Update test.

* Move CSharp code style code down to the Workspace layer.

* Rename config value.

* Add ui options.

* Add VB ui options.

* Add VB support

* Strip trivia

* Initial stubs for 'use conditional for returns'

* Add VB impl.

* Only support processing of real trees.

* Actually assign variable.

* Don't assume a single variable.

* Share more code.

* Fix shared code.

* Add check.

* Simplify code.

* Only the analyzer needs to check the severity.

* Generalize loc strings.

* remove static.

* Remove unneeded methods.

* Do cheap checks first.

* Handle more cases.

* Handle more cases.

* Add test.

* Add tests.

* Add test.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Fix tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Add tests.

* Format multiline conditions.

* Add multiline formatting for VB.

* Move code.

* Simpler formilization of casts.

* Extract out code.

* Remove file.

* Move files.

* Share more code.

* Share more code.

* Break out types.

* Share more code.

* Add more tests.

* Add VB tests.

* Simplify.

* Add comment.

* Remove newlines.

* Move method.

* Move method.

* Add comments.

* Simplify

* Update comment.

* Update comment.

* Remove line.

* Update comment.

* Update comment.

* Update comment.

* Fix comment.

* Wrap long lines.

* Wrap long lines.

* Wrap long lines.

* Handle trivia.

* Simplify.

* Fix check.

* better support for else-if chains.

* Add comments.

* Remove 'Use Conditional Expressoin'

* Remove more vestiges of
 feature.

* Remove code.

* Add back newline.

* Remove helper.  The simplifier will do the right thing now.

* try to use var first, before removing casts.

* Update tests.

as the default language version
Related to #26115 which we use to mark the skipped tests.

* Remove duplicate lock DocumentState.s_syntaxTreeToIdMapLock

This lock is only being used to protect access to an instance which contains
internal synchronization.

* Better handle surrounding directives when inlining a local variable.

* Add tests.

* Share code between VB and C#.

* Reduce allocations in UnboundLambda

Fixes #23463

* Restore ReturnInferenceCacheKey as the key for _returnInferenceCache

* Update code to more closely follow patterns of the original code

* Cleanup from code review

* basic fix for intellisense in Immediate window

* better comments and cleanup

* Add basic integration tests

* cleanup inproc Immediate window integration test helper

* fix incorrect comment

* address PR feedback

* create Immediate window on ImmediateWindow_InProc.GetText()

* Verify MSBuild version in Developer CMD prompt

Roslyn is designed to have the simplest possible contribution story:
clone then build. Every pre-req needed is either located on the machine
or bootstrapped via NuGet. All the way down to using an xcopy MSBuild if
needed.

The one case which causes a problem is the VS command prompt. In this
case MSBuild is pre-installed on the machine and may or may not be
suitable for building Roslyn.

Previously when building from a VS command prompt we just used whatever
MSBuild was provided. The assumption being a developer command prompt
was an explicit statement of whath MSBuild you wanted to use. Based on
all of our customer reports though this does not seem to be the
assumption that consumers of our repo have. The build gave them no
explicit errors about the provided toolset and hence when the build
failed they assigned flakiness to our repo.

Going forward we are applying the same version validation to MSBuild
when provided via a developer command prompt. If it doesn't match we
will refuse to build asking the user to upgrade VS or build from a
normal command prompt.

* Remove unneeded debugging line

* Comment about pre-release

* Added minimum version

* Add Omit If Default style option

* Add space to be like test without the omit

* Add/Remove without needing a property

* Reformat

* PR feedback

* Fix VB diagnostic based on feedback

* Handle case of NotApplicable modifier and field declaration list

* Fix tests

* PR feedback

* PR feedback

* PreviewCodeAction was overriding ComputeOperations but returning a post-processed operation from original action. This results in another PostProcess being called on the codeaction. If postprocess was overriden in originalaction that'll be ignored the second time (#23920)

* Support negative null-check when we are suggesting to inline type checks

Fixes #21097
Fixes #24286

* fix a case where persistent storage registration fails and some clean… (#24458)

* fix a case where persistent storage registration fails and some clean up code around it.

* added readonly

* address PR feedback

* removed comments no longer relevant

* renamed lock name

* moved waiter from diagnostics.dll to features.dll where all interfaces are defined. (#24512)

* put listener change back in (https://github.com/dotnet/roslyn/pull/24120)

* leave old types in legacy folder until partner teams move to new interface

* added legacy waiter to support partner teams

* Remove methods indirecting access to _metadataFileNameToConvertedProjectReference

This field is documented as being written and read from any thread,
but in practice all uses are guarded by an AssertIsForeground(). Thus
we can get rid of the helper methods that are trying to "help" by
locking before accessing the fields, making it really hard to track all
the real uses of it.

* Make method static that doesn't need state

* add a comment to address PR feedback

* Fix up tests of P2P to metadata reference conversion

It turns out we had some tests, but the tests were disabled. This was
because the tests weren't working properly anyways: they were calling
into UpdateProjectBinPath which only updated some (but not all) of
the project state. That was an internal helper method that shouldn't
be used by tests. Updating the tests to use
SetBinOutputPathAndRelatedData works better.

* Delete debug-only reference validation

This was some legacy code that tried to verify that the references
we have from the project system match up to what DTE and other sources
say. This was debug-only, and the actual asserts were commented out.
This is deadweight at this point, so delete it.

* added and cleaned up logs around build and live diagnostics. (#24551)

also added RoslynActivityLogger that can be enabled through project-system-tool

* Avoid closure allocations on the BindSyntaxTreeToId fast path

* CS1628 error text mentions in parameters; fixes #24584

* Small cleanup of completion logic.

* Move to xunit.console for CoreClr tests

Previously we were using xunit.console for desktop tests and dotnet-xunit for our
CoreClr tests. This change unifies us on top of xunit.console (now that it has a
netcoreapp2.0 version available).

* Move unix builds to xunit.runner.console as well

* Get actual directory name, not file

* Fix dir name issue

* fixed build break