1. 12 11月, 2019 1 次提交
  2. 01 11月, 2019 1 次提交
  3. 04 10月, 2019 1 次提交
  4. 26 9月, 2019 1 次提交
  5. 13 9月, 2019 2 次提交
  6. 23 8月, 2019 1 次提交
    • M
      Do not report an NFW for analyzer exception diagnostic in IDE · 234015bd
      Manish Vasani 提交于
      This seems to cause a noticable UI delay while the NFW gets reported. We already report the AD0001 diagnostic with exception callstack and the analysis context on which exception occurred, so user has enough information to file an actionable bug.
      Fixes #38180
      234015bd
  7. 29 6月, 2019 3 次提交
  8. 08 6月, 2019 1 次提交
  9. 07 6月, 2019 2 次提交
  10. 04 6月, 2019 1 次提交
    • T
      OOP: Remove DiagnosticData.Workspace (#35902) · 075fcfc9
      Tomáš Matoušek 提交于
      * Cleanup style
      
      * Remove BlueSquiggleForBuildDiagnostic
      
      * TableDataSource refactoring
      
      * Remove DiagnosticData.Workspace
      
      * Fix workspace reference
      
      * Simplify GetTrackingPoints
      
      * Simplify deduplication
      
      * EqualsModuloLocation
      
      * Simplify navigate to
      
      * Specialize table item
      
      * Fix assert
      
      * Feedback
      
      * Dedup TryNavigateTo
      
      * Couple of renames
      075fcfc9
  11. 31 5月, 2019 1 次提交
    • M
      Add new analyzer API (DiagnosticSuppressor) to allow programmatic suppression... · f2f7a069
      Manish Vasani 提交于
      Add new analyzer API (DiagnosticSuppressor) to allow programmatic suppression of analyzer and/or compiler non-error diagnostics
      
      Fixes #20242 and #30172
      
      Detailed design proposal [here](https://gist.github.com/mavasani/fcac17a9581b5c54cef8a689eeec954a).
      
      Added public APIs with documentation comments:
      ```cs
      namespace Microsoft.CodeAnalysis.Diagnostics
      {
          /// <summary>
          /// The base type for diagnostic suppressors that can programmatically suppress analyzer and/or compiler non-error diagnostics.
          /// </summary>
          public abstract class DiagnosticSuppressor : DiagnosticAnalyzer
          {
              // Disallow suppressors from reporting diagnostics or registering analysis actions.
              public sealed override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray<DiagnosticDescriptor>.Empty;
      
              public sealed override void Initialize(AnalysisContext context) { }
      
              /// <summary>
              /// Returns a set of descriptors for the suppressions that this suppressor is capable of producing.
              /// </summary>
              public abstract ImmutableArray<SuppressionDescriptor> SupportedSuppressions { get; }
      
              /// <summary>
              /// Suppress analyzer and/or compiler non-error diagnostics reported for the compilation.
              /// This may be a subset of the full set of reported diagnostics, as an optimization for
              /// supporting incremental and partial analysis scenarios.
              /// A diagnostic is considered suppressible by a DiagnosticSuppressor if *all* of the following conditions are met:
              ///     1. Diagnostic is not already suppressed in source via pragma/suppress message attribute.
              ///     2. Diagnostic's <see cref="Diagnostic.DefaultSeverity"/> is not <see cref="DiagnosticSeverity.Error"/>.
              ///     3. Diagnostic is not tagged with <see cref="WellKnownDiagnosticTags.NotConfigurable"/> custom tag.
              /// </summary>
              public abstract void ReportSuppressions(SuppressionAnalysisContext context);
          }
      
          /// <summary>
          /// Provides a description about a programmatic suppression of a <see cref="Diagnostic"/> by a <see cref="DiagnosticSuppressor"/>.
          /// </summary>
          public sealed class SuppressionDescriptor : IEquatable<SuppressionDescriptor>
          {
              /// <summary>
              /// An unique identifier for the suppression.
              /// </summary>
              public string Id { get; }
      
              /// <summary>
              /// Identifier of the suppressed diagnostic, i.e. <see cref="Diagnostic.Id"/>.
              /// </summary>
              public string SuppressedDiagnosticId { get; }
      
              /// <summary>
              /// A localizable description about the suppression.
              /// </summary>
              public LocalizableString Description { get; }
          }
      
          /// <summary>
          /// Context for suppressing analyzer and/or compiler non-error diagnostics reported for the compilation.
          /// </summary>
          public struct SuppressionAnalysisContext
          {
              /// <summary>
              /// Suppressible analyzer and/or compiler non-error diagnostics reported for the compilation.
              /// This may be a subset of the full set of reported diagnostics, as an optimization for
              /// supporting incremental and partial analysis scenarios.
              /// A diagnostic is considered suppressible by a DiagnosticSuppressor if *all* of the following conditions are met:
              ///     1. Diagnostic is not already suppressed in source via pragma/suppress message attribute.
              ///     2. Diagnostic's <see cref="Diagnostic.DefaultSeverity"/> is not <see cref="DiagnosticSeverity.Error"/>.
              ///     3. Diagnostic is not tagged with <see cref="WellKnownDiagnosticTags.NotConfigurable"/> custom tag.
              /// </summary>
              public ImmutableArray<Diagnostic> ReportedDiagnostics { get; }
      
              /// <summary>
              /// Report a <see cref="Suppression"/> for a reported diagnostic.
              /// </summary>
              public void ReportSuppression(Suppression suppression);
      
              /// <summary>
              /// Gets a <see cref="SemanticModel"/> for the given <see cref="SyntaxTree"/>, which is shared across all analyzers.
              /// </summary>
              public SemanticModel GetSemanticModel(SyntaxTree syntaxTree);
      
              /// <summary>
              /// <see cref="CodeAnalysis.Compilation"/> for the context.
              /// </summary>
              public Compilation Compilation { get; }
      
              /// <summary>
              /// Options specified for the analysis.
              /// </summary>
              public AnalyzerOptions Options { get; }
      
              /// <summary>
              /// Token to check for requested cancellation of the analysis.
              /// </summary>
              public CancellationToken CancellationToken { get; }
          }
      
          /// <summary>
          /// Programmatic suppression of a <see cref="Diagnostic"/> by a <see cref="DiagnosticSuppressor"/>.
          /// </summary>
          public struct Suppression
          {
              /// <summary>
              /// Creates a suppression of a <see cref="Diagnostic"/> with the given <see cref="SuppressionDescriptor"/>.
              /// </summary>
              /// <param name="descriptor">
              /// Descriptor for the suppression, which must be from <see cref="DiagnosticSuppressor.SupportedSuppressions"/>
              /// for the <see cref="DiagnosticSuppressor"/> creating this suppression.
              /// </param>
              /// <param name="suppressedDiagnostic">
              /// <see cref="Diagnostic"/> to be suppressed, which must be from <see cref="SuppressionAnalysisContext.ReportedDiagnostics"/>
              /// for the suppression context in which this suppression is being created.</param>
              public static Suppression Create(SuppressionDescriptor descriptor, Diagnostic suppressedDiagnostic);
      
              /// <summary>
              /// Descriptor for this suppression.
              /// </summary>
              public SuppressionDescriptor Descriptor { get; }
      
              /// <summary>
              /// Diagnostic suppressed by this suppression.
              /// </summary>
              public Diagnostic SuppressedDiagnostic { get; }
          }
      }
      ```
      
      For batch compilation, suppressors always run after all the analyzer diagnostics have been computed.
      For IDE partial/incremental analysis scenario, we may run the suppressors with partial diagnostics.
      Suppressed diagnostics from diagnostic suppressors are equivalent to source suppressed diagnostics: they show up in the error list with "Suppression State" column as "Suppressed" and are also output to errorlog as suppressed diagnostics.
      f2f7a069
  12. 16 5月, 2019 1 次提交
  13. 14 12月, 2018 1 次提交
  14. 10 12月, 2018 1 次提交
  15. 06 12月, 2018 1 次提交
    • H
      support semantic errors for script files in misc projects. (#31134) · c64963b6
      Heejae Chang 提交于
      * refactor and clean up diagnostic engine code so that it can be re-used stand alone.
      
      code refactored is related to properly set up CompilationWithAnalyzer and compute and return diagnostics
      
      * made default diagnostic analyzer service to share code with VS diagnostic analyzer service on computing diagnostics.
      
      unlike VS diagnostic analyzer, the default one doesn't persist data or calculate diagnostics per a analyzer to improve per analyzer freshes nor compute and maintain per project analyzers and etc.
      
      also, this add ability to calculate semantic diagnostics for script file.
      
      * enable semantic diagnostics for script file for misc workspace.
      
      now, C#/VB script files in misc workspace will get semantic errors as well as syntax errors.
      
      any language such as F# if document is added to misc workspace with SourceCodeKind.Script, they will automatically get semantic errors as well.
      
      this PR doesn't address changes propagations for #load which was never supported for existing C#/VB script support.
      
      * addressed PR feedbacks
      c64963b6
  16. 05 12月, 2018 1 次提交
  17. 04 10月, 2018 1 次提交
  18. 30 5月, 2018 1 次提交
  19. 11 4月, 2018 1 次提交
  20. 21 3月, 2018 1 次提交
  21. 07 3月, 2018 1 次提交
    • H
      Blame (#24043) · a105ce76
      Heejae Chang 提交于
      * enable logAnalyzerExecutionTime on IDE so that we can start track analyzer perf
      
      * removed unnecessary ICodeAnalysisDiagnosticAnalyzerExecutor interface.
      
      it was added when OOP is first introduced to make sure VS.Next dll won't get loaded to VS process if OOP is not enabled.
      
      when it is enabled by default, rather than removing the interface, implementation just moved down to feature layer to reduce code churn.
      
      now, I am properly removing unnecessary abstraction.
      
      * take Executor out of test MEF composition
      
      * added IRemoteDiagnosticAnalyzerService interface
      
      * made initial version working.
      
      * added tests
      
      * add tracking for inproc only analyzers
      
      * pass in diagnostic analyzer service
      
      * added open file performance tracking as well.
      
      * added PII test
      
      * dont hash analyzerId when it is reported by internal user
      
      * added link to LOF wiki
      
      * made blame to track open files as well.
      
      * forgot to add return in if statement
      
      * reduce threshold to 100ms
      
      decide to start from lower threshold and then iterate rather than start from higher threshold
      
      * added a way to log real time perf data in local machine with explicit option which can be used to train formula later
      
      * addressed ivan's feedbacks
      
      * renamed to ExpensiveAnalyzerInfo
      
      * addressed PR feedbacks
      
      * more renames
      
      * addressed PR feedbacks.
      
      renamed as much as I can find.
      
      * listener can be null in unit test
      
      * addressed PR feedbacks
      a105ce76
  22. 19 12月, 2017 1 次提交
  23. 12 12月, 2017 1 次提交
  24. 23 8月, 2017 1 次提交
  25. 29 6月, 2017 2 次提交
  26. 23 5月, 2017 1 次提交
  27. 05 5月, 2017 1 次提交
    • H
      stop exposing Workspace from WorkspaceAnalyzerOptions. · e846ff7a
      Heejae Chang 提交于
      exposing workspace directly cause people to depends on data/service analyzer is not supposed to depend on, also, it sometime access mutable data instead of snapshot of it which analyzer is not supposed to use.
      
      this cut the connection, and expose specific info analyzer is allowed to use in IDE case.
      e846ff7a
  28. 08 2月, 2017 1 次提交
  29. 10 12月, 2016 2 次提交
  30. 21 11月, 2016 1 次提交
  31. 06 11月, 2016 1 次提交
  32. 24 9月, 2016 1 次提交
  33. 14 9月, 2016 1 次提交
  34. 10 9月, 2016 1 次提交
    • H
      added OpenFileOnly in IBuiltInAnalyzer and removed RunInProcess · 0999ff02
      Heejae Chang 提交于
      now, all builtin analyzer that is not set to only run on open files will run in OOP.
      
      any builtin analyzer that can't run in OOP should mark it as open file only.
      
      for analyzers that return only hidden severity but return different severity on runtime should use the new API to control whether it want it to run full solution or not. if set to run on full solution, it will run in OOP.
      0999ff02