1. 13 2月, 2020 3 次提交
  2. 11 2月, 2020 1 次提交
  3. 10 2月, 2020 1 次提交
  4. 08 2月, 2020 1 次提交
  5. 07 2月, 2020 2 次提交
  6. 06 2月, 2020 1 次提交
  7. 05 2月, 2020 3 次提交
    • M
      Merge pull request #41417 from agocke/update-arcade · c3471194
      msftbot[bot] 提交于
      Update arcade to support SDK publishing
      c3471194
    • A
    • J
      Delete the lazy caching of GetLatestProjectVersion() · 252064f8
      Jason Malinowski 提交于
      Solution.GetLatestProjectVersion() returns the highest project version
      of any of the Projects in the Solution. This is lazily computed, but
      the lazy computation has a fatal flaw. It's implemented with a
      Lazy<VersionStamp>, and if a Solution is changed and no project was
      changed (say, you only modified a document's text), the existing
      Lazy<VersionStamp> is reused. This causes us to root an older
      SolutionState or ProjectState until somebody were to call
      GetLatestProjectVersion() and cause the Lazy<VersionStamp> to be
      evaluated.
      
      Except...that would never happen. It turns out that nothing calls
      GetLatestProjectVersion() in Visual Studio anywhere that I can find.
      The only call is in one unit test that calls it and then ignores the
      result. Thus, we'd simply leak the SolutionState/ProjectState until
      some code ran that knew it could explicitly state the value instead of
      reuse the existing Lazy<VersionStamp>.
      
      Looking through history, it appears that this used to be used more
      regularly as a part of an older implementation of the
      ProjectDependencyGraph, but that was removed in
      abd7654e.
      
      Since nobody calls this, and the actual computation (just looping
      through all projects to find the newest stamp) is fairly trivial, I'm
      just going to delete all the lazy handling and just inline the
      computation. In the unlikely case that this ever becomes a hot path,
      we can revisit the laziness at that time.
      252064f8
  8. 04 2月, 2020 12 次提交
  9. 03 2月, 2020 2 次提交
  10. 01 2月, 2020 10 次提交
  11. 31 1月, 2020 4 次提交