- 09 4月, 2015 14 次提交
-
-
由 Shyam N 提交于
1. When light bulb asks us for suggestions (i.e. in HasSuggestedActionsAsync() and GetSuggestedActions()), it also specifies the category of suggestions that it is looking for (code fixes, refactorings, anything etc.). So far, we were completely ignoring the requested categories. HasSuggestedActionsAsync() would always return true so long as we had a code fix (that is not a suppression fix) and GetSuggestedActions() would always return all types of suggestions (fixes, suppressions and refactorings) regardless of what the light bulb is asking for. This led to strange bugs where we would return refactorings even when light bulb didn't ask for them. In other cases, HasSuggestedActionsAsync() and GetSuggestedActions() would disagree for the same requested categories. This change makes things consistent so that we always honor the suggestion categories that the light bulb is requesting. 2. When computing refactorings we were completely ignoring the span specified by light bulb and only considering selection specified by user. This led to incorrect behavior in some cases - for example, on mouse hover over a squiggle, we would return the code fixes corresponding to the squiggle along with refactorings for completely unrelated portions of the code that the user may have previously selected. Fixes #1030, #1595, #1631
-
由 VSadov 提交于
Fixed parsing logic for rsp file arguments to implement speced behavior.
-
由 Heejae Chang 提交于
make persistent service not to support project k for now. ... also change to use cached IVsHierarchy only for error list filtering due to issue with caching it on shared projects
-
由 Balaji Soundrarajan 提交于
VisualBasicCodeModelService should handle Constructor case for Function ...
-
由 VSadov 提交于
In particular, it is allowed for arguments to have embedded quoted portions like /define:Unquoted"Quoted"Unquoted"Quoted" wich means /define:UnquotedQuotedUnquotedQuoted when passed on command line, and should mean exactly the same when passed in an rsp file. The change fixes #1784
-
由 Paul Harrington 提交于
Expand LINQ expression for building auto-completion brace chars to reduce JIT time in the "open file" scenario.
-
由 Balaji Soundrarajan 提交于
VisualBasic CodeModel Service should handle Declare Function and Sub for St...
-
由 Manish Vasani 提交于
Fix DiagnosticAnalyzerExtensions.GetDiagnosticAnalyzerCategory to return DiagnosticAnalyzerCategory.SemanticDocumentAnalysis if the analyzer has semantic actions and cannot support semantic span based analysis. Fixes #1709
-
由 Balaji Soundrarajan 提交于
Fix #1843 : VisualBasicCodeModelService to get the function kind for Constructor had a syntactic blunder where the case was not allowed to fall through
-
由 Balaji Soundrarajan 提交于
Fix #1839 : Visual Basic CodeModelService not handles Declare Function and Sub for StartPoint and EndPoint.
-
由 Paul Harrington 提交于
-
由 Manish Vasani 提交于
Fix DiagnosticAnalyzerExtensions.GetDiagnosticAnalyzerCategory to return DiagnosticAnalyzerCategory.SemanticDocumentAnalysis if the analyzer has semantic actions and cannot support semantic span based analysis. Fixes #1709
-
由 Heejae Chang 提交于
also change to use cached IVsHierarchy only for error list filtering due to issue with caching it on shared projects
-
由 Tomáš Matoušek 提交于
Require correct null constant encoding in metadata
-
- 08 4月, 2015 24 次提交
-
-
由 Andy Gocke 提交于
Currently, a bug is present in the perf machine where the compiler server parent directory and the client parent directory differ only by casing. Rather than try to fix this specific instance, we should remove the reliance on .NET APIs to return the same value for the client and the server by simply passing the pipe name to the compiler server. This should mean that every identical instantiation of the client results in the same pipe name and remove the logic in the server.
-
-
由 Balaji Krishnan 提交于
Document moniker look up for shared item that is a contained document
-
由 Balaji Krishnan 提交于
-
由 Balaji Krishnan 提交于
Refactoring the code a bit. Pushed the mapping of hierarchy to shared hierarchy and itemId to shareditemId into LinkedFile Utility class. So now we give a hierarchy, itemId pair and get back a sharedhierarchy, itemId pair.
-
由 Srivatsn Narayanan 提交于
Port CA1813 (Avoid Unsealed Attributes) to System.Runtime.Analyzers.
-
由 Srivatsn Narayanan 提交于
Unskip tests fixed by #662 and #679.
-
由 Brett Forsgren 提交于
show conditional element access sig-help after arbitrary expressions
-
由 Brett Forsgren 提交于
the old model would only appear after an identifier name
-
由 Brett Forsgren 提交于
don't assume that a constructor's parent is a TypeBlockSyntax
-
由 Tomas Matousek 提交于
-
由 Kevin Halverson 提交于
Fix variable capturing for VB lambdas in EE...
-
由 Kevin Halverson 提交于
Variables may have been captured by lambdas in the original method or in the expression, and we need to preserve the existing values of those variables in the expression. This requires rewriting the variables in the expression based on the closure classes from both the original method and the expression, and generating a preamble that copies values into the expression closure classes. Consider the original method: ``` Shared Sub M() Dim x, y, z as Integer ... F(Function() x + y) End Sub ``` and the expression in the EE: "F(Function() x + z)". The expression is first rewritten using the closure class and the local `<1>` from the original method: F(Function() `<1>`.x + z) Then lambda rewriting introduces a new closure class that includes the locals `<1>` and z, and a corresponding local `<2>`: F(Function() `<2>`.`<1>`.x + `<2>`.z) And a preamble is added to initialize the fields of `<2>`: ``` <2> = New <>c__DisplayClass0() <2>.<1> = <1> <2>.z = z ```
-
由 Balaji Soundrarajan 提交于
Activating a previously failed testcase
-
https://github.com/dotnet/roslyn由 Balaji Krishnan 提交于
Merge branch 'master' of https://github.com/dotnet/roslyn into DocumentMonikerLookUpForSharedItemThatIsAContainedDocument
-
由 Brett Forsgren 提交于
In script and error scenarios, VB and C# syntax nodes corresponding to constructors/methods/properties/etc. won't necessarily have a parent. Adding some null checks to prevent a future NRE.
-
由 Balaji Soundrarajan 提交于
Fixes #317 : This HandleSolutionProjectTypeSolutionFolder was failing because the msbuild bits in Jenkins were older bits. Now the bits should have been updated. Hence enabling the test.
-
由 Kevin Halverson 提交于
Add ErrorCode checks for properties of Dkm*AsyncResult...
-
由 Kevin Halverson 提交于
It appears that DkmGetFrameArgumentsAsyncResult.Arguments may throw in some cases (rather than an empty array). We should be resiliant to that and behave as though there are no argument values available. I threw in a similar check for generic type arguments as well (just for good measure).
-
由 Brett Forsgren 提交于
display the class's doc comment in attribute quick info
-
由 Brett Forsgren 提交于
In an error parsing scenario, a VB ConstructorBlockSyntax might be parented by something other than a TypeBlockSyntax. Added a check for this scenario.
-
-
由 Balaji Krishnan 提交于
For a shared item that is a contained document, use the correct itemId and hierarchy to get a document moniker from running document table.
-
由 Tomáš Matoušek 提交于
EnC: Fix analysis of expression bodied indexers and query range variables
-
- 07 4月, 2015 2 次提交
-
-
由 Manish Vasani 提交于
Add tests for #1709
-
由 Manish Vasani 提交于
-