- 31 3月, 2020 13 次提交
-
-
由 Manish Vasani 提交于
Add new API `public T GetOption<T>(OptionKey optionKey)` to OptionSet for scenarios where caller wants a typed option value. Using `(T)GetOption(optionKey)` still works for public CodeStyleOption type, but is fragile approach that relied on internal implementation details. It should be discouraged in favor of `GetOption<T>(optionKey)`.
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
Fixes #42923 We already ensured that we return the correct CodeStyle option value for `T OptionSet.GetOption<T>` overloads to fetch option. However, for `object? OptionSet.GetOption(OptionKey)`, we did not ensure that the public CodeStyleOption is returned, which could lead to a cast exception if an external consumer tries to cast the return value to CodeStyleOption. NOTE: Even though theoretically this change introduces a breaking change for all public sub-types of `OptionSet` by making an abstract public method a non-abstract method, it is not really a breaking change as `OptionSet` already has internal abstract methods, hence cannot be sub-typed outside Roslyn. I also verified none of our IVT partners sub-type `OptionSet`. Verified the repro case + also unit test failure for the modified test before the fix.
-
由 Rikki Gibson 提交于
-
由 msftbot[bot] 提交于
Port ValidateFormatString analyzer and tests to shared layer
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
-
由 msftbot[bot] 提交于
Port UseConditionalExpression analyzer/fixer/tests to shared layer
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
Add annotation based Formatter overload in CodeStyle layer that is used by the code fixer - it is an internal Formatter API in Workspaces layer
-
由 Manish Vasani 提交于
-
- 30 3月, 2020 27 次提交
-
-
由 Sam Harwell 提交于
Convert AddAccessibilityModifiersTests to the new test framework
-
由 msftbot[bot] 提交于
Add netcoreapp3.1 target for the features layer
-
由 msftbot[bot] 提交于
Fix issues with 'Remove unnecessary cast'
-
由 msftbot[bot] 提交于
Restrict ExpectedCompile validation to command line builds
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
由 Sam Harwell 提交于
-
由 Sam Harwell 提交于
-
由 Cyrus Najmabadi 提交于
-
由 Sam Harwell 提交于
Add netcoreapp3.1 target for the scripting layer
-
由 msftbot[bot] 提交于
Support larger than 16 bit unicode characters in VirtualChar (using Rune!)
-
由 CyrusNajmabadi 提交于
Only simplify to format interpolation component for IFormattable values
-
由 Sam Harwell 提交于
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
由 jnm2 提交于
-
由 jnm2 提交于
-
由 CyrusNajmabadi 提交于
Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Simplification/Simplifiers/CastSimplifier.cs Co-Authored-By: NSam Harwell <sam@tunnelvisionlabs.com>
-
由 CyrusNajmabadi 提交于
Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Simplification/Simplifiers/CastSimplifier.cs Co-Authored-By: NSam Harwell <sam@tunnelvisionlabs.com>
-
由 CyrusNajmabadi 提交于
Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Simplification/Simplifiers/CastSimplifier.cs Co-Authored-By: NSam Harwell <sam@tunnelvisionlabs.com>
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
由 CyrusNajmabadi 提交于
Use expression-bodies for very simple members.
-
由 Sam Harwell 提交于
Pooled delegates to avoid capturing allocations
-
由 Cyrus Najmabadi 提交于
-