- 14 12月, 2018 1 次提交
-
-
由 Sam Harwell 提交于
-
- 10 12月, 2018 1 次提交
-
-
由 dotnet-bot 提交于
-
- 03 8月, 2018 1 次提交
-
-
由 Sam Harwell 提交于
-
- 31 7月, 2018 1 次提交
-
-
由 Jason Malinowski 提交于
These can be very confusing, since other methods on Contract actually throw exceptions. Since we have endless amounts of code directly calling Debug.Assert, let's just use it everywhere.
-
- 29 7月, 2018 1 次提交
-
-
由 Sam Harwell 提交于
-
- 26 7月, 2018 1 次提交
-
-
由 Sam Harwell 提交于
-
- 10 7月, 2018 1 次提交
-
-
由 Jason Malinowski 提交于
VSTHRD103 reminds people not to use .Result in tasks, which is great advice but we get a few false positives; in particular our SafeContinueWith extension isn't understood by the analyzer that the tasks involved are always completed, so you can just .Result them. Rather than working around this, let's just disable the analyzer in those cases.
-
- 27 6月, 2018 3 次提交
-
-
由 Jonathon Marolf 提交于
This reverts commit 28c8c78d.
-
由 Jonathon Marolf 提交于
-
由 Jonathon Marolf 提交于
-
- 26 6月, 2018 1 次提交
-
-
由 Cyrus Najmabadi 提交于
-
- 17 5月, 2018 1 次提交
-
-
由 Jason Malinowski 提交于
We had lots of places doing GetTextAsync() and then blocking, which is an anti-pattern if we can avoid it. Awhile back we plumbed the ability to get syntax trees synchronusly in certain places, and so we had the plumbing to do this. We just never did it. I suspect "most cases" this was fine because the GetTextAsync was operating on open files which isn't an issue. But there were a few places that looked suspicious and it's easier to just do a batch refactoring.
-
- 07 5月, 2018 1 次提交
-
-
由 Cyrus Najmabadi 提交于
-
- 03 2月, 2018 1 次提交
-
-
由 dotnet bot 提交于
* Remove duplicate lock DocumentState.s_syntaxTreeToIdMapLock This lock is only being used to protect access to an instance which contains internal synchronization. * Better handle surrounding directives when inlining a local variable. * Add tests. * Share code between VB and C#. * Reduce allocations in UnboundLambda Fixes #23463 * Restore ReturnInferenceCacheKey as the key for _returnInferenceCache * Update code to more closely follow patterns of the original code * Cleanup from code review * basic fix for intellisense in Immediate window * better comments and cleanup * Add basic integration tests * cleanup inproc Immediate window integration test helper * fix incorrect comment * address PR feedback * create Immediate window on ImmediateWindow_InProc.GetText() * Verify MSBuild version in Developer CMD prompt Roslyn is designed to have the simplest possible contribution story: clone then build. Every pre-req needed is either located on the machine or bootstrapped via NuGet. All the way down to using an xcopy MSBuild if needed. The one case which causes a problem is the VS command prompt. In this case MSBuild is pre-installed on the machine and may or may not be suitable for building Roslyn. Previously when building from a VS command prompt we just used whatever MSBuild was provided. The assumption being a developer command prompt was an explicit statement of whath MSBuild you wanted to use. Based on all of our customer reports though this does not seem to be the assumption that consumers of our repo have. The build gave them no explicit errors about the provided toolset and hence when the build failed they assigned flakiness to our repo. Going forward we are applying the same version validation to MSBuild when provided via a developer command prompt. If it doesn't match we will refuse to build asking the user to upgrade VS or build from a normal command prompt. * Remove unneeded debugging line * Comment about pre-release * Added minimum version * Add Omit If Default style option * Add space to be like test without the omit * Add/Remove without needing a property * Reformat * PR feedback * Fix VB diagnostic based on feedback * Handle case of NotApplicable modifier and field declaration list * Fix tests * PR feedback * PR feedback * PreviewCodeAction was overriding ComputeOperations but returning a post-processed operation from original action. This results in another PostProcess being called on the codeaction. If postprocess was overriden in originalaction that'll be ignored the second time (#23920) * Support negative null-check when we are suggesting to inline type checks Fixes #21097 Fixes #24286 * fix a case where persistent storage registration fails and some clean… (#24458) * fix a case where persistent storage registration fails and some clean up code around it. * added readonly * address PR feedback * removed comments no longer relevant * renamed lock name * moved waiter from diagnostics.dll to features.dll where all interfaces are defined. (#24512) * put listener change back in (https://github.com/dotnet/roslyn/pull/24120) * leave old types in legacy folder until partner teams move to new interface * added legacy waiter to support partner teams * Remove methods indirecting access to _metadataFileNameToConvertedProjectReference This field is documented as being written and read from any thread, but in practice all uses are guarded by an AssertIsForeground(). Thus we can get rid of the helper methods that are trying to "help" by locking before accessing the fields, making it really hard to track all the real uses of it. * Make method static that doesn't need state * add a comment to address PR feedback * Fix up tests of P2P to metadata reference conversion It turns out we had some tests, but the tests were disabled. This was because the tests weren't working properly anyways: they were calling into UpdateProjectBinPath which only updated some (but not all) of the project state. That was an internal helper method that shouldn't be used by tests. Updating the tests to use SetBinOutputPathAndRelatedData works better. * Delete debug-only reference validation This was some legacy code that tried to verify that the references we have from the project system match up to what DTE and other sources say. This was debug-only, and the actual asserts were commented out. This is deadweight at this point, so delete it. * added and cleaned up logs around build and live diagnostics. (#24551) also added RoslynActivityLogger that can be enabled through project-system-tool * Avoid closure allocations on the BindSyntaxTreeToId fast path * CS1628 error text mentions in parameters; fixes #24584 * Small cleanup of completion logic. * Move to xunit.console for CoreClr tests Previously we were using xunit.console for desktop tests and dotnet-xunit for our CoreClr tests. This change unifies us on top of xunit.console (now that it has a netcoreapp2.0 version available). * Move unix builds to xunit.runner.console as well * Get actual directory name, not file * Fix dir name issue * fixed build break
-
- 01 2月, 2018 1 次提交
-
-
由 Heejae Chang 提交于
* put listener change back in (https://github.com/dotnet/roslyn/pull/24120) * leave old types in legacy folder until partner teams move to new interface * added legacy waiter to support partner teams
-
- 27 1月, 2018 1 次提交
-
-
由 dotnet bot 提交于
* Add UseCultureAttribute to help with culture-dependent unit tests * Disable NuGet package restore in Visual Studio for Roslyn.sln * Add named argument for literal * Fix behavior for NET46 and NETCOREAPP2_0 * Revert "moved waiter from diagnostics.dll to features.dll where all interface… (#24120)" This reverts commit 823d9730. * Add references to System.IO.Pipes.AccessControl (#24457) When adding the reference to System.IO.Pipes.AccessControl for the compiler server to use on CoreCLR, I unified the pathway for the desktop and CoreCLR server access control code. This means that System.IO.Pipes.AccessControl needed to be added as a dependent DLL for desktop too, but I forgot to do that. This change adds System.IO.Pipes.AccessControl as a dependent DLL in all the places where the build task is deployed.
-
- 25 1月, 2018 2 次提交
-
-
由 Jason Malinowski 提交于
This reverts commit 823d9730.
-
由 Oleg Tkachenko 提交于
-
- 18 1月, 2018 1 次提交
-
-
由 Oleg Tkachenko 提交于
-
- 17 1月, 2018 1 次提交
-
-
由 Heejae Chang 提交于
* moved waiter from diagnostics.dll to features.dll where all interfaces are defined. * simplified listener and waiter and moved those in product. * cleaned up a bit * fixed some comments * forgot to add new AsyncListenerProvider in test export composition * fixed dead lock found on unit tests * remove all waiters left * added dispatcher event processing in one more place * added a way to enable waiter through env variable in test such as DDRIT * added env var support so that It can be used without internalvisibleTo us. * dont wait for all waiters but only onces each test used to wait. * removed dependency to Roslyn.Services.Test.Utilities in integration test. that dll is not in probing path. * fixed test failures * fixed bug in integration tests * move call to enable waiter before creating workspace so that workspace event queue get proper async listener * expose concret type as well so that it can be directly used in test for waiter * addressed PR feedbacks. * rename mess up * extra ) left out * fixed build failure
-
- 05 10月, 2017 1 次提交
-
-
由 Jason Malinowski 提交于
These speak in terms of WPF colors and brushes, so must be moved out.
-
- 18 7月, 2017 2 次提交
-
-
由 Petr Onderka 提交于
-
由 Petr Onderka 提交于
-
- 13 7月, 2017 1 次提交
-
-
由 CyrusNajmabadi 提交于
-
- 29 6月, 2017 2 次提交
-
-
由 Sam Harwell 提交于
-
由 Sam Harwell 提交于
-
- 24 2月, 2017 1 次提交
-
-
由 CyrusNajmabadi 提交于
-
- 24 1月, 2017 2 次提交
-
-
-
由 CyrusNajmabadi 提交于
-
- 21 11月, 2016 1 次提交
-
-
由 CyrusNajmabadi 提交于
-
- 19 10月, 2016 1 次提交
-
-
由 David Poeschl 提交于
Fixes #14159 The well-known ValueTuple types are very special in that you can ask for the SymbolInfo on the ValueTuple token and not get back the ValueTuple type. This means that the token we invoke rename on has no locations, which Rename Tracking mistakenly interpreted as being okay to rename. This has been fixed, and also the RenameUtilities.GetTokenRenameInfo method has been updated to return NoSymbolsTokenInfo when it finds an ITypeSymbol with IsTupleType.
-
- 18 10月, 2016 1 次提交
-
-
由 Marco Goertz 提交于
Fix for XAML Dev15 RC issue #14565.
-
- 14 9月, 2016 2 次提交
-
-
由 Heejae Chang 提交于
added OpenFileOnly in IBuiltInAnalyzer and removed RunInProcess
-
由 VSadov 提交于
More CR feedback
-
- 10 9月, 2016 2 次提交
-
-
由 Heejae Chang 提交于
now, all builtin analyzer that is not set to only run on open files will run in OOP. any builtin analyzer that can't run in OOP should mark it as open file only. for analyzers that return only hidden severity but return different severity on runtime should use the new API to control whether it want it to run full solution or not. if set to run on full solution, it will run in OOP.
-
由 VSadov 提交于
-
- 01 9月, 2016 1 次提交
-
-
由 Jason Malinowski 提交于
-
- 05 8月, 2016 1 次提交
-
-
由 Heejae Chang 提交于
This reverts commit 720f5c5e, reversing changes made to 6a6043c3.
-
- 30 7月, 2016 1 次提交
-
-
由 Heejae Chang 提交于
changes include make SourceText::GetChecksum and AnalyzerTelemetry contructor public. added MustRunInProc in IBuiltInAnalyzer and some clean up around serializing Solution/Project/DocumentId and how DocumentState is exposed. simplified temporary storage service's temporary storage management and added ability to attach to existing temporary storage solution checksum and serialization service. added remote host client - this gives an ability for host (vs) to talk to remote host (service hub) rename and moving files between feature/workspace layers - only real change is having ICompilerDiagnosticAnalyzer interface which can either have inproc implementation or out of proc implementation. - inproc is needed since diagnostics are in feature layer and one who uses feature layer out side of VS host need an implementation. added RemoteWorkspace - RemoteWorkspace has host agnostic implementation of roslyn features/services/workspace that will run in remote host added service hub component and setup project for service hub - service hub component is basically thin layer that deals with converting data to pass in to RemoteWorkspace made devdiv insertion tool to ignore servicehub related files support byte and char array natively in ObjectReader/Writer
-
- 28 7月, 2016 1 次提交
-
-
由 Heejae Chang 提交于
-