1. 25 1月, 2020 1 次提交
    • A
      Synthesize record properties and ctor (#41011) · e85be97b
      Andy Gocke 提交于
      The synthesized constructor assigns the properties, if they are
      synthesized properties. The properties are synthesized only if no
      conflicting member already exists in the class.
      e85be97b
  2. 18 1月, 2020 7 次提交
  3. 17 1月, 2020 5 次提交
  4. 16 1月, 2020 3 次提交
    • J
      Fix tests · 511435c9
      Jared Parsons 提交于
      511435c9
    • J
      Remove fourth state of SyntaxNodeOrToken · 8b0080a2
      Jared Parsons 提交于
      The `SyntaxNodeOrToken` type had four states:
      
      1. It's a `SyntaxNode`
      1. It's a `SyntaxToken`
      1. It's `default(SyntaxNodeOrToken)`
      1. It returns `true` for `IsNode` but `AsNode` returns `null`
      
      The fourth state appears to be an accident of implementation. This
      change removes that state. The one place in the code where this appeared
      to be an issue is in the implicit conversion from `SyntaxNode?` to
      `SyntaxNodeOrToken`. In all places where this was used and the value was
      potentially `null` the caller only used `GetLocation` on the result.
      Hence the fix is simply to change that API to return `default` instead
      of the fourth state in the case of `null`
      8b0080a2
    • S
      Fix assertion for the bootstrap compiler · 038fb5f6
      Sam Harwell 提交于
      038fb5f6
  5. 15 1月, 2020 1 次提交
    • T
      EnC: Tweak handling of out-of-sync documents to work around source file... · 5f86d25c
      Tomáš Matoušek 提交于
      EnC: Tweak handling of out-of-sync documents to work around source file content inconsistencies (#40947)
      
      * Do not block in presence of out-of-sync documents.
      
      Instead, ignore any changes made to these documents while debugging until their content matches the source used to build the baseline DLL.
      
      * Only check output PDB, not debugger SymReader, for document checksums.
      Turns out SymReader does not support reading document checksums once EnC changes have been applied.
      
      Better handle errors that might occur when validating checksums. Previously some of the errors were not reported as diagnostics.
      
      We previously blocked EnC when we observed a source file that is out-of-sync (i.e. its current content does not match the checksum in the originally built PDB). We can however just ignore these files and report a warning that changes made to this file won’t be applied until the file content is reverted back to the state it was when the PDB was built (the file transitions to “matching” state). Once a file is in matching state it can’t change back to another state. We know that we have not applied any change to the code that was compiled from the file because we ignored the file while it was in out-of-sync state. Therefore we know that any changes made from now on can be safely applied to the debuggee.
      
      If we can’t determine whether a file matches or not due to error reading the PDB or the source file content we can treat it similarly to out-of-sync file. That is, ignore any changes until we are able to confirm the file matches. That can happen if, e.g. the PDB is temporarily locked by another process and unlocked later.
      
      Simplify implementation of GetStatusAsync.
      
      Fixes VSO [1051496](https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1051496) ([VS feedback](https://developercommunity.visualstudio.com/content/problem/880533/edits-were-made-which-cannot-be-compiled-stop-debu.html))
      5f86d25c
  6. 14 1月, 2020 5 次提交
  7. 12 1月, 2020 1 次提交
  8. 11 1月, 2020 2 次提交
  9. 10 1月, 2020 6 次提交
  10. 09 1月, 2020 8 次提交
  11. 07 1月, 2020 1 次提交