1. 25 2月, 2015 20 次提交
    • P
      Merge pull request #812 from pharring/ConcurrentDictionaries · e7f2534d
      Paul Harrington 提交于
      Reduce allocations from the ConcurrentDictionaries in TypeSymbol interface implementation maps.
      e7f2534d
    • M
      Merge pull request #831 from mavasani/AnalyzerResourceWorkaround · cf681ce0
      Manish Vasani 提交于
      Address couple of issues related to analyzers: 
      
      1) Don't crash command line builds when reporting analyzer diagnostics. Reporting analyzer diagnostics may involve invoking user code for LocalizableString message, which may throw while finding resources or for other unknown reasons. We catch exceptions from these callbacks and report a diagnostic with the inner exception message.
       I verified that this fixes the crash seen in #271 and #813 and we started seeing this new info diagnostic.
      
      2) Workaround for #271: The underlying cause of the crash is that our assembly resolver/CLR is unable to fallback to the main assembly for resources and ends up looking for the satellite resource assembly. We had seen this crash quite a while back, but it went away and this seems to have come up again. Workaround, as applied back then, is to mark the analyzer assembly with NeutralResourcesLanguageAttribute.
       I verified that adding this attribute to our core analyzer assemblies caused the resource to be correctly found and we don't even see the exception diagnostic from (1) above, but instead the actual diagnostic reported by the analyzer.
      cf681ce0
    • J
      Merge pull request #833 from jasonmalinowski/disable-threadpool-tests · 89161a71
      Jason Malinowski 提交于
      Disable tests related to GitHub issue #204
      89161a71
    • M
    • M
      Fix a test failure. · 7b8a3347
      Manish Vasani 提交于
      7b8a3347
    • J
      Disable tests related to GitHub issue #204 · 8b8889d5
      Jason Malinowski 提交于
      8b8889d5
    • M
      Merge pull request #808 from mavasani/SyntaxNodeActions · f2c3461e
      Manish Vasani 提交于
      Fix #565: Syntax node actions are not called for field declarations in compiler analyzer driver if the declaration defines multiple variables
      
      Simplify logic for execution of syntax node actions for field declarations: If there are multiple decls, execute syntax node actions for entire field decl (and its descendants) when processing symbol declared event for first field within it, and skip syntax node actions for rest of fields defined within that declaration.
       Current logic is unnecessarily complex in that it tries to execute syntax node actions for individual variable declarators when processing corresponding field symbol declared event, and executes the node actions for shared nodes (e.g. defining type syntax node) when processing first field symbol, and caused this bug to sneak through.
      
      Added regression tests for compiler driver (VB and C#) and IDE driver.
      f2c3461e
    • M
      Merge pull request #795 from mavasani/CSharpReportDiagnosticAnalyzerFix · 2d8f5cf5
      Manish Vasani 提交于
      Fix #671 to handle broken code case where there are multiple overrides of DiagnosticAnalyzer.SupportedDiagnostics property
      2d8f5cf5
    • M
      Missed checking in the assembly attributes files. · 14624e7a
      Manish Vasani 提交于
      14624e7a
    • M
    • M
      Address couple of issues related to analyzers: · 5cd0be7c
      Manish Vasani 提交于
      1) Don't crash command line builds when reporting analyzer diagnostics. Reporting analyzer diagnostics may involve invoking user code for LocalizableString message, which may throw while finding resources or for other unknown reasons. We catch exceptions from these callbacks and report a diagnostic with the inner exception message.
      I verified that this addressed the crash seen in #271 and #813 and we started seeing this new info diagnostic.
      
      2) Workaround for #271: The underlying cause of the crash is that our assembly resolver/CLR is unable to fallback to the main assembly for resources and ends up looking for the satellite resource assembly. We had seen this crash quite a while back, but it went away and this seems to have come up again. Workaround, as applied back then, is to mark the analyzer assembly with NeutralResourcesLanguageAttribute.
      I verified that adding this attribute to our core analyzer assemblies caused the resource to be correctly found and we don't even see the exception diagnostic from (1) above, but instead the actual diagnostic reported by the analyzer.
      5cd0be7c
    • K
      Merge pull request #727 from KevinH-MS/ResultProviderAPIChanges · 998b40f5
      Kevin Halverson 提交于
      Refactor ResultProvider (incorporating Concord API changes)...
      998b40f5
    • K
      Refactor ResultProvider (incorporating Concord API changes)... · 2fc666c3
      Kevin Halverson 提交于
      1.  DkmClrValue.InspectionContext has been removed, so a separate instance needs to be passed to all the methods that need it.
      2.  DkmClrValue.EvaluateDebuggerDisplayString is now async.  In order to avoid complicated plumbing of completion routines through result expansion, I've moved the creation of DkmEvaluationResults from *Expansion to the ResultProvider.  Expansion now produces EvalResultDataItems that contain all the information necessary to produce DkmEvaluatoinResults in a single place, just before returning from the ResultProvider entry points.  New async plumbing/Exception handling is localized to the entry points.
      3.  There are several places that the API now allows passing format specifiers.  We do not intend to support those scenarios in C#/VB, so we will ignore them.
      2fc666c3
    • P
      Review feedback · 05723141
      Paul Harrington 提交于
      Use TryGetValue followed by TryAdd to avoid delegate allocation.
      05723141
    • B
      Merge pull request #816 from basoundr/fix791ArgExcpMultiComment · c29dc68a
      Balaji 提交于
      Make OutliningSpan Creation not assume MultiLine Comment always end with...
      c29dc68a
    • D
      Merge pull request #756 from DustinCampbell/fix-739 · 15e09831
      Dustin Campbell 提交于
      Make VB Remove Unnecessary Cast a bit smarter in interpolations
      15e09831
    • B
      Make OutliningSpan Creation not assume MultiLine Comment always end with'*/' · 9a950a8f
      Balaji Soundrarajan 提交于
      Fixes #791: The code '\*' is parsed as MultiLine Comment even with the
      presence of the corresponding '*\' in some cases. Hence, OutLining Span
      creator should not assume that '*\' will always be present for Multiline
      Comment and handle the creation appropriately
      9a950a8f
    • A
      08178535
    • D
      35dca8d1
    • T
      Merge pull request #729 from tmeschter/HandleAllAssemblyResolve · 1890f9ad
      Tom Meschter 提交于
      Handle AssemblyResolve events when the requesting assembly is unknown
      1890f9ad
  2. 24 2月, 2015 20 次提交