- 20 10月, 2018 17 次提交
-
-
由 Jason Malinowski 提交于
We support dangling project references in the workspace API, and the ProjectDependencyGraph is only supposed to return references that exist within the project. Therefore, if we add a project, we have to check to make sure we didn't have a dangling reference becoming a real reference, and give inconsistent results. I expect this to be a rare situation in reality so don't want to spend a lot of time optimizing for it, but if it happens this will keep everything in sync.
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
Some of these are particularly hard; we have a lazy data structure that has "I don't know" as something the algorithm needs to deal with. Unfortunately trying to test through the public Solution APIs often doesn't work because the Solution code accidentally asks the dependency graph for things which then invalidates the "I don't know" by causing it to compute things.
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
It's unclear to me why we have another implementation of computing transitive project references; we'll just call our existing implementation.
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
Any time we made a change to the dependency structure of a solution, we threw away the dependency graph entirely and recomputed it. This was pretty wasteful, since we'd promptly recompute parts of it as a part of the workspace solution forking. The allocations were quite high, often to recompute the (almost) exact same immutable data as before. This adds the abilty to take an existing ProjectDependencyGraph and update it to produce a new graph with project references added, which reuses whatever data was easily available.
-
由 Jason Malinowski 提交于
We already have an API for adding multiple project references; let's just use that at the public entrypoints than trying to maintain near-duplicate code.
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
This will make it easier to assert intermediate states.
-
由 Jason Malinowski 提交于
By not using the map, we can easily have helpers that can be called by additional tests directly.
-
由 Jason Malinowski 提交于
The code in CreateSolutionFromReferenceMap tried very hard to support the ability that if you had the same project name with different references, that we should merge all the different references together For example, "A:B A:C" should be equivalent to "A:B,C". But if you tried this, it would have crashed anyways becuase we'd see a duplicate project name. Since it doesn't work, no reason to keep it around.
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
-
由 Jason Malinowski 提交于
These methods do not return topologically sorted results; not only is that not something that really makes sense, but they return IImmutableSets anyways so they have no way to guarantee ordering at all.
-
- 22 8月, 2018 2 次提交
-
-
由 Brett V. Forsgren 提交于
Merge dev15.8.x to dev15.8.x-vs-deps
-
由 Gen Lu 提交于
Add copyright value to nuspec
-
- 21 8月, 2018 2 次提交
- 18 8月, 2018 1 次提交
-
-
由 Gen Lu 提交于
-
- 17 8月, 2018 1 次提交
-
-
由 Jason Malinowski 提交于
Our dependency Microsoft.VisualStudio.Language.Intellisense already carries forward the version we should be referencing; this seems to be an oversight of a generic upgrade to higher packages that now means we're trying to reference something higher than it.
-
- 08 8月, 2018 4 次提交
-
-
由 dotnet-automerge-bot 提交于
Merge dev15.8.x to dev15.8.x-vs-deps
-
由 Heejae Chang 提交于
-
由 Heejae Chang 提交于
* fix race by making it thread-safe * PR feedbacks * more PR feedbacks
-
由 Cheryl Borley 提交于
* Watson fix * try null * Add IsNullOrWhitespace check * Add unit test * respond to feedback * respond to feedback
-
- 04 8月, 2018 2 次提交
-
-
由 dotnet-automerge-bot 提交于
Merge dev15.8-preview4-vs-deps to dev15.8.x-vs-deps
-
由 Andy Gocke 提交于
Merge remote-tracking branch 'upstream/dev15.8-preview4-vs-deps' into merges/dev15.8-preview4-vs-deps-to-dev15.8.x-vs-deps
-
- 02 8月, 2018 2 次提交
-
-
由 dotnet-automerge-bot 提交于
Merge dev15.8.x to dev15.8.x-vs-deps
-
由 Will Smith 提交于
This ensures the F# package is loaded for CPS only projects in a solution. Seems this was an oversight. Independent of Microsoft/visualfsharp#5391, ensuring the F# package load fixes this issue: Microsoft/visualfsharp#5395 - and it probably fixes other issues that we haven't discovered as a result of not loading the package.
-
- 01 8月, 2018 1 次提交
-
-
由 Shyam-Gupta 提交于
Merge dev15.8.x to dev15.8.x-vs-deps
-
- 31 7月, 2018 4 次提交
-
-
由 dotnet-automerge-bot 提交于
Merge dev15.8-preview4 to dev15.8.x
-
由 dotnet-automerge-bot 提交于
Merge dev15.7.x-vs-deps to dev15.8-preview4-vs-deps
-
由 dotnet-automerge-bot 提交于
Merge dev15.8-preview4 to dev15.8-preview4-vs-deps
-
由 Andy Gocke 提交于
-
- 28 7月, 2018 3 次提交
-
-
由 dotnet-automerge-bot 提交于
Merge dev15.7.x to dev15.8-preview4
-
由 Andy Gocke 提交于
Merge dev15.8.x to dev15.8.x-vs-deps
-
由 dotnet-automerge-bot 提交于
Merge dev15.7.x to dev15.7.x-vs-deps
-
- 27 7月, 2018 1 次提交
-
-
由 Jonathon Marolf 提交于
updating optprof data for expression evaluators
-